* [PATCHv2] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins
@ 2016-12-05 17:43 Niklas Söderlund
2016-12-08 13:31 ` Simon Horman
2016-12-09 10:05 ` Geert Uytterhoeven
0 siblings, 2 replies; 5+ messages in thread
From: Niklas Söderlund @ 2016-12-05 17:43 UTC (permalink / raw)
To: Simon Horman, Magnus Damm
Cc: linux-renesas-soc, Geert Uytterhoeven, Niklas Söderlund
The EthernetAVB should not depend on the bootloader to setup correct
drive-strength values. Values for drive-strength where found by
examining the registers after the bootloader has configured the
registers and successfully used the EthernetAVB.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
Changes since v1:
- Only set drive-strength for output pins, thanks Geert.
- Add all used pin groups to the mux section.
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index b1eab68..784ced9 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -225,8 +225,22 @@
};
avb_pins: avb {
- groups = "avb_mdc";
- function = "avb";
+ mux {
+ groups = "avb_link", "avb_phy_int", "avb_mdc",
+ "avb_mii";
+ function = "avb";
+ };
+
+ pins_mdc {
+ groups = "avb_mdc";
+ drive-strength = <24>;
+ };
+
+ pins_mii_tx {
+ pins = "PIN_AVB_TX_CTL", "PIN_AVB_TXC", "PIN_AVB_TD0",
+ "PIN_AVB_TD1", "PIN_AVB_TD2", "PIN_AVB_TD3";
+ drive-strength = <12>;
+ };
};
du_pins: du {
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCHv2] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins
2016-12-05 17:43 [PATCHv2] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins Niklas Söderlund
@ 2016-12-08 13:31 ` Simon Horman
2017-03-05 23:28 ` Niklas Söderlund
2016-12-09 10:05 ` Geert Uytterhoeven
1 sibling, 1 reply; 5+ messages in thread
From: Simon Horman @ 2016-12-08 13:31 UTC (permalink / raw)
To: Niklas Söderlund; +Cc: Magnus Damm, linux-renesas-soc, Geert Uytterhoeven
On Mon, Dec 05, 2016 at 06:43:10PM +0100, Niklas Söderlund wrote:
> The EthernetAVB should not depend on the bootloader to setup correct
> drive-strength values. Values for drive-strength where found by
> examining the registers after the bootloader has configured the
> registers and successfully used the EthernetAVB.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
I believe this patch has run-time dependencies on PFC patches and will
result in a regression without them. Please resubmit or otherwise ping me
once chose changes are present in an (rc) release or immutable branch.
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins
2016-12-05 17:43 [PATCHv2] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins Niklas Söderlund
2016-12-08 13:31 ` Simon Horman
@ 2016-12-09 10:05 ` Geert Uytterhoeven
1 sibling, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-12-09 10:05 UTC (permalink / raw)
To: Niklas Söderlund; +Cc: Simon Horman, Magnus Damm, Linux-Renesas
On Mon, Dec 5, 2016 at 6:43 PM, Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> The EthernetAVB should not depend on the bootloader to setup correct
> drive-strength values. Values for drive-strength where found by
> examining the registers after the bootloader has configured the
> registers and successfully used the EthernetAVB.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins
2016-12-08 13:31 ` Simon Horman
@ 2017-03-05 23:28 ` Niklas Söderlund
2017-03-06 8:58 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Niklas Söderlund @ 2017-03-05 23:28 UTC (permalink / raw)
To: Simon Horman; +Cc: Magnus Damm, linux-renesas-soc, Geert Uytterhoeven
Hi Simon,
On 2016-12-08 14:31:38 +0100, Simon Horman wrote:
> On Mon, Dec 05, 2016 at 06:43:10PM +0100, Niklas S�derlund wrote:
> > The EthernetAVB should not depend on the bootloader to setup correct
> > drive-strength values. Values for drive-strength where found by
> > examining the registers after the bootloader has configured the
> > registers and successfully used the EthernetAVB.
> >
> > Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
>
> I believe this patch has run-time dependencies on PFC patches and will
> result in a regression without them. Please resubmit or otherwise ping me
> once chose changes are present in an (rc) release or immutable branch.
The dependency for this DT change is now present in v4.11-rc1, see 1. If
it's convenient for you feel free to pick up this patch.
1. b25719eb938eb39a ("pinctrl: sh-pfc: r8a7795: Add group for AVB MDIO
and MII pins")
>
> Thanks!
--
Regards,
Niklas S�derlund
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins
2017-03-05 23:28 ` Niklas Söderlund
@ 2017-03-06 8:58 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2017-03-06 8:58 UTC (permalink / raw)
To: Niklas Söderlund; +Cc: Magnus Damm, linux-renesas-soc, Geert Uytterhoeven
On Mon, Mar 06, 2017 at 12:28:18AM +0100, Niklas Söderlund wrote:
> Hi Simon,
>
> On 2016-12-08 14:31:38 +0100, Simon Horman wrote:
> > On Mon, Dec 05, 2016 at 06:43:10PM +0100, Niklas Söderlund wrote:
> > > The EthernetAVB should not depend on the bootloader to setup correct
> > > drive-strength values. Values for drive-strength where found by
> > > examining the registers after the bootloader has configured the
> > > registers and successfully used the EthernetAVB.
> > >
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> >
> > I believe this patch has run-time dependencies on PFC patches and will
> > result in a regression without them. Please resubmit or otherwise ping me
> > once chose changes are present in an (rc) release or immutable branch.
>
> The dependency for this DT change is now present in v4.11-rc1, see 1. If
> it's convenient for you feel free to pick up this patch.
>
> 1. b25719eb938eb39a ("pinctrl: sh-pfc: r8a7795: Add group for AVB MDIO
> and MII pins")
Thanks Niklas,
I am in the process of rebasing my branches on top of v4.11-rc1
and I have queued up this patch. It should appear in the next push
of renesas-next and renesas-revel.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-06 8:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-05 17:43 [PATCHv2] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins Niklas Söderlund
2016-12-08 13:31 ` Simon Horman
2017-03-05 23:28 ` Niklas Söderlund
2017-03-06 8:58 ` Simon Horman
2016-12-09 10:05 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.