[Buildroot] [PATCH 1/1] dc3dd: new package

[Buildroot] [PATCH 1/1] dc3dd: new package

[Benoît Allard]

Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
---
 DEVELOPERS               |  3 +++
 package/Config.in        |  1 +
 package/dc3dd/Config.in  |  9 +++++++++
 package/dc3dd/dc3dd.hash |  2 ++
 package/dc3dd/dc3dd.mk   | 19 +++++++++++++++++++
 5 files changed, 34 insertions(+)
 create mode 100644 package/dc3dd/Config.in
 create mode 100644 package/dc3dd/dc3dd.hash
 create mode 100644 package/dc3dd/dc3dd.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 1bf07c3..6ed713b 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -146,6 +146,9 @@ F:	package/taskd/
 N:	Benjamin Kamath <kamath.ben@gmail.com>
 F:	package/lapack/
 
+N:	Beno?t Allard <benoit.allard@greenbone.net>
+F:	package/dc3dd/
+
 N:	Bernd Kuhls <bernd.kuhls@t-online.de>
 F:	package/apache/
 F:	package/apr/
diff --git a/package/Config.in b/package/Config.in
index 921a06c..376c573 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1762,6 +1762,7 @@ menu "System tools"
 	source "package/cpuload/Config.in"
 	source "package/dcron/Config.in"
 	source "package/ddrescue/Config.in"
+	source "package/dc3dd/Config.in"
 	source "package/debianutils/Config.in"
 	source "package/docker-containerd/Config.in"
 	source "package/docker-engine/Config.in"
diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
new file mode 100644
index 0000000..0a2a32e
--- /dev/null
+++ b/package/dc3dd/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_DC3DD
+	bool "dc3dd"
+	help
+          dc3dd is a patch to the GNU dd program, this version has several
+          features intended for forensic acquisition of data. Highlights
+          include hashing on-the-fly, split output files, pattern writing, a
+          progress meter, and file verification.
+
+          https://sourceforge.net/projects/dc3dd/
diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
new file mode 100644
index 0000000..edd75c2
--- /dev/null
+++ b/package/dc3dd/dc3dd.hash
@@ -0,0 +1,2 @@
+# From https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2.646/dc3dd%207.2.646/
+sha1 3d3d9ba5f3b18fbf4798e1f3554f2d34d0ce5e2c dc3dd-7.2.646.zip
diff --git a/package/dc3dd/dc3dd.mk b/package/dc3dd/dc3dd.mk
new file mode 100644
index 0000000..5a25bee
--- /dev/null
+++ b/package/dc3dd/dc3dd.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# dc3dd
+#
+################################################################################
+
+DC3DD_VERSION = 7.2.646
+DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).zip
+DC3DD_SITE = http://downloads.sourceforge.net/project/dc3dd/dc3dd/$(DC3DD_VERSION)/dc3dd%20$(DC3DD_VERSION)
+DC3DD_LICENSE = GPLv3
+DC3DD_LICENSE_FILES = COPYING
+
+define DC3DD_EXTRACT_CMDS
+        $(UNZIP) -d $(@D)/.. $(DL_DIR)/$(DC3DD_SOURCE) || true
+        chmod a+x $(@D)/configure
+        chmod a+x $(@D)/build-aux/install-sh
+endef
+
+$(eval $(autotools-package))
-- 
2.1.4

[Buildroot] [PATCH 1/1] dc3dd: new package

[Arnout Vandecappelle]

 Hi Benoit,

 Strange timezone you live in, GMT+32 or something like that? :-)

On 04-03-17 07:04, Beno?t Allard wrote:
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
[snip]
> diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
> new file mode 100644
> index 0000000..0a2a32e
> --- /dev/null
> +++ b/package/dc3dd/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_DC3DD
> +	bool "dc3dd"
> +	help
> +          dc3dd is a patch to the GNU dd program, this version has several
> +          features intended for forensic acquisition of data. Highlights
> +          include hashing on-the-fly, split output files, pattern writing, a

 Help text should wrap at 72 columns where the tab counts for 8, so this is 4
characters too many...

> +          progress meter, and file verification.
> +
> +          https://sourceforge.net/projects/dc3dd/
> diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
> new file mode 100644
> index 0000000..edd75c2
> --- /dev/null
> +++ b/package/dc3dd/dc3dd.hash
> @@ -0,0 +1,2 @@
> +# From https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2.646/dc3dd%207.2.646/
> +sha1 3d3d9ba5f3b18fbf4798e1f3554f2d34d0ce5e2c dc3dd-7.2.646.zip

 If only a weak hash is available upstream, please add a locally calculated sha256.

> diff --git a/package/dc3dd/dc3dd.mk b/package/dc3dd/dc3dd.mk
> new file mode 100644
> index 0000000..5a25bee
> --- /dev/null
> +++ b/package/dc3dd/dc3dd.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# dc3dd
> +#
> +################################################################################
> +
> +DC3DD_VERSION = 7.2.646

 There is a version 7.2.641 which is identical except that it has an older (!)
Changelog, and a different version number...

> +DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).zip

 and that version has a proper tar.xz.

> +DC3DD_SITE = http://downloads.sourceforge.net/project/dc3dd/dc3dd/$(DC3DD_VERSION)/dc3dd%20$(DC3DD_VERSION)
> +DC3DD_LICENSE = GPLv3

 I didn't do a full fossology but it looks like all files have the 'or later'
clause, so it's GPLv3+

> +DC3DD_LICENSE_FILES = COPYING
> +
> +define DC3DD_EXTRACT_CMDS
> +        $(UNZIP) -d $(@D)/.. $(DL_DIR)/$(DC3DD_SOURCE) || true

 || true? You want to succeed in case of failure?

 Also, we normally extract within $(@D) and then move the result. Cfr. e.g. espeak.

> +        chmod a+x $(@D)/configure
> +        chmod a+x $(@D)/build-aux/install-sh

 The tar.xz has execute permission set on all files. Not sure if that's an
improvement :-)


 Regards,
 Arnout

> +endef
> +
> +$(eval $(autotools-package))
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] dc3dd: new package

[Arnout Vandecappelle]

On 03-03-17 23:42, Arnout Vandecappelle wrote:
>  Hi Benoit,
> 
>  Strange timezone you live in, GMT+32 or something like that? :-)
> 
> On 04-03-17 07:04, Beno?t Allard wrote:
>> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> [snip]
>> diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
>> new file mode 100644
>> index 0000000..0a2a32e
>> --- /dev/null
>> +++ b/package/dc3dd/Config.in
>> @@ -0,0 +1,9 @@
>> +config BR2_PACKAGE_DC3DD
>> +	bool "dc3dd"

 Also, it fails to build on musl, and uses threads. Use the test-pkg script to
pre-test on the autobuilder toolchains, it just takes an hour or so on an
average speed computer.


 Regards,
 Arnout

>> +	help
>> +          dc3dd is a patch to the GNU dd program, this version has several
>> +          features intended for forensic acquisition of data. Highlights
>> +          include hashing on-the-fly, split output files, pattern writing, a
> 
>  Help text should wrap at 72 columns where the tab counts for 8, so this is 4
> characters too many...
> 
>> +          progress meter, and file verification.
>> +
>> +          https://sourceforge.net/projects/dc3dd/
>> diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
>> new file mode 100644
>> index 0000000..edd75c2
>> --- /dev/null
>> +++ b/package/dc3dd/dc3dd.hash
>> @@ -0,0 +1,2 @@
>> +# From https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2.646/dc3dd%207.2.646/
>> +sha1 3d3d9ba5f3b18fbf4798e1f3554f2d34d0ce5e2c dc3dd-7.2.646.zip
> 
>  If only a weak hash is available upstream, please add a locally calculated sha256.
> 
>> diff --git a/package/dc3dd/dc3dd.mk b/package/dc3dd/dc3dd.mk
>> new file mode 100644
>> index 0000000..5a25bee
>> --- /dev/null
>> +++ b/package/dc3dd/dc3dd.mk
>> @@ -0,0 +1,19 @@
>> +################################################################################
>> +#
>> +# dc3dd
>> +#
>> +################################################################################
>> +
>> +DC3DD_VERSION = 7.2.646
> 
>  There is a version 7.2.641 which is identical except that it has an older (!)
> Changelog, and a different version number...
> 
>> +DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).zip
> 
>  and that version has a proper tar.xz.
> 
>> +DC3DD_SITE = http://downloads.sourceforge.net/project/dc3dd/dc3dd/$(DC3DD_VERSION)/dc3dd%20$(DC3DD_VERSION)
>> +DC3DD_LICENSE = GPLv3
> 
>  I didn't do a full fossology but it looks like all files have the 'or later'
> clause, so it's GPLv3+
> 
>> +DC3DD_LICENSE_FILES = COPYING
>> +
>> +define DC3DD_EXTRACT_CMDS
>> +        $(UNZIP) -d $(@D)/.. $(DL_DIR)/$(DC3DD_SOURCE) || true
> 
>  || true? You want to succeed in case of failure?
> 
>  Also, we normally extract within $(@D) and then move the result. Cfr. e.g. espeak.
> 
>> +        chmod a+x $(@D)/configure
>> +        chmod a+x $(@D)/build-aux/install-sh
> 
>  The tar.xz has execute permission set on all files. Not sure if that's an
> improvement :-)
> 
> 
>  Regards,
>  Arnout
> 
>> +endef
>> +
>> +$(eval $(autotools-package))
>>
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] dc3dd: new package

[Benoît Allard]

On Fri, 3 Mar 2017 23:42:49 +0100
Arnout Vandecappelle <arnout@mind.be> wrote:

>  Hi Benoit,
> 
>  Strange timezone you live in, GMT+32 or something like that? :-)
> 

That's a development virtual-machine. The date in there was somewhat
not synchronized.

> On 04-03-17 07:04, Beno?t Allard wrote:
> > Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> [snip]
> > diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
> > new file mode 100644
> > index 0000000..0a2a32e
> > --- /dev/null
> > +++ b/package/dc3dd/Config.in
> > @@ -0,0 +1,9 @@
> > +config BR2_PACKAGE_DC3DD
> > +	bool "dc3dd"
> > +	help
> > +          dc3dd is a patch to the GNU dd program, this version has
> > several
> > +          features intended for forensic acquisition of data.
> > Highlights
> > +          include hashing on-the-fly, split output files, pattern
> > writing, a
> 
>  Help text should wrap at 72 columns where the tab counts for 8, so
> this is 4 characters too many...
> 

Will do.

> > +          progress meter, and file verification.
> > +
> > +          https://sourceforge.net/projects/dc3dd/
> > diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
> > new file mode 100644
> > index 0000000..edd75c2
> > --- /dev/null
> > +++ b/package/dc3dd/dc3dd.hash
> > @@ -0,0 +1,2 @@
> > +# From
> > https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2.646/dc3dd%207.2.646/
> > +sha1 3d3d9ba5f3b18fbf4798e1f3554f2d34d0ce5e2c dc3dd-7.2.646.zip
> 
>  If only a weak hash is available upstream, please add a locally
> calculated sha256.

Sure, will do.

> 
> > diff --git a/package/dc3dd/dc3dd.mk b/package/dc3dd/dc3dd.mk
> > new file mode 100644
> > index 0000000..5a25bee
> > --- /dev/null
> > +++ b/package/dc3dd/dc3dd.mk
> > @@ -0,0 +1,19 @@
> > +################################################################################
> > +#
> > +# dc3dd
> > +#
> > +################################################################################
> > +
> > +DC3DD_VERSION = 7.2.646
> 
>  There is a version 7.2.641 which is identical except that it has an
> older (!) Changelog, and a different version number...
> 
> > +DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).zip
> 
>  and that version has a proper tar.xz.

Indeed, I will use that older version.

> 
> > +DC3DD_SITE =
> > http://downloads.sourceforge.net/project/dc3dd/dc3dd/$(DC3DD_VERSION)/dc3dd%20$(DC3DD_VERSION)
> > +DC3DD_LICENSE = GPLv3
> 
>  I didn't do a full fossology but it looks like all files have the
> 'or later' clause, so it's GPLv3+

You are correct, most files have indeed the 'or later' mention.

> 
> > +DC3DD_LICENSE_FILES = COPYING
> > +
> > +define DC3DD_EXTRACT_CMDS
> > +        $(UNZIP) -d $(@D)/.. $(DL_DIR)/$(DC3DD_SOURCE) || true
> 
>  || true? You want to succeed in case of failure?

Yeah, the zip was somewhat malformed that we need the '|| true'. As we
test the checksum beforehand that didn't hurt much.

> 
>  Also, we normally extract within $(@D) and then move the result.
> Cfr. e.g. espeak.
> 
> > +        chmod a+x $(@D)/configure
> > +        chmod a+x $(@D)/build-aux/install-sh
> 
>  The tar.xz has execute permission set on all files. Not sure if
> that's an improvement :-)
> 
> 
>  Regards,
>  Arnout
> 
> > +endef
> > +
> > +$(eval $(autotools-package))
> > 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170306/47cd5bcb/attachment.asc>

[Buildroot] [PATCH 1/1] dc3dd: new package

[Arnout Vandecappelle]

On 06-03-17 16:57, Beno?t Allard wrote:
> On Fri, 3 Mar 2017 23:42:49 +0100
> Arnout Vandecappelle <arnout@mind.be> wrote:
[snip]
>>> +DC3DD_VERSION = 7.2.646
>>
>>  There is a version 7.2.641 which is identical except that it has an
>> older (!) Changelog, and a different version number...
>>
>>> +DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).zip
>>
>>  and that version has a proper tar.xz.
> 
> Indeed, I will use that older version.

 Please mention in the commit log that they are identical and why we prefer the
"older" one.

>>> +DC3DD_SITE = http://downloads.sourceforge.net/project/dc3dd/dc3dd/$(DC3DD_VERSION)/dc3dd%20$(DC3DD_VERSION)
>>> +DC3DD_LICENSE = GPLv3
>>
>>  I didn't do a full fossology but it looks like all files have the
>> 'or later' clause, so it's GPLv3+
> 
> You are correct, most files have indeed the 'or later' mention.

 Can you please double-check that *all* files mention 'or later'? At least the
ones that do have a copyright header. We don't want to be lying.


 Regards,
 Arnout

[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] dc3dd: new package

[Benoît Allard]

On Mon, 6 Mar 2017 17:41:48 +0100
Arnout Vandecappelle <arnout@mind.be> wrote:

> 
> 
> On 06-03-17 16:57, Beno?t Allard wrote:
> > On Fri, 3 Mar 2017 23:42:49 +0100
> > Arnout Vandecappelle <arnout@mind.be> wrote:
> [snip]
> >>> +DC3DD_VERSION = 7.2.646
> >>
> >>  There is a version 7.2.641 which is identical except that it has
> >> an older (!) Changelog, and a different version number...
> >>
> >>> +DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).zip
> >>
> >>  and that version has a proper tar.xz.
> > 
> > Indeed, I will use that older version.
> 
>  Please mention in the commit log that they are identical and why we
> prefer the "older" one.

No problem.

> 
> >>> +DC3DD_SITE =
> >>> http://downloads.sourceforge.net/project/dc3dd/dc3dd/$(DC3DD_VERSION)/dc3dd%20$(DC3DD_VERSION)
> >>> +DC3DD_LICENSE = GPLv3
> >>
> >>  I didn't do a full fossology but it looks like all files have the
> >> 'or later' clause, so it's GPLv3+
> > 
> > You are correct, most files have indeed the 'or later' mention.
> 
>  Can you please double-check that *all* files mention 'or later'? At
> least the ones that do have a copyright header. We don't want to be
> lying.
> 

Oh boy, that's gonna get fun. Fortunately, debian has a nice
"licensecheck" script (from the "devscripts" package in case you're
wondering) that can pretty well extract license information from source
code. Output attached.

Here, the files that have a copyright header and no "or later" stanza:

The following three are "freely distributable":
./src/hdparm/identify.c: UNKNOWN
./src/hdparm/hpa_dco.c: UNKNOWN
./src/hdparm/sgio.c: UNKNOWN

The following files are actually extracted from the GNU C library:
./lib/strcspn.c: GPL
./lib/stpcpy.c: GPL
./lib/strtoull.c: GPL
./lib/putenv.c: GPL
./lib/strtol.c: GPL
./lib/memcmp.c: GPL
./lib/stpncpy.c: GPL
./lib/memchr.c: GPL
./lib/utime.c: GPL
./lib/utimens.c: GPL
./lib/memchr2.c: GPL

Please advise.


> Also, it fails to build on musl, and uses threads. Use the test-pkg
> script to
> pre-test on the autobuilder toolchains, it just takes an hour or so on
> an average speed computer.

I've done that as well, and I had to add a patch to disable the
building of the man page as we don't need it and it failed on some
configurations.

New version incoming.

Regards,
Ben.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dc3dd-licensecheck
Type: application/octet-stream
Size: 18659 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170307/afd84d53/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170307/afd84d53/attachment.asc>

[Buildroot] [PATCH 1/1] dc3dd: new package

[Arnout Vandecappelle]

On 07-03-17 09:40, Beno?t Allard wrote:
> Here, the files that have a copyright header and no "or later" stanza:
> 
> The following three are "freely distributable":
> ./src/hdparm/identify.c: UNKNOWN
> ./src/hdparm/hpa_dco.c: UNKNOWN
> ./src/hdparm/sgio.c: UNKNOWN

 These we can ignore.


> The following files are actually extracted from the GNU C library:
> ./lib/strcspn.c: GPL
> ./lib/stpcpy.c: GPL
> ./lib/strtoull.c: GPL
> ./lib/putenv.c: GPL
> ./lib/strtol.c: GPL
> ./lib/memcmp.c: GPL
> ./lib/stpncpy.c: GPL
> ./lib/memchr.c: GPL
> ./lib/utime.c: GPL
> ./lib/utimens.c: GPL
> ./lib/memchr2.c: GPL

 Something wrong with your version of licensecheck, because they clearly state
"version 3 or any later version". My licensecheck (sid, 3.0.29-1) correctly
identifies them as GPLv3+.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] dc3dd: new package

[Benoît Allard]

On Tue, 7 Mar 2017 11:31:48 +0100
Arnout Vandecappelle <arnout@mind.be> wrote:

> 
> 
> On 07-03-17 09:40, Beno?t Allard wrote:
> 
> > The following files are actually extracted from the GNU C library:
> > ./lib/strcspn.c: GPL
> > ./lib/stpcpy.c: GPL
> > ./lib/strtoull.c: GPL
> > ./lib/putenv.c: GPL
> > ./lib/strtol.c: GPL
> > ./lib/memcmp.c: GPL
> > ./lib/stpncpy.c: GPL
> > ./lib/memchr.c: GPL
> > ./lib/utime.c: GPL
> > ./lib/utimens.c: GPL
> > ./lib/memchr2.c: GPL
> 
>  Something wrong with your version of licensecheck, because they
> clearly state "version 3 or any later version". My licensecheck (sid,
> 3.0.29-1) correctly identifies them as GPLv3+.
> 

Ok, great, thanks for checking ! I indeed used an older version of the
script (jessie). With that cleared, please consider reviewing the v2 of
my patch :)

Regards,
Ben.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170307/0d197aa7/attachment.asc>

[Buildroot] [PATCH v2 1/1] dc3dd: new package

[Benoît Allard]

We actually prefer the version 7.2.641 (over 7.2.646) as the
content of the release is identical and the 641 has the advantage
of providing a proper .tar.xz file.

Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
---
Changes v1 -> v2 (Suggestions by Arnoud)
  - Fix line lengths in Config.in
  - Add a locally calculated sha256
  - Use a version that has a proper tar.xz file
  - Correct license to be GPLv3+
  - Add dependency on THREADS
  - Add conflict with musl
  - Add patch to not build the manpage

---
 DEVELOPERS                      |  3 +++
 package/Config.in               |  1 +
 package/dc3dd/0001-no_man.patch | 12 ++++++++++++
 package/dc3dd/Config.in         |  9 +++++++++
 package/dc3dd/dc3dd.hash        |  4 ++++
 package/dc3dd/dc3dd.mk          | 13 +++++++++++++
 6 files changed, 42 insertions(+)
 create mode 100644 package/dc3dd/0001-no_man.patch
 create mode 100644 package/dc3dd/Config.in
 create mode 100644 package/dc3dd/dc3dd.hash
 create mode 100644 package/dc3dd/dc3dd.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index ff72ca1..e0a28a6 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -147,6 +147,9 @@ F:	package/taskd/
 N:	Benjamin Kamath <kamath.ben@gmail.com>
 F:	package/lapack/
 
+N:	Beno?t Allard <benoit.allard@greenbone.net>
+F:	package/dc3dd/
+
 N:	Bernd Kuhls <bernd.kuhls@t-online.de>
 F:	package/apache/
 F:	package/apr/
diff --git a/package/Config.in b/package/Config.in
index cfe7fc6..d0fdca4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1767,6 +1767,7 @@ menu "System tools"
 	source "package/cpuload/Config.in"
 	source "package/dcron/Config.in"
 	source "package/ddrescue/Config.in"
+	source "package/dc3dd/Config.in"
 	source "package/debianutils/Config.in"
 	source "package/docker-containerd/Config.in"
 	source "package/docker-engine/Config.in"
diff --git a/package/dc3dd/0001-no_man.patch b/package/dc3dd/0001-no_man.patch
new file mode 100644
index 0000000..07bf713
--- /dev/null
+++ b/package/dc3dd/0001-no_man.patch
@@ -0,0 +1,12 @@
+--- a/Makefile.in	2017-03-06 16:42:29.728814841 +0100
++++ b/Makefile.in	2017-03-06 16:42:54.191899036 +0100
+@@ -685,7 +685,7 @@
+ target_alias = @target_alias@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+-SUBDIRS = lib src man po
++SUBDIRS = lib src po
+ EXTRA_DIST = cfg.mk maint.mk \
+   .prev-version THANKS-to-translators THANKStt.in \
+   .version \
+
diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
new file mode 100644
index 0000000..de8fec1
--- /dev/null
+++ b/package/dc3dd/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_DC3DD
+	bool "dc3dd"
+	help
+	  dc3dd is a patch to the GNU dd program, this version has
+	  several features intended for forensic acquisition of data.
+	  Highlights include hashing on-the-fly, split output files,
+	  pattern writing, a progress meter, and file verification.
+
+	  https://sourceforge.net/projects/dc3dd/
diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
new file mode 100644
index 0000000..5490d8d
--- /dev/null
+++ b/package/dc3dd/dc3dd.hash
@@ -0,0 +1,4 @@
+# From https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2/
+sha1 1bfe81a921a8473a6ecb46f328ecaab761afb55d dc3dd-7.2.641.tar.xz
+# Locally computed
+sha256 7f50aadc38649845ab11014d11013928411c9d2128c941e9630939d4c28cae6d  dc3dd-7.2.641.tar.xz
diff --git a/package/dc3dd/dc3dd.mk b/package/dc3dd/dc3dd.mk
new file mode 100644
index 0000000..3c2aebe
--- /dev/null
+++ b/package/dc3dd/dc3dd.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# dc3dd
+#
+################################################################################
+
+DC3DD_VERSION = 7.2.641
+DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).tar.xz
+DC3DD_SITE = https://downloads.sourceforge.net/project/dc3dd/dc3dd/7.2
+DC3DD_LICENSE = GPLv3+
+DC3DD_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
-- 
2.1.4

[Buildroot] [PATCH v2 1/1] dc3dd: new package

[Benoît Allard]

On Tue,  7 Mar 2017 09:42:18 +0100
Beno?t Allard <benoit.allard@greenbone.net> wrote:

> We actually prefer the version 7.2.641 (over 7.2.646) as the
> content of the release is identical and the 641 has the advantage
> of providing a proper .tar.xz file.
> 
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> ---
> Changes v1 -> v2 (Suggestions by Arnoud)
>   - Fix line lengths in Config.in
>   - Add a locally calculated sha256
>   - Use a version that has a proper tar.xz file
>   - Correct license to be GPLv3+
>   - Add dependency on THREADS
>   - Add conflict with musl
>   - Add patch to not build the manpage
> 
> ---
>  DEVELOPERS                      |  3 +++
>  package/Config.in               |  1 +
>  package/dc3dd/0001-no_man.patch | 12 ++++++++++++
>  package/dc3dd/Config.in         |  9 +++++++++
>  package/dc3dd/dc3dd.hash        |  4 ++++
>  package/dc3dd/dc3dd.mk          | 13 +++++++++++++
>  6 files changed, 42 insertions(+)
>  create mode 100644 package/dc3dd/0001-no_man.patch
>  create mode 100644 package/dc3dd/Config.in
>  create mode 100644 package/dc3dd/dc3dd.hash
>  create mode 100644 package/dc3dd/dc3dd.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index ff72ca1..e0a28a6 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -147,6 +147,9 @@ F:	package/taskd/
>  N:	Benjamin Kamath <kamath.ben@gmail.com>
>  F:	package/lapack/
>  
> +N:	Beno?t Allard <benoit.allard@greenbone.net>
> +F:	package/dc3dd/
> +
>  N:	Bernd Kuhls <bernd.kuhls@t-online.de>
>  F:	package/apache/
>  F:	package/apr/
> diff --git a/package/Config.in b/package/Config.in
> index cfe7fc6..d0fdca4 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1767,6 +1767,7 @@ menu "System tools"
>  	source "package/cpuload/Config.in"
>  	source "package/dcron/Config.in"
>  	source "package/ddrescue/Config.in"
> +	source "package/dc3dd/Config.in"
>  	source "package/debianutils/Config.in"
>  	source "package/docker-containerd/Config.in"
>  	source "package/docker-engine/Config.in"
> diff --git a/package/dc3dd/0001-no_man.patch
> b/package/dc3dd/0001-no_man.patch new file mode 100644
> index 0000000..07bf713
> --- /dev/null
> +++ b/package/dc3dd/0001-no_man.patch
> @@ -0,0 +1,12 @@
> +--- a/Makefile.in	2017-03-06 16:42:29.728814841 +0100
> ++++ b/Makefile.in	2017-03-06 16:42:54.191899036 +0100
> +@@ -685,7 +685,7 @@
> + target_alias = @target_alias@
> + top_builddir = @top_builddir@
> + top_srcdir = @top_srcdir@
> +-SUBDIRS = lib src man po
> ++SUBDIRS = lib src po
> + EXTRA_DIST = cfg.mk maint.mk \
> +   .prev-version THANKS-to-translators THANKStt.in \
> +   .version \
> +
> diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
> new file mode 100644
> index 0000000..de8fec1
> --- /dev/null
> +++ b/package/dc3dd/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_DC3DD
> +	bool "dc3dd"

Somehow the "depends on" made it to the commit changelog, but not
there ... I'll be sending a newer version soon.

> +	help
> +	  dc3dd is a patch to the GNU dd program, this version has
> +	  several features intended for forensic acquisition of data.
> +	  Highlights include hashing on-the-fly, split output files,
> +	  pattern writing, a progress meter, and file verification.
> +
> +	  https://sourceforge.net/projects/dc3dd/
> diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
> new file mode 100644
> index 0000000..5490d8d
> --- /dev/null
> +++ b/package/dc3dd/dc3dd.hash
> @@ -0,0 +1,4 @@
> +# From https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2/
> +sha1 1bfe81a921a8473a6ecb46f328ecaab761afb55d dc3dd-7.2.641.tar.xz
> +# Locally computed
> +sha256
> 7f50aadc38649845ab11014d11013928411c9d2128c941e9630939d4c28cae6d
> dc3dd-7.2.641.tar.xz diff --git a/package/dc3dd/dc3dd.mk
> b/package/dc3dd/dc3dd.mk new file mode 100644 index 0000000..3c2aebe
> --- /dev/null
> +++ b/package/dc3dd/dc3dd.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# dc3dd
> +#
> +################################################################################
> +
> +DC3DD_VERSION = 7.2.641
> +DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).tar.xz
> +DC3DD_SITE =
> https://downloads.sourceforge.net/project/dc3dd/dc3dd/7.2
> +DC3DD_LICENSE = GPLv3+ +DC3DD_LICENSE_FILES = COPYING
> +
> +$(eval $(autotools-package))

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170309/3c1eca5b/attachment.asc>

[Buildroot] [PATCH v3 1/1] dc3dd: new package

[Benoît Allard]

We actually prefer the version 7.2.641 (over 7.2.646) as the
content of the release is identical and the 641 has the advantage
of providing a proper .tar.xz file.

Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
---
Changes v1 -> v2 (Suggestions by Arnoud)
  - Fix line lengths in Config.in
  - Add a locally calculated sha256
  - Use a version that has a proper tar.xz file
  - Correct license to be GPLv3+
  - Add patch to not build the manpage
Changes v2 -> v3
  - Add dependency on THREADS
  - Add conflict with musl

---
 DEVELOPERS                      |  3 +++
 package/Config.in               |  1 +
 package/dc3dd/0001-no_man.patch | 12 ++++++++++++
 package/dc3dd/Config.in         | 11 +++++++++++
 package/dc3dd/dc3dd.hash        |  4 ++++
 package/dc3dd/dc3dd.mk          | 13 +++++++++++++
 6 files changed, 44 insertions(+)
 create mode 100644 package/dc3dd/0001-no_man.patch
 create mode 100644 package/dc3dd/Config.in
 create mode 100644 package/dc3dd/dc3dd.hash
 create mode 100644 package/dc3dd/dc3dd.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index ff72ca1..e0a28a6 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -147,6 +147,9 @@ F:	package/taskd/
 N:	Benjamin Kamath <kamath.ben@gmail.com>
 F:	package/lapack/
 
+N:	Beno?t Allard <benoit.allard@greenbone.net>
+F:	package/dc3dd/
+
 N:	Bernd Kuhls <bernd.kuhls@t-online.de>
 F:	package/apache/
 F:	package/apr/
diff --git a/package/Config.in b/package/Config.in
index cfe7fc6..d0fdca4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1767,6 +1767,7 @@ menu "System tools"
 	source "package/cpuload/Config.in"
 	source "package/dcron/Config.in"
 	source "package/ddrescue/Config.in"
+	source "package/dc3dd/Config.in"
 	source "package/debianutils/Config.in"
 	source "package/docker-containerd/Config.in"
 	source "package/docker-engine/Config.in"
diff --git a/package/dc3dd/0001-no_man.patch b/package/dc3dd/0001-no_man.patch
new file mode 100644
index 0000000..07bf713
--- /dev/null
+++ b/package/dc3dd/0001-no_man.patch
@@ -0,0 +1,12 @@
+--- a/Makefile.in	2017-03-06 16:42:29.728814841 +0100
++++ b/Makefile.in	2017-03-06 16:42:54.191899036 +0100
+@@ -685,7 +685,7 @@
+ target_alias = @target_alias@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+-SUBDIRS = lib src man po
++SUBDIRS = lib src po
+ EXTRA_DIST = cfg.mk maint.mk \
+   .prev-version THANKS-to-translators THANKStt.in \
+   .version \
+
diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
new file mode 100644
index 0000000..63066f9
--- /dev/null
+++ b/package/dc3dd/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_DC3DD
+	bool "dc3dd"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_USES_MUSL
+	help
+	  dc3dd is a patch to the GNU dd program, this version has
+	  several features intended for forensic acquisition of data.
+	  Highlights include hashing on-the-fly, split output files,
+	  pattern writing, a progress meter, and file verification.
+
+	  https://sourceforge.net/projects/dc3dd/
diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
new file mode 100644
index 0000000..5490d8d
--- /dev/null
+++ b/package/dc3dd/dc3dd.hash
@@ -0,0 +1,4 @@
+# From https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2/
+sha1 1bfe81a921a8473a6ecb46f328ecaab761afb55d dc3dd-7.2.641.tar.xz
+# Locally computed
+sha256 7f50aadc38649845ab11014d11013928411c9d2128c941e9630939d4c28cae6d  dc3dd-7.2.641.tar.xz
diff --git a/package/dc3dd/dc3dd.mk b/package/dc3dd/dc3dd.mk
new file mode 100644
index 0000000..3c2aebe
--- /dev/null
+++ b/package/dc3dd/dc3dd.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# dc3dd
+#
+################################################################################
+
+DC3DD_VERSION = 7.2.641
+DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).tar.xz
+DC3DD_SITE = https://downloads.sourceforge.net/project/dc3dd/dc3dd/7.2
+DC3DD_LICENSE = GPLv3+
+DC3DD_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
-- 
2.1.4

[Buildroot] [PATCH v3 1/1] dc3dd: new package

[Jerzy Grzegorek]

Hi Beno?t,

> We actually prefer the version 7.2.641 (over 7.2.646) as the
> content of the release is identical and the 641 has the advantage
> of providing a proper .tar.xz file.
>
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> ---
> Changes v1 -> v2 (Suggestions by Arnoud)
>    - Fix line lengths in Config.in
>    - Add a locally calculated sha256
>    - Use a version that has a proper tar.xz file
>    - Correct license to be GPLv3+
>    - Add patch to not build the manpage
> Changes v2 -> v3
>    - Add dependency on THREADS
>    - Add conflict with musl
>
> ---
>   DEVELOPERS                      |  3 +++
>   package/Config.in               |  1 +
>   package/dc3dd/0001-no_man.patch | 12 ++++++++++++
>   package/dc3dd/Config.in         | 11 +++++++++++
>   package/dc3dd/dc3dd.hash        |  4 ++++
>   package/dc3dd/dc3dd.mk          | 13 +++++++++++++
>   6 files changed, 44 insertions(+)
>   create mode 100644 package/dc3dd/0001-no_man.patch
>   create mode 100644 package/dc3dd/Config.in
>   create mode 100644 package/dc3dd/dc3dd.hash
>   create mode 100644 package/dc3dd/dc3dd.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index ff72ca1..e0a28a6 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -147,6 +147,9 @@ F:	package/taskd/
>   N:	Benjamin Kamath <kamath.ben@gmail.com>
>   F:	package/lapack/
>   
> +N:	Beno?t Allard <benoit.allard@greenbone.net>
> +F:	package/dc3dd/
> +
>   N:	Bernd Kuhls <bernd.kuhls@t-online.de>
>   F:	package/apache/
>   F:	package/apr/
> diff --git a/package/Config.in b/package/Config.in
> index cfe7fc6..d0fdca4 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1767,6 +1767,7 @@ menu "System tools"
>   	source "package/cpuload/Config.in"
>   	source "package/dcron/Config.in"
>   	source "package/ddrescue/Config.in"
> +	source "package/dc3dd/Config.in"

This should be alphabetically ordered.

>   	source "package/debianutils/Config.in"
>   	source "package/docker-containerd/Config.in"
>   	source "package/docker-engine/Config.in"
> diff --git a/package/dc3dd/0001-no_man.patch b/package/dc3dd/0001-no_man.patch
> new file mode 100644
> index 0000000..07bf713
> --- /dev/null
> +++ b/package/dc3dd/0001-no_man.patch
> @@ -0,0 +1,12 @@
> +--- a/Makefile.in	2017-03-06 16:42:29.728814841 +0100
> ++++ b/Makefile.in	2017-03-06 16:42:54.191899036 +0100
> +@@ -685,7 +685,7 @@
> + target_alias = @target_alias@
> + top_builddir = @top_builddir@
> + top_srcdir = @top_srcdir@
> +-SUBDIRS = lib src man po
> ++SUBDIRS = lib src po
> + EXTRA_DIST = cfg.mk maint.mk \
> +   .prev-version THANKS-to-translators THANKStt.in \
> +   .version \
> +
> diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
> new file mode 100644
> index 0000000..63066f9
> --- /dev/null
> +++ b/package/dc3dd/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_DC3DD
> +	bool "dc3dd"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_TOOLCHAIN_USES_MUSL
> +	help
> +	  dc3dd is a patch to the GNU dd program, this version has
> +	  several features intended for forensic acquisition of data.
> +	  Highlights include hashing on-the-fly, split output files,
> +	  pattern writing, a progress meter, and file verification.
> +
> +	  https://sourceforge.net/projects/dc3dd/
> diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
> new file mode 100644
> index 0000000..5490d8d
> --- /dev/null
> +++ b/package/dc3dd/dc3dd.hash
> @@ -0,0 +1,4 @@
> +# From https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2/
> +sha1 1bfe81a921a8473a6ecb46f328ecaab761afb55d dc3dd-7.2.641.tar.xz
> +# Locally computed
> +sha256 7f50aadc38649845ab11014d11013928411c9d2128c941e9630939d4c28cae6d  dc3dd-7.2.641.tar.xz
> diff --git a/package/dc3dd/dc3dd.mk b/package/dc3dd/dc3dd.mk
> new file mode 100644
> index 0000000..3c2aebe
> --- /dev/null
> +++ b/package/dc3dd/dc3dd.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# dc3dd
> +#
> +################################################################################
> +

And here a cosmetic change:

+DC3DD_VERSION_MAJOR = 7.2
+DC3DD_VERSION = $(DC3DD_VERSION_MAJOR).641

> +DC3DD_VERSION = 7.2.641
> +DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).tar.xz
> +DC3DD_SITE = https://downloads.sourceforge.net/project/dc3dd/dc3dd/7.2

+DC3DD_SITE = https://downloads.sourceforge.net/project/dc3dd/dc3dd/$(DC3DD_VERSION_MAJOR)


Regards,
Jerzy

> +DC3DD_LICENSE = GPLv3+
> +DC3DD_LICENSE_FILES = COPYING
> +
> +$(eval $(autotools-package))

[Buildroot] [PATCH v3 1/1] dc3dd: new package

[Thomas Petazzoni]

Hello,

On Thu,  9 Mar 2017 15:20:59 +0100, Beno?t Allard wrote:
> We actually prefer the version 7.2.641 (over 7.2.646) as the
> content of the release is identical and the 641 has the advantage
> of providing a proper .tar.xz file.
> 
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>

In addition to the comment from Jerzy, here is another comment (see
below).

> diff --git a/package/dc3dd/0001-no_man.patch b/package/dc3dd/0001-no_man.patch
> new file mode 100644
> index 0000000..07bf713
> --- /dev/null
> +++ b/package/dc3dd/0001-no_man.patch
> @@ -0,0 +1,12 @@
> +--- a/Makefile.in	2017-03-06 16:42:29.728814841 +0100
> ++++ b/Makefile.in	2017-03-06 16:42:54.191899036 +0100

This patch should have a description + Signed-off-by.

Also it should explain why you are patching Makefile.in and not
Makefile.am. We normally prefer patching Makefile.am and use
<pkg>_AUTORECONF = YES.

Of course, if the upstream project is active, you can submit a patch
adding a --disable-manpages option.

> diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
> new file mode 100644
> index 0000000..63066f9
> --- /dev/null
> +++ b/package/dc3dd/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_DC3DD
> +	bool "dc3dd"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_TOOLCHAIN_USES_MUSL
> +	help
> +	  dc3dd is a patch to the GNU dd program, this version has
> +	  several features intended for forensic acquisition of data.
> +	  Highlights include hashing on-the-fly, split output files,
> +	  pattern writing, a progress meter, and file verification.
> +
> +	  https://sourceforge.net/projects/dc3dd/

You're missing a Config.in comment here about the threads dependency:

comment "dc3dd needs a glibc or uClibc toolchain w/ threads"
	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
		BR2_TOOLCHAIN_USES_MUSL

Could you fix those issues, and the ones reported by Jerzy, and submit
an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4] dc3dd: new package

[Benoît Allard]

We actually prefer the version 7.2.641 (over 7.2.646) as the
content of the release is identical and the 641 has the advantage
of providing a proper .tar.xz file.

Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
---
Changes v1 -> v2 (Suggestions by Arnoud)
   - Fix line lengths in Config.in
   - Add a locally calculated sha256
   - Use a version that has a proper tar.xz file
   - Correct license to be GPLv3+
   - Add patch to not build the manpage
Changes v2 -> v3
   - Add dependency on THREADS
   - Add conflict with musl
Changes v3 -> v4
   - Fix the alphabetical order in Config.in (Suggestion by Jerzy)
   - Add MAJOR variable in mk file (Suggestion by Jerzy)
   - patch the Makefile.am file and add autoreconf (Suggestion by Thomas)
   - Add a comment about the thread dependency in Config.in (Suggestion by Thomas)

---
 DEVELOPERS                      |  3 +++
 package/Config.in               |  1 +
 package/dc3dd/0001-no_man.patch | 14 ++++++++++++++
 package/dc3dd/Config.in         | 15 +++++++++++++++
 package/dc3dd/dc3dd.hash        |  4 ++++
 package/dc3dd/dc3dd.mk          | 16 ++++++++++++++++
 6 files changed, 53 insertions(+)
 create mode 100644 package/dc3dd/0001-no_man.patch
 create mode 100644 package/dc3dd/Config.in
 create mode 100644 package/dc3dd/dc3dd.hash
 create mode 100644 package/dc3dd/dc3dd.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 215a3b4..5f4a635 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -149,6 +149,9 @@ F:	package/taskd/
 N:	Benjamin Kamath <kamath.ben@gmail.com>
 F:	package/lapack/
 
+N:	Beno?t Allard <benoit.allard@greenbone.net>
+F:	package/dc3dd/
+
 N:	Bernd Kuhls <bernd.kuhls@t-online.de>
 F:	package/apache/
 F:	package/apr/
diff --git a/package/Config.in b/package/Config.in
index 9a78e0a..6d91fba 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1779,6 +1779,7 @@ menu "System tools"
 	source "package/coreutils/Config.in"
 	source "package/cpuload/Config.in"
 	source "package/dcron/Config.in"
+	source "package/dc3dd/Config.in"
 	source "package/ddrescue/Config.in"
 	source "package/debianutils/Config.in"
 	source "package/docker-containerd/Config.in"
diff --git a/package/dc3dd/0001-no_man.patch b/package/dc3dd/0001-no_man.patch
new file mode 100644
index 0000000..9abdeac
--- /dev/null
+++ b/package/dc3dd/0001-no_man.patch
@@ -0,0 +1,14 @@
+Remove the man directory to the subdirs to prevent building the man pages
+
+Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
+--- a/Makefile.am	2017-03-27 09:53:19.988820588 +0200
++++ b/Makefile.am	2017-03-27 09:54:14.325817466 +0200
+@@ -15,7 +15,7 @@
+ # You should have received a copy of the GNU General Public License
+ # along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ 
+-SUBDIRS = lib src man po
++SUBDIRS = lib src po
+ EXTRA_DIST = cfg.mk maint.mk \
+   .prev-version THANKS-to-translators THANKStt.in \
+   .version \
diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
new file mode 100644
index 0000000..0383897
--- /dev/null
+++ b/package/dc3dd/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_DC3DD
+	bool "dc3dd"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_USES_MUSL
+	help
+	  dc3dd is a patch to the GNU dd program, this version has
+	  several features intended for forensic acquisition of data.
+	  Highlights include hashing on-the-fly, split output files,
+	  pattern writing, a progress meter, and file verification.
+
+	  https://sourceforge.net/projects/dc3dd/
+
+comment "dc3dd needs a glibc or uClibc toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_TOOLCHAIN_USES_MUSL
diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
new file mode 100644
index 0000000..5490d8d
--- /dev/null
+++ b/package/dc3dd/dc3dd.hash
@@ -0,0 +1,4 @@
+# From https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2/
+sha1 1bfe81a921a8473a6ecb46f328ecaab761afb55d dc3dd-7.2.641.tar.xz
+# Locally computed
+sha256 7f50aadc38649845ab11014d11013928411c9d2128c941e9630939d4c28cae6d  dc3dd-7.2.641.tar.xz
diff --git a/package/dc3dd/dc3dd.mk b/package/dc3dd/dc3dd.mk
new file mode 100644
index 0000000..fef9093
--- /dev/null
+++ b/package/dc3dd/dc3dd.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# dc3dd
+#
+################################################################################
+
+DC3DD_VERSION_MAJOR = 7.2
+DC3DD_VERSION = $(DC3DD_VERSION_MAJOR).641
+DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).tar.xz
+DC3DD_SITE = https://downloads.sourceforge.net/project/dc3dd/dc3dd/$(DC3DD_VERSION_MAJOR)
+DC3DD_LICENSE = GPLv3+
+DC3DD_LICENSE_FILES = COPYING
+# We are patching the Makefile.am
+DC3DD_AUTORECONF = yes
+
+$(eval $(autotools-package))
-- 
2.1.4

[Buildroot] [PATCH v4] dc3dd: new package

[Thomas Petazzoni]

Hello,

On Mon, 27 Mar 2017 10:32:10 +0200, Beno?t Allard wrote:
> We actually prefer the version 7.2.641 (over 7.2.646) as the
> content of the release is identical and the 641 has the advantage
> of providing a proper .tar.xz file.
> 
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> ---
> Changes v1 -> v2 (Suggestions by Arnoud)
>    - Fix line lengths in Config.in
>    - Add a locally calculated sha256
>    - Use a version that has a proper tar.xz file
>    - Correct license to be GPLv3+
>    - Add patch to not build the manpage
> Changes v2 -> v3
>    - Add dependency on THREADS
>    - Add conflict with musl
> Changes v3 -> v4
>    - Fix the alphabetical order in Config.in (Suggestion by Jerzy)
>    - Add MAJOR variable in mk file (Suggestion by Jerzy)
>    - patch the Makefile.am file and add autoreconf (Suggestion by Thomas)
>    - Add a comment about the thread dependency in Config.in (Suggestion by Thomas)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] (no subject)

[Benoît Allard]

[Buildroot] [PATCH 1/1] dc3dd: new package

[Benoît Allard]

Looks like I mis-configured my mail client ... Want me to send it
again ?

On Thu, 02 Mar 2017 16:27:04 +0100
Beno?t Allard <benoit.allard@greenbone.net> wrote:

> From cba443f28cdc816450acd0f7cdcf47d7655dff04 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Beno=C3=AEt=20Allard?= <benoit.allard@greenbone.net>
> Date: Sat, 4 Mar 2017 00:31:42 +0100
> Subject: [PATCH 1/1] dc3dd: new package
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> ---
>  DEVELOPERS               |  3 +++
>  package/Config.in        |  1 +
>  package/dc3dd/Config.in  |  9 +++++++++
>  package/dc3dd/dc3dd.hash |  2 ++
>  package/dc3dd/dc3dd.mk   | 19 +++++++++++++++++++
>  5 files changed, 34 insertions(+)
>  create mode 100644 package/dc3dd/Config.in
>  create mode 100644 package/dc3dd/dc3dd.hash
>  create mode 100644 package/dc3dd/dc3dd.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 1bf07c3..6ed713b 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -146,6 +146,9 @@ F:	package/taskd/
>  N:	Benjamin Kamath <kamath.ben@gmail.com>
>  F:	package/lapack/
>  
> +N:	Beno?t Allard <benoit.allard@greenbone.net>
> +F:	package/dc3dd/
> +
>  N:	Bernd Kuhls <bernd.kuhls@t-online.de>
>  F:	package/apache/
>  F:	package/apr/
> diff --git a/package/Config.in b/package/Config.in
> index 921a06c..376c573 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1762,6 +1762,7 @@ menu "System tools"
>  	source "package/cpuload/Config.in"
>  	source "package/dcron/Config.in"
>  	source "package/ddrescue/Config.in"
> +	source "package/dc3dd/Config.in"
>  	source "package/debianutils/Config.in"
>  	source "package/docker-containerd/Config.in"
>  	source "package/docker-engine/Config.in"
> diff --git a/package/dc3dd/Config.in b/package/dc3dd/Config.in
> new file mode 100644
> index 0000000..0a2a32e
> --- /dev/null
> +++ b/package/dc3dd/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_DC3DD
> +	bool "dc3dd"
> +	help
> +          dc3dd is a patch to the GNU dd program, this version has
> several
> +          features intended for forensic acquisition of data.
> Highlights
> +          include hashing on-the-fly, split output files, pattern
> writing, a
> +          progress meter, and file verification.
> +
> +          https://sourceforge.net/projects/dc3dd/
> diff --git a/package/dc3dd/dc3dd.hash b/package/dc3dd/dc3dd.hash
> new file mode 100644
> index 0000000..edd75c2
> --- /dev/null
> +++ b/package/dc3dd/dc3dd.hash
> @@ -0,0 +1,2 @@
> +# From
> https://sourceforge.net/projects/dc3dd/files/dc3dd/7.2.646/dc3dd%207.2.646/
> +sha1 3d3d9ba5f3b18fbf4798e1f3554f2d34d0ce5e2c dc3dd-7.2.646.zip diff
> --git a/package/dc3dd/dc3dd.mk b/package/dc3dd/dc3dd.mk new file mode
> 100644 index 0000000..5a25bee
> --- /dev/null
> +++ b/package/dc3dd/dc3dd.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# dc3dd
> +#
> +################################################################################
> +
> +DC3DD_VERSION = 7.2.646
> +DC3DD_SOURCE = dc3dd-$(DC3DD_VERSION).zip
> +DC3DD_SITE =
> http://downloads.sourceforge.net/project/dc3dd/dc3dd/$(DC3DD_VERSION)/dc3dd%20$(DC3DD_VERSION)
> +DC3DD_LICENSE = GPLv3 +DC3DD_LICENSE_FILES = COPYING
> +
> +define DC3DD_EXTRACT_CMDS
> +        $(UNZIP) -d $(@D)/.. $(DL_DIR)/$(DC3DD_SOURCE) || true
> +        chmod a+x $(@D)/configure
> +        chmod a+x $(@D)/build-aux/install-sh
> +endef
> +
> +$(eval $(autotools-package))

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170302/55b2881e/attachment.asc>

[Buildroot] [PATCH 1/1] dc3dd: new package

[Fabio Estevam]

On Thu, Mar 2, 2017 at 12:58 PM, Beno?t Allard
<benoit.allard@greenbone.net> wrote:
> Looks like I mis-configured my mail client ... Want me to send it
> again ?

Please try again with 'git send-email'.