* [PATCH] workqueue: use setup_deferrable_timer
@ 2017-02-26 0:58 Geliang Tang
2017-02-26 0:58 ` Geliang Tang
2017-03-06 20:43 ` [PATCH] workqueue: " Tejun Heo
0 siblings, 2 replies; 4+ messages in thread
From: Geliang Tang @ 2017-02-26 0:58 UTC (permalink / raw)
To: Tejun Heo, Lai Jiangshan; +Cc: Geliang Tang, linux-kernel
Use setup_deferrable_timer() instead of init_timer_deferrable() to
simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
kernel/workqueue.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 072cbc9..54a8fff 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -3208,9 +3208,8 @@ static int init_worker_pool(struct worker_pool *pool)
INIT_LIST_HEAD(&pool->idle_list);
hash_init(pool->busy_hash);
- init_timer_deferrable(&pool->idle_timer);
- pool->idle_timer.function = idle_worker_timeout;
- pool->idle_timer.data = (unsigned long)pool;
+ setup_deferrable_timer(&pool->idle_timer, idle_worker_timeout,
+ (unsigned long)pool);
setup_timer(&pool->mayday_timer, pool_mayday_timeout,
(unsigned long)pool);
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] writeback: use setup_deferrable_timer
2017-02-26 0:58 [PATCH] workqueue: use setup_deferrable_timer Geliang Tang
@ 2017-02-26 0:58 ` Geliang Tang
2017-03-06 20:43 ` [PATCH] workqueue: " Tejun Heo
1 sibling, 0 replies; 4+ messages in thread
From: Geliang Tang @ 2017-02-26 0:58 UTC (permalink / raw)
To: Andrew Morton, Johannes Weiner, Mel Gorman, Michal Hocko, Jens Axboe
Cc: Geliang Tang, linux-mm, linux-kernel
Use setup_deferrable_timer() instead of init_timer_deferrable() to
simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
mm/page-writeback.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 26a6081..9e7d576 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -649,9 +649,8 @@ int wb_domain_init(struct wb_domain *dom, gfp_t gfp)
spin_lock_init(&dom->lock);
- init_timer_deferrable(&dom->period_timer);
- dom->period_timer.function = writeout_period;
- dom->period_timer.data = (unsigned long)dom;
+ setup_deferrable_timer(&dom->period_timer, writeout_period,
+ (unsigned long)dom);
dom->dirty_limit_tstamp = jiffies;
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] writeback: use setup_deferrable_timer
@ 2017-02-26 0:58 ` Geliang Tang
0 siblings, 0 replies; 4+ messages in thread
From: Geliang Tang @ 2017-02-26 0:58 UTC (permalink / raw)
To: Andrew Morton, Johannes Weiner, Mel Gorman, Michal Hocko, Jens Axboe
Cc: Geliang Tang, linux-mm, linux-kernel
Use setup_deferrable_timer() instead of init_timer_deferrable() to
simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
mm/page-writeback.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 26a6081..9e7d576 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -649,9 +649,8 @@ int wb_domain_init(struct wb_domain *dom, gfp_t gfp)
spin_lock_init(&dom->lock);
- init_timer_deferrable(&dom->period_timer);
- dom->period_timer.function = writeout_period;
- dom->period_timer.data = (unsigned long)dom;
+ setup_deferrable_timer(&dom->period_timer, writeout_period,
+ (unsigned long)dom);
dom->dirty_limit_tstamp = jiffies;
--
2.9.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] workqueue: use setup_deferrable_timer
2017-02-26 0:58 [PATCH] workqueue: use setup_deferrable_timer Geliang Tang
2017-02-26 0:58 ` Geliang Tang
@ 2017-03-06 20:43 ` Tejun Heo
1 sibling, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2017-03-06 20:43 UTC (permalink / raw)
To: Geliang Tang; +Cc: Lai Jiangshan, linux-kernel
On Sun, Feb 26, 2017 at 08:58:21AM +0800, Geliang Tang wrote:
> Use setup_deferrable_timer() instead of init_timer_deferrable() to
> simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Applied to wq/for-4.12.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-06 20:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-26 0:58 [PATCH] workqueue: use setup_deferrable_timer Geliang Tang
2017-02-26 0:58 ` [PATCH] writeback: " Geliang Tang
2017-02-26 0:58 ` Geliang Tang
2017-03-06 20:43 ` [PATCH] workqueue: " Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.