[PATCH] staging: speakup: kobjects: Delete comparison

[PATCH] staging: speakup: kobjects: Delete comparison

[Tamara Diaconita]

Delete comparison in 'if' structure to fix the checkpath.pl issue:
CHECK: Comparison to NULL could be written 'synth'.

Comparison to NULL is not necessary because 'if' structure tests if
'synth' is NULL anyway.

Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
---
 drivers/staging/speakup/kobjects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index ac6ed8b..0cd5384 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -391,7 +391,7 @@ static ssize_t synth_store(struct kobject *kobj, struct kobj_attribute *attr,
 		len--;
 	new_synth_name[len] = '\0';
 	spk_strlwr(new_synth_name);
-	if ((synth != NULL) && (!strcmp(new_synth_name, synth->name))) {
+	if ((synth) && (!strcmp(new_synth_name, synth->name))) {
 		pr_warn("%s already in use\n", new_synth_name);
 	} else if (synth_init(new_synth_name) != 0) {
 		pr_warn("failed to init synth %s\n", new_synth_name);
-- 
2.9.3

Re: [Outreachy kernel] [PATCH] staging: speakup: kobjects: Delete comparison

[Daniel Baluta]

On Tue, Mar 7, 2017 at 11:21 AM, Tamara Diaconita
<diaconitatamara@gmail.com> wrote:
> Delete comparison in 'if' structure to fix the checkpath.pl issue:
> CHECK: Comparison to NULL could be written 'synth'.
>
> Comparison to NULL is not necessary because 'if' structure tests if
> 'synth' is NULL anyway.
This explanation should be placed before mentioning checkpatch.pl.

The commit message shouldn't focus on the error reported
by checkpatch, but mostly on why this patch is needed.

After, you explain this you can add a mention that it was discovered
using checkpatch :).


>
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
> ---
>  drivers/staging/speakup/kobjects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index ac6ed8b..0cd5384 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -391,7 +391,7 @@ static ssize_t synth_store(struct kobject *kobj, struct kobj_attribute *attr,
>                 len--;
>         new_synth_name[len] = '\0';
>         spk_strlwr(new_synth_name);
> -       if ((synth != NULL) && (!strcmp(new_synth_name, synth->name))) {
> +       if ((synth) && (!strcmp(new_synth_name, synth->name))) {
>                 pr_warn("%s already in use\n", new_synth_name);

At this point you can remove the parenthesis (synth) -> synth

>         } else if (synth_init(new_synth_name) != 0) {
>                 pr_warn("failed to init synth %s\n", new_synth_name);

Re: [Outreachy kernel] [PATCH] staging: speakup: kobjects: Delete comparison

[Julia Lawall]

On Tue, 7 Mar 2017, Tamara Diaconita wrote:

> Delete comparison in 'if' structure to fix the checkpath.pl issue:
> CHECK: Comparison to NULL could be written 'synth'.
>
> Comparison to NULL is not necessary because 'if' structure tests if
> 'synth' is NULL anyway.
>
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
> ---
>  drivers/staging/speakup/kobjects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index ac6ed8b..0cd5384 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -391,7 +391,7 @@ static ssize_t synth_store(struct kobject *kobj, struct kobj_attribute *attr,
>  		len--;
>  	new_synth_name[len] = '\0';
>  	spk_strlwr(new_synth_name);
> -	if ((synth != NULL) && (!strcmp(new_synth_name, synth->name))) {
> +	if ((synth) && (!strcmp(new_synth_name, synth->name))) {

The parentheses around synth are also not needed.

julia

>  		pr_warn("%s already in use\n", new_synth_name);
>  	} else if (synth_init(new_synth_name) != 0) {
>  		pr_warn("failed to init synth %s\n", new_synth_name);
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170307092155.14802-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>