* [PATCH] staging: bcm2835-audio: Fix alignment with parenthesis
@ 2017-03-07 14:30 Sreya Mittal
2017-03-07 15:54 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Sreya Mittal @ 2017-03-07 14:30 UTC (permalink / raw)
To: outreachy-kernel
Cc: Sreya Mittal, Greg Kroah-Hartman, Florian Fainelli, Ray Jui,
Scott Branden, bcm-kernel-feedback-list, Stephen Warren,
Lee Jones, Eric Anholt
Fix the checkpatch issue:
Alignment should match open parenthesis
Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
---
drivers/staging/bcm2835-audio/bcm2835-ctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
index a4ffa1b..2d8bc08 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
@@ -107,7 +107,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,
}
static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol,
- struct snd_ctl_elem_value *ucontrol)
+ struct snd_ctl_elem_value *ucontrol)
{
struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
int changed = 0;
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fix alignment with parenthesis
2017-03-07 14:30 [PATCH] staging: bcm2835-audio: Fix alignment with parenthesis Sreya Mittal
@ 2017-03-07 15:54 ` Julia Lawall
2017-03-07 19:06 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2017-03-07 15:54 UTC (permalink / raw)
To: Sreya Mittal
Cc: outreachy-kernel, Greg Kroah-Hartman, Florian Fainelli, Ray Jui,
Scott Branden, bcm-kernel-feedback-list, Stephen Warren,
Lee Jones, Eric Anholt
On Tue, 7 Mar 2017, Sreya Mittal wrote:
> Fix the checkpatch issue:
> Alignment should match open parenthesis
>
> Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
> ---
> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 2 +-
I don't see this file in staging-testing anymore.
julia
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> index a4ffa1b..2d8bc08 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> @@ -107,7 +107,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,
> }
>
> static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol,
> - struct snd_ctl_elem_value *ucontrol)
> + struct snd_ctl_elem_value *ucontrol)
> {
> struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
> int changed = 0;
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170307143056.3252-1-sreyamittal5%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fix alignment with parenthesis
2017-03-07 15:54 ` [Outreachy kernel] " Julia Lawall
@ 2017-03-07 19:06 ` Greg Kroah-Hartman
2017-03-07 19:50 ` Sreya Mittal
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-07 19:06 UTC (permalink / raw)
To: Julia Lawall
Cc: Sreya Mittal, outreachy-kernel, Florian Fainelli, Ray Jui,
Scott Branden, bcm-kernel-feedback-list, Stephen Warren,
Lee Jones, Eric Anholt
On Tue, Mar 07, 2017 at 04:54:07PM +0100, Julia Lawall wrote:
>
>
> On Tue, 7 Mar 2017, Sreya Mittal wrote:
>
> > Fix the checkpatch issue:
> > Alignment should match open parenthesis
> >
> > Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
> > ---
> > drivers/staging/bcm2835-audio/bcm2835-ctl.c | 2 +-
>
> I don't see this file in staging-testing anymore.
It moved. And I think someone else already made this change :(
Sreya, please rebase your patch and see if it still is needed. If so,
please resend the updated version.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fix alignment with parenthesis
2017-03-07 19:06 ` Greg Kroah-Hartman
@ 2017-03-07 19:50 ` Sreya Mittal
2017-03-07 19:57 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Sreya Mittal @ 2017-03-07 19:50 UTC (permalink / raw)
To: outreachy-kernel
Cc: julia.lawall, sreyamittal5, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, swarren, lee, eric
[-- Attachment #1.1: Type: text/plain, Size: 841 bytes --]
On Wednesday, March 8, 2017 at 12:36:16 AM UTC+5:30, gregkh wrote:
>
> On Tue, Mar 07, 2017 at 04:54:07PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 7 Mar 2017, Sreya Mittal wrote:
> >
> > > Fix the checkpatch issue:
> > > Alignment should match open parenthesis
> > >
> > > Signed-off-by: Sreya Mittal <sreyam...@gmail.com <javascript:>>
> > > ---
> > > drivers/staging/bcm2835-audio/bcm2835-ctl.c | 2 +-
> >
> > I don't see this file in staging-testing anymore.
>
> It moved. And I think someone else already made this change :(
>
> Sreya, please rebase your patch and see if it still is needed. If so,
> please resend the updated version.
>
The file exists in drivers/staging/vc04_services/bcm2835-audio without
the change I had made. Should I redo the patch in this file?
Sreya
>
> thanks,
>
> greg k-h
>
[-- Attachment #1.2: Type: text/html, Size: 1466 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fix alignment with parenthesis
2017-03-07 19:50 ` Sreya Mittal
@ 2017-03-07 19:57 ` Greg KH
2017-03-07 20:13 ` Sreya Mittal
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2017-03-07 19:57 UTC (permalink / raw)
To: Sreya Mittal
Cc: outreachy-kernel, julia.lawall, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, swarren, lee, eric
On Tue, Mar 07, 2017 at 11:50:26AM -0800, Sreya Mittal wrote:
>
>
> On Wednesday, March 8, 2017 at 12:36:16 AM UTC+5:30, gregkh wrote:
>
> On Tue, Mar 07, 2017 at 04:54:07PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 7 Mar 2017, Sreya Mittal wrote:
> >
> > > Fix the checkpatch issue:
> > > Alignment should match open parenthesis
> > >
> > > Signed-off-by: Sreya Mittal <sreyam...@gmail.com>
> > > ---
> > > �drivers/staging/bcm2835-audio/bcm2835-ctl.c | 2 +-
> >
> > I don't see this file in staging-testing anymore.
>
> It moved. �And I think someone else already made this change :(
>
> Sreya, please rebase your patch and see if it still is needed. �If so,
> please resend the updated version.
>
>
> The file exists in drivers/staging/vc04_services/bcm2835-audio without
> the change I had made. Should I redo the patch in this file?
Yes please.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fix alignment with parenthesis
2017-03-07 19:57 ` Greg KH
@ 2017-03-07 20:13 ` Sreya Mittal
0 siblings, 0 replies; 6+ messages in thread
From: Sreya Mittal @ 2017-03-07 20:13 UTC (permalink / raw)
To: outreachy-kernel
Cc: sreyamittal5, julia.lawall, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, swarren, lee, eric
[-- Attachment #1.1: Type: text/plain, Size: 1110 bytes --]
On Wednesday, March 8, 2017 at 1:28:05 AM UTC+5:30, Greg Kroah-Hartman
wrote:
>
> On Tue, Mar 07, 2017 at 11:50:26AM -0800, Sreya Mittal wrote:
> >
> >
> > On Wednesday, March 8, 2017 at 12:36:16 AM UTC+5:30, gregkh wrote:
> >
> > On Tue, Mar 07, 2017 at 04:54:07PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 7 Mar 2017, Sreya Mittal wrote:
> > >
> > > > Fix the checkpatch issue:
> > > > Alignment should match open parenthesis
> > > >
> > > > Signed-off-by: Sreya Mittal <sreyam...@gmail.com>
> > > > ---
> > > > drivers/staging/bcm2835-audio/bcm2835-ctl.c | 2 +-
> > >
> > > I don't see this file in staging-testing anymore.
> >
> > It moved. And I think someone else already made this change :(
> >
> > Sreya, please rebase your patch and see if it still is needed. If
> so,
> > please resend the updated version.
> >
> >
> > The file exists in drivers/staging/vc04_services/bcm2835-audio without
> > the change I had made. Should I redo the patch in this file?
>
> Yes please.
>
Done :)
Sreya
[-- Attachment #1.2: Type: text/html, Size: 1541 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-07 20:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-07 14:30 [PATCH] staging: bcm2835-audio: Fix alignment with parenthesis Sreya Mittal
2017-03-07 15:54 ` [Outreachy kernel] " Julia Lawall
2017-03-07 19:06 ` Greg Kroah-Hartman
2017-03-07 19:50 ` Sreya Mittal
2017-03-07 19:57 ` Greg KH
2017-03-07 20:13 ` Sreya Mittal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.