All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Yong Wang <wang.yong19@zte.com.cn>
Cc: jianfeng.tan@intel.com, dev@dpdk.org
Subject: Re: [PATCH] doc: fix parameter of virtio_user for container
Date: Wed, 8 Mar 2017 09:36:34 +0800	[thread overview]
Message-ID: <20170308013634.GU18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1488894525-5430-1-git-send-email-wang.yong19@zte.com.cn>

On Tue, Mar 07, 2017 at 08:48:45AM -0500, Yong Wang wrote:
> Update the "Virtio_user for Container Networking" doc, add the
> "--file-prefix" option to testpmd in host and container to avoid
> hugepage config file conflict.
> 
> Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container
> networking")

Fixline should be one line: don't break it to two.

> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
>  doc/guides/howto/virtio_user_for_container_networking.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/howto/virtio_user_for_container_networking.rst b/doc/guides/howto/virtio_user_for_container_networking.rst
> index dbb9319..d08a5e3 100644
> --- a/doc/guides/howto/virtio_user_for_container_networking.rst
> +++ b/doc/guides/howto/virtio_user_for_container_networking.rst
> @@ -111,7 +111,8 @@ some minor changes.
>      .. code-block:: console
>  
>          $(testpmd) -l 0-1 -n 4 --socket-mem 1024,1024 \
> -            --vdev 'eth_vhost0,iface=/tmp/sock0' --no-pci -- -i
> +            --vdev 'eth_vhost0,iface=/tmp/sock0' \
> +            --file-prefix=host_ --no-pci -- -i

Though it's okay to add the "_", it looks a bit weird. I'd like to
remove it.

Besides that,

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>


	--yliu
>  
>  #. Start a container instance with a virtio-user port.
>  
> @@ -121,6 +122,7 @@ some minor changes.
>              -v /dev/hugepages:/dev/hugepages \
>              dpdk-app-testpmd testpmd -l 6-7 -n 4 -m 1024 --no-pci \
>              --vdev=virtio_user0,path=/var/run/usvhost \
> +            --file-prefix=container_ \
>  	    -- -i --txqflags=0xf00 --disable-hw-vlan
>  
>  Note: If we run all above setup on the host, it's a shm-based IPC.
> -- 
> 1.8.3.1
> 

      parent reply	other threads:[~2017-03-08  1:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 13:48 [PATCH] doc: fix parameter of virtio_user for container Yong Wang
2017-03-07 17:24 ` Mcnamara, John
2017-03-08  1:36 ` Yuanhan Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170308013634.GU18844@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=wang.yong19@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.