All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH umr] Fix ring offset to dword instead of bytes
@ 2017-03-08 16:31 Tom St Denis
       [not found] ` <20170308163139.20015-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Tom St Denis @ 2017-03-08 16:31 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Tom St Denis

This allows you to specify (say)

-R gfx[16:32] to read words 16 through 32 which is
consistent with how the data is presented.

This patch also correctly enables the PM4 decoder
when specifying a range of words.

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
---
 src/app/ring_read.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/app/ring_read.c b/src/app/ring_read.c
index 970310b9bf52..d6b3df58be4d 100644
--- a/src/app/ring_read.c
+++ b/src/app/ring_read.c
@@ -96,7 +96,10 @@ void umr_read_ring(struct umr_asic *asic, char *ringpath)
 		} else {
 			sscanf(from, "%"SCNu32, &start);
 			sscanf(to, "%"SCNu32, &end);
+			start *= 4;
+			end *= 4;
 			use_decoder = 1;
+			decoder.pm4.cur_opcode = 0xFFFFFFFF;
 		}
 	}
 	end %= ringsize;
-- 
2.11.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH umr] Fix ring offset to dword instead of bytes
       [not found] ` <20170308163139.20015-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
@ 2017-03-08 22:53   ` Edward O'Callaghan
  0 siblings, 0 replies; 2+ messages in thread
From: Edward O'Callaghan @ 2017-03-08 22:53 UTC (permalink / raw)
  To: Tom St Denis, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Tom St Denis


[-- Attachment #1.1.1: Type: text/plain, Size: 998 bytes --]

Acked-by: Edward O'Callaghan <funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>

On 03/09/2017 03:31 AM, Tom St Denis wrote:
> This allows you to specify (say)
> 
> -R gfx[16:32] to read words 16 through 32 which is
> consistent with how the data is presented.
> 
> This patch also correctly enables the PM4 decoder
> when specifying a range of words.
> 
> Signed-off-by: Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>
> ---
>  src/app/ring_read.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/app/ring_read.c b/src/app/ring_read.c
> index 970310b9bf52..d6b3df58be4d 100644
> --- a/src/app/ring_read.c
> +++ b/src/app/ring_read.c
> @@ -96,7 +96,10 @@ void umr_read_ring(struct umr_asic *asic, char *ringpath)
>  		} else {
>  			sscanf(from, "%"SCNu32, &start);
>  			sscanf(to, "%"SCNu32, &end);
> +			start *= 4;
> +			end *= 4;
>  			use_decoder = 1;
> +			decoder.pm4.cur_opcode = 0xFFFFFFFF;
>  		}
>  	}
>  	end %= ringsize;
> 


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-08 22:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-08 16:31 [PATCH umr] Fix ring offset to dword instead of bytes Tom St Denis
     [not found] ` <20170308163139.20015-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2017-03-08 22:53   ` Edward O'Callaghan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.