All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	nsekhar@ti.com
Subject: Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support
Date: Wed, 8 Mar 2017 11:14:19 -0800	[thread overview]
Message-ID: <20170308191419.GA12085@infradead.org> (raw)
In-Reply-To: <650c53fc-482c-feab-faa3-c30689d3d128@synopsys.com>

On Wed, Mar 08, 2017 at 03:32:03PM +0000, Joao Pinto wrote:
> #define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register)		\
> 					((0x3 << 20) | (region << 9) |	\
> 					(0x1 << 8)

Can you turn this and any similar macro into inline functions?

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Joao Pinto <Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Jingoo Han <jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	nsekhar-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support
Date: Wed, 8 Mar 2017 11:14:19 -0800	[thread overview]
Message-ID: <20170308191419.GA12085@infradead.org> (raw)
In-Reply-To: <650c53fc-482c-feab-faa3-c30689d3d128-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>

On Wed, Mar 08, 2017 at 03:32:03PM +0000, Joao Pinto wrote:
> #define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register)		\
> 					((0x3 << 20) | (region << 9) |	\
> 					(0x1 << 8)

Can you turn this and any similar macro into inline functions?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	Jingoo Han <jingoohan1@gmail.com>,
	nsekhar@ti.com, linux-kernel@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support
Date: Wed, 8 Mar 2017 11:14:19 -0800	[thread overview]
Message-ID: <20170308191419.GA12085@infradead.org> (raw)
In-Reply-To: <650c53fc-482c-feab-faa3-c30689d3d128@synopsys.com>

On Wed, Mar 08, 2017 at 03:32:03PM +0000, Joao Pinto wrote:
> #define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register)		\
> 					((0x3 << 20) | (region << 9) |	\
> 					(0x1 << 8)

Can you turn this and any similar macro into inline functions?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support
Date: Wed, 8 Mar 2017 11:14:19 -0800	[thread overview]
Message-ID: <20170308191419.GA12085@infradead.org> (raw)
In-Reply-To: <650c53fc-482c-feab-faa3-c30689d3d128@synopsys.com>

On Wed, Mar 08, 2017 at 03:32:03PM +0000, Joao Pinto wrote:
> #define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register)		\
> 					((0x3 << 20) | (region << 9) |	\
> 					(0x1 << 8)

Can you turn this and any similar macro into inline functions?

  parent reply	other threads:[~2017-03-08 19:14 UTC|newest]

Thread overview: 184+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17  9:50 [PATCH v2 00/22] PCI: Support for configurable PCI endpoint Kishon Vijay Abraham I
2017-02-17  9:50 ` Kishon Vijay Abraham I
2017-02-17  9:50 ` Kishon Vijay Abraham I
2017-02-17  9:50 ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 01/22] PCI: endpoint: Add EP core layer to enable EP controller and EP functions Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17 11:26   ` Joao Pinto
2017-02-17 11:26     ` Joao Pinto
2017-02-17 11:26     ` Joao Pinto
2017-02-17 11:26     ` Joao Pinto
2017-02-17 11:37     ` Kishon Vijay Abraham I
2017-02-17 11:37       ` Kishon Vijay Abraham I
2017-02-17 11:37       ` Kishon Vijay Abraham I
2017-02-17 11:37       ` Kishon Vijay Abraham I
2017-02-17 11:39       ` Joao Pinto
2017-02-17 11:39         ` Joao Pinto
2017-02-17 11:39         ` Joao Pinto
2017-02-17 11:39         ` Joao Pinto
2017-02-17  9:50 ` [PATCH v2 02/22] Documentation: PCI: Guide to use PCI Endpoint Core Layer Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17 11:43   ` Joao Pinto
2017-02-17 11:43     ` Joao Pinto
2017-02-17 11:43     ` Joao Pinto
2017-02-17 11:43     ` Joao Pinto
2017-02-17  9:50 ` [PATCH v2 03/22] PCI: endpoint: Introduce configfs entry for configuring EP functions Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17 12:01   ` Kishon Vijay Abraham I
2017-02-17 12:01     ` Kishon Vijay Abraham I
2017-02-17 12:01     ` Kishon Vijay Abraham I
2017-02-17 17:04   ` Christoph Hellwig
2017-02-17 17:04     ` Christoph Hellwig
2017-02-17 17:04     ` Christoph Hellwig
2017-03-06  9:41     ` Kishon Vijay Abraham I
2017-03-06  9:41       ` Kishon Vijay Abraham I
2017-03-06  9:41       ` Kishon Vijay Abraham I
2017-03-06  9:41       ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 04/22] Documentation: PCI: Guide to use pci endpoint configfs Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17 13:05   ` Joao Pinto
2017-02-17 13:05     ` Joao Pinto
2017-02-17 13:05     ` Joao Pinto
2017-02-17 13:05     ` Joao Pinto
2017-02-17 17:15   ` Christoph Hellwig
2017-02-17 17:15     ` Christoph Hellwig
2017-02-17 17:15     ` Christoph Hellwig
2017-02-17 17:15     ` Christoph Hellwig
2017-03-06 10:16     ` Kishon Vijay Abraham I
2017-03-06 10:16       ` Kishon Vijay Abraham I
2017-03-06 10:16       ` Kishon Vijay Abraham I
2017-03-06 10:16       ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 05/22] Documentation: PCI: Add specification for the *pci test* function device Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 06/22] PCI: endpoint: functions: Add an EP function to test PCI Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 07/22] Documentation: PCI: Add binding documentation for pci-test endpoint function Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17 13:15   ` Kishon Vijay Abraham I
2017-02-17 13:15     ` Kishon Vijay Abraham I
2017-02-17 13:15     ` Kishon Vijay Abraham I
2017-02-17 13:15     ` Kishon Vijay Abraham I
2017-02-17 17:20   ` Joao Pinto
2017-02-17 17:20     ` Joao Pinto
2017-02-17 17:20     ` Joao Pinto
2017-02-17 17:20     ` Joao Pinto
2017-03-06  9:55     ` Kishon Vijay Abraham I
2017-03-06  9:55       ` Kishon Vijay Abraham I
2017-03-06  9:55       ` Kishon Vijay Abraham I
2017-03-06  9:55       ` Kishon Vijay Abraham I
2017-03-07  5:18     ` Kishon Vijay Abraham I
2017-03-07  5:18       ` Kishon Vijay Abraham I
2017-03-07  5:18       ` Kishon Vijay Abraham I
2017-03-07  5:18       ` Kishon Vijay Abraham I
2017-03-07 11:10       ` Joao Pinto
2017-03-07 11:10         ` Joao Pinto
2017-03-07 11:10         ` Joao Pinto
2017-03-07 11:10         ` Joao Pinto
2017-03-08 11:32         ` Joao Pinto
2017-03-08 11:32           ` Joao Pinto
2017-03-08 11:32           ` Joao Pinto
2017-03-08 11:32           ` Joao Pinto
2017-03-08 11:35           ` Kishon Vijay Abraham I
2017-03-08 11:35             ` Kishon Vijay Abraham I
2017-03-08 11:35             ` Kishon Vijay Abraham I
2017-03-08 11:35             ` Kishon Vijay Abraham I
2017-03-08 11:37             ` Joao Pinto
2017-03-08 11:37               ` Joao Pinto
2017-03-08 11:37               ` Joao Pinto
2017-03-08 11:37               ` Joao Pinto
2017-03-08 13:31               ` Kishon Vijay Abraham I
2017-03-08 13:31                 ` Kishon Vijay Abraham I
2017-03-08 13:31                 ` Kishon Vijay Abraham I
2017-03-08 13:31                 ` Kishon Vijay Abraham I
2017-03-08 15:32                 ` Joao Pinto
2017-03-08 15:32                   ` Joao Pinto
2017-03-08 15:32                   ` Joao Pinto
2017-03-08 15:32                   ` Joao Pinto
2017-03-08 15:33                   ` Joao Pinto
2017-03-08 15:33                     ` Joao Pinto
2017-03-08 15:33                     ` Joao Pinto
2017-03-08 15:33                     ` Joao Pinto
2017-03-08 19:14                   ` Christoph Hellwig [this message]
2017-03-08 19:14                     ` Christoph Hellwig
2017-03-08 19:14                     ` Christoph Hellwig
2017-03-08 19:14                     ` Christoph Hellwig
2017-03-09 11:55                     ` Joao Pinto
2017-03-09 11:55                       ` Joao Pinto
2017-03-09 11:55                       ` Joao Pinto
2017-03-09 11:55                       ` Joao Pinto
2017-02-17  9:50 ` [PATCH v2 09/22] dt-bindings: PCI: Add dt bindings for pci designware EP mode Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 10/22] PCI: dwc: dra7xx: Facilitate wrapper and msi interrupts to be enabled independently Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 11/22] PCI: dwc: dra7xx: Add EP mode support Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 12/22] dt-bindings: PCI: dra7xx: Add dt bindings for pci dra7xx EP mode Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 13/22] PCI: dwc: dra7xx: Workaround for errata id i870 Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-27 16:40   ` Rob Herring
2017-02-27 16:40     ` Rob Herring
2017-02-27 16:40     ` Rob Herring
2017-02-27 16:40     ` Rob Herring
2017-02-28  3:28     ` Kishon Vijay Abraham I
2017-02-28  3:28       ` Kishon Vijay Abraham I
2017-02-28  3:28       ` Kishon Vijay Abraham I
2017-02-28  3:28       ` Kishon Vijay Abraham I
2017-03-06  9:56     ` Kishon Vijay Abraham I
2017-03-06  9:56       ` Kishon Vijay Abraham I
2017-03-06  9:56       ` Kishon Vijay Abraham I
2017-03-06  9:56       ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 15/22] PCI: Add device IDs for DRA74x and DRA72x Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 16/22] misc: Add host side pci driver for pci test function device Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 17/22] Documentation: misc-devices: Add Documentation for pci-endpoint-test driver Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 18/22] tools: PCI: Add a userspace tool to test PCI endpoint Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 19/22] tools: PCI: Add sample test script to invoke pcitest Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 20/22] Documentation: PCI: Add userguide for PCI endpoint test function Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 21/22] MAINTAINERS: add PCI EP maintainer Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50 ` [PATCH v2 22/22] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I
2017-02-17  9:50   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170308191419.GA12085@infradead.org \
    --to=hch@infradead.org \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.