* [PATCH 2/3] staging: wilc1000: wilc_spi: Correct variable name
@ 2017-03-08 17:06 Tamara Diaconita
2017-03-08 20:14 ` [Outreachy kernel] " Alison Schofield
0 siblings, 1 reply; 2+ messages in thread
From: Tamara Diaconita @ 2017-03-08 17:06 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh, outreachy-kernel; +Cc: Tamara Diaconita
Correct 'unkmown_mask' variable name to 'unknown_mask'.
Fix the checkpath.pl issue:
CHECK: unkmown may be misspelled, perhaps 'unknown'?.
Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
---
drivers/staging/wilc1000/wilc_spi.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index 2464b4c..4a4b8c3 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -969,16 +969,22 @@ static int wilc_spi_read_int(struct wilc *wilc, u32 *int_status)
if (g_spi.nint > 5) {
wilc_spi_read_reg(wilc, 0x1a94,
&irq_flags);
- tmp |= (((irq_flags >> 0) & 0x7) << (IRG_FLAGS_OFFSET + 5));
+ tmp |= (((irq_flags >> 0) & 0x7) <<
+ (IRG_FLAGS_OFFSET + 5));
}
{
- u32 unkmown_mask;
+ u32 unknown_mask;
- unkmown_mask = ~((1ul << g_spi.nint) - 1);
+ unknown_mask = ~((1ul << g_spi.nint)
+ - 1);
- if ((tmp >> IRG_FLAGS_OFFSET) & unkmown_mask) {
- dev_err(&spi->dev, "Unexpected interrupt (2): j=%d, tmp=%x, mask=%x\n", j, tmp, unkmown_mask);
+ if ((tmp >> IRG_FLAGS_OFFSET) &
+ unknown_mask) {
+ dev_err(&spi->dev, "Unexpected
+ interrupt (2): j=%d,
+ tmp=%x, mask=%x\n", j,
+ tmp, unknown_mask);
happended = 1;
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/3] staging: wilc1000: wilc_spi: Correct variable name
2017-03-08 17:06 [PATCH 2/3] staging: wilc1000: wilc_spi: Correct variable name Tamara Diaconita
@ 2017-03-08 20:14 ` Alison Schofield
0 siblings, 0 replies; 2+ messages in thread
From: Alison Schofield @ 2017-03-08 20:14 UTC (permalink / raw)
To: Tamara Diaconita
Cc: aditya.shankar, ganesh.krishna, gregkh, outreachy-kernel,
Tamara Diaconita
On Wed, Mar 08, 2017 at 07:06:37PM +0200, Tamara Diaconita wrote:
> Correct 'unkmown_mask' variable name to 'unknown_mask'.
>
> Fix the checkpath.pl issue:
> CHECK: unkmown may be misspelled, perhaps 'unknown'?.
Hi Tamara,
I can't get this one to compile. Please check.
When you redo it, you can correct "happended" also:
staging/wilc1000$ codespell wilc*.c
wilc_spi.c:964: happended ==> happened
wilc_spi.c:970: happended ==> happened
wilc_spi.c:994: happended ==> happened
wilc_spi.c:998: happended ==> happened
Subject can be: Correct spelling of variable names.
Thanks,
alisons
>
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_spi.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
> index 2464b4c..4a4b8c3 100644
> --- a/drivers/staging/wilc1000/wilc_spi.c
> +++ b/drivers/staging/wilc1000/wilc_spi.c
> @@ -969,16 +969,22 @@ static int wilc_spi_read_int(struct wilc *wilc, u32 *int_status)
> if (g_spi.nint > 5) {
> wilc_spi_read_reg(wilc, 0x1a94,
> &irq_flags);
> - tmp |= (((irq_flags >> 0) & 0x7) << (IRG_FLAGS_OFFSET + 5));
> + tmp |= (((irq_flags >> 0) & 0x7) <<
> + (IRG_FLAGS_OFFSET + 5));
> }
>
> {
> - u32 unkmown_mask;
> + u32 unknown_mask;
>
> - unkmown_mask = ~((1ul << g_spi.nint) - 1);
> + unknown_mask = ~((1ul << g_spi.nint)
> + - 1);
>
> - if ((tmp >> IRG_FLAGS_OFFSET) & unkmown_mask) {
> - dev_err(&spi->dev, "Unexpected interrupt (2): j=%d, tmp=%x, mask=%x\n", j, tmp, unkmown_mask);
> + if ((tmp >> IRG_FLAGS_OFFSET) &
> + unknown_mask) {
> + dev_err(&spi->dev, "Unexpected
> + interrupt (2): j=%d,
> + tmp=%x, mask=%x\n", j,
> + tmp, unknown_mask);
> happended = 1;
> }
> }
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170308170637.3947-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-08 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-08 17:06 [PATCH 2/3] staging: wilc1000: wilc_spi: Correct variable name Tamara Diaconita
2017-03-08 20:14 ` [Outreachy kernel] " Alison Schofield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.