All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: linux-gpio@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: i.MX7 pinctrl driver writing to non existent registers
Date: Thu, 9 Mar 2017 08:21:30 +0100	[thread overview]
Message-ID: <20170309072130.sdb6dbqvwyxn6idh@pengutronix.de> (raw)
In-Reply-To: <20170308135751.GB19934@x250>

On Wed, Mar 08, 2017 at 02:57:53PM +0100, Shawn Guo wrote:
> On Wed, Feb 08, 2017 at 10:08:17AM +0100, Sascha Hauer wrote:
> > Hi All,
> > 
> > The i.MX7 has two pinmux controllers, the LPSR and the regular one. We
> > instantiate a driver for each one. Now the driver assumes that the pins
> > are completely configured with one iomux controller, but for the LPSR
> > pins this is not true: The MUX_CTL and PAD_CTL registers are indeed
> > in the LPSR controller, but the SELECT_INPUT registers for the same
> > pin are found in the regular controller.
> > 
> > The result is that with this pin for example:
> > 
> > #define MX7D_PAD_GPIO1_IO06__UART5_DCE_RX                         0x0018 0x0048 0x0714 0x3 0x4
> > 
> > The LPSR controller writes to LPSR_BASE + 0x714 where it should really
> > be IOMUX_BASE + 0x714.
> 
> Isn't property fsl,input-sel being there for addressing that?

Indeed, I have overlooked that. Sorry for the noise.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: i.MX7 pinctrl driver writing to non existent registers
Date: Thu, 9 Mar 2017 08:21:30 +0100	[thread overview]
Message-ID: <20170309072130.sdb6dbqvwyxn6idh@pengutronix.de> (raw)
In-Reply-To: <20170308135751.GB19934@x250>

On Wed, Mar 08, 2017 at 02:57:53PM +0100, Shawn Guo wrote:
> On Wed, Feb 08, 2017 at 10:08:17AM +0100, Sascha Hauer wrote:
> > Hi All,
> > 
> > The i.MX7 has two pinmux controllers, the LPSR and the regular one. We
> > instantiate a driver for each one. Now the driver assumes that the pins
> > are completely configured with one iomux controller, but for the LPSR
> > pins this is not true: The MUX_CTL and PAD_CTL registers are indeed
> > in the LPSR controller, but the SELECT_INPUT registers for the same
> > pin are found in the regular controller.
> > 
> > The result is that with this pin for example:
> > 
> > #define MX7D_PAD_GPIO1_IO06__UART5_DCE_RX                         0x0018 0x0048 0x0714 0x3 0x4
> > 
> > The LPSR controller writes to LPSR_BASE + 0x714 where it should really
> > be IOMUX_BASE + 0x714.
> 
> Isn't property fsl,input-sel being there for addressing that?

Indeed, I have overlooked that. Sorry for the noise.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2017-03-09  7:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08  9:08 i.MX7 pinctrl driver writing to non existent registers Sascha Hauer
2017-02-08  9:08 ` Sascha Hauer
2017-02-08 15:28 ` Jean-Christophe PLAGNIOL-VILLARD
2017-02-08 15:28   ` Jean-Christophe PLAGNIOL-VILLARD
2017-03-08 13:57 ` Shawn Guo
2017-03-08 13:57   ` Shawn Guo
2017-03-09  7:21   ` Sascha Hauer [this message]
2017-03-09  7:21     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170309072130.sdb6dbqvwyxn6idh@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.