* [PATCH] powerpc/8xx: fix mpc8xx_get_irq() return on no irq
@ 2017-03-10 10:37 Christophe Leroy
2017-06-05 10:21 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Christophe Leroy @ 2017-03-10 10:37 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman, Scott Wood
Cc: linux-kernel, linuxppc-dev, vitb
IRQ 0 is a valid HW interrupt. So get_irq() shall return 0 when
there is no irq, instead of returning irq_linear_revmap(... ,0)
Fixes: f2a0bd3753dad ("[POWERPC] 8xx: powerpc port of core CPM PIC")
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
arch/powerpc/sysdev/mpc8xx_pic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/mpc8xx_pic.c b/arch/powerpc/sysdev/mpc8xx_pic.c
index 3e828b20c21e..2842f9d63d21 100644
--- a/arch/powerpc/sysdev/mpc8xx_pic.c
+++ b/arch/powerpc/sysdev/mpc8xx_pic.c
@@ -79,7 +79,7 @@ unsigned int mpc8xx_get_irq(void)
irq = in_be32(&siu_reg->sc_sivec) >> 26;
if (irq == PIC_VEC_SPURRIOUS)
- irq = 0;
+ return 0;
return irq_linear_revmap(mpc8xx_pic_host, irq);
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: powerpc/8xx: fix mpc8xx_get_irq() return on no irq
2017-03-10 10:37 [PATCH] powerpc/8xx: fix mpc8xx_get_irq() return on no irq Christophe Leroy
@ 2017-06-05 10:21 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2017-06-05 10:21 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras, Scott Wood
Cc: linuxppc-dev, linux-kernel
On Fri, 2017-03-10 at 10:37:01 UTC, Christophe Leroy wrote:
> IRQ 0 is a valid HW interrupt. So get_irq() shall return 0 when
> there is no irq, instead of returning irq_linear_revmap(... ,0)
>
> Fixes: f2a0bd3753dad ("[POWERPC] 8xx: powerpc port of core CPM PIC")
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/3c29b6038828c1f4c9ecbfec14d4fc
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-05 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-10 10:37 [PATCH] powerpc/8xx: fix mpc8xx_get_irq() return on no irq Christophe Leroy
2017-06-05 10:21 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.