All of lore.kernel.org
 help / color / mirror / Atom feed
* master - pool: drop duplicated sign test
@ 2017-03-10 18:35 Zdenek Kabelac
  0 siblings, 0 replies; only message in thread
From: Zdenek Kabelac @ 2017-03-10 18:35 UTC (permalink / raw)
  To: lvm-devel

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=8c72878cf2f53811cf5ae6fc9b7c787feb74e0c6
Commit:        8c72878cf2f53811cf5ae6fc9b7c787feb74e0c6
Parent:        acfc82ae29eea2b107fb97e4d6fd350b3347f925
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Thu Mar 9 17:09:31 2017 +0100
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Fri Mar 10 19:33:00 2017 +0100

pool: drop duplicated sign test

Avoid duplicate testing of '-' sign.
Already checked with arg_from_list_is_negative().
---
 tools/toollib.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/tools/toollib.c b/tools/toollib.c
index f2951a7..c10f5ca 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -1243,11 +1243,6 @@ int get_pool_params(struct cmd_context *cmd,
 	}
 
 	if (arg_is_set(cmd, poolmetadatasize_ARG)) {
-		if (arg_sign_value(cmd, poolmetadatasize_ARG, SIGN_NONE) == SIGN_MINUS) {
-			log_error("Negative pool metadata size is invalid.");
-			return 0;
-		}
-
 		if (arg_is_set(cmd, poolmetadata_ARG)) {
 			log_error("Please specify either metadata logical volume or its size.");
 			return 0;



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-10 18:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-10 18:35 master - pool: drop duplicated sign test Zdenek Kabelac

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.