[PATCH] MIPS: Lantiq: fix missing xbar kernel panic

[PATCH] MIPS: Lantiq: fix missing xbar kernel panic

[Hauke Mehrtens]

Commit 08b3c894e5 "MIPS: lantiq: Disable xbar fpi burst mode"
accidentally requested the resources from the pmu address region
instead of the xbar registers region, but the check for the returns
value of request_mem_region() was wrong. Commit 98ea51cb0c8 "MIPS:
Lantiq: Fix another request_mem_region() return code check" fixed the
check of the return value of request_mem_region() which made the kernel
panics.
This patch now makes use of the correct memory region for the cross bar.

Fixes: 08b3c894e5 ("MIPS: lantiq: Disable xbar fpi burst mode")
Cc: <stable@vger.kernel.org> # 4.4.x-
Cc: John Crispin <john@phrozen.org>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 arch/mips/lantiq/xway/sysctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
index 3c3aa05891dd..95bec460b651 100644
--- a/arch/mips/lantiq/xway/sysctrl.c
+++ b/arch/mips/lantiq/xway/sysctrl.c
@@ -467,7 +467,7 @@ void __init ltq_soc_init(void)
 
 		if (!np_xbar)
 			panic("Failed to load xbar nodes from devicetree");
-		if (of_address_to_resource(np_pmu, 0, &res_xbar))
+		if (of_address_to_resource(np_xbar, 0, &res_xbar))
 			panic("Failed to get xbar resources");
 		if (!request_mem_region(res_xbar.start, resource_size(&res_xbar),
 			res_xbar.name))
-- 
2.11.0

Re: [PATCH] MIPS: Lantiq: fix missing xbar kernel panic

[Sergei Shtylyov]

Hello!

On 3/12/2017 9:16 PM, Hauke Mehrtens wrote:

> Commit 08b3c894e5 "MIPS: lantiq: Disable xbar fpi burst mode"

    Also need parens around the commit summary. And 12 hex digits for the 
commit ID.

> accidentally requested the resources from the pmu address region
> instead of the xbar registers region, but the check for the returns

    s/returns/return/?

> value of request_mem_region() was wrong. Commit 98ea51cb0c8 "MIPS:
> Lantiq: Fix another request_mem_region() return code check" fixed the

    Same here...

> check of the return value of request_mem_region() which made the kernel
> panics.
> This patch now makes use of the correct memory region for the cross bar.
>
> Fixes: 08b3c894e5 ("MIPS: lantiq: Disable xbar fpi burst mode")
> Cc: <stable@vger.kernel.org> # 4.4.x-
> Cc: John Crispin <john@phrozen.org>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
[...]

MBR, Sergei