* [PATCH] iommu/arm-smmu: Print message when Cavium erratum 27704 was detected
@ 2017-03-13 10:39 ` Robert Richter
0 siblings, 0 replies; 6+ messages in thread
From: Robert Richter @ 2017-03-13 10:39 UTC (permalink / raw)
To: Will Deacon, Robin Murphy, Joerg Roedel
Cc: Robert Richter, linux-arm-kernel, iommu, linux-kernel
Firmware is responsible for properly enabling smmu workarounds. Print
a message for better diagnostics when Cavium erratum 27704 was
detected.
Signed-off-by: Robert Richter <rrichter@cavium.com>
---
drivers/iommu/arm-smmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index abf6496843a6..c88bf8deb958 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1887,6 +1887,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu)
atomic_add_return(smmu->num_context_banks,
&cavium_smmu_context_count);
smmu->cavium_id_base -= smmu->num_context_banks;
+ dev_notice(smmu->dev, "\tenabling workaround for Cavium erratum 27704\n");
}
/* ID2 */
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] iommu/arm-smmu: Print message when Cavium erratum 27704 was detected
@ 2017-03-13 10:39 ` Robert Richter
0 siblings, 0 replies; 6+ messages in thread
From: Robert Richter @ 2017-03-13 10:39 UTC (permalink / raw)
To: Will Deacon, Robin Murphy, Joerg Roedel
Cc: Robert Richter,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Firmware is responsible for properly enabling smmu workarounds. Print
a message for better diagnostics when Cavium erratum 27704 was
detected.
Signed-off-by: Robert Richter <rrichter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
---
drivers/iommu/arm-smmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index abf6496843a6..c88bf8deb958 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1887,6 +1887,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu)
atomic_add_return(smmu->num_context_banks,
&cavium_smmu_context_count);
smmu->cavium_id_base -= smmu->num_context_banks;
+ dev_notice(smmu->dev, "\tenabling workaround for Cavium erratum 27704\n");
}
/* ID2 */
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] iommu/arm-smmu: Print message when Cavium erratum 27704 was detected
@ 2017-03-13 10:39 ` Robert Richter
0 siblings, 0 replies; 6+ messages in thread
From: Robert Richter @ 2017-03-13 10:39 UTC (permalink / raw)
To: linux-arm-kernel
Firmware is responsible for properly enabling smmu workarounds. Print
a message for better diagnostics when Cavium erratum 27704 was
detected.
Signed-off-by: Robert Richter <rrichter@cavium.com>
---
drivers/iommu/arm-smmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index abf6496843a6..c88bf8deb958 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1887,6 +1887,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu)
atomic_add_return(smmu->num_context_banks,
&cavium_smmu_context_count);
smmu->cavium_id_base -= smmu->num_context_banks;
+ dev_notice(smmu->dev, "\tenabling workaround for Cavium erratum 27704\n");
}
/* ID2 */
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iommu/arm-smmu: Print message when Cavium erratum 27704 was detected
@ 2017-03-13 12:15 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2017-03-13 12:15 UTC (permalink / raw)
To: Robert Richter, Will Deacon, Joerg Roedel
Cc: linux-arm-kernel, iommu, linux-kernel
On 13/03/17 10:39, Robert Richter wrote:
> Firmware is responsible for properly enabling smmu workarounds. Print
> a message for better diagnostics when Cavium erratum 27704 was
> detected.
The wording there could possibly be misinterpreted as the firmware
actively having to do something to the hardware prior to handing it off
to Linux, as opposed to merely supplying a correct FDT or IORT table,
but I'm not sure it matters all that much, and the patch itself is fine:
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Thanks,
Robin.
> Signed-off-by: Robert Richter <rrichter@cavium.com>
> ---
> drivers/iommu/arm-smmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index abf6496843a6..c88bf8deb958 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1887,6 +1887,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu)
> atomic_add_return(smmu->num_context_banks,
> &cavium_smmu_context_count);
> smmu->cavium_id_base -= smmu->num_context_banks;
> + dev_notice(smmu->dev, "\tenabling workaround for Cavium erratum 27704\n");
> }
>
> /* ID2 */
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iommu/arm-smmu: Print message when Cavium erratum 27704 was detected
@ 2017-03-13 12:15 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2017-03-13 12:15 UTC (permalink / raw)
To: Robert Richter, Will Deacon, Joerg Roedel
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On 13/03/17 10:39, Robert Richter wrote:
> Firmware is responsible for properly enabling smmu workarounds. Print
> a message for better diagnostics when Cavium erratum 27704 was
> detected.
The wording there could possibly be misinterpreted as the firmware
actively having to do something to the hardware prior to handing it off
to Linux, as opposed to merely supplying a correct FDT or IORT table,
but I'm not sure it matters all that much, and the patch itself is fine:
Reviewed-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Thanks,
Robin.
> Signed-off-by: Robert Richter <rrichter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> ---
> drivers/iommu/arm-smmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index abf6496843a6..c88bf8deb958 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1887,6 +1887,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu)
> atomic_add_return(smmu->num_context_banks,
> &cavium_smmu_context_count);
> smmu->cavium_id_base -= smmu->num_context_banks;
> + dev_notice(smmu->dev, "\tenabling workaround for Cavium erratum 27704\n");
> }
>
> /* ID2 */
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] iommu/arm-smmu: Print message when Cavium erratum 27704 was detected
@ 2017-03-13 12:15 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2017-03-13 12:15 UTC (permalink / raw)
To: linux-arm-kernel
On 13/03/17 10:39, Robert Richter wrote:
> Firmware is responsible for properly enabling smmu workarounds. Print
> a message for better diagnostics when Cavium erratum 27704 was
> detected.
The wording there could possibly be misinterpreted as the firmware
actively having to do something to the hardware prior to handing it off
to Linux, as opposed to merely supplying a correct FDT or IORT table,
but I'm not sure it matters all that much, and the patch itself is fine:
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Thanks,
Robin.
> Signed-off-by: Robert Richter <rrichter@cavium.com>
> ---
> drivers/iommu/arm-smmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index abf6496843a6..c88bf8deb958 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1887,6 +1887,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu)
> atomic_add_return(smmu->num_context_banks,
> &cavium_smmu_context_count);
> smmu->cavium_id_base -= smmu->num_context_banks;
> + dev_notice(smmu->dev, "\tenabling workaround for Cavium erratum 27704\n");
> }
>
> /* ID2 */
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-13 12:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-13 10:39 [PATCH] iommu/arm-smmu: Print message when Cavium erratum 27704 was detected Robert Richter
2017-03-13 10:39 ` Robert Richter
2017-03-13 10:39 ` Robert Richter
2017-03-13 12:15 ` Robin Murphy
2017-03-13 12:15 ` Robin Murphy
2017-03-13 12:15 ` Robin Murphy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.