* [Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit
@ 2017-03-13 9:31 Nikunj A Dadhania
2017-03-13 12:54 ` Mark Cave-Ayland
2017-03-14 0:21 ` [Qemu-devel] " David Gibson
0 siblings, 2 replies; 4+ messages in thread
From: Nikunj A Dadhania @ 2017-03-13 9:31 UTC (permalink / raw)
To: qemu-ppc, david, mark.cave-ayland; +Cc: qemu-devel, rth, nikunj
A bug was introduced in following commit:
dc0ad84 target/ppc: update overflow flags for add/sub
As for 32-bit ppc target extracting bit 63 for overflow is not correct.
Made it dependent on TARGET_LOG_BITS. This had broken booting MacOS
9.2.1 image
Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
---
target/ppc/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index b6abc60..f40b5a1 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -818,7 +818,7 @@ static inline void gen_op_arith_compute_ov(DisasContext *ctx, TCGv arg0,
if (is_isa300(ctx)) {
tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1);
}
- tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1);
+ tcg_gen_extract_tl(cpu_ov, cpu_ov, TARGET_LONG_BITS - 1, 1);
}
tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov);
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit
2017-03-13 9:31 [Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit Nikunj A Dadhania
@ 2017-03-13 12:54 ` Mark Cave-Ayland
2017-03-13 21:01 ` [Qemu-devel] [Qemu-ppc] " Mark Cave-Ayland
2017-03-14 0:21 ` [Qemu-devel] " David Gibson
1 sibling, 1 reply; 4+ messages in thread
From: Mark Cave-Ayland @ 2017-03-13 12:54 UTC (permalink / raw)
To: Nikunj A Dadhania, qemu-ppc, david; +Cc: qemu-devel, rth
On 13/03/17 09:31, Nikunj A Dadhania wrote:
> A bug was introduced in following commit:
>
> dc0ad84 target/ppc: update overflow flags for add/sub
>
> As for 32-bit ppc target extracting bit 63 for overflow is not correct.
> Made it dependent on TARGET_LOG_BITS. This had broken booting MacOS
> 9.2.1 image
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> ---
> target/ppc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index b6abc60..f40b5a1 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -818,7 +818,7 @@ static inline void gen_op_arith_compute_ov(DisasContext *ctx, TCGv arg0,
> if (is_isa300(ctx)) {
> tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1);
> }
> - tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1);
> + tcg_gen_extract_tl(cpu_ov, cpu_ov, TARGET_LONG_BITS - 1, 1);
> }
> tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov);
> }
>
Hi Nikunj,
I can confirm that this patch fixes the segfault for me - thanks!
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
However even with this fix in place, I'm still seeing strange horizontal
artifacts on the screen as demonstrated here:
https://www.ilande.co.uk/tmp/qemu/macos9-stripe.png
With the patch above I'll try bisecting again later today to try and
understand where these lines are coming from. So far I've spotted them
in MacOS 9 and OS X during tests...
ATB,
Mark.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit
2017-03-13 12:54 ` Mark Cave-Ayland
@ 2017-03-13 21:01 ` Mark Cave-Ayland
0 siblings, 0 replies; 4+ messages in thread
From: Mark Cave-Ayland @ 2017-03-13 21:01 UTC (permalink / raw)
To: Nikunj A Dadhania, qemu-ppc, david; +Cc: qemu-devel, rth
On 13/03/17 12:54, Mark Cave-Ayland wrote:
> With the patch above I'll try bisecting again later today to try and
> understand where these lines are coming from. So far I've spotted them
> in MacOS 9 and OS X during tests...
Okay - I've completed the bisection, and the artifacts I'm seeing aren't
related to any of the PPC patches. Thanks once again for looking into this.
ATB,
Mark.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit
2017-03-13 9:31 [Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit Nikunj A Dadhania
2017-03-13 12:54 ` Mark Cave-Ayland
@ 2017-03-14 0:21 ` David Gibson
1 sibling, 0 replies; 4+ messages in thread
From: David Gibson @ 2017-03-14 0:21 UTC (permalink / raw)
To: Nikunj A Dadhania; +Cc: qemu-ppc, mark.cave-ayland, qemu-devel, rth
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
On Mon, Mar 13, 2017 at 03:01:04PM +0530, Nikunj A Dadhania wrote:
> A bug was introduced in following commit:
>
> dc0ad84 target/ppc: update overflow flags for add/sub
>
> As for 32-bit ppc target extracting bit 63 for overflow is not correct.
> Made it dependent on TARGET_LOG_BITS. This had broken booting MacOS
> 9.2.1 image
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Applied to ppc-for-2.9, thanks.
> ---
> target/ppc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index b6abc60..f40b5a1 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -818,7 +818,7 @@ static inline void gen_op_arith_compute_ov(DisasContext *ctx, TCGv arg0,
> if (is_isa300(ctx)) {
> tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1);
> }
> - tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1);
> + tcg_gen_extract_tl(cpu_ov, cpu_ov, TARGET_LONG_BITS - 1, 1);
> }
> tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov);
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-14 0:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-13 9:31 [Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit Nikunj A Dadhania
2017-03-13 12:54 ` Mark Cave-Ayland
2017-03-13 21:01 ` [Qemu-devel] [Qemu-ppc] " Mark Cave-Ayland
2017-03-14 0:21 ` [Qemu-devel] " David Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.