All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 0/2] staging: checkpatch cleanups
@ 2017-03-14 13:55 Arushi Singhal
  2017-03-14 13:55 ` [PATCH v4 1/2] staging: speakup: identation should use tabs Arushi Singhal
  2017-03-14 13:55 ` [PATCH v4 2/2] staging: dvb-frontends: removed code in comments Arushi Singhal
  0 siblings, 2 replies; 3+ messages in thread
From: Arushi Singhal @ 2017-03-14 13:55 UTC (permalink / raw)
  To: w.d.hubbs
  Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
	devel, linux-kernel, Arushi Singhal

Improve readability by fixing multiple checkpatch.pl
issues in drivers. 

Arushi Singhal (2):
  staging: speakup: identation should use tabs
  staging: dvb-frontends: removed code in comments.

 drivers/media/dvb-frontends/drxk_hard.c  |   1 -
 drivers/staging/speakup/speakup_dtlk.h   |  10 +++++-----
 2 files changed, 5 insertions(+), 6 deletions(-)

-- 
Changes since v4:
 -Include the changes done different versions.
 -Change the subject of cover Letter.
 -Made the subject of the patches in the patch series more clear.

2.11.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v4 1/2] staging: speakup: identation should use tabs
  2017-03-14 13:55 [PATCH v4 0/2] staging: checkpatch cleanups Arushi Singhal
@ 2017-03-14 13:55 ` Arushi Singhal
  2017-03-14 13:55 ` [PATCH v4 2/2] staging: dvb-frontends: removed code in comments Arushi Singhal
  1 sibling, 0 replies; 3+ messages in thread
From: Arushi Singhal @ 2017-03-14 13:55 UTC (permalink / raw)
  To: w.d.hubbs
  Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
	devel, linux-kernel, Arushi Singhal

Indentation should always use tabs and never spaces.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
Changes since v4
-Added the changes done since v4.

 drivers/staging/speakup/speakup_dtlk.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/staging/speakup/speakup_dtlk.h
index b3b3cfc3db07..46d885fcfb20 100644
--- a/drivers/staging/speakup/speakup_dtlk.h
+++ b/drivers/staging/speakup/speakup_dtlk.h
@@ -24,11 +24,11 @@
 				 * usec later.
 				 */
 #define TTS_ALMOST_FULL	0x08	/* mask for AF bit: When set to 1,
-				         * indicates that less than 300 bytes
-				         * are available in the TTS input
-				         * buffer. AF is always 0 in the PCM,
-				         * TGN and CVSD modes.
-				         */
+					 * indicates that less than 300 bytes
+					 * are available in the TTS input
+					 * buffer. AF is always 0 in the PCM,
+					 * TGN and CVSD modes.
+					 */
 #define TTS_ALMOST_EMPTY 0x04	/* mask for AE bit: When set to 1,
 				 * indicates that less than 300 bytes
 				 * are remaining in DoubleTalk's input
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v4 2/2] staging: dvb-frontends: removed code in comments.
  2017-03-14 13:55 [PATCH v4 0/2] staging: checkpatch cleanups Arushi Singhal
  2017-03-14 13:55 ` [PATCH v4 1/2] staging: speakup: identation should use tabs Arushi Singhal
@ 2017-03-14 13:55 ` Arushi Singhal
  1 sibling, 0 replies; 3+ messages in thread
From: Arushi Singhal @ 2017-03-14 13:55 UTC (permalink / raw)
  To: w.d.hubbs
  Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
	devel, linux-kernel, Arushi Singhal

Commenting out Code is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments  does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 changes since v4
 - Improve the commit message
 - Added the changes done in v4 in cover-letter.

 drivers/media/dvb-frontends/drxk_hard.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c
index 7e1bbbaad625..2fe493768003 100644
--- a/drivers/media/dvb-frontends/drxk_hard.c
+++ b/drivers/media/dvb-frontends/drxk_hard.c
@@ -5283,7 +5283,6 @@ static int qam_set_symbolrate(struct drxk_state *state)
 	/* Select & calculate correct IQM rate */
 	adc_frequency = (state->m_sys_clock_freq * 1000) / 3;
 	ratesel = 0;
-	/* printk(KERN_DEBUG "drxk: SR %d\n", state->props.symbol_rate); */
 	if (state->props.symbol_rate <= 1188750)
 		ratesel = 3;
 	else if (state->props.symbol_rate <= 2377500)
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-14 13:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 13:55 [PATCH v4 0/2] staging: checkpatch cleanups Arushi Singhal
2017-03-14 13:55 ` [PATCH v4 1/2] staging: speakup: identation should use tabs Arushi Singhal
2017-03-14 13:55 ` [PATCH v4 2/2] staging: dvb-frontends: removed code in comments Arushi Singhal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.