* [RESEND PATCH] drm: amd: remove broken include path
@ 2017-03-14 21:27 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-03-14 21:27 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie
Cc: Arnd Bergmann, amd-gfx, dri-devel, linux-kernel
The AMD ACP driver adds "-I../acp -I../acp/include" to the gcc command
line, which makes no sense, since these are evaluated relative to the
build directory. When we build with "make W=1", they instead cause
a warning:
cc1: error: ../acp/: No such file or directory [-Werror=missing-include-dirs]
cc1: error: ../acp/include: No such file or directory [-Werror=missing-include-dirs]
cc1: all warnings being treated as errors
../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed
../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.o' failed
../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_kms.o' failed
This removes the subdir-ccflags variable that evidently did not
serve any purpose here.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Originally submitted in June 2016. All other patches for this warning got
merged, once this gets in we can turn on the warning flag for everyone.
---
drivers/gpu/drm/amd/acp/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/acp/Makefile b/drivers/gpu/drm/amd/acp/Makefile
index 8363cb57915b..8a08e81ee90d 100644
--- a/drivers/gpu/drm/amd/acp/Makefile
+++ b/drivers/gpu/drm/amd/acp/Makefile
@@ -3,6 +3,4 @@
# of AMDSOC/AMDGPU drm driver.
# It provides the HW control for ACP related functionalities.
-subdir-ccflags-y += -I$(AMDACPPATH)/ -I$(AMDACPPATH)/include
-
AMD_ACP_FILES := $(AMDACPPATH)/acp_hw.o
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND PATCH] drm: amd: remove broken include path
@ 2017-03-14 21:27 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-03-14 21:27 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie
Cc: dri-devel, amd-gfx, Arnd Bergmann, linux-kernel
The AMD ACP driver adds "-I../acp -I../acp/include" to the gcc command
line, which makes no sense, since these are evaluated relative to the
build directory. When we build with "make W=1", they instead cause
a warning:
cc1: error: ../acp/: No such file or directory [-Werror=missing-include-dirs]
cc1: error: ../acp/include: No such file or directory [-Werror=missing-include-dirs]
cc1: all warnings being treated as errors
../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed
../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.o' failed
../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_kms.o' failed
This removes the subdir-ccflags variable that evidently did not
serve any purpose here.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Originally submitted in June 2016. All other patches for this warning got
merged, once this gets in we can turn on the warning flag for everyone.
---
drivers/gpu/drm/amd/acp/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/acp/Makefile b/drivers/gpu/drm/amd/acp/Makefile
index 8363cb57915b..8a08e81ee90d 100644
--- a/drivers/gpu/drm/amd/acp/Makefile
+++ b/drivers/gpu/drm/amd/acp/Makefile
@@ -3,6 +3,4 @@
# of AMDSOC/AMDGPU drm driver.
# It provides the HW control for ACP related functionalities.
-subdir-ccflags-y += -I$(AMDACPPATH)/ -I$(AMDACPPATH)/include
-
AMD_ACP_FILES := $(AMDACPPATH)/acp_hw.o
--
2.9.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] drm: amd: remove broken include path
@ 2017-03-15 14:20 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2017-03-15 14:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alex Deucher, Christian König, David Airlie,
Maling list - DRI developers, amd-gfx list, LKML
On Tue, Mar 14, 2017 at 5:27 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The AMD ACP driver adds "-I../acp -I../acp/include" to the gcc command
> line, which makes no sense, since these are evaluated relative to the
> build directory. When we build with "make W=1", they instead cause
> a warning:
>
> cc1: error: ../acp/: No such file or directory [-Werror=missing-include-dirs]
> cc1: error: ../acp/include: No such file or directory [-Werror=missing-include-dirs]
> cc1: all warnings being treated as errors
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.o' failed
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_kms.o' failed
>
> This removes the subdir-ccflags variable that evidently did not
> serve any purpose here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied. thanks!
Alex
> ---
> Originally submitted in June 2016. All other patches for this warning got
> merged, once this gets in we can turn on the warning flag for everyone.
> ---
> drivers/gpu/drm/amd/acp/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/acp/Makefile b/drivers/gpu/drm/amd/acp/Makefile
> index 8363cb57915b..8a08e81ee90d 100644
> --- a/drivers/gpu/drm/amd/acp/Makefile
> +++ b/drivers/gpu/drm/amd/acp/Makefile
> @@ -3,6 +3,4 @@
> # of AMDSOC/AMDGPU drm driver.
> # It provides the HW control for ACP related functionalities.
>
> -subdir-ccflags-y += -I$(AMDACPPATH)/ -I$(AMDACPPATH)/include
> -
> AMD_ACP_FILES := $(AMDACPPATH)/acp_hw.o
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] drm: amd: remove broken include path
@ 2017-03-15 14:20 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2017-03-15 14:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David Airlie, LKML, amd-gfx list, Maling list - DRI developers,
Alex Deucher, Christian König
On Tue, Mar 14, 2017 at 5:27 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The AMD ACP driver adds "-I../acp -I../acp/include" to the gcc command
> line, which makes no sense, since these are evaluated relative to the
> build directory. When we build with "make W=1", they instead cause
> a warning:
>
> cc1: error: ../acp/: No such file or directory [-Werror=missing-include-dirs]
> cc1: error: ../acp/include: No such file or directory [-Werror=missing-include-dirs]
> cc1: all warnings being treated as errors
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.o' failed
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_kms.o' failed
>
> This removes the subdir-ccflags variable that evidently did not
> serve any purpose here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied. thanks!
Alex
> ---
> Originally submitted in June 2016. All other patches for this warning got
> merged, once this gets in we can turn on the warning flag for everyone.
> ---
> drivers/gpu/drm/amd/acp/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/acp/Makefile b/drivers/gpu/drm/amd/acp/Makefile
> index 8363cb57915b..8a08e81ee90d 100644
> --- a/drivers/gpu/drm/amd/acp/Makefile
> +++ b/drivers/gpu/drm/amd/acp/Makefile
> @@ -3,6 +3,4 @@
> # of AMDSOC/AMDGPU drm driver.
> # It provides the HW control for ACP related functionalities.
>
> -subdir-ccflags-y += -I$(AMDACPPATH)/ -I$(AMDACPPATH)/include
> -
> AMD_ACP_FILES := $(AMDACPPATH)/acp_hw.o
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-15 14:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 21:27 [RESEND PATCH] drm: amd: remove broken include path Arnd Bergmann
2017-03-14 21:27 ` Arnd Bergmann
2017-03-15 14:20 ` Alex Deucher
2017-03-15 14:20 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.