From: Stafford Horne <shorne@gmail.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Jonas Bonn <jonas@southpole.se>, Christian Svensson <blue@cmd.nu>, openrisc@lists.librecores.org, Ingo Molnar <mingo@kernel.org> Subject: Re: [OpenRISC] [PATCH 3/3] openrisc: Export symbols needed by modules Date: Wed, 15 Mar 2017 07:17:01 +0900 [thread overview] Message-ID: <20170314221701.GF2418@lianli.shorne-pla.net> (raw) In-Reply-To: <CAMuHMdVR5xL4SDD7GTd5JdGfhHLGuVvM7v0m-k2iJAd6U21sUg@mail.gmail.com> On Tue, Mar 14, 2017 at 04:25:30PM +0100, Geert Uytterhoeven wrote: > Hi Stafford, > > On Tue, Mar 14, 2017 at 3:56 PM, Stafford Horne <shorne@gmail.com> wrote: > > This was detected by allmodconfig, errors reported: > > > > ERROR: "empty_zero_page" [net/ceph/libceph.ko] undefined! > > ERROR: "__ucmpdi2" [lib/842/842_decompress.ko] undefined! > > ERROR: "empty_zero_page" [fs/nfs/objlayout/objlayoutdriver.ko] undefined! > > ERROR: "empty_zero_page" [fs/exofs/exofs.ko] undefined! > > ERROR: "empty_zero_page" [fs/crypto/fscrypto.ko] undefined! > > ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined! > > ERROR: "pm_power_off" [drivers/regulator/act8865-regulator.ko] undefined! > > > > Signed-off-by: Stafford Horne <shorne@gmail.com> > > > --- a/arch/openrisc/kernel/or32_ksyms.c > > +++ b/arch/openrisc/kernel/or32_ksyms.c > > @@ -42,6 +42,11 @@ DECLARE_EXPORT(__muldi3); > > DECLARE_EXPORT(__ashrdi3); > > DECLARE_EXPORT(__ashldi3); > > DECLARE_EXPORT(__lshrdi3); > > +DECLARE_EXPORT(__ucmpdi2); > > + > > +extern unsigned long empty_zero_page[2048]; > > Can't you #include <asm/pgtable.h> instead of adding a forward > declaration? Right, I can do this. In the end I was hoping to convert empty_zero_page to be more like parisc. which would put something like this mm/init.c unsigned long *empty_zero_page __read_mostly; EXPORT_SYMBOL(empty_zero_page); in init { empty_zero_page = get_memblock(PAGE_SIZE); } But I was going to wait until 4.12 for that change. -Stafford > > +EXPORT_SYMBOL(empty_zero_page); > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Stafford Horne <shorne@gmail.com> To: openrisc@lists.librecores.org Subject: [OpenRISC] [PATCH 3/3] openrisc: Export symbols needed by modules Date: Wed, 15 Mar 2017 07:17:01 +0900 [thread overview] Message-ID: <20170314221701.GF2418@lianli.shorne-pla.net> (raw) In-Reply-To: <CAMuHMdVR5xL4SDD7GTd5JdGfhHLGuVvM7v0m-k2iJAd6U21sUg@mail.gmail.com> On Tue, Mar 14, 2017 at 04:25:30PM +0100, Geert Uytterhoeven wrote: > Hi Stafford, > > On Tue, Mar 14, 2017 at 3:56 PM, Stafford Horne <shorne@gmail.com> wrote: > > This was detected by allmodconfig, errors reported: > > > > ERROR: "empty_zero_page" [net/ceph/libceph.ko] undefined! > > ERROR: "__ucmpdi2" [lib/842/842_decompress.ko] undefined! > > ERROR: "empty_zero_page" [fs/nfs/objlayout/objlayoutdriver.ko] undefined! > > ERROR: "empty_zero_page" [fs/exofs/exofs.ko] undefined! > > ERROR: "empty_zero_page" [fs/crypto/fscrypto.ko] undefined! > > ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined! > > ERROR: "pm_power_off" [drivers/regulator/act8865-regulator.ko] undefined! > > > > Signed-off-by: Stafford Horne <shorne@gmail.com> > > > --- a/arch/openrisc/kernel/or32_ksyms.c > > +++ b/arch/openrisc/kernel/or32_ksyms.c > > @@ -42,6 +42,11 @@ DECLARE_EXPORT(__muldi3); > > DECLARE_EXPORT(__ashrdi3); > > DECLARE_EXPORT(__ashldi3); > > DECLARE_EXPORT(__lshrdi3); > > +DECLARE_EXPORT(__ucmpdi2); > > + > > +extern unsigned long empty_zero_page[2048]; > > Can't you #include <asm/pgtable.h> instead of adding a forward > declaration? Right, I can do this. In the end I was hoping to convert empty_zero_page to be more like parisc. which would put something like this mm/init.c unsigned long *empty_zero_page __read_mostly; EXPORT_SYMBOL(empty_zero_page); in init { empty_zero_page = get_memblock(PAGE_SIZE); } But I was going to wait until 4.12 for that change. -Stafford > > +EXPORT_SYMBOL(empty_zero_page); > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
next prev parent reply other threads:[~2017-03-14 22:17 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-14 14:56 [PATCH 0/3] Openrisc fixes for 4.11 Stafford Horne 2017-03-14 14:56 ` [OpenRISC] " Stafford Horne 2017-03-14 14:56 ` [PATCH 1/3] openrisc: xchg: fix `computed is not used` warning Stafford Horne 2017-03-14 14:56 ` [OpenRISC] " Stafford Horne 2017-03-14 14:56 ` [PATCH 2/3] openrisc: fix issue handling 8 byte get_user calls Stafford Horne 2017-03-14 14:56 ` [OpenRISC] " Stafford Horne 2017-03-14 14:56 ` [PATCH 3/3] openrisc: Export symbols needed by modules Stafford Horne 2017-03-14 14:56 ` [OpenRISC] " Stafford Horne 2017-03-14 15:25 ` Geert Uytterhoeven 2017-03-14 15:25 ` Geert Uytterhoeven 2017-03-14 22:17 ` Stafford Horne [this message] 2017-03-14 22:17 ` Stafford Horne
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170314221701.GF2418@lianli.shorne-pla.net \ --to=shorne@gmail.com \ --cc=blue@cmd.nu \ --cc=geert@linux-m68k.org \ --cc=jonas@southpole.se \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=openrisc@lists.librecores.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.