* [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register
@ 2017-02-09 15:03 William Breathitt Gray
2017-02-11 9:37 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: William Breathitt Gray @ 2017-02-09 15:03 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler
Cc: linux-iio, linux-kernel
The flag register is offset by 1 from the respective channel data
register. This patch fixes an off-by-one error when attempting to read a
channel flag register where the base address was not properly offset.
Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/iio/counter/104-quad-8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
index a5913e97945e..f9b8fc9ae13f 100644
--- a/drivers/iio/counter/104-quad-8.c
+++ b/drivers/iio/counter/104-quad-8.c
@@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
return IIO_VAL_INT;
}
- flags = inb(base_offset);
+ flags = inb(base_offset + 1);
borrow = flags & BIT(0);
carry = !!(flags & BIT(1));
--
2.11.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register
2017-02-09 15:03 [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register William Breathitt Gray
@ 2017-02-11 9:37 ` Jonathan Cameron
2017-03-13 13:33 ` William Breathitt Gray
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2017-02-11 9:37 UTC (permalink / raw)
To: William Breathitt Gray, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler
Cc: linux-iio, linux-kernel
On 09/02/17 15:03, William Breathitt Gray wrote:
> The flag register is offset by 1 from the respective channel data
> register. This patch fixes an off-by-one error when attempting to read a
> channel flag register where the base address was not properly offset.
>
> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git
Clue to when this will go upstream is in the name ;)
Thanks,
Jonathan
> ---
> drivers/iio/counter/104-quad-8.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
> index a5913e97945e..f9b8fc9ae13f 100644
> --- a/drivers/iio/counter/104-quad-8.c
> +++ b/drivers/iio/counter/104-quad-8.c
> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
> return IIO_VAL_INT;
> }
>
> - flags = inb(base_offset);
> + flags = inb(base_offset + 1);
> borrow = flags & BIT(0);
> carry = !!(flags & BIT(1));
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register
2017-02-11 9:37 ` Jonathan Cameron
@ 2017-03-13 13:33 ` William Breathitt Gray
2017-03-13 21:33 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: William Breathitt Gray @ 2017-03-13 13:33 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, linux-kernel
On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
>On 09/02/17 15:03, William Breathitt Gray wrote:
>> The flag register is offset by 1 from the respective channel data
>> register. This patch fixes an off-by-one error when attempting to read a
>> channel flag register where the base address was not properly offset.
>>
>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>Applied to the fixes-togreg-post-rc1 branch of iio.git
>Clue to when this will go upstream is in the name ;)
>
>Thanks,
>
>Jonathan
Hi Jonathan,
I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
Is this patch on track to appear in stable, or should I explicitly CC
stable@vger.kernel.org to pick this up?
Thanks,
William Breathitt Gray
>> ---
>> drivers/iio/counter/104-quad-8.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>> index a5913e97945e..f9b8fc9ae13f 100644
>> --- a/drivers/iio/counter/104-quad-8.c
>> +++ b/drivers/iio/counter/104-quad-8.c
>> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>> return IIO_VAL_INT;
>> }
>>
>> - flags = inb(base_offset);
>> + flags = inb(base_offset + 1);
>> borrow = flags & BIT(0);
>> carry = !!(flags & BIT(1));
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register
2017-03-13 13:33 ` William Breathitt Gray
@ 2017-03-13 21:33 ` Jonathan Cameron
2017-03-14 15:00 ` William Breathitt Gray
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2017-03-13 21:33 UTC (permalink / raw)
To: William Breathitt Gray
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, linux-kernel
On 13/03/17 13:33, William Breathitt Gray wrote:
> On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
>> On 09/02/17 15:03, William Breathitt Gray wrote:
>>> The flag register is offset by 1 from the respective channel data
>>> register. This patch fixes an off-by-one error when attempting to read a
>>> channel flag register where the base address was not properly offset.
>>>
>>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>> Applied to the fixes-togreg-post-rc1 branch of iio.git
>> Clue to when this will go upstream is in the name ;)
>>
>> Thanks,
>>
>> Jonathan
>
> Hi Jonathan,
>
> I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
> Is this patch on track to appear in stable, or should I explicitly CC
> stable@vger.kernel.org to pick this up?
I was half asleep and failed to tag this in the first place.
Send an email to stable@vger.kernel.org with the commit ID and a request
that it is picked up. Cc me.
Jonathan
>
> Thanks,
>
> William Breathitt Gray
>
>>> ---
>>> drivers/iio/counter/104-quad-8.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>>> index a5913e97945e..f9b8fc9ae13f 100644
>>> --- a/drivers/iio/counter/104-quad-8.c
>>> +++ b/drivers/iio/counter/104-quad-8.c
>>> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>>> return IIO_VAL_INT;
>>> }
>>>
>>> - flags = inb(base_offset);
>>> + flags = inb(base_offset + 1);
>>> borrow = flags & BIT(0);
>>> carry = !!(flags & BIT(1));
>>>
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register
2017-03-13 21:33 ` Jonathan Cameron
@ 2017-03-14 15:00 ` William Breathitt Gray
2017-03-15 5:33 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: William Breathitt Gray @ 2017-03-14 15:00 UTC (permalink / raw)
To: stable
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, linux-iio, linux-kernel
On Mon, Mar 13, 2017 at 09:33:45PM +0000, Jonathan Cameron wrote:
>On 13/03/17 13:33, William Breathitt Gray wrote:
>> On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
>>> On 09/02/17 15:03, William Breathitt Gray wrote:
>>>> The flag register is offset by 1 from the respective channel data
>>>> register. This patch fixes an off-by-one error when attempting to read a
>>>> channel flag register where the base address was not properly offset.
>>>>
>>>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>>>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>>> Applied to the fixes-togreg-post-rc1 branch of iio.git
>>> Clue to when this will go upstream is in the name ;)
>>>
>>> Thanks,
>>>
>>> Jonathan
>>
>> Hi Jonathan,
>>
>> I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
>> Is this patch on track to appear in stable, or should I explicitly CC
>> stable@vger.kernel.org to pick this up?
>I was half asleep and failed to tag this in the first place.
>
>Send an email to stable@vger.kernel.org with the commit ID and a request
>that it is picked up. Cc me.
>
>Jonathan
>>
>> Thanks,
>>
>> William Breathitt Gray
>>
Hello,
This patch was merged into Linus' tree as commit ca8d8e03b4c9 ("iio:
104-quad-8: Fix off-by-one error when addressing flag register"). This
fix should be merged into the 4.10 stable tree as well to fix an
off-by-one error which causes garbage data to be read as count values --
effectively preventing proper usage of the driver.
This patch fixes commit 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support
for the ACCES 104-QUAD-8").
Thank you,
William Breathitt Gray
>>>> ---
>>>> drivers/iio/counter/104-quad-8.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>>>> index a5913e97945e..f9b8fc9ae13f 100644
>>>> --- a/drivers/iio/counter/104-quad-8.c
>>>> +++ b/drivers/iio/counter/104-quad-8.c
>>>> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>>>> return IIO_VAL_INT;
>>>> }
>>>>
>>>> - flags = inb(base_offset);
>>>> + flags = inb(base_offset + 1);
>>>> borrow = flags & BIT(0);
>>>> carry = !!(flags & BIT(1));
>>>>
>>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register
2017-03-14 15:00 ` William Breathitt Gray
@ 2017-03-15 5:33 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-03-15 5:33 UTC (permalink / raw)
To: William Breathitt Gray
Cc: stable, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, linux-iio, linux-kernel
On Tue, Mar 14, 2017 at 11:00:43AM -0400, William Breathitt Gray wrote:
> On Mon, Mar 13, 2017 at 09:33:45PM +0000, Jonathan Cameron wrote:
> >On 13/03/17 13:33, William Breathitt Gray wrote:
> >> On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
> >>> On 09/02/17 15:03, William Breathitt Gray wrote:
> >>>> The flag register is offset by 1 from the respective channel data
> >>>> register. This patch fixes an off-by-one error when attempting to read a
> >>>> channel flag register where the base address was not properly offset.
> >>>>
> >>>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
> >>>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> >>> Applied to the fixes-togreg-post-rc1 branch of iio.git
> >>> Clue to when this will go upstream is in the name ;)
> >>>
> >>> Thanks,
> >>>
> >>> Jonathan
> >>
> >> Hi Jonathan,
> >>
> >> I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
> >> Is this patch on track to appear in stable, or should I explicitly CC
> >> stable@vger.kernel.org to pick this up?
> >I was half asleep and failed to tag this in the first place.
> >
> >Send an email to stable@vger.kernel.org with the commit ID and a request
> >that it is picked up. Cc me.
> >
> >Jonathan
> >>
> >> Thanks,
> >>
> >> William Breathitt Gray
> >>
>
> Hello,
>
> This patch was merged into Linus' tree as commit ca8d8e03b4c9 ("iio:
> 104-quad-8: Fix off-by-one error when addressing flag register"). This
> fix should be merged into the 4.10 stable tree as well to fix an
> off-by-one error which causes garbage data to be read as count values --
> effectively preventing proper usage of the driver.
>
> This patch fixes commit 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support
> for the ACCES 104-QUAD-8").
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-15 5:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 15:03 [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register William Breathitt Gray
2017-02-11 9:37 ` Jonathan Cameron
2017-03-13 13:33 ` William Breathitt Gray
2017-03-13 21:33 ` Jonathan Cameron
2017-03-14 15:00 ` William Breathitt Gray
2017-03-15 5:33 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.