From: Lee Jones <lee.jones@linaro.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation
Date: Wed, 15 Mar 2017 12:19:48 +0000 [thread overview]
Message-ID: <20170315121948.ys63ntordjwcm6rb@dell> (raw)
In-Reply-To: <20170314182117.4c6c2162@bbrezillon>
On Tue, 14 Mar 2017, Boris Brezillon wrote:
> On Tue, 14 Mar 2017 17:00:03 +0000
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > On Mon, 20 Feb 2017, Boris Brezillon wrote:
> >
> > > These new helpers + macro definitions are meant to replace the old ones
> > > which are unpractical to use.
> > >
> > > Note that the macros and function prefixes have been intentionally
> > > changed to ATMEL_[H]SMC_XX and atmel_[h]smc_ to reflect the fact that
> > > this IP is also embedded in avr32 SoCs (and not only in at91 ones).
> >
> > I'm going to NACK this patch.
> >
> > I don't see any reason why all those functions have to be inline and
> > shoved into a header file.
>
> Because those are simple conversion helpers, and I thought a
> dedicated C file was not required, but I can move them into a C file
> and export these functions using EXPORT_SYMBOL_GPL() if you prefer.
>
> Would that work for you?
I think that would be better TBH. Those functions aren't all that
simple. There is certainly too much meat on the bones for me to be
happy for them to be shoved into a header file.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation
Date: Wed, 15 Mar 2017 12:19:48 +0000 [thread overview]
Message-ID: <20170315121948.ys63ntordjwcm6rb@dell> (raw)
In-Reply-To: <20170314182117.4c6c2162@bbrezillon>
On Tue, 14 Mar 2017, Boris Brezillon wrote:
> On Tue, 14 Mar 2017 17:00:03 +0000
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > On Mon, 20 Feb 2017, Boris Brezillon wrote:
> >
> > > These new helpers + macro definitions are meant to replace the old ones
> > > which are unpractical to use.
> > >
> > > Note that the macros and function prefixes have been intentionally
> > > changed to ATMEL_[H]SMC_XX and atmel_[h]smc_ to reflect the fact that
> > > this IP is also embedded in avr32 SoCs (and not only in at91 ones).
> >
> > I'm going to NACK this patch.
> >
> > I don't see any reason why all those functions have to be inline and
> > shoved into a header file.
>
> Because those are simple conversion helpers, and I thought a
> dedicated C file was not required, but I can move them into a C file
> and export these functions using EXPORT_SYMBOL_GPL() if you prefer.
>
> Would that work for you?
I think that would be better TBH. Those functions aren't all that
simple. There is certainly too much meat on the bones for me to be
happy for them to be shoved into a header file.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-03-15 12:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 16:54 [PATCH 0/7] memory: atmel-ebi: Add PM ops Boris Brezillon
2017-02-20 16:54 ` Boris Brezillon
2017-02-20 16:54 ` [PATCH 1/7] mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation Boris Brezillon
2017-02-20 16:54 ` Boris Brezillon
2017-03-14 17:00 ` Lee Jones
2017-03-14 17:00 ` Lee Jones
2017-03-14 17:21 ` Boris Brezillon
2017-03-14 17:21 ` Boris Brezillon
2017-03-15 12:19 ` Lee Jones [this message]
2017-03-15 12:19 ` Lee Jones
2017-03-15 13:21 ` Boris Brezillon
2017-03-15 13:21 ` Boris Brezillon
2017-02-20 16:54 ` [PATCH 2/7] memory: atmel-ebi: Simplify SMC config code Boris Brezillon
2017-02-20 16:54 ` Boris Brezillon
2017-03-02 12:02 ` Alexander Dahl
2017-03-02 12:02 ` Alexander Dahl
2017-03-02 12:30 ` Boris Brezillon
2017-03-02 12:30 ` Boris Brezillon
2017-07-24 9:12 ` Alexander Dahl
2017-07-24 9:12 ` Alexander Dahl
2017-07-24 19:21 ` Boris Brezillon
2017-07-24 19:21 ` Boris Brezillon
2017-07-25 11:43 ` Alexander Dahl
2017-07-25 11:43 ` Alexander Dahl
2017-02-20 16:54 ` [PATCH 3/7] memory: atmel-ebi: Stop using reg_field objects for simple things Boris Brezillon
2017-02-20 16:54 ` Boris Brezillon
2017-02-20 16:54 ` [PATCH 4/7] mfd: syscon: atmel-smc: Remove unused helpers/macros Boris Brezillon
2017-02-20 16:54 ` Boris Brezillon
2017-02-20 16:54 ` [PATCH 5/7] memory: atmel-ebi: Change naming scheme Boris Brezillon
2017-02-20 16:54 ` Boris Brezillon
2017-02-20 16:55 ` [PATCH 6/7] memory: atmel-ebi: Add missing ->numcs assignment Boris Brezillon
2017-02-20 16:55 ` Boris Brezillon
2017-02-20 16:55 ` [PATCH 7/7] memory: atmel-ebi: Add PM ops Boris Brezillon
2017-02-20 16:55 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315121948.ys63ntordjwcm6rb@dell \
--to=lee.jones@linaro.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.