All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/6] staging: ks7010: clean up return statement code
@ 2017-03-14 10:20 Tobin C. Harding
  2017-03-14 10:20 ` [PATCH 1/6] staging: ks7010: remove custom return values Tobin C. Harding
                   ` (6 more replies)
  0 siblings, 7 replies; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-14 10:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: driverdev-devel, Wolfram Sang

The need for this patch set arose because driver code uses custom
integer return values to indicate function error. This is in itself
not that useful for other kernel code and also means that the source
code of each function has to be checked to see what the return code
means. Also the return codes are often positive.

In changing the return codes to use standard kernel error codes it
became apparent that a few other clean up tasks could also be
done. goto labels are inconsistent in their naming and usage. Also,
for the uber pedantic, spacing around return statements is not
uniform.

Patch 01 changes custom error codes to standard kernel error codes.

The next two patches rename all identifiers used as return code to
use the same name.

Patch 02: retval -> rc
Patch 03: ret -> rc

Patch 04 audits all goto statements and makes usage and naming uniform
across the driver.

Patch 05 refactors return statement code. Patch is whitespace
only. And it is *ouch* super pedantic.

Patch 06 removes unnecessary definition of identifiers at declaration
time.

Code is untested. Each patch applies and builds on x86_64 and
PowerPC. Tree with patch set applied was checked with Sparse and
Smatch and introduced no new warnings. Also checked with checkpatch
--strict, I don't think series introduces any new warnings (there are
a whole bunch still to go).

Tobin C. Harding (6):
  staging: ks7010: remove custom return values
  staging: ks7010: replace identifier retval with rc
  staging: ks7010: replace identifier ret with rc
  staging: ks7010: make goto label naming uniform
  staging: ks7010: clean up return statement code
  staging: ks7010: remove definition from declaration

 drivers/staging/ks7010/ks7010_sdio.c | 343 +++++++++++++++++------------------
 drivers/staging/ks7010/ks_hostif.c   |  27 ++-
 drivers/staging/ks7010/ks_wlan_net.c |  53 ++++--
 3 files changed, 222 insertions(+), 201 deletions(-)

-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH 1/6] staging: ks7010: remove custom return values
  2017-03-14 10:20 [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
@ 2017-03-14 10:20 ` Tobin C. Harding
  2017-03-14 10:20 ` [PATCH 2/6] staging: ks7010: replace identifier retval with rc Tobin C. Harding
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-14 10:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: driverdev-devel, Wolfram Sang

Driver code uses custom return values (often positive) to signal error
condition instead of using standard kernel error codes.

Replace custom return values with standard kernel error codes.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 drivers/staging/ks7010/ks7010_sdio.c | 161 ++++++++++++++++-------------------
 drivers/staging/ks7010/ks_hostif.c   |  26 +++---
 drivers/staging/ks7010/ks_wlan_net.c |   4 +-
 3 files changed, 93 insertions(+), 98 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index df90c20..f3ae9db 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -241,21 +241,18 @@ static int enqueue_txdev(struct ks_wlan_private *priv, unsigned char *p,
 			 void *arg1, void *arg2)
 {
 	struct tx_device_buffer *sp;
+	int rc;
 
 	if (priv->dev_state < DEVICE_STATE_BOOT) {
-		kfree(p);
-		if (complete_handler)
-			(*complete_handler) (arg1, arg2);
-		return 1;
+		rc = -EPERM;
+		goto err_complete;
 	}
 
 	if ((TX_DEVICE_BUFF_SIZE - 1) <= cnt_txqbody(priv)) {
 		/* in case of buffer overflow */
 		DPRINTK(1, "tx buffer overflow\n");
-		kfree(p);
-		if (complete_handler)
-			(*complete_handler) (arg1, arg2);
-		return 1;
+		rc = -EOVERFLOW;
+		goto err_complete;
 	}
 
 	sp = &priv->tx_dev.tx_dev_buff[priv->tx_dev.qtail];
@@ -267,15 +264,22 @@ static int enqueue_txdev(struct ks_wlan_private *priv, unsigned char *p,
 	inc_txqtail(priv);
 
 	return 0;
+
+err_complete:
+	kfree(p);
+	if (complete_handler)
+		(*complete_handler) (arg1, arg2);
+
+	return rc;
 }
 
 /* write data */
 static int write_to_device(struct ks_wlan_private *priv, unsigned char *buffer,
 			   unsigned long size)
 {
-	int retval;
 	unsigned char rw_data;
 	struct hostif_hdr *hdr;
+	int rc;
 
 	hdr = (struct hostif_hdr *)buffer;
 
@@ -285,18 +289,17 @@ static int write_to_device(struct ks_wlan_private *priv, unsigned char *buffer,
 		return 0;
 	}
 
-	retval = ks7010_sdio_write(priv, DATA_WINDOW, buffer, size);
-	if (retval) {
-		DPRINTK(1, " write error : retval=%d\n", retval);
-		return -4;
+	rc = ks7010_sdio_write(priv, DATA_WINDOW, buffer, size);
+	if (rc) {
+		DPRINTK(1, " write error : retval=%d\n", rc);
+		return rc;
 	}
 
 	rw_data = WRITE_STATUS_BUSY;
-	retval =
-	    ks7010_sdio_write(priv, WRITE_STATUS, &rw_data, sizeof(rw_data));
-	if (retval) {
+	rc = ks7010_sdio_write(priv, WRITE_STATUS, &rw_data, sizeof(rw_data));
+	if (rc) {
 		DPRINTK(1, " error : WRITE_STATUS=%02X\n", rw_data);
-		return -3;
+		return rc;
 	}
 
 	return 0;
@@ -675,30 +678,27 @@ static void trx_device_exit(struct ks_wlan_private *priv)
 
 static int ks7010_sdio_update_index(struct ks_wlan_private *priv, u32 index)
 {
-	int rc = 0;
-	int retval;
+	int rc;
 	unsigned char *data_buf;
 
 	data_buf = kmalloc(sizeof(u32), GFP_KERNEL);
-	if (!data_buf) {
-		rc = 1;
-		goto error_out;
-	}
+	if (!data_buf)
+		return -ENOMEM;
 
 	memcpy(data_buf, &index, sizeof(index));
-	retval = ks7010_sdio_write(priv, WRITE_INDEX, data_buf, sizeof(index));
-	if (retval) {
-		rc = 2;
+	rc = ks7010_sdio_write(priv, WRITE_INDEX, data_buf, sizeof(index));
+	if (rc)
 		goto error_out;
-	}
 
-	retval = ks7010_sdio_write(priv, READ_INDEX, data_buf, sizeof(index));
-	if (retval) {
-		rc = 3;
+	rc = ks7010_sdio_write(priv, READ_INDEX, data_buf, sizeof(index));
+	if (rc)
 		goto error_out;
-	}
+
+	return 0;
+
  error_out:
 	kfree(data_buf);
+
 	return rc;
 }
 
@@ -706,29 +706,28 @@ static int ks7010_sdio_update_index(struct ks_wlan_private *priv, u32 index)
 static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32 address,
 				    unsigned char *data, unsigned int size)
 {
-	int rc = 0;
-	int retval;
+	int rc;
 	unsigned char *read_buf;
 
 	read_buf = kmalloc(ROM_BUFF_SIZE, GFP_KERNEL);
-	if (!read_buf) {
-		rc = 1;
-		goto error_out;
-	}
-	retval = ks7010_sdio_read(priv, address, read_buf, size);
-	if (retval) {
-		rc = 2;
+	if (!read_buf)
+		return -ENOMEM;
+
+	rc = ks7010_sdio_read(priv, address, read_buf, size);
+	if (rc)
 		goto error_out;
-	}
-	retval = memcmp(data, read_buf, size);
 
-	if (retval) {
-		DPRINTK(0, "data compare error (%d)\n", retval);
-		rc = 3;
+	rc = memcmp(data, read_buf, size);
+	if (rc) {
+		DPRINTK(0, "data compare error (%d)\n", rc);
 		goto error_out;
 	}
+
+	return 0;
+
  error_out:
 	kfree(read_buf);
+
 	return rc;
 }
 
@@ -738,28 +737,27 @@ static int ks7010_upload_firmware(struct ks_wlan_private *priv,
 	unsigned int size, offset, n = 0;
 	unsigned char *rom_buf;
 	unsigned char rw_data = 0;
-	int retval, rc = 0;
+	int rc;
 	int length;
 	const struct firmware *fw_entry = NULL;
 
 	/* buffer allocate */
 	rom_buf = kmalloc(ROM_BUFF_SIZE, GFP_KERNEL);
 	if (!rom_buf)
-		return 3;
+		return -ENOMEM;
 
 	sdio_claim_host(card->func);
 
 	/* Firmware running ? */
-	retval = ks7010_sdio_read(priv, GCR_A, &rw_data, sizeof(rw_data));
+	rc = ks7010_sdio_read(priv, GCR_A, &rw_data, sizeof(rw_data));
 	if (rw_data == GCR_A_RUN) {
 		DPRINTK(0, "MAC firmware running ...\n");
-		rc = 0;
-		goto error_out0;
+		goto release_host_and_free;
 	}
 
-	retval = request_firmware(&fw_entry, ROM_FILE, &priv->ks_wlan_hw.sdio_card->func->dev);
-	if (retval)
-		goto error_out0;
+	rc = request_firmware(&fw_entry, ROM_FILE, &priv->ks_wlan_hw.sdio_card->func->dev);
+	if (rc)
+		goto release_host_and_free;
 
 	length = fw_entry->size;
 
@@ -779,67 +777,58 @@ static int ks7010_upload_firmware(struct ks_wlan_private *priv,
 		memcpy(rom_buf, fw_entry->data + n, size);
 		/* Update write index */
 		offset = n;
-		retval =
-		    ks7010_sdio_update_index(priv,
-					     KS7010_IRAM_ADDRESS + offset);
-		if (retval) {
-			rc = 6;
-			goto error_out1;
-		}
+		rc = ks7010_sdio_update_index(priv,
+					      KS7010_IRAM_ADDRESS + offset);
+		if (rc)
+			goto release_firmware;
 
 		/* Write data */
-		retval = ks7010_sdio_write(priv, DATA_WINDOW, rom_buf, size);
-		if (retval) {
-			rc = 8;
-			goto error_out1;
-		}
+		rc = ks7010_sdio_write(priv, DATA_WINDOW, rom_buf, size);
+		if (rc)
+			goto release_firmware;
 
 		/* compare */
-		retval =
-		    ks7010_sdio_data_compare(priv, DATA_WINDOW, rom_buf, size);
-		if (retval) {
-			rc = 9;
-			goto error_out1;
-		}
+		rc = ks7010_sdio_data_compare(priv, DATA_WINDOW, rom_buf, size);
+		if (rc)
+			goto release_firmware;
+
 		n += size;
 
 	} while (size);
 
 	/* Remap request */
 	rw_data = GCR_A_REMAP;
-	retval = ks7010_sdio_write(priv, GCR_A, &rw_data, sizeof(rw_data));
-	if (retval) {
-		rc = 11;
-		goto error_out1;
-	}
+	rc = ks7010_sdio_write(priv, GCR_A, &rw_data, sizeof(rw_data));
+	if (rc)
+		goto release_firmware;
+
 	DPRINTK(4, " REMAP Request : GCR_A=%02X\n", rw_data);
 
 	/* Firmware running check */
 	for (n = 0; n < 50; ++n) {
 		mdelay(10);	/* wait_ms(10); */
-		retval =
-		    ks7010_sdio_read(priv, GCR_A, &rw_data, sizeof(rw_data));
-		if (retval) {
-			rc = 11;
-			goto error_out1;
-		}
+		rc = ks7010_sdio_read(priv, GCR_A, &rw_data, sizeof(rw_data));
+		if (rc)
+			goto release_firmware;
+
 		if (rw_data == GCR_A_RUN)
 			break;
 	}
 	DPRINTK(4, "firmware wakeup (%d)!!!!\n", n);
 	if ((50) <= n) {
 		DPRINTK(1, "firmware can't start\n");
-		rc = 12;
-		goto error_out1;
+		rc = -EIO;
+		goto release_firmware;
 	}
 
 	rc = 0;
 
- error_out1:
+ release_firmware:
 	release_firmware(fw_entry);
- error_out0:
+ release_host_and_free:
 	sdio_release_host(card->func);
 	kfree(rom_buf);
+
 	return rc;
 }
 
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 1e49717..db10e16 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -110,14 +110,13 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
 	struct local_ap_t *ap;
 	union iwreq_data wrqu;
 	struct net_device *netdev = priv->net_dev;
-	int rc = 0;
 
 	DPRINTK(3, "\n");
 	ap = &priv->current_ap;
 
 	if ((priv->connect_status & CONNECT_STATUS_MASK) == DISCONNECT_STATUS) {
 		memset(ap, 0, sizeof(struct local_ap_t));
-		return 1;
+		return -EPERM;
 	}
 
 	/* bssid */
@@ -198,7 +197,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
 	DPRINTK(4, "\n    ext_rate_set_size=%d\n    rate_set_size=%d\n",
 		ap_info->ext_rate_set.size, ap_info->rate_set.size);
 
-	return rc;
+	return 0;
 }
 
 static
@@ -1125,12 +1124,13 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet)
 	struct ieee802_1x_hdr *aa1x_hdr;
 	struct wpa_eapol_key *eap_key;
 	struct ethhdr *eth;
+	int rc;
 
 	packet_len = packet->len;
 	if (packet_len > ETH_FRAME_LEN) {
 		DPRINTK(1, "bad length packet_len=%d\n", packet_len);
-		dev_kfree_skb(packet);
-		return -1;
+		rc = -EOVERFLOW;
+		goto err_kfree_skb;
 	}
 
 	if (((priv->connect_status & CONNECT_STATUS_MASK) == DISCONNECT_STATUS)
@@ -1157,8 +1157,8 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet)
 
 	if (!pp) {
 		DPRINTK(3, "allocate memory failed..\n");
-		dev_kfree_skb(packet);
-		return -2;
+		rc = -ENOMEM;
+		goto err_kfree_skb;
 	}
 
 	p = (unsigned char *)pp->data;
@@ -1171,9 +1171,8 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet)
 	if (memcmp(&priv->eth_addr[0], eth->h_source, ETH_ALEN)) {
 		DPRINTK(1, "invalid mac address !!\n");
 		DPRINTK(1, "ethernet->h_source=%pM\n", eth->h_source);
-		dev_kfree_skb(packet);
-		kfree(pp);
-		return -3;
+		rc = -ENXIO;
+		goto err_kfree;
 	}
 
 	/* MAC address copy */
@@ -1276,6 +1275,13 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet)
 	}
 
 	return result;
+
+err_kfree:
+	kfree(pp);
+err_kfree_skb:
+	dev_kfree_skb(packet);
+
+	return rc;
 }
 
 #define ps_confirm_wait_inc(priv) do { \
diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index 0852a1d..f384dd2 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -89,10 +89,10 @@ int ks_wlan_update_phy_information(struct ks_wlan_private *priv)
 	DPRINTK(4, "in_interrupt = %ld\n", in_interrupt());
 
 	if (priv->dev_state < DEVICE_STATE_READY)
-		return -1;	/* not finished initialize */
+		return -EBUSY;	/* not finished initialize */
 
 	if (atomic_read(&update_phyinfo))
-		return 1;
+		return -EPERM;
 
 	/* The status */
 	wstats->status = priv->reg.operation_mode;	/* Operation mode */
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH 2/6] staging: ks7010: replace identifier retval with rc
  2017-03-14 10:20 [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
  2017-03-14 10:20 ` [PATCH 1/6] staging: ks7010: remove custom return values Tobin C. Harding
@ 2017-03-14 10:20 ` Tobin C. Harding
  2017-03-16  2:40   ` Greg Kroah-Hartman
  2017-03-14 10:20 ` [PATCH 3/6] staging: ks7010: replace identifier ret " Tobin C. Harding
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-14 10:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: driverdev-devel, Wolfram Sang

Code uses identifiers retval, ret, and rc all for function return
values. It would be more readable if the whole driver used a single
identifier for this task. Lets use 'rc' since it is the shortest.

Change retval -> rc

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 drivers/staging/ks7010/ks7010_sdio.c | 72 ++++++++++++++++++------------------
 1 file changed, 36 insertions(+), 36 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index f3ae9db..3da34b1 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -89,7 +89,7 @@ static int ks7010_sdio_write(struct ks_wlan_private *priv, unsigned int address,
 static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv)
 {
 	unsigned char rw_data;
-	int retval;
+	int rc;
 
 	DPRINTK(4, "\n");
 
@@ -98,9 +98,9 @@ static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv)
 
 	if (atomic_read(&priv->sleepstatus.status) == 0) {
 		rw_data = GCR_B_DOZE;
-		retval =
+		rc =
 		    ks7010_sdio_write(priv, GCR_B, &rw_data, sizeof(rw_data));
-		if (retval) {
+		if (rc) {
 			DPRINTK(1, " error : GCR_B=%02X\n", rw_data);
 			goto out;
 		}
@@ -119,7 +119,7 @@ static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv)
 static void ks_wlan_hw_sleep_wakeup_request(struct ks_wlan_private *priv)
 {
 	unsigned char rw_data;
-	int retval;
+	int rc;
 
 	DPRINTK(4, "\n");
 
@@ -128,9 +128,9 @@ static void ks_wlan_hw_sleep_wakeup_request(struct ks_wlan_private *priv)
 
 	if (atomic_read(&priv->sleepstatus.status) == 1) {
 		rw_data = WAKEUP_REQ;
-		retval =
+		rc =
 		    ks7010_sdio_write(priv, WAKEUP, &rw_data, sizeof(rw_data));
-		if (retval) {
+		if (rc) {
 			DPRINTK(1, " error : WAKEUP=%02X\n", rw_data);
 			goto out;
 		}
@@ -149,14 +149,14 @@ static void ks_wlan_hw_sleep_wakeup_request(struct ks_wlan_private *priv)
 void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv)
 {
 	unsigned char rw_data;
-	int retval;
+	int rc;
 
 	DPRINTK(4, "\n");
 	if (atomic_read(&priv->psstatus.status) == PS_SNOOZE) {
 		rw_data = WAKEUP_REQ;
-		retval =
+		rc =
 		    ks7010_sdio_write(priv, WAKEUP, &rw_data, sizeof(rw_data));
-		if (retval)
+		if (rc)
 			DPRINTK(1, " error : WAKEUP=%02X\n", rw_data);
 
 		DPRINTK(4, "wake up : WAKEUP=%02X\n", rw_data);
@@ -171,7 +171,7 @@ void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv)
 static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
 {
 	unsigned char rw_data;
-	int retval;
+	int rc;
 
 	if (priv->reg.powermgt == POWMGT_ACTIVE_MODE)
 		return 0;
@@ -195,9 +195,9 @@ static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
 	if (!atomic_read(&priv->psstatus.confirm_wait) &&
 		!atomic_read(&priv->psstatus.snooze_guard) &&
 		!cnt_txqbody(priv)) {
-		retval = ks7010_sdio_read(priv, INT_PENDING, &rw_data,
+		rc = ks7010_sdio_read(priv, INT_PENDING, &rw_data,
 					  sizeof(rw_data));
-		if (retval) {
+		if (rc) {
 			DPRINTK(1, " error : INT_PENDING=%02X\n", rw_data);
 			queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
 					   &priv->ks_wlan_hw.rw_wq, 1);
@@ -205,9 +205,9 @@ static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
 		}
 		if (!rw_data) {
 			rw_data = GCR_B_DOZE;
-			retval = ks7010_sdio_write(priv, GCR_B, &rw_data,
+			rc = ks7010_sdio_write(priv, GCR_B, &rw_data,
 						   sizeof(rw_data));
-			if (retval) {
+			if (rc) {
 				DPRINTK(1, " error : GCR_B=%02X\n", rw_data);
 				queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
 						   &priv->ks_wlan_hw.rw_wq, 1);
@@ -291,7 +291,7 @@ static int write_to_device(struct ks_wlan_private *priv, unsigned char *buffer,
 
 	rc = ks7010_sdio_write(priv, DATA_WINDOW, buffer, size);
 	if (rc) {
-		DPRINTK(1, " write error : retval=%d\n", rc);
+		DPRINTK(1, " write error : rc=%d\n", rc);
 		return rc;
 	}
 
@@ -388,7 +388,7 @@ static void rx_event_task(unsigned long dev)
 static void ks_wlan_hw_rx(void *dev, uint16_t size)
 {
 	struct ks_wlan_private *priv = (struct ks_wlan_private *)dev;
-	int retval;
+	int rc;
 	struct rx_device_buffer *rx_buffer;
 	struct hostif_hdr *hdr;
 	unsigned char read_status;
@@ -404,10 +404,10 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 	}
 	rx_buffer = &priv->rx_dev.rx_dev_buff[priv->rx_dev.qtail];
 
-	retval =
+	rc =
 	    ks7010_sdio_read(priv, DATA_WINDOW, &rx_buffer->data[0],
 			     hif_align_size(size));
-	if (retval)
+	if (rc)
 		goto error_out;
 
 	/* length check */
@@ -420,10 +420,10 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 #endif
 		/* rx_status update */
 		read_status = READ_STATUS_IDLE;
-		retval =
+		rc =
 		    ks7010_sdio_write(priv, READ_STATUS, &read_status,
 				      sizeof(read_status));
-		if (retval)
+		if (rc)
 			DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
 
 		goto error_out;
@@ -436,10 +436,10 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 
 	/* read status update */
 	read_status = READ_STATUS_IDLE;
-	retval =
+	rc =
 	    ks7010_sdio_write(priv, READ_STATUS, &read_status,
 			      sizeof(read_status));
-	if (retval)
+	if (rc)
 		DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
 
 	DPRINTK(4, "READ_STATUS=%02X\n", read_status);
@@ -463,7 +463,7 @@ static void ks7010_rw_function(struct work_struct *work)
 	struct hw_info_t *hw;
 	struct ks_wlan_private *priv;
 	unsigned char rw_data;
-	int retval;
+	int rc;
 
 	hw = container_of(work, struct hw_info_t, rw_wq.work);
 	priv = container_of(hw, struct ks_wlan_private, ks_wlan_hw);
@@ -512,9 +512,9 @@ static void ks7010_rw_function(struct work_struct *work)
 	}
 
 	/* read (WriteStatus/ReadDataSize FN1:00_0014) */
-	retval =
+	rc =
 	    ks7010_sdio_read(priv, WSTATUS_RSIZE, &rw_data, sizeof(rw_data));
-	if (retval) {
+	if (rc) {
 		DPRINTK(1, " error : WSTATUS_RSIZE=%02X psstatus=%d\n", rw_data,
 			atomic_read(&priv->psstatus.status));
 		goto err_out;
@@ -536,7 +536,7 @@ static void ks7010_rw_function(struct work_struct *work)
 
 static void ks_sdio_interrupt(struct sdio_func *func)
 {
-	int retval;
+	int rc;
 	struct ks_sdio_card *card;
 	struct ks_wlan_private *priv;
 	unsigned char status, rsize, rw_data;
@@ -546,11 +546,11 @@ static void ks_sdio_interrupt(struct sdio_func *func)
 	DPRINTK(4, "\n");
 
 	if (priv->dev_state >= DEVICE_STATE_BOOT) {
-		retval =
+		rc =
 		    ks7010_sdio_read(priv, INT_PENDING, &status,
 				     sizeof(status));
-		if (retval) {
-			DPRINTK(1, "read INT_PENDING Failed!!(%d)\n", retval);
+		if (rc) {
+			DPRINTK(1, "read INT_PENDING Failed!!(%d)\n", rc);
 			goto intr_out;
 		}
 		DPRINTK(4, "INT_PENDING=%02X\n", rw_data);
@@ -562,10 +562,10 @@ static void ks_sdio_interrupt(struct sdio_func *func)
 		/* bit2 -> Read Status Busy  */
 		if (status & INT_GCR_B
 		    || atomic_read(&priv->psstatus.status) == PS_SNOOZE) {
-			retval =
+			rc =
 			    ks7010_sdio_read(priv, GCR_B, &rw_data,
 					     sizeof(rw_data));
-			if (retval) {
+			if (rc) {
 				DPRINTK(1, " error : GCR_B=%02X\n", rw_data);
 				goto intr_out;
 			}
@@ -583,10 +583,10 @@ static void ks_sdio_interrupt(struct sdio_func *func)
 
 		do {
 			/* read (WriteStatus/ReadDataSize FN1:00_0014) */
-			retval =
+			rc =
 			    ks7010_sdio_read(priv, WSTATUS_RSIZE, &rw_data,
 					     sizeof(rw_data));
-			if (retval) {
+			if (rc) {
 				DPRINTK(1, " error : WSTATUS_RSIZE=%02X\n",
 					rw_data);
 				goto intr_out;
@@ -603,14 +603,14 @@ static void ks_sdio_interrupt(struct sdio_func *func)
 				    && !cnt_txqbody(priv)) {
 					/* dummy write for interrupt clear */
 					rw_data = 0;
-					retval =
+					rc =
 					    ks7010_sdio_write(priv, DATA_WINDOW,
 							      &rw_data,
 							      sizeof(rw_data));
-					if (retval) {
+					if (rc) {
 						DPRINTK(1,
 							"write DATA_WINDOW Failed!!(%d)\n",
-							retval);
+							rc);
 					}
 					status &= ~INT_WRITE_STATUS;
 				} else {
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH 3/6] staging: ks7010: replace identifier ret with rc
  2017-03-14 10:20 [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
  2017-03-14 10:20 ` [PATCH 1/6] staging: ks7010: remove custom return values Tobin C. Harding
  2017-03-14 10:20 ` [PATCH 2/6] staging: ks7010: replace identifier retval with rc Tobin C. Harding
@ 2017-03-14 10:20 ` Tobin C. Harding
  2017-03-16  2:41   ` Greg Kroah-Hartman
  2017-03-14 10:20 ` [PATCH 4/6] staging: ks7010: make goto label naming uniform Tobin C. Harding
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-14 10:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: driverdev-devel, Wolfram Sang

Code uses identifier names ret, and rc for function return
values. It would be more readable if the whole driver used a single
identifier for this task. Lets use 'rc' since it is the shortest.

Change ret -> rc

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 drivers/staging/ks7010/ks7010_sdio.c | 48 ++++++++++++++++++------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 3da34b1..213dae9 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -920,7 +920,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	struct ks_sdio_card *card;
 	struct net_device *netdev;
 	unsigned char rw_data;
-	int ret;
+	int rc;
 
 	DPRINTK(5, "ks7010_sdio_probe()\n");
 
@@ -942,29 +942,29 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	/* Issue config request to override clock rate */
 
 	/* function blocksize set */
-	ret = sdio_set_block_size(func, KS7010_IO_BLOCK_SIZE);
+	rc = sdio_set_block_size(func, KS7010_IO_BLOCK_SIZE);
 	DPRINTK(5, "multi_block=%d sdio_set_block_size()=%d %d\n",
-		func->card->cccr.multi_block, func->cur_blksize, ret);
+		func->card->cccr.multi_block, func->cur_blksize, rc);
 
 	/* Allocate the slot current */
 
 	/* function enable */
-	ret = sdio_enable_func(func);
-	DPRINTK(5, "sdio_enable_func() %d\n", ret);
-	if (ret)
+	rc = sdio_enable_func(func);
+	DPRINTK(5, "sdio_enable_func() %d\n", rc);
+	if (rc)
 		goto error_free_card;
 
 	/* interrupt disable */
-	sdio_writeb(func, 0, INT_ENABLE, &ret);
-	if (ret)
+	sdio_writeb(func, 0, INT_ENABLE, &rc);
+	if (rc)
 		goto error_free_card;
-	sdio_writeb(func, 0xff, INT_PENDING, &ret);
-	if (ret)
+	sdio_writeb(func, 0xff, INT_PENDING, &rc);
+	if (rc)
 		goto error_disable_func;
 
 	/* setup interrupt handler */
-	ret = sdio_claim_irq(func, ks_sdio_interrupt);
-	if (ret)
+	rc = sdio_claim_irq(func, ks_sdio_interrupt);
+	if (rc)
 		goto error_disable_func;
 
 	sdio_release_host(func);
@@ -1020,11 +1020,11 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	ks7010_init_defaults(priv);
 
 	/* Upload firmware */
-	ret = ks7010_upload_firmware(priv, card);	/* firmware load */
-	if (ret) {
+	rc = ks7010_upload_firmware(priv, card);	/* firmware load */
+	if (rc) {
 		dev_err(&card->func->dev,
 			"ks7010: firmware load failed !! return code = %d\n",
-			 ret);
+			rc);
 		goto error_free_read_buf;
 	}
 
@@ -1032,9 +1032,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	/* clear Interrupt status write (ARMtoSD_InterruptPending FN1:00_0024) */
 	rw_data = 0xff;
 	sdio_claim_host(func);
-	ret = ks7010_sdio_write(priv, INT_PENDING, &rw_data, sizeof(rw_data));
+	rc = ks7010_sdio_write(priv, INT_PENDING, &rw_data, sizeof(rw_data));
 	sdio_release_host(func);
-	if (ret)
+	if (rc)
 		DPRINTK(1, " error : INT_PENDING=%02X\n", rw_data);
 
 	DPRINTK(4, " clear Interrupt : INT_PENDING=%02X\n", rw_data);
@@ -1042,9 +1042,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	/* enable ks7010sdio interrupt (INT_GCR_B|INT_READ_STATUS|INT_WRITE_STATUS) */
 	rw_data = (INT_GCR_B | INT_READ_STATUS | INT_WRITE_STATUS);
 	sdio_claim_host(func);
-	ret = ks7010_sdio_write(priv, INT_ENABLE, &rw_data, sizeof(rw_data));
+	rc = ks7010_sdio_write(priv, INT_ENABLE, &rw_data, sizeof(rw_data));
 	sdio_release_host(func);
-	if (ret)
+	if (rc)
 		DPRINTK(1, " error : INT_ENABLE=%02X\n", rw_data);
 
 	DPRINTK(4, " enable Interrupt : INT_ENABLE=%02X\n", rw_data);
@@ -1059,8 +1059,8 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	INIT_DELAYED_WORK(&priv->ks_wlan_hw.rw_wq, ks7010_rw_function);
 	ks7010_card_init(priv);
 
-	ret = register_netdev(priv->net_dev);
-	if (ret)
+	rc = register_netdev(priv->net_dev);
+	if (rc)
 		goto error_free_read_buf;
 
 	return 0;
@@ -1086,7 +1086,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 
 static void ks7010_sdio_remove(struct sdio_func *func)
 {
-	int ret;
+	int rc;
 	struct ks_sdio_card *card;
 	struct ks_wlan_private *priv;
 
@@ -1107,8 +1107,8 @@ static void ks7010_sdio_remove(struct sdio_func *func)
 
 		/* interrupt disable */
 		sdio_claim_host(func);
-		sdio_writeb(func, 0, INT_ENABLE, &ret);
-		sdio_writeb(func, 0xff, INT_PENDING, &ret);
+		sdio_writeb(func, 0, INT_ENABLE, &rc);
+		sdio_writeb(func, 0xff, INT_PENDING, &rc);
 		sdio_release_host(func);
 		DPRINTK(1, "interrupt disable\n");
 
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH 4/6] staging: ks7010: make goto label naming uniform
  2017-03-14 10:20 [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
                   ` (2 preceding siblings ...)
  2017-03-14 10:20 ` [PATCH 3/6] staging: ks7010: replace identifier ret " Tobin C. Harding
@ 2017-03-14 10:20 ` Tobin C. Harding
  2017-03-14 10:20 ` [PATCH 5/6] staging: ks7010: clean up return statement code Tobin C. Harding
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-14 10:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: driverdev-devel, Wolfram Sang

Driver has some functions using goto statements without clean up code
being done after label.

There are multiple goto labels covering identical situations. If we
use the same label to cover the same situation it makes the code
easier to read. If naming conventions are uniform across the
whole driver readability is also increased.

One call site appears, at first glance, to be a bug (missing braces)
however it is not. If we comment this code the next developer need not
pause to check if it is correct or not.

A general audit of goto statement usage and return statements would
add to the overall cleanliness of the driver.

Rename goto labels using uniform conventions. Audit all return
statements. Comment obfuscated code.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 drivers/staging/ks7010/ks7010_sdio.c | 52 +++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 27 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 213dae9..3a0fe44 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -400,7 +400,7 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 	if (cnt_rxqbody(priv) >= (RX_DEVICE_BUFF_SIZE - 1)) {
 		/* in case of buffer overflow */
 		DPRINTK(1, "rx buffer overflow\n");
-		goto error_out;
+		return;
 	}
 	rx_buffer = &priv->rx_dev.rx_dev_buff[priv->rx_dev.qtail];
 
@@ -408,7 +408,7 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 	    ks7010_sdio_read(priv, DATA_WINDOW, &rx_buffer->data[0],
 			     hif_align_size(size));
 	if (rc)
-		goto error_out;
+		return;
 
 	/* length check */
 	if (size > 2046 || size == 0) {
@@ -426,7 +426,8 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 		if (rc)
 			DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
 
-		goto error_out;
+		/* length check failed */
+		return;
 	}
 
 	hdr = (struct hostif_hdr *)&rx_buffer->data[0];
@@ -453,9 +454,6 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 
 	/* rx_event_task((void *)priv); */
 	tasklet_schedule(&priv->ks_wlan_hw.rx_bh_task);
-
- error_out:
-	return;
 }
 
 static void ks7010_rw_function(struct work_struct *work)
@@ -688,15 +686,15 @@ static int ks7010_sdio_update_index(struct ks_wlan_private *priv, u32 index)
 	memcpy(data_buf, &index, sizeof(index));
 	rc = ks7010_sdio_write(priv, WRITE_INDEX, data_buf, sizeof(index));
 	if (rc)
-		goto error_out;
+		goto err_kfree;
 
 	rc = ks7010_sdio_write(priv, READ_INDEX, data_buf, sizeof(index));
 	if (rc)
-		goto error_out;
+		goto err_kfree;
 
 	return 0;
 
- error_out:
+ err_kfree:
 	kfree(data_buf);
 
 	return rc;
@@ -715,17 +713,17 @@ static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32 address,
 
 	rc = ks7010_sdio_read(priv, address, read_buf, size);
 	if (rc)
-		goto error_out;
+		goto err_kfree;
 
 	rc = memcmp(data, read_buf, size);
 	if (rc) {
 		DPRINTK(0, "data compare error (%d)\n", rc);
-		goto error_out;
+		goto err_kfree;
 	}
 
 	return 0;
 
- error_out:
+ err_kfree:
 	kfree(read_buf);
 
 	return rc;
@@ -952,20 +950,20 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	rc = sdio_enable_func(func);
 	DPRINTK(5, "sdio_enable_func() %d\n", rc);
 	if (rc)
-		goto error_free_card;
+		goto err_free_card;
 
 	/* interrupt disable */
 	sdio_writeb(func, 0, INT_ENABLE, &rc);
 	if (rc)
-		goto error_free_card;
+		goto err_free_card;
 	sdio_writeb(func, 0xff, INT_PENDING, &rc);
 	if (rc)
-		goto error_disable_func;
+		goto err_disable_func;
 
 	/* setup interrupt handler */
 	rc = sdio_claim_irq(func, ks_sdio_interrupt);
 	if (rc)
-		goto error_disable_func;
+		goto err_disable_func;
 
 	sdio_release_host(func);
 
@@ -978,12 +976,12 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	netdev = alloc_etherdev(sizeof(*priv));
 	if (!netdev) {
 		dev_err(&card->func->dev, "ks7010 : Unable to alloc new net device\n");
-		goto error_release_irq;
+		goto err_release_irq;
 	}
 	if (dev_alloc_name(netdev, "wlan%d") < 0) {
 		dev_err(&card->func->dev,
 			"ks7010 :  Couldn't get name!\n");
-		goto error_free_netdev;
+		goto err_free_netdev;
 	}
 
 	priv = netdev_priv(netdev);
@@ -997,7 +995,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	priv->ks_wlan_hw.read_buf = NULL;
 	priv->ks_wlan_hw.read_buf = kmalloc(RX_DATA_SIZE, GFP_KERNEL);
 	if (!priv->ks_wlan_hw.read_buf)
-		goto error_free_netdev;
+		goto err_free_netdev;
 
 	priv->dev_state = DEVICE_STATE_PREBOOT;
 	priv->net_dev = netdev;
@@ -1025,7 +1023,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 		dev_err(&card->func->dev,
 			"ks7010: firmware load failed !! return code = %d\n",
 			rc);
-		goto error_free_read_buf;
+		goto err_free_read_buf;
 	}
 
 	/* interrupt setting */
@@ -1053,7 +1051,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	priv->ks_wlan_hw.ks7010sdio_wq = create_workqueue("ks7010sdio_wq");
 	if (!priv->ks_wlan_hw.ks7010sdio_wq) {
 		DPRINTK(1, "create_workqueue failed !!\n");
-		goto error_free_read_buf;
+		goto err_free_read_buf;
 	}
 
 	INIT_DELAYED_WORK(&priv->ks_wlan_hw.rw_wq, ks7010_rw_function);
@@ -1061,22 +1059,22 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 
 	rc = register_netdev(priv->net_dev);
 	if (rc)
-		goto error_free_read_buf;
+		goto err_free_read_buf;
 
 	return 0;
 
- error_free_read_buf:
+ err_free_read_buf:
 	kfree(priv->ks_wlan_hw.read_buf);
 	priv->ks_wlan_hw.read_buf = NULL;
- error_free_netdev:
+ err_free_netdev:
 	free_netdev(priv->net_dev);
 	card->priv = NULL;
- error_release_irq:
+ err_release_irq:
 	sdio_claim_host(func);
 	sdio_release_irq(func);
- error_disable_func:
+ err_disable_func:
 	sdio_disable_func(func);
- error_free_card:
+ err_free_card:
 	sdio_release_host(func);
 	sdio_set_drvdata(func, NULL);
 	kfree(card);
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH 5/6] staging: ks7010: clean up return statement code
  2017-03-14 10:20 [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
                   ` (3 preceding siblings ...)
  2017-03-14 10:20 ` [PATCH 4/6] staging: ks7010: make goto label naming uniform Tobin C. Harding
@ 2017-03-14 10:20 ` Tobin C. Harding
  2017-03-14 10:20 ` [PATCH 6/6] staging: ks7010: remove definition from declaration Tobin C. Harding
  2017-03-21  2:36 ` [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
  6 siblings, 0 replies; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-14 10:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: driverdev-devel, Wolfram Sang

All return statement call sites and associated identifiers and goto
labels have been audited in previous patches. There remains just a few
hodgepodge refactor changes to make ks7010 super clean in regard to
function returns.

Spacing around return statement varies, we can be super pedantic and make this
uniform. And finally we can do whitespace refactor on any calls
that involve the return code 'rc' identifier (since the identifier was
previously shortened).

Refactor call sites that involve the identifier 'rc'. Make spacing
around calls to return uniform. Make whitespace changes only.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 drivers/staging/ks7010/ks7010_sdio.c | 16 +++++--------
 drivers/staging/ks7010/ks_hostif.c   |  1 +
 drivers/staging/ks7010/ks_wlan_net.c | 45 ++++++++++++++++++++++++++++++------
 3 files changed, 45 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 3a0fe44..6d6b9d5 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -318,8 +318,7 @@ static void tx_device_task(void *dev)
 		if (priv->dev_state >= DEVICE_STATE_BOOT) {
 			rc = write_to_device(priv, sp->sendp, sp->size);
 			if (rc) {
-				DPRINTK(1, "write_to_device error !!(%d)\n",
-					rc);
+				DPRINTK(1, "write_to_device error !(%d)\n", rc);
 				queue_delayed_work(priv->ks_wlan_hw.
 						   ks7010sdio_wq,
 						   &priv->ks_wlan_hw.rw_wq, 1);
@@ -404,9 +403,8 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 	}
 	rx_buffer = &priv->rx_dev.rx_dev_buff[priv->rx_dev.qtail];
 
-	rc =
-	    ks7010_sdio_read(priv, DATA_WINDOW, &rx_buffer->data[0],
-			     hif_align_size(size));
+	rc = ks7010_sdio_read(priv, DATA_WINDOW, &rx_buffer->data[0],
+			      hif_align_size(size));
 	if (rc)
 		return;
 
@@ -420,9 +418,8 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 #endif
 		/* rx_status update */
 		read_status = READ_STATUS_IDLE;
-		rc =
-		    ks7010_sdio_write(priv, READ_STATUS, &read_status,
-				      sizeof(read_status));
+		rc = ks7010_sdio_write(priv, READ_STATUS, &read_status,
+				       sizeof(read_status));
 		if (rc)
 			DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
 
@@ -1021,8 +1018,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	rc = ks7010_upload_firmware(priv, card);	/* firmware load */
 	if (rc) {
 		dev_err(&card->func->dev,
-			"ks7010: firmware load failed !! return code = %d\n",
-			rc);
+			"ks7010: firmware load failed! return code = %d\n", rc);
 		goto err_free_read_buf;
 	}
 
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index db10e16..6fa2d55 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -101,6 +101,7 @@ int ks_wlan_do_power_save(struct ks_wlan_private *priv)
 		hostif_sme_enqueue(priv, SME_POW_MNGMT_REQUEST);
 	else
 		priv->dev_state = DEVICE_STATE_READY;
+
 	return 0;
 }
 
diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index f384dd2..47a618f 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -327,6 +327,7 @@ static int ks_wlan_set_essid(struct net_device *dev,
 //      return  -EINPROGRESS;   /* Call commit handler */
 	ks_wlan_setup_parameter(priv, priv->need_commit);
 	priv->need_commit = 0;
+
 	return 0;
 }
 
@@ -407,6 +408,7 @@ static int ks_wlan_set_wap(struct net_device *dev, struct iw_request_info *info,
 		priv->need_commit |= SME_MODE_SET;
 		return -EINPROGRESS;	/* Call commit handler */
 	}
+
 	return 0;
 }
 
@@ -1006,6 +1008,7 @@ static int ks_wlan_set_encode(struct net_device *dev,
 		ks_wlan_setup_parameter(priv, priv->need_commit);
 		priv->need_commit = 0;
 	}
+
 	return 0;
 }
 
@@ -1088,6 +1091,7 @@ static int ks_wlan_get_txpow(struct net_device *dev,
 	vwrq->value = 0;
 	vwrq->disabled = (vwrq->value == 0);
 	vwrq->fixed = 1;
+
 	return 0;
 }
 
@@ -1114,6 +1118,7 @@ static int ks_wlan_get_retry(struct net_device *dev,
 	vwrq->value = 0;
 	vwrq->disabled = (vwrq->value == 0);
 	vwrq->fixed = 1;
+
 	return 0;
 }
 #endif /* KSC_OPNOTSUPP */
@@ -1349,6 +1354,7 @@ static int ks_wlan_get_sens(struct net_device *dev,
 	vwrq->value = 0;
 	vwrq->disabled = (vwrq->value == 0);
 	vwrq->fixed = 1;
+
 	return 0;
 }
 #endif /* KSC_OPNOTSUPP */
@@ -1658,6 +1664,7 @@ static int ks_wlan_config_commit(struct net_device *dev,
 
 	ks_wlan_setup_parameter(priv, priv->need_commit);
 	priv->need_commit = 0;
+
 	return 0;
 }
 
@@ -1674,9 +1681,9 @@ static int ks_wlan_set_genie(struct net_device *dev,
 
 	if (priv->sleep_mode == SLP_SLEEP)
 		return -EPERM;
+
 	/* for SLEEP MODE */
 	return 0;
-//      return -EOPNOTSUPP;
 }
 
 /*------------------------------------------------------------------*/
@@ -1813,6 +1820,7 @@ static int ks_wlan_set_auth_mode(struct net_device *dev,
 		ks_wlan_setup_parameter(priv, priv->need_commit);
 		priv->need_commit = 0;
 	}
+
 	return 0;
 }
 
@@ -1859,6 +1867,7 @@ static int ks_wlan_get_auth_mode(struct net_device *dev,
 		/* return -EOPNOTSUPP; */
 		break;
 	}
+
 	return 0;
 }
 
@@ -2093,6 +2102,7 @@ static int ks_wlan_set_pmksa(struct net_device *dev,
 	}
 
 	hostif_sme_enqueue(priv, SME_SET_PMKSA);
+
 	return 0;
 }
 
@@ -2140,6 +2150,7 @@ static int ks_wlan_set_stop_request(struct net_device *dev,
 		return -EINVAL;
 
 	hostif_sme_enqueue(priv, SME_STOP_REQUEST);
+
 	return 0;
 }
 
@@ -2183,6 +2194,7 @@ static int ks_wlan_get_firmware_version(struct net_device *dev,
 	    (struct ks_wlan_private *)netdev_priv(dev);
 	strcpy(extra, priv->firmware_version);
 	dwrq->length = priv->version_size + 1;
+
 	return 0;
 }
 
@@ -2210,6 +2222,7 @@ static int ks_wlan_set_detach(struct net_device *dev,
 	} else {
 		return -EINVAL;
 	}
+
 	return 0;
 }
 
@@ -2226,6 +2239,7 @@ static int ks_wlan_get_detach(struct net_device *dev,
 
 	/* for SLEEP MODE */
 	*uwrq = ((priv->connect_status & FORCE_DISCONNECT) ? 1 : 0);
+
 	return 0;
 }
 
@@ -2242,6 +2256,7 @@ static int ks_wlan_get_connect(struct net_device *dev,
 
 	/* for SLEEP MODE */
 	*uwrq = (priv->connect_status & CONNECT_STATUS_MASK);
+
 	return 0;
 }
 #endif
@@ -2285,6 +2300,7 @@ static int ks_wlan_get_preamble(struct net_device *dev,
 
 	/* for SLEEP MODE */
 	*uwrq = priv->reg.preamble;
+
 	return 0;
 }
 
@@ -2336,6 +2352,7 @@ static int ks_wlan_get_powermgt(struct net_device *dev,
 
 	/* for SLEEP MODE */
 	*uwrq = priv->reg.powermgt;
+
 	return 0;
 }
 
@@ -2375,6 +2392,7 @@ static int ks_wlan_get_scan_type(struct net_device *dev,
 		return -EPERM;
 	/* for SLEEP MODE */
 	*uwrq = priv->reg.scan_type;
+
 	return 0;
 }
 
@@ -2505,6 +2523,7 @@ static int ks_wlan_get_wep_ascii(struct net_device *dev,
 
 	memcpy(extra, tmp, len);
 	dwrq->length = len + 1;
+
 	return 0;
 }
 #endif
@@ -2529,9 +2548,9 @@ static int ks_wlan_set_beacon_lost(struct net_device *dev,
 	if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
 		priv->need_commit |= SME_MODE_SET;
 		return -EINPROGRESS;	/* Call commit handler */
-	} else {
-		return 0;
 	}
+
+	return 0;
 }
 
 /*------------------------------------------------------------------*/
@@ -2547,6 +2566,7 @@ static int ks_wlan_get_beacon_lost(struct net_device *dev,
 		return -EPERM;
 	/* for SLEEP MODE */
 	*uwrq = priv->reg.beacon_lost_count;
+
 	return 0;
 }
 
@@ -2573,6 +2593,7 @@ static int ks_wlan_set_phy_type(struct net_device *dev,
 	}
 
 	priv->need_commit |= SME_MODE_SET;
+
 	return -EINPROGRESS;	/* Call commit handler */
 }
 
@@ -2589,6 +2610,7 @@ static int ks_wlan_get_phy_type(struct net_device *dev,
 		return -EPERM;
 	/* for SLEEP MODE */
 	*uwrq = priv->reg.phy_type;
+
 	return 0;
 }
 
@@ -2618,6 +2640,7 @@ static int ks_wlan_set_cts_mode(struct net_device *dev,
 	}
 
 	priv->need_commit |= SME_MODE_SET;
+
 	return -EINPROGRESS;	/* Call commit handler */
 }
 
@@ -2634,6 +2657,7 @@ static int ks_wlan_get_cts_mode(struct net_device *dev,
 		return -EPERM;
 	/* for SLEEP MODE */
 	*uwrq = priv->reg.cts_mode;
+
 	return 0;
 }
 
@@ -2716,6 +2740,7 @@ static int ks_wlan_get_phy_information_timer(struct net_device *dev,
 		return -EPERM;
 	/* for SLEEP MODE */
 	*uwrq = priv->reg.phy_info_timer;
+
 	return 0;
 }
 #endif
@@ -2814,6 +2839,7 @@ static int ks_wlan_get_wps_probe_req(struct net_device *dev,
 
 	if (priv->sleep_mode == SLP_SLEEP)
 		return -EPERM;
+
 	/* for SLEEP MODE */
 	return 0;
 }
@@ -2843,6 +2869,7 @@ static int ks_wlan_set_tx_gain(struct net_device *dev,
 		priv->gain.TxMode = 0;
 
 	hostif_sme_enqueue(priv, SME_SET_GAIN);
+
 	return 0;
 }
 
@@ -2860,6 +2887,7 @@ static int ks_wlan_get_tx_gain(struct net_device *dev,
 	/* for SLEEP MODE */
 	*uwrq = priv->gain.TxGain;
 	hostif_sme_enqueue(priv, SME_GET_GAIN);
+
 	return 0;
 }
 
@@ -2886,6 +2914,7 @@ static int ks_wlan_set_rx_gain(struct net_device *dev,
 		priv->gain.RxMode = 0;
 
 	hostif_sme_enqueue(priv, SME_SET_GAIN);
+
 	return 0;
 }
 
@@ -2903,6 +2932,7 @@ static int ks_wlan_get_rx_gain(struct net_device *dev,
 	/* for SLEEP MODE */
 	*uwrq = priv->gain.RxGain;
 	hostif_sme_enqueue(priv, SME_GET_GAIN);
+
 	return 0;
 }
 
@@ -2924,6 +2954,7 @@ static int ks_wlan_set_region(struct net_device *dev,
 		return -EINVAL;
 
 	hostif_sme_enqueue(priv, SME_SET_REGION);
+
 	return 0;
 }
 #endif
@@ -2938,6 +2969,7 @@ static int ks_wlan_get_eeprom_cksum(struct net_device *dev,
 	    (struct ks_wlan_private *)netdev_priv(dev);
 
 	*uwrq = priv->eeprom_checksum;
+
 	return 0;
 }
 
@@ -3069,6 +3101,7 @@ static int ks_wlan_hostt(struct net_device *dev, struct iw_request_info *info,
 				     SME_EVENT_BUFF_SIZE];
 		print_hif_event(dev, event);
 	}
+
 	return 0;
 }
 
@@ -3299,6 +3332,7 @@ int ks_wlan_set_mac_address(struct net_device *dev, void *addr)
 	priv->mac_address_valid = 0;
 	hostif_sme_enqueue(priv, SME_MACADDRESS_SET_REQUEST);
 	netdev_info(dev, "ks_wlan:  MAC ADDRESS = %pM\n", priv->eth_addr);
+
 	return 0;
 }
 
@@ -3337,12 +3371,9 @@ int ks_wlan_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
 	rc = hostif_data_request(priv, skb);
 	netif_trans_update(dev);
-
 	DPRINTK(4, "rc=%d\n", rc);
-	if (rc)
-		rc = 0;
 
-	return rc;
+	return 0;
 }
 
 void send_packet_complete(void *arg1, void *arg2)
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH 6/6] staging: ks7010: remove definition from declaration
  2017-03-14 10:20 [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
                   ` (4 preceding siblings ...)
  2017-03-14 10:20 ` [PATCH 5/6] staging: ks7010: clean up return statement code Tobin C. Harding
@ 2017-03-14 10:20 ` Tobin C. Harding
  2017-03-21  2:36 ` [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
  6 siblings, 0 replies; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-14 10:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: driverdev-devel, Wolfram Sang

Identifier does not need to be defined to 0 if it
is assigned to before being returned on all code paths.

Remove definition to 0 from declaration of return code identifier.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 drivers/staging/ks7010/ks7010_sdio.c | 2 +-
 drivers/staging/ks7010/ks_wlan_net.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 6d6b9d5..32197c0 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -341,7 +341,7 @@ int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p, unsigned long size,
 		  void (*complete_handler)(void *arg1, void *arg2),
 		  void *arg1, void *arg2)
 {
-	int result = 0;
+	int result;
 	struct hostif_hdr *hdr;
 
 	hdr = (struct hostif_hdr *)p;
diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index 47a618f..38a22ac 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -3291,7 +3291,7 @@ static const struct iw_handler_def ks_wlan_handler_def = {
 static int ks_wlan_netdev_ioctl(struct net_device *dev, struct ifreq *rq,
 				int cmd)
 {
-	int rc = 0;
+	int rc;
 	struct iwreq *wrq = (struct iwreq *)rq;
 
 	switch (cmd) {
@@ -3353,7 +3353,7 @@ static
 int ks_wlan_start_xmit(struct sk_buff *skb, struct net_device *dev)
 {
 	struct ks_wlan_private *priv = netdev_priv(dev);
-	int rc = 0;
+	int rc;
 
 	DPRINTK(3, "in_interrupt()=%ld\n", in_interrupt());
 
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc
  2017-03-14 10:20 ` [PATCH 2/6] staging: ks7010: replace identifier retval with rc Tobin C. Harding
@ 2017-03-16  2:40   ` Greg Kroah-Hartman
  2017-03-16  4:40     ` Tobin C. Harding
  2017-03-16 11:29     ` Dan Carpenter
  0 siblings, 2 replies; 13+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-16  2:40 UTC (permalink / raw)
  To: Tobin C. Harding; +Cc: driverdev-devel, Wolfram Sang

On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote:
> Code uses identifiers retval, ret, and rc all for function return
> values. It would be more readable if the whole driver used a single
> identifier for this task. Lets use 'rc' since it is the shortest.
> 
> Change retval -> rc

Ick, retval is much more readable, please use that.


> 
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 72 ++++++++++++++++++------------------
>  1 file changed, 36 insertions(+), 36 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index f3ae9db..3da34b1 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -89,7 +89,7 @@ static int ks7010_sdio_write(struct ks_wlan_private *priv, unsigned int address,
>  static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv)
>  {
>  	unsigned char rw_data;
> -	int retval;
> +	int rc;
>  
>  	DPRINTK(4, "\n");
>  
> @@ -98,9 +98,9 @@ static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv)
>  
>  	if (atomic_read(&priv->sleepstatus.status) == 0) {
>  		rw_data = GCR_B_DOZE;
> -		retval =
> +		rc =
>  		    ks7010_sdio_write(priv, GCR_B, &rw_data, sizeof(rw_data));

Also note that this could have been moved up to be on one line, so I'll
reject this patch anyway :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 3/6] staging: ks7010: replace identifier ret with rc
  2017-03-14 10:20 ` [PATCH 3/6] staging: ks7010: replace identifier ret " Tobin C. Harding
@ 2017-03-16  2:41   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 13+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-16  2:41 UTC (permalink / raw)
  To: Tobin C. Harding; +Cc: driverdev-devel, Wolfram Sang

On Tue, Mar 14, 2017 at 09:20:14PM +1100, Tobin C. Harding wrote:
> Code uses identifier names ret, and rc for function return
> values. It would be more readable if the whole driver used a single
> identifier for this task. Lets use 'rc' since it is the shortest.
> 
> Change ret -> rc

Again, retval is nicer.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc
  2017-03-16  2:40   ` Greg Kroah-Hartman
@ 2017-03-16  4:40     ` Tobin C. Harding
  2017-03-16 11:29     ` Dan Carpenter
  1 sibling, 0 replies; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-16  4:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: driverdev-devel, Wolfram Sang

On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote:
> > Code uses identifiers retval, ret, and rc all for function return
> > values. It would be more readable if the whole driver used a single
> > identifier for this task. Lets use 'rc' since it is the shortest.
> > 
> > Change retval -> rc
> 
> Ick, retval is much more readable, please use that.

retval it is.

> 
> 
> > 
> > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> > ---
> >  drivers/staging/ks7010/ks7010_sdio.c | 72 ++++++++++++++++++------------------
> >  1 file changed, 36 insertions(+), 36 deletions(-)
> > 
> > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> > index f3ae9db..3da34b1 100644
> > --- a/drivers/staging/ks7010/ks7010_sdio.c
> > +++ b/drivers/staging/ks7010/ks7010_sdio.c
> > @@ -89,7 +89,7 @@ static int ks7010_sdio_write(struct ks_wlan_private *priv, unsigned int address,
> >  static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv)
> >  {
> >  	unsigned char rw_data;
> > -	int retval;
> > +	int rc;
> >  
> >  	DPRINTK(4, "\n");
> >  
> > @@ -98,9 +98,9 @@ static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv)
> >  
> >  	if (atomic_read(&priv->sleepstatus.status) == 0) {
> >  		rw_data = GCR_B_DOZE;
> > -		retval =
> > +		rc =
> >  		    ks7010_sdio_write(priv, GCR_B, &rw_data, sizeof(rw_data));
> 
> Also note that this could have been moved up to be on one line, so I'll
> reject this patch anyway :)

Woops, I thought I learned that lesson this week already - when
splitting up a patch set don't leave things that scream out to be fixed in the diff.

thanks for you patience,
Tobin.

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc
  2017-03-16  2:40   ` Greg Kroah-Hartman
  2017-03-16  4:40     ` Tobin C. Harding
@ 2017-03-16 11:29     ` Dan Carpenter
  2017-03-16 12:36       ` Tobin C. Harding
  1 sibling, 1 reply; 13+ messages in thread
From: Dan Carpenter @ 2017-03-16 11:29 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Wolfram Sang, driverdev-devel

On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote:
> > Code uses identifiers retval, ret, and rc all for function return
> > values. It would be more readable if the whole driver used a single
> > identifier for this task. Lets use 'rc' since it is the shortest.
> > 
> > Change retval -> rc
> 
> Ick, retval is much more readable, please use that.
> 

Or "ret" is probably the most common.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc
  2017-03-16 11:29     ` Dan Carpenter
@ 2017-03-16 12:36       ` Tobin C. Harding
  0 siblings, 0 replies; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-16 12:36 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Greg Kroah-Hartman, driverdev-devel, Wolfram Sang

On Thu, Mar 16, 2017 at 02:29:04PM +0300, Dan Carpenter wrote:
> On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote:
> > On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote:
> > > Code uses identifiers retval, ret, and rc all for function return
> > > values. It would be more readable if the whole driver used a single
> > > identifier for this task. Lets use 'rc' since it is the shortest.
> > > 
> > > Change retval -> rc
> > 
> > Ick, retval is much more readable, please use that.
> > 
> 
> Or "ret" is probably the most common.

fight!

$ git grep -e 'int ret;' --or -e 'int ret =' | wc -l
36610

$ git grep -e 'int retval;' --or -e 'int retval =' | wc -l
2420

$ git grep -e 'int rc;' --or -e 'int rc =' | wc -l
8307

*ouch*! 'retval' is more readable, 'rc' is shorter but perfectly
descriptive and 'ret' is just plain common.


thanks,
Tobin.

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 0/6] staging: ks7010: clean up return statement code
  2017-03-14 10:20 [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
                   ` (5 preceding siblings ...)
  2017-03-14 10:20 ` [PATCH 6/6] staging: ks7010: remove definition from declaration Tobin C. Harding
@ 2017-03-21  2:36 ` Tobin C. Harding
  6 siblings, 0 replies; 13+ messages in thread
From: Tobin C. Harding @ 2017-03-21  2:36 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: driverdev-devel, Wolfram Sang

On Tue, Mar 14, 2017 at 09:20:11PM +1100, Tobin C. Harding wrote:
[snip]

Drop this series please. (patch 1 of set already merged).

thanks,
Tobin.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-03-21  2:36 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 10:20 [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding
2017-03-14 10:20 ` [PATCH 1/6] staging: ks7010: remove custom return values Tobin C. Harding
2017-03-14 10:20 ` [PATCH 2/6] staging: ks7010: replace identifier retval with rc Tobin C. Harding
2017-03-16  2:40   ` Greg Kroah-Hartman
2017-03-16  4:40     ` Tobin C. Harding
2017-03-16 11:29     ` Dan Carpenter
2017-03-16 12:36       ` Tobin C. Harding
2017-03-14 10:20 ` [PATCH 3/6] staging: ks7010: replace identifier ret " Tobin C. Harding
2017-03-16  2:41   ` Greg Kroah-Hartman
2017-03-14 10:20 ` [PATCH 4/6] staging: ks7010: make goto label naming uniform Tobin C. Harding
2017-03-14 10:20 ` [PATCH 5/6] staging: ks7010: clean up return statement code Tobin C. Harding
2017-03-14 10:20 ` [PATCH 6/6] staging: ks7010: remove definition from declaration Tobin C. Harding
2017-03-21  2:36 ` [PATCH 0/6] staging: ks7010: clean up return statement code Tobin C. Harding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.