All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] Kconfig: Don't use RSA_FREESCALE_EXP on IMX
@ 2017-03-16 21:17 George McCollister
  2017-03-17 14:08 ` Tom Rini
  2017-03-21 18:09 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: George McCollister @ 2017-03-16 21:17 UTC (permalink / raw)
  To: u-boot

The CAAM in IMX parts doesn't support public key hardware acceleration
(PKHA), so don't use RSA_FREESCALE_EXP. If you try to use it on IMX
(assuming you have the clocks enabled first) you will get back an
"Invalid KEY Command" error since PKHA isn't a valid key destination for
these parts.

Signed-off-by: George McCollister <george.mccollister@gmail.com>
---
 lib/rsa/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig
index 09ec358242..fde1ac108d 100644
--- a/lib/rsa/Kconfig
+++ b/lib/rsa/Kconfig
@@ -1,6 +1,6 @@
 config RSA
 	bool "Use RSA Library"
-	select RSA_FREESCALE_EXP if FSL_CAAM
+	select RSA_FREESCALE_EXP if FSL_CAAM && !ARCH_MX7 && !ARCH_MX6 && !ARCH_MX5
 	select RSA_SOFTWARE_EXP if !RSA_FREESCALE_EXP
 	help
 	  RSA support. This enables the RSA algorithm used for FIT image
@@ -29,7 +29,7 @@ config RSA_SOFTWARE_EXP
 
 config RSA_FREESCALE_EXP
 	bool "Enable RSA Modular Exponentiation with FSL crypto accelerator"
-	depends on DM && RSA && FSL_CAAM
+	depends on DM && RSA && FSL_CAAM && !ARCH_MX7 && !ARCH_MX6 && !ARCH_MX5
 	help
 	Enables driver for RSA modular exponentiation using Freescale cryptographic
 	accelerator - CAAM.
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] Kconfig: Don't use RSA_FREESCALE_EXP on IMX
  2017-03-16 21:17 [U-Boot] [PATCH] Kconfig: Don't use RSA_FREESCALE_EXP on IMX George McCollister
@ 2017-03-17 14:08 ` Tom Rini
  2017-03-21 18:09 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-03-17 14:08 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 16, 2017 at 04:17:06PM -0500, George McCollister wrote:

> The CAAM in IMX parts doesn't support public key hardware acceleration
> (PKHA), so don't use RSA_FREESCALE_EXP. If you try to use it on IMX
> (assuming you have the clocks enabled first) you will get back an
> "Invalid KEY Command" error since PKHA isn't a valid key destination for
> these parts.
> 
> Signed-off-by: George McCollister <george.mccollister@gmail.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170317/7ea797f3/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] Kconfig: Don't use RSA_FREESCALE_EXP on IMX
  2017-03-16 21:17 [U-Boot] [PATCH] Kconfig: Don't use RSA_FREESCALE_EXP on IMX George McCollister
  2017-03-17 14:08 ` Tom Rini
@ 2017-03-21 18:09 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-03-21 18:09 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 16, 2017 at 04:17:06PM -0500, George McCollister wrote:

> The CAAM in IMX parts doesn't support public key hardware acceleration
> (PKHA), so don't use RSA_FREESCALE_EXP. If you try to use it on IMX
> (assuming you have the clocks enabled first) you will get back an
> "Invalid KEY Command" error since PKHA isn't a valid key destination for
> these parts.
> 
> Signed-off-by: George McCollister <george.mccollister@gmail.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170321/c4c40737/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-21 18:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-16 21:17 [U-Boot] [PATCH] Kconfig: Don't use RSA_FREESCALE_EXP on IMX George McCollister
2017-03-17 14:08 ` Tom Rini
2017-03-21 18:09 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.