[Buildroot] [PATCH 1/2] acl: add host variant

[Buildroot] [PATCH 1/2] acl: add host variant

[Arnout Vandecappelle]

We need host-acl to fix issues with fakeroot.

Unfortunately, all the hacks have to be repeated again.

Cc: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Andreas Naumann <dev@andin.de>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/acl/acl.mk | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/package/acl/acl.mk b/package/acl/acl.mk
index cbe5e93961..b38cc4c0c3 100644
--- a/package/acl/acl.mk
+++ b/package/acl/acl.mk
@@ -37,4 +37,13 @@ endef
 
 ACL_POST_INSTALL_STAGING_HOOKS += ACL_FIX_LIBTOOL_LA_LIBDIR
 
+HOST_ACL_DEPENDENCIES = host-attr
+HOST_ACL_CONF_OPTS = --enable-gettext=no
+HOST_ACL_INSTALL_OPTS = \
+	prefix=$(HOST_DIR)/usr \
+	exec_prefix=$(HOST_DIR)/usr \
+	PKG_DEVLIB_DIR=$(HOST_DIR)/usr/lib \
+	install-dev install-lib
+
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.11.0

[Buildroot] [PATCH 2/2] fakeroot: depend on acl

[Arnout Vandecappelle]

Recent versions of fakeroot have grown support for acl. We don't really
need this since we don't use acls in Buildroot. However, it turns out
that "cp -a" does something funky with acls, with the result that
fakeroot without acl support looses the ownership and permissions on
the copied file. "cp -a" may be (is even likely to be) used in a
BR2_ROOTFS_POST_FAKEROOT_SCRIPT, so we need to support this.

Note that host-acl itself depends on host-attr, so this pulls in two
extra packages in each build. The impact on build time is about 10s.

Cc: Andreas Naumann <dev@andin.de>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/fakeroot/fakeroot.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/fakeroot/fakeroot.mk b/package/fakeroot/fakeroot.mk
index 168cd13a48..731b06a5f4 100644
--- a/package/fakeroot/fakeroot.mk
+++ b/package/fakeroot/fakeroot.mk
@@ -7,6 +7,8 @@
 FAKEROOT_VERSION = 1.20.2
 FAKEROOT_SOURCE = fakeroot_$(FAKEROOT_VERSION).orig.tar.bz2
 FAKEROOT_SITE = http://snapshot.debian.org/archive/debian/20141005T221953Z/pool/main/f/fakeroot
+
+HOST_FAKEROOT_DEPENDENCIES = host-acl
 # Force capabilities detection off
 # For now these are process capabilities (faked) rather than file
 # so they're of no real use
-- 
2.11.0

[Buildroot] [PATCH 1/2] acl: add host variant

[Andreas Naumann]

Hi Arnout,
thanks for the patch.

However, when I run it I get a
acl_get_fd.c:26:24: fatal error: attr/xattr.h: No such file or directory

I find this file in
output/host/usr/include/attr/xattr.h

but that's outside the sysroot, so probably not included, right?

When I install
apt-get install libattr1-dev
on the host it works.

But we shouldnt depend on that, should we?


regards, Andreas

Am 16.03.2017 um 23:38 schrieb Arnout Vandecappelle (Essensium/Mind):
> We need host-acl to fix issues with fakeroot.
>
> Unfortunately, all the hacks have to be repeated again.
>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> Cc: Andreas Naumann <dev@andin.de>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  package/acl/acl.mk | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/package/acl/acl.mk b/package/acl/acl.mk
> index cbe5e93961..b38cc4c0c3 100644
> --- a/package/acl/acl.mk
> +++ b/package/acl/acl.mk
> @@ -37,4 +37,13 @@ endef
>
>  ACL_POST_INSTALL_STAGING_HOOKS += ACL_FIX_LIBTOOL_LA_LIBDIR
>
> +HOST_ACL_DEPENDENCIES = host-attr
> +HOST_ACL_CONF_OPTS = --enable-gettext=no
> +HOST_ACL_INSTALL_OPTS = \
> +	prefix=$(HOST_DIR)/usr \
> +	exec_prefix=$(HOST_DIR)/usr \
> +	PKG_DEVLIB_DIR=$(HOST_DIR)/usr/lib \
> +	install-dev install-lib
> +
>  $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
>

[Buildroot] [PATCH 1/2] acl: add host variant

[Baruch Siach]

Hi Andreas,

On Fri, Mar 17, 2017 at 09:59:24AM +0100, Andreas Naumann wrote:
> However, when I run it I get a
> acl_get_fd.c:26:24: fatal error: attr/xattr.h: No such file or directory
> 
> I find this file in
> output/host/usr/include/attr/xattr.h
> 
> but that's outside the sysroot, so probably not included, right?

This is the host variant of acl, so don't expect it to be in the target 
sysroot.

> When I install
> apt-get install libattr1-dev
> on the host it works.
> 
> But we shouldnt depend on that, should we?

We should. Something went wrong with the host headers search path.

baurch

> Am 16.03.2017 um 23:38 schrieb Arnout Vandecappelle (Essensium/Mind):
> > We need host-acl to fix issues with fakeroot.
> > 
> > Unfortunately, all the hacks have to be repeated again.
> > 
> > Cc: Yegor Yefremov <yegorslists@googlemail.com>
> > Cc: Andreas Naumann <dev@andin.de>
> > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> > ---
> >  package/acl/acl.mk | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/package/acl/acl.mk b/package/acl/acl.mk
> > index cbe5e93961..b38cc4c0c3 100644
> > --- a/package/acl/acl.mk
> > +++ b/package/acl/acl.mk
> > @@ -37,4 +37,13 @@ endef
> > 
> >  ACL_POST_INSTALL_STAGING_HOOKS += ACL_FIX_LIBTOOL_LA_LIBDIR
> > 
> > +HOST_ACL_DEPENDENCIES = host-attr
> > +HOST_ACL_CONF_OPTS = --enable-gettext=no
> > +HOST_ACL_INSTALL_OPTS = \
> > +	prefix=$(HOST_DIR)/usr \
> > +	exec_prefix=$(HOST_DIR)/usr \
> > +	PKG_DEVLIB_DIR=$(HOST_DIR)/usr/lib \
> > +	install-dev install-lib
> > +
> >  $(eval $(autotools-package))
> > +$(eval $(host-autotools-package))

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 1/2] acl: add host variant

[Arnout Vandecappelle]

On 17-03-17 11:51, Baruch Siach wrote:
> Hi Andreas,
> 
> On Fri, Mar 17, 2017 at 09:59:24AM +0100, Andreas Naumann wrote:
>> However, when I run it I get a
>> acl_get_fd.c:26:24: fatal error: attr/xattr.h: No such file or directory
>>
>> I find this file in
>> output/host/usr/include/attr/xattr.h
>>
>> but that's outside the sysroot, so probably not included, right?
> This is the host variant of acl, so don't expect it to be in the target 
> sysroot.
> 
>> When I install
>> apt-get install libattr1-dev
>> on the host it works.

 I indeed had libattr1-dev installed while testing.


>> But we shouldnt depend on that, should we?
> We should. Something went wrong with the host headers search path.

 Yes, it seems the acl build system ignores CFLAGS. v2 follows.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF