From: Michal Hocko <mhocko@kernel.org> To: Joe Perches <joe@perches.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Date: Fri, 17 Mar 2017 08:39:44 +0100 [thread overview] Message-ID: <20170317073943.GA26298@dhcp22.suse.cz> (raw) In-Reply-To: <1489696343.13953.11.camel@perches.com> On Thu 16-03-17 13:32:23, Joe Perches wrote: > On Thu, 2017-03-16 at 11:56 +0100, Michal Hocko wrote: > > On Wed 15-03-17 18:43:13, Joe Perches wrote: > > > Function calls with large argument counts cause x86-64 register > > > spilling. Reducing the number of arguments in a multi-line printk > > > by converting to multiple printks which saves some object code size. > > > > > > $ size mm/page_alloc.o* (defconfig) > > > text data bss dec hex filename > > > 35914 1699 628 38241 9561 mm/page_alloc.o.new > > > 36018 1699 628 38345 95c9 mm/page_alloc.o.old > > > > > > Miscellanea: > > > > > > o Remove line leading spaces from the formerly multi-line printks > > > commit a25700a53f71 ("mm: show bounce pages in oom killer output") > > > back in 2007 started the leading space when a single long line > > > was split into multiple lines but the leading space was likely > > > mistakenly kept and subsequent commits followed suit. > > > o Align arguments in a few more printks > > > > This is really hard to review. Could you just drop all the whitespace > > changes please? > > It's a single, simple change. no it adds a lot of whitespace noise to an actual change. It takes to check every single line to see whether some typo or unintended change has been made. > It's IMO trivial to review. it's not IMNSHO. -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Joe Perches <joe@perches.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Date: Fri, 17 Mar 2017 08:39:44 +0100 [thread overview] Message-ID: <20170317073943.GA26298@dhcp22.suse.cz> (raw) In-Reply-To: <1489696343.13953.11.camel@perches.com> On Thu 16-03-17 13:32:23, Joe Perches wrote: > On Thu, 2017-03-16 at 11:56 +0100, Michal Hocko wrote: > > On Wed 15-03-17 18:43:13, Joe Perches wrote: > > > Function calls with large argument counts cause x86-64 register > > > spilling. Reducing the number of arguments in a multi-line printk > > > by converting to multiple printks which saves some object code size. > > > > > > $ size mm/page_alloc.o* (defconfig) > > > text data bss dec hex filename > > > 35914 1699 628 38241 9561 mm/page_alloc.o.new > > > 36018 1699 628 38345 95c9 mm/page_alloc.o.old > > > > > > Miscellanea: > > > > > > o Remove line leading spaces from the formerly multi-line printks > > > commit a25700a53f71 ("mm: show bounce pages in oom killer output") > > > back in 2007 started the leading space when a single long line > > > was split into multiple lines but the leading space was likely > > > mistakenly kept and subsequent commits followed suit. > > > o Align arguments in a few more printks > > > > This is really hard to review. Could you just drop all the whitespace > > changes please? > > It's a single, simple change. no it adds a lot of whitespace noise to an actual change. It takes to check every single line to see whether some typo or unintended change has been made. > It's IMO trivial to review. it's not IMNSHO. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-17 7:39 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-16 1:43 [PATCH 0/3] mm: page_alloc: Object code reductions and logging fix Joe Perches 2017-03-16 1:43 ` Joe Perches 2017-03-16 1:43 ` [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Joe Perches 2017-03-16 1:43 ` Joe Perches 2017-03-16 10:56 ` Michal Hocko 2017-03-16 10:56 ` Michal Hocko 2017-03-16 20:32 ` Joe Perches 2017-03-16 20:32 ` Joe Perches 2017-03-17 7:39 ` Michal Hocko [this message] 2017-03-17 7:39 ` Michal Hocko 2017-03-16 11:30 ` Sergey Senozhatsky 2017-03-16 11:30 ` Sergey Senozhatsky 2017-03-16 18:37 ` Joe Perches 2017-03-16 18:37 ` Joe Perches 2017-03-16 22:53 ` Andrew Morton 2017-03-16 22:53 ` Andrew Morton 2017-03-17 1:56 ` Sergey Senozhatsky 2017-03-17 1:56 ` Sergey Senozhatsky 2017-03-18 19:31 ` Joe Perches 2017-03-18 19:31 ` Joe Perches 2017-03-20 13:00 ` Petr Mladek 2017-03-20 13:00 ` Petr Mladek 2017-03-16 1:43 ` [PATCH 2/3] mm: page_alloc: Fix misordered logging output, reduce code size Joe Perches 2017-03-16 1:43 ` Joe Perches 2017-03-16 10:57 ` Michal Hocko 2017-03-16 10:57 ` Michal Hocko 2017-03-16 1:43 ` [PATCH 3/3] mm: page_alloc: Break up a long single-line printk Joe Perches 2017-03-16 1:43 ` Joe Perches 2017-03-16 10:58 ` Michal Hocko 2017-03-16 10:58 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170317073943.GA26298@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=joe@perches.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.