All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anna Schumaker <Anna.Schumaker@Netapp.com>
To: fstests@vger.kernel.org
Cc: Anna.Schumaker@Netapp.com, linux-nfs@vger.kernel.org, hch@infradead.org
Subject: [PATCH v5 5/5] generic/420: Add a copy test for invalid input
Date: Fri, 17 Mar 2017 15:52:33 -0400	[thread overview]
Message-ID: <20170317195233.4042-6-Anna.Schumaker@Netapp.com> (raw)
In-Reply-To: <20170317195233.4042-1-Anna.Schumaker@Netapp.com>

This test passes invalid argumnt combinations to the copy_file_range()
system call to test that input is verified before attempting to copy.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
 tests/generic/420     | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/420.out | 12 ++++++++
 tests/generic/group   |  1 +
 3 files changed, 89 insertions(+)
 create mode 100644 tests/generic/420
 create mode 100644 tests/generic/420.out

diff --git a/tests/generic/420 b/tests/generic/420
new file mode 100644
index 00000000..703b4c13
--- /dev/null
+++ b/tests/generic/420
@@ -0,0 +1,76 @@
+#!/bin/bash
+# FS QA Test No. 420
+#
+# Tests vfs_copy_file_range() error checking
+#-----------------------------------------------------------------------
+# Copyright (c) 2016 Netapp, Inc. All rights reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1    # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -rf $tmp.*
+}
+
+# get standard environment
+. common/rc
+. common/filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+_require_xfs_io_command "copy_range"
+_require_test
+
+testdir=$TEST_DIR/test-$seq
+rm -rf $testdir
+mkdir $testdir
+rm -f $seqres.full
+
+echo "Create the original files"
+$XFS_IO_PROG -f -c 'pwrite -S 0x61 0 1000' $testdir/file >> $seqres.full 2>&1
+mknod $testdir/dev1 c 1 3
+mkfifo $testdir/fifo
+
+echo "Try to copy when source pos > source size"
+$XFS_IO_PROG -f -c "copy_range -s 1000 -l 100 $testdir/file" "$testdir/copy" 2>&1
+
+echo "Try to copy to a read-only file"
+$XFS_IO_PROG -r -f -c "copy_range -s 0 -l 100 $testdir/file" "$testdir/copy" 2>&1
+
+echo "Try to copy to an append-only file"
+$XFS_IO_PROG -a -f -c "copy_range -s 0 -l 100 $testdir/file" "$testdir/copy" 2>&1
+
+echo "Try to copy to a device"
+$XFS_IO_PROG -a -f -c "copy_range -s 0 -l 100 $testdir/file" "$testdir/dev1" 2>&1
+
+echo "Try to copy to a fifo"
+$XFS_IO_PROG -a -f -c "copy_range -s 0 -l 100 $testdir/file" "$testdir/fifo" 2>&1
+
+#success, all done
+status=0
+exit
diff --git a/tests/generic/420.out b/tests/generic/420.out
new file mode 100644
index 00000000..b1da880a
--- /dev/null
+++ b/tests/generic/420.out
@@ -0,0 +1,12 @@
+QA output created by 420
+Create the original files
+Try to copy when source pos > source size
+copy_range: Invalid argument
+Try to copy to a read-only file
+copy_range: Bad file descriptor
+Try to copy to an append-only file
+copy_range: Bad file descriptor
+Try to copy to a device
+copy_range: Invalid argument
+Try to copy to a fifo
+copy_range: Invalid argument
diff --git a/tests/generic/group b/tests/generic/group
index 6a2d3ee8..69ab8f03 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -422,3 +422,4 @@
 417 auto quick copy
 418 auto quick copy
 419 auto quick copy
+420 auto quick copy
-- 
2.12.0


WARNING: multiple messages have this Message-ID (diff)
From: Anna Schumaker <Anna.Schumaker@Netapp.com>
To: <fstests@vger.kernel.org>
Cc: <Anna.Schumaker@Netapp.com>, <linux-nfs@vger.kernel.org>,
	<hch@infradead.org>
Subject: [PATCH v5 5/5] generic/420: Add a copy test for invalid input
Date: Fri, 17 Mar 2017 15:52:33 -0400	[thread overview]
Message-ID: <20170317195233.4042-6-Anna.Schumaker@Netapp.com> (raw)
In-Reply-To: <20170317195233.4042-1-Anna.Schumaker@Netapp.com>

This test passes invalid argumnt combinations to the copy_file_range()
system call to test that input is verified before attempting to copy.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
 tests/generic/420     | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/420.out | 12 ++++++++
 tests/generic/group   |  1 +
 3 files changed, 89 insertions(+)
 create mode 100644 tests/generic/420
 create mode 100644 tests/generic/420.out

diff --git a/tests/generic/420 b/tests/generic/420
new file mode 100644
index 00000000..703b4c13
--- /dev/null
+++ b/tests/generic/420
@@ -0,0 +1,76 @@
+#!/bin/bash
+# FS QA Test No. 420
+#
+# Tests vfs_copy_file_range() error checking
+#-----------------------------------------------------------------------
+# Copyright (c) 2016 Netapp, Inc. All rights reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1    # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -rf $tmp.*
+}
+
+# get standard environment
+. common/rc
+. common/filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+_require_xfs_io_command "copy_range"
+_require_test
+
+testdir=$TEST_DIR/test-$seq
+rm -rf $testdir
+mkdir $testdir
+rm -f $seqres.full
+
+echo "Create the original files"
+$XFS_IO_PROG -f -c 'pwrite -S 0x61 0 1000' $testdir/file >> $seqres.full 2>&1
+mknod $testdir/dev1 c 1 3
+mkfifo $testdir/fifo
+
+echo "Try to copy when source pos > source size"
+$XFS_IO_PROG -f -c "copy_range -s 1000 -l 100 $testdir/file" "$testdir/copy" 2>&1
+
+echo "Try to copy to a read-only file"
+$XFS_IO_PROG -r -f -c "copy_range -s 0 -l 100 $testdir/file" "$testdir/copy" 2>&1
+
+echo "Try to copy to an append-only file"
+$XFS_IO_PROG -a -f -c "copy_range -s 0 -l 100 $testdir/file" "$testdir/copy" 2>&1
+
+echo "Try to copy to a device"
+$XFS_IO_PROG -a -f -c "copy_range -s 0 -l 100 $testdir/file" "$testdir/dev1" 2>&1
+
+echo "Try to copy to a fifo"
+$XFS_IO_PROG -a -f -c "copy_range -s 0 -l 100 $testdir/file" "$testdir/fifo" 2>&1
+
+#success, all done
+status=0
+exit
diff --git a/tests/generic/420.out b/tests/generic/420.out
new file mode 100644
index 00000000..b1da880a
--- /dev/null
+++ b/tests/generic/420.out
@@ -0,0 +1,12 @@
+QA output created by 420
+Create the original files
+Try to copy when source pos > source size
+copy_range: Invalid argument
+Try to copy to a read-only file
+copy_range: Bad file descriptor
+Try to copy to an append-only file
+copy_range: Bad file descriptor
+Try to copy to a device
+copy_range: Invalid argument
+Try to copy to a fifo
+copy_range: Invalid argument
diff --git a/tests/generic/group b/tests/generic/group
index 6a2d3ee8..69ab8f03 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -422,3 +422,4 @@
 417 auto quick copy
 418 auto quick copy
 419 auto quick copy
+420 auto quick copy
-- 
2.12.0


  parent reply	other threads:[~2017-03-17 20:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 19:52 [PATCH v5 0/5] Add copy_file_range() tests Anna Schumaker
2017-03-17 19:52 ` Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 1/5] generic/416: Add copy to new file test Anna Schumaker
2017-03-17 19:52   ` Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 2/5] generic/417: Add small copies " Anna Schumaker
2017-03-17 19:52   ` Anna Schumaker
2017-03-22 16:45   ` Boaz Harrosh
2017-03-22 16:45     ` Boaz Harrosh
2017-03-17 19:52 ` [PATCH v5 3/5] generic/418: Add copy test that overwrites data Anna Schumaker
2017-03-17 19:52   ` Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 4/5] generic/419: Add a copy test for overwriting small amounts of data Anna Schumaker
2017-03-17 19:52   ` Anna Schumaker
2017-03-17 19:52 ` Anna Schumaker [this message]
2017-03-17 19:52   ` [PATCH v5 5/5] generic/420: Add a copy test for invalid input Anna Schumaker
2017-03-17 22:02 ` [PATCH v5 0/5] Add copy_file_range() tests Darrick J. Wong
2017-03-20  5:24   ` Eryu Guan
2017-05-02 22:16     ` Darrick J. Wong
2017-05-03 12:56       ` Olga Kornievskaia
2017-05-03 15:48         ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170317195233.4042-6-Anna.Schumaker@Netapp.com \
    --to=anna.schumaker@netapp.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.