All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, davem@davemloft.net,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Vlad Yasevich <vyasevich@gmail.com>,
	ja@ssi.bg
Subject: Re: [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport
Date: Sat, 18 Mar 2017 15:07:08 -0400	[thread overview]
Message-ID: <20170318190708.GB14004@neilslaptop.think-freely.org> (raw)
In-Reply-To: <b4390881b14adce583817529e5d58599acb5a8ee.1489836443.git.lucien.xin@gmail.com>

On Sat, Mar 18, 2017 at 07:27:23PM +0800, Xin Long wrote:
> As tp->dst_pending_confirm's value can only be set 0 or 1, this
> patch is to change to define it as a bit instead of __u32.
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
>  include/net/sctp/structs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 07a0b12..4f64519 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -753,6 +753,8 @@ struct sctp_transport {
>  		/* Is the Path MTU update pending on this tranport */
>  		pmtu_pending:1,
>  
> +		dst_pending_confirm:1,	/* need to confirm neighbour */
> +
>  		/* Has this transport moved the ctsn since we last sacked */
>  		sack_generation:1;
>  	u32 dst_cookie;
> @@ -806,8 +808,6 @@ struct sctp_transport {
>  
>  	__u32 burst_limited;	/* Holds old cwnd when max.burst is applied */
>  
> -	__u32 dst_pending_confirm;	/* need to confirm neighbour */
> -
>  	/* Destination */
>  	struct dst_entry *dst;
>  	/* Source address. */
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>

WARNING: multiple messages have this Message-ID (diff)
From: Neil Horman <nhorman@tuxdriver.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, davem@davemloft.net,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Vlad Yasevich <vyasevich@gmail.com>,
	ja@ssi.bg
Subject: Re: [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport
Date: Sat, 18 Mar 2017 19:07:08 +0000	[thread overview]
Message-ID: <20170318190708.GB14004@neilslaptop.think-freely.org> (raw)
In-Reply-To: <b4390881b14adce583817529e5d58599acb5a8ee.1489836443.git.lucien.xin@gmail.com>

On Sat, Mar 18, 2017 at 07:27:23PM +0800, Xin Long wrote:
> As tp->dst_pending_confirm's value can only be set 0 or 1, this
> patch is to change to define it as a bit instead of __u32.
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
>  include/net/sctp/structs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 07a0b12..4f64519 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -753,6 +753,8 @@ struct sctp_transport {
>  		/* Is the Path MTU update pending on this tranport */
>  		pmtu_pending:1,
>  
> +		dst_pending_confirm:1,	/* need to confirm neighbour */
> +
>  		/* Has this transport moved the ctsn since we last sacked */
>  		sack_generation:1;
>  	u32 dst_cookie;
> @@ -806,8 +808,6 @@ struct sctp_transport {
>  
>  	__u32 burst_limited;	/* Holds old cwnd when max.burst is applied */
>  
> -	__u32 dst_pending_confirm;	/* need to confirm neighbour */
> -
>  	/* Destination */
>  	struct dst_entry *dst;
>  	/* Source address. */
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>


  reply	other threads:[~2017-03-18 19:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-18 11:27 [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport Xin Long
2017-03-18 11:27 ` Xin Long
2017-03-18 19:07 ` Neil Horman [this message]
2017-03-18 19:07   ` Neil Horman
2017-03-22  1:32 ` David Miller
2017-03-22  1:32   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170318190708.GB14004@neilslaptop.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=ja@ssi.bg \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.