All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: matthew.gerlach@linux.intel.com
Cc: atull@kernel.org, moritz.fischer@ettus.com,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	mark.rutland@arm.com
Subject: Re: [PATCH v5 4/4] fpga pr ip: Platform driver for Altera Partial Reconfiguration IP.
Date: Sat, 18 Mar 2017 19:27:50 +0100	[thread overview]
Message-ID: <20170318192750.716e9b28@crub> (raw)
In-Reply-To: <1489174827-6033-5-git-send-email-matthew.gerlach@linux.intel.com>

Hi Matthew,

On Fri, 10 Mar 2017 11:40:27 -0800
matthew.gerlach@linux.intel.com matthew.gerlach@linux.intel.com wrote:

...
>+#include "altera-pr-ip-core.h"

Shouldn't we put this header to include/linux? Compiling the
out-of-tree modules using alt_pr_register/alt_pr_unregister
will not work if this header is in drivers/fpga.

...
>+
>+module_platform_driver(alt_pr_platform_driver);

Please add MODULE_LICENSE("GPL v2") here. Otherwise, when built as
a module it cannot be loaded because the alt_pr register/unregister
functions are exported as GPL only. Also please add module author
and description.

Thanks,

Anatolij

  parent reply	other threads:[~2017-03-18 18:53 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 19:40 [PATCH v5 0/4] Altera Partial Reconfiguration IP matthew.gerlach
2017-03-10 19:40 ` matthew.gerlach-VuQAYsv1563Yd54FQh9/CA
2017-03-10 19:40 ` [PATCH v5 1/4] fpga: add config complete timeout matthew.gerlach
2017-03-10 19:40   ` matthew.gerlach-VuQAYsv1563Yd54FQh9/CA
2017-03-13 20:46   ` Moritz Fischer
2017-03-13 20:46     ` Moritz Fischer
2017-03-10 19:40 ` [PATCH v5 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP matthew.gerlach
2017-03-10 19:40   ` matthew.gerlach-VuQAYsv1563Yd54FQh9/CA
2017-03-13 20:49   ` Moritz Fischer
2017-03-13 20:49     ` Moritz Fischer
2017-03-18 18:53   ` Anatolij Gustschin
2017-03-20 23:49     ` matthew.gerlach
2017-03-20 23:49       ` matthew.gerlach-VuQAYsv1563Yd54FQh9/CA
2017-03-21 21:04   ` Anatolij Gustschin
2017-03-21 21:04     ` Anatolij Gustschin
2017-03-22 16:08     ` matthew.gerlach
2017-03-22 16:08       ` matthew.gerlach-VuQAYsv1563Yd54FQh9/CA
2017-03-22 16:39       ` Anatolij Gustschin
2017-03-10 19:40 ` [PATCH v5 3/4] fpga dt: bindings " matthew.gerlach
2017-03-10 19:40   ` matthew.gerlach-VuQAYsv1563Yd54FQh9/CA
2017-03-13 20:47   ` Moritz Fischer
2017-03-13 20:47     ` Moritz Fischer
2017-03-10 19:40 ` [PATCH v5 4/4] fpga pr ip: Platform driver " matthew.gerlach
2017-03-10 19:40   ` matthew.gerlach-VuQAYsv1563Yd54FQh9/CA
2017-03-13 20:48   ` Moritz Fischer
2017-03-18 18:27   ` Anatolij Gustschin [this message]
2017-03-20 23:42     ` matthew.gerlach
2017-03-13 20:46 ` [PATCH v5 0/4] " Moritz Fischer
2017-03-13 20:46   ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170318192750.716e9b28@crub \
    --to=agust@denx.de \
    --cc=atull@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthew.gerlach@linux.intel.com \
    --cc=moritz.fischer@ettus.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.