From: kbuild test robot <lkp@intel.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: kbuild-all@01.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Israel Rukshin <israelr@mellanox.com>,
Max Gurtovoy <maxg@mellanox.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 3/3] Ensure that scsi_target_unblock() examines all devices
Date: Sun, 19 Mar 2017 04:22:53 +0800 [thread overview]
Message-ID: <201703190427.YhKUDRL7%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170316205650.3322-4-bart.vanassche@sandisk.com>
[-- Attachment #1: Type: text/plain, Size: 3262 bytes --]
Hi Bart,
[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.11-rc2 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Bart-Van-Assche/Unblock-SCSI-devices-even-if-the-LLD-is-being-unloaded/20170318-214016
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
drivers/scsi/scsi.c:669: warning: No description found for parameter 'sdev'
drivers/scsi/scsi.c:679: warning: No description found for parameter 'sdev'
>> drivers/scsi/scsi_lib.c:3087: warning: No description found for parameter 'dev'
>> drivers/scsi/scsi_lib.c:3087: warning: No description found for parameter 'data'
drivers/scsi/constants.c:1: warning: no structured comments found
vim +/dev +3087 drivers/scsi/scsi_lib.c
5d9fb5cc1 Mike Christie 2012-05-17 3071 scsi_internal_device_unblock(sdev, *(enum scsi_device_state *)data);
^1da177e4 Linus Torvalds 2005-04-16 3072 }
^1da177e4 Linus Torvalds 2005-04-16 3073
ae188a841 Bart Van Assche 2017-03-16 3074 /**
ae188a841 Bart Van Assche 2017-03-16 3075 * target_unblock() - unblock all devices associated with a SCSI target
ae188a841 Bart Van Assche 2017-03-16 3076 *
ae188a841 Bart Van Assche 2017-03-16 3077 * Notes:
ae188a841 Bart Van Assche 2017-03-16 3078 * - Do not use scsi_device_get() nor any of the macros that use this
ae188a841 Bart Van Assche 2017-03-16 3079 * function from inside scsi_target_block() because otherwise this function
ae188a841 Bart Van Assche 2017-03-16 3080 * won't have any effect when called while the SCSI LLD is being unloaded.
ae188a841 Bart Van Assche 2017-03-16 3081 * - Do not hold the host lock around the device_unblock() calls because at
ae188a841 Bart Van Assche 2017-03-16 3082 * least for blk-sq the block layer queue lock is the outer lock and the
ae188a841 Bart Van Assche 2017-03-16 3083 * SCSI host lock is the inner lock.
ae188a841 Bart Van Assche 2017-03-16 3084 */
^1da177e4 Linus Torvalds 2005-04-16 3085 static int
^1da177e4 Linus Torvalds 2005-04-16 3086 target_unblock(struct device *dev, void *data)
^1da177e4 Linus Torvalds 2005-04-16 @3087 {
^1da177e4 Linus Torvalds 2005-04-16 3088 if (scsi_is_target_device(dev))
ae188a841 Bart Van Assche 2017-03-16 3089 starget_for_all_devices(to_scsi_target(dev), data,
^1da177e4 Linus Torvalds 2005-04-16 3090 device_unblock);
^1da177e4 Linus Torvalds 2005-04-16 3091 return 0;
^1da177e4 Linus Torvalds 2005-04-16 3092 }
^1da177e4 Linus Torvalds 2005-04-16 3093
ae188a841 Bart Van Assche 2017-03-16 3094 /**
ae188a841 Bart Van Assche 2017-03-16 3095 * scsi_target_unblock() - unblock all devices associated with a SCSI target
:::::: The code at line 3087 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6576 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Israel Rukshin <israelr@mellanox.com>,
Max Gurtovoy <maxg@mellanox.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 3/3] Ensure that scsi_target_unblock() examines all devices
Date: Sun, 19 Mar 2017 04:22:53 +0800 [thread overview]
Message-ID: <201703190427.YhKUDRL7%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170316205650.3322-4-bart.vanassche@sandisk.com>
[-- Attachment #1: Type: text/plain, Size: 3262 bytes --]
Hi Bart,
[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.11-rc2 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Bart-Van-Assche/Unblock-SCSI-devices-even-if-the-LLD-is-being-unloaded/20170318-214016
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
drivers/scsi/scsi.c:669: warning: No description found for parameter 'sdev'
drivers/scsi/scsi.c:679: warning: No description found for parameter 'sdev'
>> drivers/scsi/scsi_lib.c:3087: warning: No description found for parameter 'dev'
>> drivers/scsi/scsi_lib.c:3087: warning: No description found for parameter 'data'
drivers/scsi/constants.c:1: warning: no structured comments found
vim +/dev +3087 drivers/scsi/scsi_lib.c
5d9fb5cc1 Mike Christie 2012-05-17 3071 scsi_internal_device_unblock(sdev, *(enum scsi_device_state *)data);
^1da177e4 Linus Torvalds 2005-04-16 3072 }
^1da177e4 Linus Torvalds 2005-04-16 3073
ae188a841 Bart Van Assche 2017-03-16 3074 /**
ae188a841 Bart Van Assche 2017-03-16 3075 * target_unblock() - unblock all devices associated with a SCSI target
ae188a841 Bart Van Assche 2017-03-16 3076 *
ae188a841 Bart Van Assche 2017-03-16 3077 * Notes:
ae188a841 Bart Van Assche 2017-03-16 3078 * - Do not use scsi_device_get() nor any of the macros that use this
ae188a841 Bart Van Assche 2017-03-16 3079 * function from inside scsi_target_block() because otherwise this function
ae188a841 Bart Van Assche 2017-03-16 3080 * won't have any effect when called while the SCSI LLD is being unloaded.
ae188a841 Bart Van Assche 2017-03-16 3081 * - Do not hold the host lock around the device_unblock() calls because at
ae188a841 Bart Van Assche 2017-03-16 3082 * least for blk-sq the block layer queue lock is the outer lock and the
ae188a841 Bart Van Assche 2017-03-16 3083 * SCSI host lock is the inner lock.
ae188a841 Bart Van Assche 2017-03-16 3084 */
^1da177e4 Linus Torvalds 2005-04-16 3085 static int
^1da177e4 Linus Torvalds 2005-04-16 3086 target_unblock(struct device *dev, void *data)
^1da177e4 Linus Torvalds 2005-04-16 @3087 {
^1da177e4 Linus Torvalds 2005-04-16 3088 if (scsi_is_target_device(dev))
ae188a841 Bart Van Assche 2017-03-16 3089 starget_for_all_devices(to_scsi_target(dev), data,
^1da177e4 Linus Torvalds 2005-04-16 3090 device_unblock);
^1da177e4 Linus Torvalds 2005-04-16 3091 return 0;
^1da177e4 Linus Torvalds 2005-04-16 3092 }
^1da177e4 Linus Torvalds 2005-04-16 3093
ae188a841 Bart Van Assche 2017-03-16 3094 /**
ae188a841 Bart Van Assche 2017-03-16 3095 * scsi_target_unblock() - unblock all devices associated with a SCSI target
:::::: The code at line 3087 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6576 bytes --]
next prev parent reply other threads:[~2017-03-18 20:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 20:56 [PATCH 0/3] Unblock SCSI devices even if the LLD is being unloaded Bart Van Assche
2017-03-16 20:56 ` [PATCH 1/3] __scsi_iterate_devices(): Make the get and put functions arguments Bart Van Assche
2017-03-16 20:56 ` Bart Van Assche
2017-03-16 20:56 ` [PATCH 2/3] Introduce starget_for_all_devices() and shost_for_all_devices() Bart Van Assche
2017-03-16 20:56 ` Bart Van Assche
2017-03-18 17:14 ` kbuild test robot
2017-03-18 17:14 ` kbuild test robot
2017-03-16 20:56 ` [PATCH 3/3] Ensure that scsi_target_unblock() examines all devices Bart Van Assche
2017-03-16 20:56 ` Bart Van Assche
2017-03-18 20:22 ` kbuild test robot [this message]
2017-03-18 20:22 ` kbuild test robot
2017-03-16 22:53 ` [PATCH 0/3] Unblock SCSI devices even if the LLD is being unloaded James Bottomley
2017-03-16 23:19 ` Bart Van Assche
2017-03-17 12:54 ` James Bottomley
2017-03-17 16:40 ` Bart Van Assche
2017-03-18 12:44 ` James Bottomley
2017-03-18 20:49 ` Bart Van Assche
2017-04-10 17:46 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201703190427.YhKUDRL7%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=israelr@mellanox.com \
--cc=kbuild-all@01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=maxg@mellanox.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.