sparse-llvm the LLVM IR for select instruction fails due to different types

sparse-llvm the LLVM IR for select instruction fails due to different types

[Dibyendu Majumdar]

Hi,

LLVM complains when the operands of a select are not the same type. I
think it is okay to cast one of the operands to the type of the other
- on the basis that subsequent operations will cast things anyway.

Regards
Dibyendu

Re: sparse-llvm the LLVM IR for select instruction fails due to different types

[Luc Van Oostenryck]

On Tue, Mar 14, 2017 at 04:07:40PM +0000, Dibyendu Majumdar wrote:
> Hi,
> 
> LLVM complains when the operands of a select are not the same type. I
> think it is okay to cast one of the operands to the type of the other
> - on the basis that subsequent operations will cast things anyway.

Submit a test case, please.

-- Luc 

Re: sparse-llvm the LLVM IR for select instruction fails due to different types

[Dibyendu Majumdar]

On 19 March 2017 at 00:21, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> On Tue, Mar 14, 2017 at 04:07:40PM +0000, Dibyendu Majumdar wrote:
>> LLVM complains when the operands of a select are not the same type. I
>> think it is okay to cast one of the operands to the type of the other
>> - on the basis that subsequent operations will cast things anyway.
>
> Submit a test case, please.
>

typedef union GCObject GCObject;
typedef union {
 GCObject *gc;
 void *p;
 int b;
} Value;
typedef struct lua_TValue {
 Value value;
 int tt;
} TValue;
typedef struct CClosure {
 GCObject *next;
 TValue upvalue[1];
} CClosure;
typedef struct LClosure {
 GCObject *next;
 GCObject *gclist;
} LClosure;
typedef union Closure {
 CClosure c;
 LClosure l;
} Closure;
static TValue luaO_nilobject_;
TValue *select(Closure *closure, int op)
{
 return op == 1 ? &closure->c.upvalue[0] : (TValue *) &luaO_nilobject_;
}

Re: sparse-llvm the LLVM IR for select instruction fails due to different types

[Luc Van Oostenryck]

On Sun, Mar 19, 2017 at 01:04:30PM +0000, Dibyendu Majumdar wrote:
> On 19 March 2017 at 00:21, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
> > On Tue, Mar 14, 2017 at 04:07:40PM +0000, Dibyendu Majumdar wrote:
> >> LLVM complains when the operands of a select are not the same type. I
> >> think it is okay to cast one of the operands to the type of the other
> >> - on the basis that subsequent operations will cast things anyway.
> >
> > Submit a test case, please.
> >

I was thinking to something for the test suite. 
Anyway, this is fixed in the llvm-fixes-v3 serie I submitted yesterday.

-- Luc