* [PATCH] drm/i915/guc: Correct the request_in tracepoint position
@ 2017-03-20 13:25 Tvrtko Ursulin
2017-03-20 13:37 ` Chris Wilson
2017-03-20 13:42 ` ✓ Fi.CI.BAT: success for " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2017-03-20 13:25 UTC (permalink / raw)
To: Intel-gfx; +Cc: intel-gfx, Daniel Vetter
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
It has to be called after the global seqno has been assigned.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: 31de73501ac9 ("drm/i915/scheduler: emulate a scheduler for guc")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Michał Winiarski <michal.winiarski@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
---
drivers/gpu/drm/i915/i915_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index 4514168c55f3..67fa6fdfad77 100644
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -597,8 +597,8 @@ static bool i915_guc_dequeue(struct intel_engine_cs *engine)
RB_CLEAR_NODE(&rq->priotree.node);
rq->priotree.priority = INT_MAX;
- trace_i915_gem_request_in(rq, port - engine->execlist_port);
i915_guc_submit(rq);
+ trace_i915_gem_request_in(rq, port - engine->execlist_port);
last = rq;
submit = true;
}
--
2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/guc: Correct the request_in tracepoint position
2017-03-20 13:25 [PATCH] drm/i915/guc: Correct the request_in tracepoint position Tvrtko Ursulin
@ 2017-03-20 13:37 ` Chris Wilson
2017-03-20 13:41 ` Tvrtko Ursulin
2017-03-20 13:42 ` ✓ Fi.CI.BAT: success for " Patchwork
1 sibling, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2017-03-20 13:37 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: Intel-gfx, Daniel Vetter
On Mon, Mar 20, 2017 at 01:25:56PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It has to be called after the global seqno has been assigned.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Fixes: 31de73501ac9 ("drm/i915/scheduler: emulate a scheduler for guc")
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
So be it. Your script is ready for the same request to be submitted
multiple times with different global_seqno?
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/guc: Correct the request_in tracepoint position
2017-03-20 13:37 ` Chris Wilson
@ 2017-03-20 13:41 ` Tvrtko Ursulin
2017-03-20 13:48 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Tvrtko Ursulin @ 2017-03-20 13:41 UTC (permalink / raw)
To: Chris Wilson, Tvrtko Ursulin, Intel-gfx, Tvrtko Ursulin,
Joonas Lahtinen, Michał Winiarski, Daniel Vetter,
Jani Nikula
On 20/03/2017 13:37, Chris Wilson wrote:
> On Mon, Mar 20, 2017 at 01:25:56PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> It has to be called after the global seqno has been assigned.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Fixes: 31de73501ac9 ("drm/i915/scheduler: emulate a scheduler for guc")
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>
> So be it. Your script is ready for the same request to be submitted
Why so be it? It matches the one in execlists and is logical.
> multiple times with different global_seqno?
Nope, but it survived the zero global seqno unexpectedly well! :)
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks!
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/guc: Correct the request_in tracepoint position
2017-03-20 13:41 ` Tvrtko Ursulin
@ 2017-03-20 13:48 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2017-03-20 13:48 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: Intel-gfx, Daniel Vetter
On Mon, Mar 20, 2017 at 01:41:28PM +0000, Tvrtko Ursulin wrote:
>
> On 20/03/2017 13:37, Chris Wilson wrote:
> >On Mon, Mar 20, 2017 at 01:25:56PM +0000, Tvrtko Ursulin wrote:
> >>From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>
> >>It has to be called after the global seqno has been assigned.
> >>
> >>Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>Fixes: 31de73501ac9 ("drm/i915/scheduler: emulate a scheduler for guc")
> >>Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >
> >So be it. Your script is ready for the same request to be submitted
>
> Why so be it? It matches the one in execlists and is logical.
Just the staircasing, that's all.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/guc: Correct the request_in tracepoint position
2017-03-20 13:25 [PATCH] drm/i915/guc: Correct the request_in tracepoint position Tvrtko Ursulin
2017-03-20 13:37 ` Chris Wilson
@ 2017-03-20 13:42 ` Patchwork
2017-03-21 8:25 ` Tvrtko Ursulin
1 sibling, 1 reply; 6+ messages in thread
From: Patchwork @ 2017-03-20 13:42 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Correct the request_in tracepoint position
URL : https://patchwork.freedesktop.org/series/21538/
State : success
== Summary ==
Series 21538v1 drm/i915/guc: Correct the request_in tracepoint position
https://patchwork.freedesktop.org/api/1.0/series/21538/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-bxt-t5700) fdo#100125
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 460s
fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 574s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 532s
fi-bxt-t5700 total:278 pass:257 dwarn:1 dfail:0 fail:0 skip:20 time: 559s
fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 498s
fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 495s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 433s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 437s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 438s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 515s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 494s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 482s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 477s
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 595s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 484s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 515s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 552s
fi-snb-2600 total:278 pass:248 dwarn:0 dfail:0 fail:1 skip:29 time: 425s
3f1ca80b4b2cd698202fc8121029bdc094bf7d7f drm-tip: 2017y-03m-20d-10h-48m-39s UTC integration manifest
b69cfd8 drm/i915/guc: Correct the request_in tracepoint position
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4228/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: ✓ Fi.CI.BAT: success for drm/i915/guc: Correct the request_in tracepoint position
2017-03-20 13:42 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-03-21 8:25 ` Tvrtko Ursulin
0 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2017-03-21 8:25 UTC (permalink / raw)
To: intel-gfx, Tvrtko Ursulin
On 20/03/2017 13:42, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/guc: Correct the request_in tracepoint position
> URL : https://patchwork.freedesktop.org/series/21538/
> State : success
>
> == Summary ==
>
> Series 21538v1 drm/i915/guc: Correct the request_in tracepoint position
> https://patchwork.freedesktop.org/api/1.0/series/21538/revisions/1/mbox/
>
> Test gem_exec_suspend:
> Subgroup basic-s4-devices:
> pass -> DMESG-WARN (fi-bxt-t5700) fdo#100125
>
> fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
>
> fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 460s
> fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 574s
> fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 532s
> fi-bxt-t5700 total:278 pass:257 dwarn:1 dfail:0 fail:0 skip:20 time: 559s
> fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 498s
> fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 495s
> fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 433s
> fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 437s
> fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 438s
> fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 515s
> fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 494s
> fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 482s
> fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 477s
> fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 595s
> fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 484s
> fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 515s
> fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 552s
> fi-snb-2600 total:278 pass:248 dwarn:0 dfail:0 fail:1 skip:29 time: 425s
>
> 3f1ca80b4b2cd698202fc8121029bdc094bf7d7f drm-tip: 2017y-03m-20d-10h-48m-39s UTC integration manifest
> b69cfd8 drm/i915/guc: Correct the request_in tracepoint position
Pushed, thanks for the review!
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-21 8:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-20 13:25 [PATCH] drm/i915/guc: Correct the request_in tracepoint position Tvrtko Ursulin
2017-03-20 13:37 ` Chris Wilson
2017-03-20 13:41 ` Tvrtko Ursulin
2017-03-20 13:48 ` Chris Wilson
2017-03-20 13:42 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-21 8:25 ` Tvrtko Ursulin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.