From: Alex Thorlton <alex.thorlton@hpe.com> To: Aaron Lu <aaron.lu@intel.com> Cc: Alex Thorlton <alex.thorlton@hpe.com>, <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>, Dave Hansen <dave.hansen@intel.com>, Tim Chen <tim.c.chen@intel.com>, Andrew Morton <akpm@linux-foundation.org>, Ying Huang <ying.huang@intel.com> Subject: Re: [PATCH v2 0/5] mm: support parallel free of memory Date: Mon, 20 Mar 2017 14:15:36 -0500 [thread overview] Message-ID: <20170320191536.GG196487@stormcage.americas.sgi.com> (raw) In-Reply-To: <20170317022158.GB18964@aaronlu.sh.intel.com> On Fri, Mar 17, 2017 at 10:21:58AM +0800, Aaron Lu wrote: > On Thu, Mar 16, 2017 at 02:38:44PM -0500, Alex Thorlton wrote: > > On Wed, Mar 15, 2017 at 04:59:59PM +0800, Aaron Lu wrote: > > > v2 changes: Nothing major, only minor ones. > > > - rebased on top of v4.11-rc2-mmotm-2017-03-14-15-41; > > > - use list_add_tail instead of list_add to add worker to tlb's worker > > > list so that when doing flush, the first queued worker gets flushed > > > first(based on the comsumption that the first queued worker has a > > > better chance of finishing its job than those later queued workers); > > > - use bool instead of int for variable free_batch_page in function > > > tlb_flush_mmu_free_batches; > > > - style change according to ./scripts/checkpatch; > > > - reword some of the changelogs to make it more readable. > > > > > > v1 is here: > > > https://lkml.org/lkml/2017/2/24/245 > > > > I tested v1 on a Haswell system with 64 sockets/1024 cores/2048 threads > > and 8TB of RAM, with a 1TB malloc. The average free() time for a 1TB > > malloc on a vanilla kernel was 41.69s, the patched kernel averaged > > 21.56s for the same test. > > Thanks a lot for the test result. > > > > > I am testing v2 now and will report back with results in the next day or > > so. > > Testing plain v2 shouldn't bring any surprise/difference You're right! Not much difference here. v2 averaged a 23.17s free time for a 1T allocation. > better set the > following param before the test(I'm planning to make them default in the > next version): > # echo 64 > /sys/devices/virtual/workqueue/batch_free_wq/max_active > # echo 1030 > /sys/kernel/debug/parallel_free/max_gather_batch_count 10 test runs with these params set averaged 22.22s to free 1T. So, we're still seeing a nearly 50% decrease in free time vs. the unpatched kernel. - Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Thorlton <alex.thorlton@hpe.com> To: Aaron Lu <aaron.lu@intel.com> Cc: Alex Thorlton <alex.thorlton@hpe.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>, Tim Chen <tim.c.chen@intel.com>, Andrew Morton <akpm@linux-foundation.org>, Ying Huang <ying.huang@intel.com> Subject: Re: [PATCH v2 0/5] mm: support parallel free of memory Date: Mon, 20 Mar 2017 14:15:36 -0500 [thread overview] Message-ID: <20170320191536.GG196487@stormcage.americas.sgi.com> (raw) In-Reply-To: <20170317022158.GB18964@aaronlu.sh.intel.com> On Fri, Mar 17, 2017 at 10:21:58AM +0800, Aaron Lu wrote: > On Thu, Mar 16, 2017 at 02:38:44PM -0500, Alex Thorlton wrote: > > On Wed, Mar 15, 2017 at 04:59:59PM +0800, Aaron Lu wrote: > > > v2 changes: Nothing major, only minor ones. > > > - rebased on top of v4.11-rc2-mmotm-2017-03-14-15-41; > > > - use list_add_tail instead of list_add to add worker to tlb's worker > > > list so that when doing flush, the first queued worker gets flushed > > > first(based on the comsumption that the first queued worker has a > > > better chance of finishing its job than those later queued workers); > > > - use bool instead of int for variable free_batch_page in function > > > tlb_flush_mmu_free_batches; > > > - style change according to ./scripts/checkpatch; > > > - reword some of the changelogs to make it more readable. > > > > > > v1 is here: > > > https://lkml.org/lkml/2017/2/24/245 > > > > I tested v1 on a Haswell system with 64 sockets/1024 cores/2048 threads > > and 8TB of RAM, with a 1TB malloc. The average free() time for a 1TB > > malloc on a vanilla kernel was 41.69s, the patched kernel averaged > > 21.56s for the same test. > > Thanks a lot for the test result. > > > > > I am testing v2 now and will report back with results in the next day or > > so. > > Testing plain v2 shouldn't bring any surprise/difference You're right! Not much difference here. v2 averaged a 23.17s free time for a 1T allocation. > better set the > following param before the test(I'm planning to make them default in the > next version): > # echo 64 > /sys/devices/virtual/workqueue/batch_free_wq/max_active > # echo 1030 > /sys/kernel/debug/parallel_free/max_gather_batch_count 10 test runs with these params set averaged 22.22s to free 1T. So, we're still seeing a nearly 50% decrease in free time vs. the unpatched kernel. - Alex -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-20 19:15 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-15 8:59 [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu 2017-03-15 8:59 ` Aaron Lu 2017-03-15 9:00 ` [PATCH v2 1/5] mm: add tlb_flush_mmu_free_batches Aaron Lu 2017-03-15 9:00 ` Aaron Lu 2017-03-15 9:00 ` [PATCH v2 2/5] mm: parallel free pages Aaron Lu 2017-03-15 9:00 ` Aaron Lu 2017-03-15 9:42 ` Hillf Danton 2017-03-15 9:42 ` Hillf Danton 2017-03-15 11:54 ` Aaron Lu 2017-03-15 11:54 ` Aaron Lu 2017-03-15 9:00 ` [PATCH v2 3/5] mm: use a dedicated workqueue for the free workers Aaron Lu 2017-03-15 9:00 ` Aaron Lu 2017-03-22 6:33 ` Minchan Kim 2017-03-22 6:33 ` Minchan Kim 2017-03-22 8:41 ` Aaron Lu 2017-03-22 8:41 ` Aaron Lu 2017-03-22 8:55 ` Minchan Kim 2017-03-22 8:55 ` Minchan Kim 2017-03-22 13:43 ` Aaron Lu 2017-03-22 13:43 ` Aaron Lu 2017-03-23 5:53 ` Minchan Kim 2017-03-23 5:53 ` Minchan Kim 2017-03-23 15:38 ` Dave Hansen 2017-03-23 15:38 ` Dave Hansen 2017-03-24 12:37 ` Aaron Lu 2017-03-24 12:37 ` Aaron Lu 2017-03-15 9:00 ` [PATCH v2 4/5] mm: add force_free_pages in zap_pte_range Aaron Lu 2017-03-15 9:00 ` Aaron Lu 2017-03-15 9:00 ` [PATCH v2 5/5] mm: add debugfs interface for parallel free tuning Aaron Lu 2017-03-15 9:00 ` Aaron Lu 2017-03-15 14:18 ` [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko 2017-03-15 14:18 ` Michal Hocko 2017-03-15 15:44 ` Aaron Lu 2017-03-15 15:44 ` Aaron Lu 2017-03-15 16:28 ` Michal Hocko 2017-03-15 16:28 ` Michal Hocko 2017-03-15 21:38 ` Tim Chen 2017-03-15 21:38 ` Tim Chen 2017-03-16 9:07 ` Michal Hocko 2017-03-16 9:07 ` Michal Hocko 2017-03-16 18:36 ` Tim Chen 2017-03-16 18:36 ` Tim Chen 2017-03-17 7:47 ` Michal Hocko 2017-03-17 7:47 ` Michal Hocko 2017-03-17 8:07 ` Minchan Kim 2017-03-17 8:07 ` Minchan Kim 2017-03-17 12:33 ` Aaron Lu 2017-03-17 12:33 ` Aaron Lu 2017-03-17 12:59 ` Michal Hocko 2017-03-17 12:59 ` Michal Hocko 2017-03-17 13:16 ` Peter Zijlstra 2017-03-17 13:16 ` Peter Zijlstra 2017-03-17 12:53 ` Peter Zijlstra 2017-03-17 12:53 ` Peter Zijlstra 2017-03-17 13:05 ` Michal Hocko 2017-03-17 13:05 ` Michal Hocko 2017-03-21 14:54 ` Dave Hansen 2017-03-21 14:54 ` Dave Hansen 2017-03-22 8:02 ` Aaron Lu 2017-03-22 8:02 ` Aaron Lu 2017-03-24 7:04 ` Aaron Lu 2017-03-24 7:04 ` Aaron Lu 2017-03-21 15:18 ` Tim Chen 2017-03-21 15:18 ` Tim Chen 2017-03-16 6:54 ` Aaron Lu 2017-03-16 6:54 ` Aaron Lu 2017-03-16 7:34 ` Aaron Lu 2017-03-16 7:34 ` Aaron Lu 2017-03-16 13:51 ` Aaron Lu 2017-03-16 13:51 ` Aaron Lu 2017-03-16 14:14 ` Aaron Lu 2017-03-16 14:14 ` Aaron Lu 2017-03-15 14:56 ` Vlastimil Babka 2017-03-15 14:56 ` Vlastimil Babka 2017-03-15 15:50 ` Aaron Lu 2017-03-15 15:50 ` Aaron Lu 2017-03-17 3:10 ` Aaron Lu 2017-03-17 3:10 ` Aaron Lu 2017-03-16 19:38 ` Alex Thorlton 2017-03-16 19:38 ` Alex Thorlton 2017-03-17 2:21 ` Aaron Lu 2017-03-17 2:21 ` Aaron Lu 2017-03-20 19:15 ` Alex Thorlton [this message] 2017-03-20 19:15 ` Alex Thorlton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170320191536.GG196487@stormcage.americas.sgi.com \ --to=alex.thorlton@hpe.com \ --cc=aaron.lu@intel.com \ --cc=akpm@linux-foundation.org \ --cc=dave.hansen@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=tim.c.chen@intel.com \ --cc=ying.huang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.