All of lore.kernel.org
 help / color / mirror / Atom feed
From: Piotr Sroka <piotrs@cadence.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Piotr <piotrs@cadence.com>
Subject: RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration
Date: Tue, 21 Mar 2017 07:19:17 +0000	[thread overview]
Message-ID: <201703210719.v2L7JHLV032698@lvloginb.cadence.com> (raw)
In-Reply-To: <CAK7LNAR_i0Q0jymENMSxu-hn4S3KQ3kEwbPmju1H5K2pmMranw@mail.gmail.com>

Hi Masahiro,

> Hi Piotr,
> 
> 2017-03-20 17:47 GMT+09:00 Piotr Sroka <piotrs@cadence.com>:
> >
> >>
> >> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> >> >         struct sdhci_cdns_priv *priv;
> >> >         struct clk *clk;
> >> >         int ret;
> >> > +       struct device *dev = &pdev->dev;
> >> >
> >> >         clk = devm_clk_get(&pdev->dev, NULL);
> >>
> >>
> >> If you add "dev", please use it for devm_clk_get, too.
> >>
> > I did on the first patch version but Ulf pointed that this is unrelated change and should be removed.
> > Therefore I remove it.
> 
> Ah, OK.
> 
> Could you consider to send a separate patch for this?
> 
Ok. If v5 is needed I will add additional patch making this modification. If not I will prepare a spearate patch.


Best Regards
Piotr Sroka

  reply	other threads:[~2017-03-21  8:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 12:38 [v3 1/3] mmc: sdhci-cadence: Fix writing PHY delay Piotr Sroka
2017-03-17 12:38 ` Piotr Sroka
2017-03-17 12:40 ` [v3 2/3] Documentation: bindings: add description of PHY delays for sdhci-cadence Piotr Sroka
2017-03-17 12:40   ` Piotr Sroka
2017-03-17 17:29   ` Masahiro Yamada
2017-03-17 17:29     ` Masahiro Yamada
2017-03-20  8:49     ` Piotr Sroka
2017-03-17 12:41 ` [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration Piotr Sroka
2017-03-17 12:41   ` Piotr Sroka
2017-03-17 17:23   ` Masahiro Yamada
2017-03-20  8:47     ` Piotr Sroka
2017-03-21  1:50       ` Masahiro Yamada
2017-03-21  7:19         ` Piotr Sroka [this message]
2017-03-17 17:34   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201703210719.v2L7JHLV032698@lvloginb.cadence.com \
    --to=piotrs@cadence.com \
    --cc=adrian.hunter@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.