* [PATCH rdma-next 1/2] IB/rxe: Avoid accessing timers for non RC QPs
@ 2017-03-19 9:20 Leon Romanovsky
[not found] ` <20170319092057.9103-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2017-03-19 9:20 UTC (permalink / raw)
To: Doug Ledford; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Parav Pandit
From: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
This patch avoids RNR NAK timer and retransmit timer initialization and
cleanup for non RC QPs (such as UD QP, GSI QP).
Reviewed-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/infiniband/sw/rxe/rxe_qp.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
index f98a19e61a3d..3ad9b48212de 100644
--- a/drivers/infiniband/sw/rxe/rxe_qp.c
+++ b/drivers/infiniband/sw/rxe/rxe_qp.c
@@ -273,10 +273,11 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp,
rxe_init_task(rxe, &qp->comp.task, qp,
rxe_completer, "comp");
- setup_timer(&qp->rnr_nak_timer, rnr_nak_timer, (unsigned long)qp);
- setup_timer(&qp->retrans_timer, retransmit_timer, (unsigned long)qp);
qp->qp_timeout_jiffies = 0; /* Can't be set for UD/UC in modify_qp */
-
+ if (init->qp_type == IB_QPT_RC) {
+ setup_timer(&qp->rnr_nak_timer, rnr_nak_timer, (unsigned long)qp);
+ setup_timer(&qp->retrans_timer, retransmit_timer, (unsigned long)qp);
+ }
return 0;
}
@@ -804,8 +805,10 @@ void rxe_qp_destroy(struct rxe_qp *qp)
qp->qp_timeout_jiffies = 0;
rxe_cleanup_task(&qp->resp.task);
- del_timer_sync(&qp->retrans_timer);
- del_timer_sync(&qp->rnr_nak_timer);
+ if (qp_type(qp) == IB_QPT_RC) {
+ del_timer_sync(&qp->retrans_timer);
+ del_timer_sync(&qp->rnr_nak_timer);
+ }
rxe_cleanup_task(&qp->req.task);
rxe_cleanup_task(&qp->comp.task);
--
2.12.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH rdma-next 2/2] IB/rxe: Do not export module's private function
[not found] ` <20170319092057.9103-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2017-03-19 9:20 ` Leon Romanovsky
[not found] ` <20170319092057.9103-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-21 8:31 ` [PATCH rdma-next 1/2] IB/rxe: Avoid accessing timers for non RC QPs Yuval Shaia
2017-04-24 16:05 ` Doug Ledford
2 siblings, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2017-03-19 9:20 UTC (permalink / raw)
To: Doug Ledford; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Parav Pandit
From: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Function rxe_rcv is used internally in RXE and don't need to be
exported. This patch removes such export declaration.
Signed-off-by: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/infiniband/sw/rxe/rxe_recv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c
index 50886031096f..9775d8274b64 100644
--- a/drivers/infiniband/sw/rxe/rxe_recv.c
+++ b/drivers/infiniband/sw/rxe/rxe_recv.c
@@ -417,4 +417,3 @@ int rxe_rcv(struct sk_buff *skb)
kfree_skb(skb);
return 0;
}
-EXPORT_SYMBOL(rxe_rcv);
--
2.12.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-next 1/2] IB/rxe: Avoid accessing timers for non RC QPs
[not found] ` <20170319092057.9103-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-19 9:20 ` [PATCH rdma-next 2/2] IB/rxe: Do not export module's private function Leon Romanovsky
@ 2017-03-21 8:31 ` Yuval Shaia
2017-04-24 16:05 ` Doug Ledford
2 siblings, 0 replies; 6+ messages in thread
From: Yuval Shaia @ 2017-03-21 8:31 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Parav Pandit
On Sun, Mar 19, 2017 at 11:20:56AM +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> This patch avoids RNR NAK timer and retransmit timer initialization and
> cleanup for non RC QPs (such as UD QP, GSI QP).
>
> Reviewed-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> drivers/infiniband/sw/rxe/rxe_qp.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
> index f98a19e61a3d..3ad9b48212de 100644
> --- a/drivers/infiniband/sw/rxe/rxe_qp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_qp.c
> @@ -273,10 +273,11 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp,
> rxe_init_task(rxe, &qp->comp.task, qp,
> rxe_completer, "comp");
>
> - setup_timer(&qp->rnr_nak_timer, rnr_nak_timer, (unsigned long)qp);
> - setup_timer(&qp->retrans_timer, retransmit_timer, (unsigned long)qp);
> qp->qp_timeout_jiffies = 0; /* Can't be set for UD/UC in modify_qp */
> -
> + if (init->qp_type == IB_QPT_RC) {
> + setup_timer(&qp->rnr_nak_timer, rnr_nak_timer, (unsigned long)qp);
> + setup_timer(&qp->retrans_timer, retransmit_timer, (unsigned long)qp);
> + }
> return 0;
> }
>
> @@ -804,8 +805,10 @@ void rxe_qp_destroy(struct rxe_qp *qp)
> qp->qp_timeout_jiffies = 0;
> rxe_cleanup_task(&qp->resp.task);
>
> - del_timer_sync(&qp->retrans_timer);
> - del_timer_sync(&qp->rnr_nak_timer);
> + if (qp_type(qp) == IB_QPT_RC) {
> + del_timer_sync(&qp->retrans_timer);
> + del_timer_sync(&qp->rnr_nak_timer);
> + }
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> rxe_cleanup_task(&qp->req.task);
> rxe_cleanup_task(&qp->comp.task);
> --
> 2.12.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-next 2/2] IB/rxe: Do not export module's private function
[not found] ` <20170319092057.9103-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2017-03-21 8:33 ` Yuval Shaia
2017-04-24 16:05 ` Doug Ledford
1 sibling, 0 replies; 6+ messages in thread
From: Yuval Shaia @ 2017-03-21 8:33 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Parav Pandit
On Sun, Mar 19, 2017 at 11:20:57AM +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> Function rxe_rcv is used internally in RXE and don't need to be
> exported. This patch removes such export declaration.
>
> Signed-off-by: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> drivers/infiniband/sw/rxe/rxe_recv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c
> index 50886031096f..9775d8274b64 100644
> --- a/drivers/infiniband/sw/rxe/rxe_recv.c
> +++ b/drivers/infiniband/sw/rxe/rxe_recv.c
> @@ -417,4 +417,3 @@ int rxe_rcv(struct sk_buff *skb)
> kfree_skb(skb);
> return 0;
> }
> -EXPORT_SYMBOL(rxe_rcv);
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> --
> 2.12.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-next 1/2] IB/rxe: Avoid accessing timers for non RC QPs
[not found] ` <20170319092057.9103-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-19 9:20 ` [PATCH rdma-next 2/2] IB/rxe: Do not export module's private function Leon Romanovsky
2017-03-21 8:31 ` [PATCH rdma-next 1/2] IB/rxe: Avoid accessing timers for non RC QPs Yuval Shaia
@ 2017-04-24 16:05 ` Doug Ledford
2 siblings, 0 replies; 6+ messages in thread
From: Doug Ledford @ 2017-04-24 16:05 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Parav Pandit
On Sun, 2017-03-19 at 11:20 +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> This patch avoids RNR NAK timer and retransmit timer initialization
> and
> cleanup for non RC QPs (such as UD QP, GSI QP).
>
> Reviewed-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-next 2/2] IB/rxe: Do not export module's private function
[not found] ` <20170319092057.9103-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-21 8:33 ` Yuval Shaia
@ 2017-04-24 16:05 ` Doug Ledford
1 sibling, 0 replies; 6+ messages in thread
From: Doug Ledford @ 2017-04-24 16:05 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Parav Pandit
On Sun, 2017-03-19 at 11:20 +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> Function rxe_rcv is used internally in RXE and don't need to be
> exported. This patch removes such export declaration.
>
> Signed-off-by: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-24 16:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-19 9:20 [PATCH rdma-next 1/2] IB/rxe: Avoid accessing timers for non RC QPs Leon Romanovsky
[not found] ` <20170319092057.9103-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-19 9:20 ` [PATCH rdma-next 2/2] IB/rxe: Do not export module's private function Leon Romanovsky
[not found] ` <20170319092057.9103-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-21 8:33 ` Yuval Shaia
2017-04-24 16:05 ` Doug Ledford
2017-03-21 8:31 ` [PATCH rdma-next 1/2] IB/rxe: Avoid accessing timers for non RC QPs Yuval Shaia
2017-04-24 16:05 ` Doug Ledford
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.