[PATCH] staging: vt6656: rf.c: resolve all checkpatch issues.

[PATCH] staging: vt6656: rf.c: resolve all checkpatch issues.

[Matthew Giassa]

These patches address a few outstanding checkpatch warnings/errors in
rf.c, mainly due to space/indentation (style) issues.

---
 drivers/staging/vt6656/rf.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)
---

[PATCH 1/2] staging: vt6656: rf.c: alignment should match open parentheses

[Matthew Giassa]

Resolving 5 instances of checkpatch error/warning statements generated
due to:
ERROR: code indent should use tabs where possible
CHECK: Alignment should match open parenthesis

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/vt6656/rf.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c8..0e3a62a 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -876,7 +876,7 @@ void vnt_rf_table_download(struct vnt_private *priv)
 	memcpy(array, addr1, length1);
 
 	vnt_control_out(priv, MESSAGE_TYPE_WRITE, 0,
-		        MESSAGE_REQUEST_RF_INIT, length1, array);
+			MESSAGE_REQUEST_RF_INIT, length1, array);
 
 	/* Channel Table 0 */
 	value = 0;
@@ -889,7 +889,7 @@ void vnt_rf_table_download(struct vnt_private *priv)
 		memcpy(array, addr2, length);
 
 		vnt_control_out(priv, MESSAGE_TYPE_WRITE,
-			        value, MESSAGE_REQUEST_RF_CH0, length, array);
+				value, MESSAGE_REQUEST_RF_CH0, length, array);
 
 		length2 -= length;
 		value += length;
@@ -907,7 +907,7 @@ void vnt_rf_table_download(struct vnt_private *priv)
 		memcpy(array, addr3, length);
 
 		vnt_control_out(priv, MESSAGE_TYPE_WRITE,
-			        value, MESSAGE_REQUEST_RF_CH1, length, array);
+				value, MESSAGE_REQUEST_RF_CH1, length, array);
 
 		length3 -= length;
 		value += length;
@@ -924,7 +924,7 @@ void vnt_rf_table_download(struct vnt_private *priv)
 
 		/* Init Table 2 */
 		vnt_control_out(priv, MESSAGE_TYPE_WRITE,
-			        0, MESSAGE_REQUEST_RF_INIT2, length1, array);
+				0, MESSAGE_REQUEST_RF_INIT2, length1, array);
 
 		/* Channel Table 0 */
 		value = 0;
@@ -937,7 +937,8 @@ void vnt_rf_table_download(struct vnt_private *priv)
 			memcpy(array, addr2, length);
 
 			vnt_control_out(priv, MESSAGE_TYPE_WRITE,
-				        value, MESSAGE_REQUEST_RF_CH2, length, array);
+					value, MESSAGE_REQUEST_RF_CH2, length,
+					array);
 
 			length2 -= length;
 			value += length;
-- 
2.7.4

[PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

[Matthew Giassa]

Resolving 2 checkpatch warnings generated due to:
CHECK: spaces preferred around that '-'

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/vt6656/rf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 0e3a62a..fe09627 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data)
 	reg_data[3] = (u8)(data >> 24);
 
 	vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF,
-				0, 0, ARRAY_SIZE(reg_data), reg_data);
+			0, 0, ARRAY_SIZE(reg_data), reg_data);
 
 	return true;
 }
@@ -643,9 +643,9 @@ int vnt_rf_setpower(struct vnt_private *priv, u32 rate, u32 channel)
 	case RATE_48M:
 	case RATE_54M:
 		if (channel > CB_MAX_CHANNEL_24G)
-			power = priv->ofdm_a_pwr_tbl[channel-15];
+			power = priv->ofdm_a_pwr_tbl[channel - 15];
 		else
-			power = priv->ofdm_pwr_tbl[channel-1];
+			power = priv->ofdm_pwr_tbl[channel - 1];
 		break;
 	}
 
-- 
2.7.4

Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

[Dan Carpenter]

On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
> Resolving 2 checkpatch warnings generated due to:
> CHECK: spaces preferred around that '-'
> 
> Signed-off-by: Matthew Giassa <matthew@giassa.net>
> ---
>  drivers/staging/vt6656/rf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> index 0e3a62a..fe09627 100644
> --- a/drivers/staging/vt6656/rf.c
> +++ b/drivers/staging/vt6656/rf.c
> @@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data)
>  	reg_data[3] = (u8)(data >> 24);
>  
>  	vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF,
> -				0, 0, ARRAY_SIZE(reg_data), reg_data);
> +			0, 0, ARRAY_SIZE(reg_data), reg_data);

This isn't described in the changelog.

regards,
dan carpenter

Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

[Matthew Giassa]

* Dan Carpenter <dan.carpenter@oracle.com> [2017-03-21 15:55:52 +0300]:

>On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
>> Resolving 2 checkpatch warnings generated due to:
>> CHECK: spaces preferred around that '-'
>>
>> Signed-off-by: Matthew Giassa <matthew@giassa.net>
>> ---
>>  drivers/staging/vt6656/rf.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
>> index 0e3a62a..fe09627 100644
>> --- a/drivers/staging/vt6656/rf.c
>> +++ b/drivers/staging/vt6656/rf.c
>> @@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data)
>>  	reg_data[3] = (u8)(data >> 24);
>>
>>  	vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF,
>> -				0, 0, ARRAY_SIZE(reg_data), reg_data);
>> +			0, 0, ARRAY_SIZE(reg_data), reg_data);
>
>This isn't described in the changelog.
>
>regards,
>dan carpenter
>

Would it be preferable if the changelog was more verbose? The
literal text from the checkpatch.pl warning itself is indeed in the
changelog:

>On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
>> Resolving 2 checkpatch warnings generated due to:
>> CHECK: spaces preferred around that '-'

Cheers.