* [Qemu-devel] [PATCH v2 0/2] some remaining vmgenid tweaks for 2.9
@ 2017-03-20 17:05 Laszlo Ersek
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types Laszlo Ersek
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device Laszlo Ersek
0 siblings, 2 replies; 7+ messages in thread
From: Laszlo Ersek @ 2017-03-20 17:05 UTC (permalink / raw)
To: qemu devel list
Cc: Michael S. Tsirkin, Ben Warren, Igor Mammedov, Paolo Bonzini
V2 changes are documented per patch.
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Ben Warren <ben@skyportsystems.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Laszlo Ersek (2):
hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types
hw/acpi/vmgenid: prevent more than one vmgenid device
include/hw/acpi/vmgenid.h | 2 ++
include/hw/compat.h | 4 ++++
hw/acpi/vmgenid.c | 22 ++++++++++++++++++++++
3 files changed, 28 insertions(+)
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH v2 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types
2017-03-20 17:05 [Qemu-devel] [PATCH v2 0/2] some remaining vmgenid tweaks for 2.9 Laszlo Ersek
@ 2017-03-20 17:05 ` Laszlo Ersek
2017-03-21 12:13 ` Igor Mammedov
2017-03-22 0:53 ` Ben Warren
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device Laszlo Ersek
1 sibling, 2 replies; 7+ messages in thread
From: Laszlo Ersek @ 2017-03-20 17:05 UTC (permalink / raw)
To: qemu devel list
Cc: Michael S. Tsirkin, Ben Warren, Igor Mammedov, Paolo Bonzini
The WRITE_POINTER linker/loader command that underlies VMGENID depends on
commit baf2d5bfbac0 ("fw-cfg: support writeable blobs", 2017-01-12), which
in turn depends on fw_cfg DMA.
DMA for fw_cfg is enabled in 2.5+ machine types only (see commit
e6915b5f3a87, "fw_cfg: unbreak migration compatibility for 2.4 and earlier
machines", 2016-02-18).
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Ben Warren <ben@skyportsystems.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Notes:
v2:
- disable/enable vmgenid exactly in parallel with DMA support for fw_cfg
[Michael, Paolo]
include/hw/acpi/vmgenid.h | 1 +
include/hw/compat.h | 4 ++++
hw/acpi/vmgenid.c | 14 ++++++++++++++
3 files changed, 19 insertions(+)
diff --git a/include/hw/acpi/vmgenid.h b/include/hw/acpi/vmgenid.h
index db7fa0e63303..8578476baebe 100644
--- a/include/hw/acpi/vmgenid.h
+++ b/include/hw/acpi/vmgenid.h
@@ -21,6 +21,7 @@ typedef struct VmGenIdState {
DeviceClass parent_obj;
QemuUUID guid; /* The 128-bit GUID seen by the guest */
uint8_t vmgenid_addr_le[8]; /* Address of the GUID (little-endian) */
+ bool write_pointer_available;
} VmGenIdState;
static inline Object *find_vmgenid_dev(void)
diff --git a/include/hw/compat.h b/include/hw/compat.h
index fc8c3e060007..5d5be91daf59 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -131,6 +131,10 @@
.driver = "fw_cfg_io",\
.property = "dma_enabled",\
.value = "off",\
+ },{\
+ .driver = "vmgenid",\
+ .property = "x-write-pointer-available",\
+ .value = "off",\
},
#define HW_COMPAT_2_3 \
diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
index 7a3ad17d66ef..c3ddcc8e7cb0 100644
--- a/hw/acpi/vmgenid.c
+++ b/hw/acpi/vmgenid.c
@@ -205,9 +205,22 @@ static void vmgenid_handle_reset(void *opaque)
memset(vms->vmgenid_addr_le, 0, ARRAY_SIZE(vms->vmgenid_addr_le));
}
+static Property vmgenid_properties[] = {
+ DEFINE_PROP_BOOL("x-write-pointer-available", VmGenIdState,
+ write_pointer_available, true),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
static void vmgenid_realize(DeviceState *dev, Error **errp)
{
VmGenIdState *vms = VMGENID(dev);
+
+ if (!vms->write_pointer_available) {
+ error_setg(errp, "%s requires DMA write support in fw_cfg, "
+ "which this machine type does not provide", VMGENID_DEVICE);
+ return;
+ }
+
qemu_register_reset(vmgenid_handle_reset, vms);
}
@@ -218,6 +231,7 @@ static void vmgenid_device_class_init(ObjectClass *klass, void *data)
dc->vmsd = &vmstate_vmgenid;
dc->realize = vmgenid_realize;
dc->hotpluggable = false;
+ dc->props = vmgenid_properties;
object_class_property_add_str(klass, VMGENID_GUID, NULL,
vmgenid_set_guid, NULL);
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device
2017-03-20 17:05 [Qemu-devel] [PATCH v2 0/2] some remaining vmgenid tweaks for 2.9 Laszlo Ersek
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types Laszlo Ersek
@ 2017-03-20 17:05 ` Laszlo Ersek
2017-03-20 23:41 ` Ben Warren
2017-03-21 12:14 ` Igor Mammedov
1 sibling, 2 replies; 7+ messages in thread
From: Laszlo Ersek @ 2017-03-20 17:05 UTC (permalink / raw)
To: qemu devel list
Cc: Michael S. Tsirkin, Ben Warren, Igor Mammedov, Paolo Bonzini
A system with multiple VMGENID devices is undefined in the VMGENID spec by
omission.
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Ben Warren <ben@skyportsystems.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Notes:
v2:
- use find_vmgenid_dev() rather than open-code
object_resolve_path_type() [Michael]
- add comments to both the definition of find_vmgenid_dev() and its call
site in vmgenid_realize() [Michael]
include/hw/acpi/vmgenid.h | 1 +
hw/acpi/vmgenid.c | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/include/hw/acpi/vmgenid.h b/include/hw/acpi/vmgenid.h
index 8578476baebe..7beb9592fb01 100644
--- a/include/hw/acpi/vmgenid.h
+++ b/include/hw/acpi/vmgenid.h
@@ -24,6 +24,7 @@ typedef struct VmGenIdState {
bool write_pointer_available;
} VmGenIdState;
+/* returns NULL unless there is exactly one device */
static inline Object *find_vmgenid_dev(void)
{
return object_resolve_path_type("", VMGENID_DEVICE, NULL);
diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
index c3ddcc8e7cb0..a32b847fe0df 100644
--- a/hw/acpi/vmgenid.c
+++ b/hw/acpi/vmgenid.c
@@ -221,6 +221,14 @@ static void vmgenid_realize(DeviceState *dev, Error **errp)
return;
}
+ /* Given that this function is executing, there is at least one VMGENID
+ * device. Check if there are several.
+ */
+ if (!find_vmgenid_dev()) {
+ error_setg(errp, "at most one %s device is permitted", VMGENID_DEVICE);
+ return;
+ }
+
qemu_register_reset(vmgenid_handle_reset, vms);
}
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device Laszlo Ersek
@ 2017-03-20 23:41 ` Ben Warren
2017-03-21 12:14 ` Igor Mammedov
1 sibling, 0 replies; 7+ messages in thread
From: Ben Warren @ 2017-03-20 23:41 UTC (permalink / raw)
To: Laszlo Ersek
Cc: qemu devel list, Michael S. Tsirkin, Igor Mammedov, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 1954 bytes --]
Thanks Laszlo!
> On Mar 20, 2017, at 10:05 AM, Laszlo Ersek <lersek@redhat.com> wrote:
>
> A system with multiple VMGENID devices is undefined in the VMGENID spec by
> omission.
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Ben Warren <ben@skyportsystems.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Ben Warren <ben@skyportsystems.com>
> ---
>
> Notes:
> v2:
> - use find_vmgenid_dev() rather than open-code
> object_resolve_path_type() [Michael]
> - add comments to both the definition of find_vmgenid_dev() and its call
> site in vmgenid_realize() [Michael]
>
> include/hw/acpi/vmgenid.h | 1 +
> hw/acpi/vmgenid.c | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/include/hw/acpi/vmgenid.h b/include/hw/acpi/vmgenid.h
> index 8578476baebe..7beb9592fb01 100644
> --- a/include/hw/acpi/vmgenid.h
> +++ b/include/hw/acpi/vmgenid.h
> @@ -24,6 +24,7 @@ typedef struct VmGenIdState {
> bool write_pointer_available;
> } VmGenIdState;
>
> +/* returns NULL unless there is exactly one device */
> static inline Object *find_vmgenid_dev(void)
> {
> return object_resolve_path_type("", VMGENID_DEVICE, NULL);
> diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
> index c3ddcc8e7cb0..a32b847fe0df 100644
> --- a/hw/acpi/vmgenid.c
> +++ b/hw/acpi/vmgenid.c
> @@ -221,6 +221,14 @@ static void vmgenid_realize(DeviceState *dev, Error **errp)
> return;
> }
>
> + /* Given that this function is executing, there is at least one VMGENID
> + * device. Check if there are several.
> + */
> + if (!find_vmgenid_dev()) {
> + error_setg(errp, "at most one %s device is permitted", VMGENID_DEVICE);
> + return;
> + }
> +
> qemu_register_reset(vmgenid_handle_reset, vms);
> }
>
> --
> 2.9.3
>
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3583 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types Laszlo Ersek
@ 2017-03-21 12:13 ` Igor Mammedov
2017-03-22 0:53 ` Ben Warren
1 sibling, 0 replies; 7+ messages in thread
From: Igor Mammedov @ 2017-03-21 12:13 UTC (permalink / raw)
To: Laszlo Ersek
Cc: qemu devel list, Paolo Bonzini, Ben Warren, Michael S. Tsirkin
On Mon, 20 Mar 2017 18:05:56 +0100
Laszlo Ersek <lersek@redhat.com> wrote:
> The WRITE_POINTER linker/loader command that underlies VMGENID depends on
> commit baf2d5bfbac0 ("fw-cfg: support writeable blobs", 2017-01-12), which
> in turn depends on fw_cfg DMA.
>
> DMA for fw_cfg is enabled in 2.5+ machine types only (see commit
> e6915b5f3a87, "fw_cfg: unbreak migration compatibility for 2.4 and earlier
> machines", 2016-02-18).
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Ben Warren <ben@skyportsystems.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
>
> Notes:
> v2:
> - disable/enable vmgenid exactly in parallel with DMA support for fw_cfg
> [Michael, Paolo]
>
> include/hw/acpi/vmgenid.h | 1 +
> include/hw/compat.h | 4 ++++
> hw/acpi/vmgenid.c | 14 ++++++++++++++
> 3 files changed, 19 insertions(+)
>
> diff --git a/include/hw/acpi/vmgenid.h b/include/hw/acpi/vmgenid.h
> index db7fa0e63303..8578476baebe 100644
> --- a/include/hw/acpi/vmgenid.h
> +++ b/include/hw/acpi/vmgenid.h
> @@ -21,6 +21,7 @@ typedef struct VmGenIdState {
> DeviceClass parent_obj;
> QemuUUID guid; /* The 128-bit GUID seen by the guest */
> uint8_t vmgenid_addr_le[8]; /* Address of the GUID (little-endian) */
> + bool write_pointer_available;
> } VmGenIdState;
>
> static inline Object *find_vmgenid_dev(void)
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> index fc8c3e060007..5d5be91daf59 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -131,6 +131,10 @@
> .driver = "fw_cfg_io",\
> .property = "dma_enabled",\
> .value = "off",\
> + },{\
> + .driver = "vmgenid",\
> + .property = "x-write-pointer-available",\
> + .value = "off",\
> },
>
> #define HW_COMPAT_2_3 \
> diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
> index 7a3ad17d66ef..c3ddcc8e7cb0 100644
> --- a/hw/acpi/vmgenid.c
> +++ b/hw/acpi/vmgenid.c
> @@ -205,9 +205,22 @@ static void vmgenid_handle_reset(void *opaque)
> memset(vms->vmgenid_addr_le, 0, ARRAY_SIZE(vms->vmgenid_addr_le));
> }
>
> +static Property vmgenid_properties[] = {
> + DEFINE_PROP_BOOL("x-write-pointer-available", VmGenIdState,
> + write_pointer_available, true),
> + DEFINE_PROP_END_OF_LIST(),
> +};
> +
> static void vmgenid_realize(DeviceState *dev, Error **errp)
> {
> VmGenIdState *vms = VMGENID(dev);
> +
> + if (!vms->write_pointer_available) {
> + error_setg(errp, "%s requires DMA write support in fw_cfg, "
> + "which this machine type does not provide", VMGENID_DEVICE);
> + return;
> + }
> +
> qemu_register_reset(vmgenid_handle_reset, vms);
> }
>
> @@ -218,6 +231,7 @@ static void vmgenid_device_class_init(ObjectClass *klass, void *data)
> dc->vmsd = &vmstate_vmgenid;
> dc->realize = vmgenid_realize;
> dc->hotpluggable = false;
> + dc->props = vmgenid_properties;
>
> object_class_property_add_str(klass, VMGENID_GUID, NULL,
> vmgenid_set_guid, NULL);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device Laszlo Ersek
2017-03-20 23:41 ` Ben Warren
@ 2017-03-21 12:14 ` Igor Mammedov
1 sibling, 0 replies; 7+ messages in thread
From: Igor Mammedov @ 2017-03-21 12:14 UTC (permalink / raw)
To: Laszlo Ersek
Cc: qemu devel list, Michael S. Tsirkin, Ben Warren, Paolo Bonzini
On Mon, 20 Mar 2017 18:05:57 +0100
Laszlo Ersek <lersek@redhat.com> wrote:
> A system with multiple VMGENID devices is undefined in the VMGENID spec by
> omission.
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Ben Warren <ben@skyportsystems.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
>
> Notes:
> v2:
> - use find_vmgenid_dev() rather than open-code
> object_resolve_path_type() [Michael]
> - add comments to both the definition of find_vmgenid_dev() and its call
> site in vmgenid_realize() [Michael]
>
> include/hw/acpi/vmgenid.h | 1 +
> hw/acpi/vmgenid.c | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/include/hw/acpi/vmgenid.h b/include/hw/acpi/vmgenid.h
> index 8578476baebe..7beb9592fb01 100644
> --- a/include/hw/acpi/vmgenid.h
> +++ b/include/hw/acpi/vmgenid.h
> @@ -24,6 +24,7 @@ typedef struct VmGenIdState {
> bool write_pointer_available;
> } VmGenIdState;
>
> +/* returns NULL unless there is exactly one device */
> static inline Object *find_vmgenid_dev(void)
> {
> return object_resolve_path_type("", VMGENID_DEVICE, NULL);
> diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
> index c3ddcc8e7cb0..a32b847fe0df 100644
> --- a/hw/acpi/vmgenid.c
> +++ b/hw/acpi/vmgenid.c
> @@ -221,6 +221,14 @@ static void vmgenid_realize(DeviceState *dev, Error **errp)
> return;
> }
>
> + /* Given that this function is executing, there is at least one VMGENID
> + * device. Check if there are several.
> + */
> + if (!find_vmgenid_dev()) {
> + error_setg(errp, "at most one %s device is permitted", VMGENID_DEVICE);
> + return;
> + }
> +
> qemu_register_reset(vmgenid_handle_reset, vms);
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types Laszlo Ersek
2017-03-21 12:13 ` Igor Mammedov
@ 2017-03-22 0:53 ` Ben Warren
1 sibling, 0 replies; 7+ messages in thread
From: Ben Warren @ 2017-03-22 0:53 UTC (permalink / raw)
To: Laszlo Ersek
Cc: qemu devel list, Michael S. Tsirkin, Igor Mammedov, Paolo Bonzini
> On Mar 20, 2017, at 10:05 AM, Laszlo Ersek <lersek@redhat.com> wrote:
>
> The WRITE_POINTER linker/loader command that underlies VMGENID depends on
> commit baf2d5bfbac0 ("fw-cfg: support writeable blobs", 2017-01-12), which
> in turn depends on fw_cfg DMA.
>
> DMA for fw_cfg is enabled in 2.5+ machine types only (see commit
> e6915b5f3a87, "fw_cfg: unbreak migration compatibility for 2.4 and earlier
> machines", 2016-02-18).
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Ben Warren <ben@skyportsystems.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ben Warren <ben@skyportsystems.com <mailto:ben@skyportsystems.com>>
> ---
>
> Notes:
> v2:
> - disable/enable vmgenid exactly in parallel with DMA support for fw_cfg
> [Michael, Paolo]
>
> include/hw/acpi/vmgenid.h | 1 +
> include/hw/compat.h | 4 ++++
> hw/acpi/vmgenid.c | 14 ++++++++++++++
> 3 files changed, 19 insertions(+)
>
> diff --git a/include/hw/acpi/vmgenid.h b/include/hw/acpi/vmgenid.h
> index db7fa0e63303..8578476baebe 100644
> --- a/include/hw/acpi/vmgenid.h
> +++ b/include/hw/acpi/vmgenid.h
> @@ -21,6 +21,7 @@ typedef struct VmGenIdState {
> DeviceClass parent_obj;
> QemuUUID guid; /* The 128-bit GUID seen by the guest */
> uint8_t vmgenid_addr_le[8]; /* Address of the GUID (little-endian) */
> + bool write_pointer_available;
> } VmGenIdState;
>
> static inline Object *find_vmgenid_dev(void)
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> index fc8c3e060007..5d5be91daf59 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -131,6 +131,10 @@
> .driver = "fw_cfg_io",\
> .property = "dma_enabled",\
> .value = "off",\
> + },{\
> + .driver = "vmgenid",\
> + .property = "x-write-pointer-available",\
> + .value = "off",\
> },
>
> #define HW_COMPAT_2_3 \
> diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
> index 7a3ad17d66ef..c3ddcc8e7cb0 100644
> --- a/hw/acpi/vmgenid.c
> +++ b/hw/acpi/vmgenid.c
> @@ -205,9 +205,22 @@ static void vmgenid_handle_reset(void *opaque)
> memset(vms->vmgenid_addr_le, 0, ARRAY_SIZE(vms->vmgenid_addr_le));
> }
>
> +static Property vmgenid_properties[] = {
> + DEFINE_PROP_BOOL("x-write-pointer-available", VmGenIdState,
> + write_pointer_available, true),
> + DEFINE_PROP_END_OF_LIST(),
> +};
> +
> static void vmgenid_realize(DeviceState *dev, Error **errp)
> {
> VmGenIdState *vms = VMGENID(dev);
> +
> + if (!vms->write_pointer_available) {
> + error_setg(errp, "%s requires DMA write support in fw_cfg, "
> + "which this machine type does not provide", VMGENID_DEVICE);
> + return;
> + }
> +
> qemu_register_reset(vmgenid_handle_reset, vms);
> }
>
> @@ -218,6 +231,7 @@ static void vmgenid_device_class_init(ObjectClass *klass, void *data)
> dc->vmsd = &vmstate_vmgenid;
> dc->realize = vmgenid_realize;
> dc->hotpluggable = false;
> + dc->props = vmgenid_properties;
>
> object_class_property_add_str(klass, VMGENID_GUID, NULL,
> vmgenid_set_guid, NULL);
> --
> 2.9.3
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-22 0:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-20 17:05 [Qemu-devel] [PATCH v2 0/2] some remaining vmgenid tweaks for 2.9 Laszlo Ersek
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types Laszlo Ersek
2017-03-21 12:13 ` Igor Mammedov
2017-03-22 0:53 ` Ben Warren
2017-03-20 17:05 ` [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device Laszlo Ersek
2017-03-20 23:41 ` Ben Warren
2017-03-21 12:14 ` Igor Mammedov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.