[PATCH 0/2] IIO coding tasks

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/2] IIO coding tasks
@ 2017-03-21 13:30 Arushi Singhal
  2017-03-21 13:30 ` [PATCH 1/2] staging: ad7759: Replace mlock with driver private lock Arushi Singhal
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Arushi Singhal @ 2017-03-21 13:30 UTC (permalink / raw)
  To: jic23
  Cc: knaack.h, outreachy-kernel, Michael.Hennerich, lars, gregkh,
	speakup, devel, linux-kernel, pmeerw, linux-iio, Arushi Singhal

Patchseries of IIO coding tasks

Arushi Singhal (2):
  staging: ad7759: Replace mlock with driver private lock
  staging: iio: ade7759: Move header content to implementation file

 drivers/staging/iio/meter/ade7759.c   | 56 +++++++++++++++++++++++++++++++++--
 drivers/staging/iio/meter/ade7759.h   | 53 ---------------------------------
 2 files changed, 54 insertions(+), 57 deletions(-)

-- 
2.11.0



^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/2] staging: ad7759: Replace mlock with driver private lock
  2017-03-21 13:30 [PATCH 0/2] IIO coding tasks Arushi Singhal
@ 2017-03-21 13:30 ` Arushi Singhal
  2017-03-21 13:30 ` [PATCH 2/2] staging: iio: ade7759: Move header content to implementation file Arushi Singhal
  2017-03-21 16:03 ` [Outreachy kernel] [PATCH 0/2] IIO coding tasks Alison Schofield
  2 siblings, 0 replies; 14+ messages in thread
From: Arushi Singhal @ 2017-03-21 13:30 UTC (permalink / raw)
  To: jic23
  Cc: knaack.h, outreachy-kernel, Michael.Hennerich, lars, gregkh,
	speakup, devel, linux-kernel, pmeerw, linux-iio, Arushi Singhal

The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.

In this driver, mlock was being used to protect hardware state
changes.  Replace it with a lock in the devices global data.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/iio/meter/ade7759.c | 4 ++--
 drivers/staging/iio/meter/ade7759.h | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c
index 944ee3401029..1d1e0b33021f 100644
--- a/drivers/staging/iio/meter/ade7759.c
+++ b/drivers/staging/iio/meter/ade7759.c
@@ -381,7 +381,7 @@ static ssize_t ade7759_write_frequency(struct device *dev,
 	if (!val)
 		return -EINVAL;
 
-	mutex_lock(&indio_dev->mlock);
+	mutex_lock(&st->buf_lock);
 
 	t = 27900 / val;
 	if (t > 0)
@@ -402,7 +402,7 @@ static ssize_t ade7759_write_frequency(struct device *dev,
 	ret = ade7759_spi_write_reg_16(dev, ADE7759_MODE, reg);
 
 out:
-	mutex_unlock(&indio_dev->mlock);
+	mutex_unlock(&st->buf_lock);
 
 	return ret ? ret : len;
 }
diff --git a/drivers/staging/iio/meter/ade7759.h b/drivers/staging/iio/meter/ade7759.h
index f0716d2fdf8e..4f69bb93cc45 100644
--- a/drivers/staging/iio/meter/ade7759.h
+++ b/drivers/staging/iio/meter/ade7759.h
@@ -42,6 +42,7 @@
  * @buf_lock:		mutex to protect tx and rx
  * @tx:			transmit buffer
  * @rx:			receive buffer
+ * @lock		protect sensor state
  **/
 struct ade7759_state {
 	struct spi_device	*us;
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 2/2] staging: iio: ade7759: Move header content to implementation file
  2017-03-21 13:30 [PATCH 0/2] IIO coding tasks Arushi Singhal
  2017-03-21 13:30 ` [PATCH 1/2] staging: ad7759: Replace mlock with driver private lock Arushi Singhal
@ 2017-03-21 13:30 ` Arushi Singhal
  2017-03-21 16:03 ` [Outreachy kernel] [PATCH 0/2] IIO coding tasks Alison Schofield
  2 siblings, 0 replies; 14+ messages in thread
From: Arushi Singhal @ 2017-03-21 13:30 UTC (permalink / raw)
  To: jic23
  Cc: knaack.h, outreachy-kernel, Michael.Hennerich, lars, gregkh,
	speakup, devel, linux-kernel, pmeerw, linux-iio, Arushi Singhal

The contents of ade7759.h are only used in ade7759.c.
Move the header contents to the implemtation file,
and delete the header file.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/iio/meter/ade7759.c | 52 ++++++++++++++++++++++++++++++++++-
 drivers/staging/iio/meter/ade7759.h | 54 -------------------------------------
 2 files changed, 51 insertions(+), 55 deletions(-)

diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c
index 1d1e0b33021f..86ac103dffe5 100644
--- a/drivers/staging/iio/meter/ade7759.c
+++ b/drivers/staging/iio/meter/ade7759.c
@@ -21,7 +21,57 @@
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
 #include "meter.h"
-#include "ade7759.h"
+
+#define ADE7759_WAVEFORM  0x01
+#define ADE7759_AENERGY   0x02
+#define ADE7759_RSTENERGY 0x03
+#define ADE7759_STATUS    0x04
+#define ADE7759_RSTSTATUS 0x05
+#define ADE7759_MODE      0x06
+#define ADE7759_CFDEN     0x07
+#define ADE7759_CH1OS     0x08
+#define ADE7759_CH2OS     0x09
+#define ADE7759_GAIN      0x0A
+#define ADE7759_APGAIN    0x0B
+#define ADE7759_PHCAL     0x0C
+#define ADE7759_APOS      0x0D
+#define ADE7759_ZXTOUT    0x0E
+#define ADE7759_SAGCYC    0x0F
+#define ADE7759_IRQEN     0x10
+#define ADE7759_SAGLVL    0x11
+#define ADE7759_TEMP      0x12
+#define ADE7759_LINECYC   0x13
+#define ADE7759_LENERGY   0x14
+#define ADE7759_CFNUM     0x15
+#define ADE7759_CHKSUM    0x1E
+#define ADE7759_DIEREV    0x1F
+
+#define ADE7759_READ_REG(a)    a
+#define ADE7759_WRITE_REG(a) ((a) | 0x80)
+
+#define ADE7759_MAX_TX    6
+#define ADE7759_MAX_RX    6
+#define ADE7759_STARTUP_DELAY 1000
+
+#define ADE7759_SPI_SLOW        (u32)(300 * 1000)
+#define ADE7759_SPI_BURST       (u32)(1000 * 1000)
+#define ADE7759_SPI_FAST        (u32)(2000 * 1000)
+
+/**
+ * struct ade7759_state - device instance specific data
+ * @us:			actual spi_device
+ * @buf_lock:		mutex to protect tx and rx
+ * @tx:			transmit buffer
+ * @rx:			receive buffer
+ * @lock		protect sensor state
+ **/
+
+struct ade7759_state {
+	struct spi_device	*us;
+	struct mutex		buf_lock; /* protect tx and rx */
+	u8			tx[ADE7759_MAX_TX] ____cacheline_aligned;
+	u8			rx[ADE7759_MAX_RX];
+};
 
 static int ade7759_spi_write_reg_8(struct device *dev,
 		u8 reg_address,
diff --git a/drivers/staging/iio/meter/ade7759.h b/drivers/staging/iio/meter/ade7759.h
index 4f69bb93cc45..e69de29bb2d1 100644
--- a/drivers/staging/iio/meter/ade7759.h
+++ b/drivers/staging/iio/meter/ade7759.h
@@ -1,54 +0,0 @@
-#ifndef _ADE7759_H
-#define _ADE7759_H
-
-#define ADE7759_WAVEFORM  0x01
-#define ADE7759_AENERGY   0x02
-#define ADE7759_RSTENERGY 0x03
-#define ADE7759_STATUS    0x04
-#define ADE7759_RSTSTATUS 0x05
-#define ADE7759_MODE      0x06
-#define ADE7759_CFDEN     0x07
-#define ADE7759_CH1OS     0x08
-#define ADE7759_CH2OS     0x09
-#define ADE7759_GAIN      0x0A
-#define ADE7759_APGAIN    0x0B
-#define ADE7759_PHCAL     0x0C
-#define ADE7759_APOS      0x0D
-#define ADE7759_ZXTOUT    0x0E
-#define ADE7759_SAGCYC    0x0F
-#define ADE7759_IRQEN     0x10
-#define ADE7759_SAGLVL    0x11
-#define ADE7759_TEMP      0x12
-#define ADE7759_LINECYC   0x13
-#define ADE7759_LENERGY   0x14
-#define ADE7759_CFNUM     0x15
-#define ADE7759_CHKSUM    0x1E
-#define ADE7759_DIEREV    0x1F
-
-#define ADE7759_READ_REG(a)    a
-#define ADE7759_WRITE_REG(a) ((a) | 0x80)
-
-#define ADE7759_MAX_TX    6
-#define ADE7759_MAX_RX    6
-#define ADE7759_STARTUP_DELAY 1000
-
-#define ADE7759_SPI_SLOW	(u32)(300 * 1000)
-#define ADE7759_SPI_BURST	(u32)(1000 * 1000)
-#define ADE7759_SPI_FAST	(u32)(2000 * 1000)
-
-/**
- * struct ade7759_state - device instance specific data
- * @us:			actual spi_device
- * @buf_lock:		mutex to protect tx and rx
- * @tx:			transmit buffer
- * @rx:			receive buffer
- * @lock		protect sensor state
- **/
-struct ade7759_state {
-	struct spi_device	*us;
-	struct mutex		buf_lock;
-	u8			tx[ADE7759_MAX_TX] ____cacheline_aligned;
-	u8			rx[ADE7759_MAX_RX];
-};
-
-#endif
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
  2017-03-21 13:30 [PATCH 0/2] IIO coding tasks Arushi Singhal
  2017-03-21 13:30 ` [PATCH 1/2] staging: ad7759: Replace mlock with driver private lock Arushi Singhal
  2017-03-21 13:30 ` [PATCH 2/2] staging: iio: ade7759: Move header content to implementation file Arushi Singhal
@ 2017-03-21 16:03 ` Alison Schofield
  2017-03-21 16:36   ` Arushi Singhal
  2 siblings, 1 reply; 14+ messages in thread
From: Alison Schofield @ 2017-03-21 16:03 UTC (permalink / raw)
  To: Arushi Singhal
  Cc: jic23, knaack.h, outreachy-kernel, Michael.Hennerich, lars,
	gregkh, speakup, devel, linux-kernel, pmeerw, linux-iio

On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> Patchseries of IIO coding tasks

This wouldn't be a patchset.  Although they touch the same
driver, the changes are unrelated.  See more below...
> 
> Arushi Singhal (2):
>   staging: ad7759: Replace mlock with driver private lock

This one is already been submitted.  If you have a v2 for it, then v2
the original patch.

>   staging: iio: ade7759: Move header content to implementation file

This patch is done and applied already.  See the Coding Task #1 notes
in the IIO Tasks page.

alisons

> 
>  drivers/staging/iio/meter/ade7759.c   | 56 +++++++++++++++++++++++++++++++++--
>  drivers/staging/iio/meter/ade7759.h   | 53 ---------------------------------
>  2 files changed, 54 insertions(+), 57 deletions(-)
> 
> -- 
> 2.11.0
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737-1-arushisinghal19971997%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
  2017-03-21 16:03 ` [Outreachy kernel] [PATCH 0/2] IIO coding tasks Alison Schofield
@ 2017-03-21 16:36   ` Arushi Singhal
  2017-03-21 16:39     ` Julia Lawall
  0 siblings, 1 reply; 14+ messages in thread
From: Arushi Singhal @ 2017-03-21 16:36 UTC (permalink / raw)
  To: Alison Schofield
  Cc: Jonathan Cameron, Hartmut Knaack, outreachy-kernel,
	Michael Hennerich, lars, Greg KH, speakup, driverdevel,
	linux-kernel, Peter Meerwald-Stadler, linux-iio

[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]

On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield <amsfield22@gmail.com>
wrote:

> On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> > Patchseries of IIO coding tasks
>
> This wouldn't be a patchset.  Although they touch the same
> driver, the changes are unrelated.  See more below...
>
This I have send as a Patchset because as you have mentioned below that the
[PATCH 2/2] was already done before by someone but I think so it is not yet
applied in the Greg's tree yet.So I have done both the changes and as they
should be applied one after other so that's why I have send them as
Patchset.

> >
> > Arushi Singhal (2):
> >   staging: ad7759: Replace mlock with driver private lock
>
> This one is already been submitted.  If you have a v2 for it, then v2
> the original patch.
>
> Is it submitted by me only before? And this is not the v2.
I have just resed it.

> >   staging: iio: ade7759: Move header content to implementation file
>
> This patch is done and applied already.  See the Coding Task #1 notes
> in the IIO Tasks page.
>
Not at applied I think so.
Thanks
Arushi

>
> alisons
>
> >
> >  drivers/staging/iio/meter/ade7759.c   | 56
> +++++++++++++++++++++++++++++++++--
> >  drivers/staging/iio/meter/ade7759.h   | 53
> ---------------------------------
> >  2 files changed, 54 insertions(+), 57 deletions(-)
> >
> > --
> > 2.11.0
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/
> msgid/outreachy-kernel/20170321133021.6737-1-
> arushisinghal19971997%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 3444 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
  2017-03-21 16:36   ` Arushi Singhal
@ 2017-03-21 16:39     ` Julia Lawall
  2017-03-21 17:02         ` Alison Schofield
  0 siblings, 1 reply; 14+ messages in thread
From: Julia Lawall @ 2017-03-21 16:39 UTC (permalink / raw)
  To: Arushi Singhal
  Cc: Alison Schofield, Jonathan Cameron, Hartmut Knaack,
	outreachy-kernel, Michael Hennerich, lars, Greg KH, speakup,
	driverdevel, linux-kernel, Peter Meerwald-Stadler, linux-iio

[-- Attachment #1: Type: text/plain, Size: 2877 bytes --]



On Tue, 21 Mar 2017, Arushi Singhal wrote:

> On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield <amsfield22@gmail.com>
> wrote:
>       On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
>       > Patchseries of IIO coding tasks
>
>       This wouldn't be a patchset.  Although they touch the same
>       driver, the changes are unrelated.  See more below...
>
> This I have send as a Patchset because as you have mentioned below that the
> [PATCH 2/2] was already done before by someone but I think so it is not yet
> applied in the Greg's tree yet.So I have done both the changes and as they
> should be applied one after other so that's why I have send them as
> Patchset.

For the IIO patches, it is better to work on the IIO tree, not Greg's.
Greg manages staging, not IIO.  The IIO patches should appear in Greg's
tree eventually.

julia

>       >
>       > Arushi Singhal (2):
>       >   staging: ad7759: Replace mlock with driver private lock
>
>       This one is already been submitted.  If you have a v2 for it,
>       then v2
>       the original patch.
>
> Is it submitted by me only before? And this is not the v2.
> I have just resed it.
>       >   staging: iio: ade7759: Move header content to implementation
>       file
>
>       This patch is done and applied already.  See the Coding Task #1
>       notes
>       in the IIO Tasks page.
>
> Not at applied I think so.
> Thanks
> Arushi
>
>       alisons
>
>       >
>       >  drivers/staging/iio/meter/ade7759.c   | 56
>       +++++++++++++++++++++++++++++++++--
>       >  drivers/staging/iio/meter/ade7759.h   | 53
>       ---------------------------------
>       >  2 files changed, 54 insertions(+), 57 deletions(-)
>       >
>       > --
>       > 2.11.0
>       >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to
> outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar
> ushisinghal19971997%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x
> taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
  2017-03-21 16:39     ` Julia Lawall
@ 2017-03-21 17:02         ` Alison Schofield
  0 siblings, 0 replies; 14+ messages in thread
From: Alison Schofield @ 2017-03-21 17:02 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Arushi Singhal, Jonathan Cameron, Hartmut Knaack,
	outreachy-kernel, Michael Hennerich, lars, Greg KH, speakup,
	driverdevel, linux-kernel, Peter Meerwald-Stadler, linux-iio

On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 21 Mar 2017, Arushi Singhal wrote:
> 
> > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield <amsfield22@gmail.com>
> > wrote:
> >       On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> >       > Patchseries of IIO coding tasks
> >
> >       This wouldn't be a patchset.  Although they touch the same
> >       driver, the changes are unrelated.  See more below...
> >
> > This I have send as a Patchset because as you have mentioned below that the
> > [PATCH 2/2] was already done before by someone but I think so it is not yet
> > applied in the Greg's tree yet.So I have done both the changes and as they
> > should be applied one after other so that's why I have send them as
> > Patchset.
> 
> For the IIO patches, it is better to work on the IIO tree, not Greg's.
> Greg manages staging, not IIO.  The IIO patches should appear in Greg's
> tree eventually.
> 
> julia

We didn't direct applicants to create an iio tree.  At this point,
it seems more than is necessary.  They can follow the directions in the
task descriptions and avoid the collisions.

Of course, they are welcome to create a tree to iio/testing.

(IMHO it's more overhead/busy work and maybe not the best use
of time in the home stretch of the application period.)

alisons
> 
> >       >
> >       > Arushi Singhal (2):
> >       >   staging: ad7759: Replace mlock with driver private lock
> >
> >       This one is already been submitted.  If you have a v2 for it,
> >       then v2
> >       the original patch.
> >
> > Is it submitted by me only before? And this is not the v2.
> > I have just resed it.
> >       >   staging: iio: ade7759: Move header content to implementation
> >       file
> >
> >       This patch is done and applied already.  See the Coding Task #1
> >       notes
> >       in the IIO Tasks page.
> >
> > Not at applied I think so.
> > Thanks
> > Arushi
> >
> >       alisons
> >
> >       >
> >       >  drivers/staging/iio/meter/ade7759.c   | 56
> >       +++++++++++++++++++++++++++++++++--
> >       >  drivers/staging/iio/meter/ade7759.h   | 53
> >       ---------------------------------
> >       >  2 files changed, 54 insertions(+), 57 deletions(-)
> >       >
> >       > --
> >       > 2.11.0
> >       >
> > > --
> > > You received this message because you are subscribed to the Google
> > Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it,
> > send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to
> > outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar
> > ushisinghal19971997%40gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x
> > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
@ 2017-03-21 17:02         ` Alison Schofield
  0 siblings, 0 replies; 14+ messages in thread
From: Alison Schofield @ 2017-03-21 17:02 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Arushi Singhal, Jonathan Cameron, Hartmut Knaack,
	outreachy-kernel, Michael Hennerich, lars, Greg KH, speakup,
	driverdevel, linux-kernel, Peter Meerwald-Stadler, linux-iio

On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 21 Mar 2017, Arushi Singhal wrote:
> 
> > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield <amsfield22@gmail.com>
> > wrote:
> >       On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> >       > Patchseries of IIO coding tasks
> >
> >       This wouldn't be a patchset.ï¿½ Although they touch the same
> >       driver, the changes are unrelated.ï¿½ See more below...
> >
> > This I have send as a Patchset because as you have mentioned below that the
> > [PATCH 2/2] was already done before by someone but I think so it is not yet
> > applied in the Greg's tree yet.So I have done both the changes and as they
> > should be applied one after other so that's why I have send them as
> > Patchset.
> 
> For the IIO patches, it is better to work on the IIO tree, not Greg's.
> Greg manages staging, not IIO.  The IIO patches should appear in Greg's
> tree eventually.
> 
> julia

We didn't direct applicants to create an iio tree.  At this point,
it seems more than is necessary.  They can follow the directions in the
task descriptions and avoid the collisions.

Of course, they are welcome to create a tree to iio/testing.

(IMHO it's more overhead/busy work and maybe not the best use
of time in the home stretch of the application period.)

alisons
> 
> >       >
> >       > Arushi Singhal (2):
> >       >ï¿½ ï¿½staging: ad7759: Replace mlock with driver private lock
> >
> >       This one is already been submitted.ï¿½ If you have a v2 for it,
> >       then v2
> >       the original patch.
> >
> > Is it submitted by me only before? And this is not the v2.
> > I have just resed it.
> >       >ï¿½ ï¿½staging: iio: ade7759: Move header content to implementation
> >       file
> >
> >       This patch is done and applied already.ï¿½ See the Coding Task #1
> >       notes
> >       in the IIO Tasks page.
> >
> > Not at applied I think so.
> > Thanks
> > Arushi
> >
> >       alisons
> >
> >       >
> >       >ï¿½ drivers/staging/iio/meter/ade7759.cï¿½ ï¿½| 56
> >       +++++++++++++++++++++++++++++++++--
> >       >ï¿½ drivers/staging/iio/meter/ade7759.hï¿½ ï¿½| 53
> >       ---------------------------------
> >       >ï¿½ 2 files changed, 54 insertions(+), 57 deletions(-)
> >       >
> >       > --
> >       > 2.11.0
> >       >
> > > --
> > > You received this message because you are subscribed to the Google
> > Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it,
> > send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to
> > outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar
> > ushisinghal19971997%40gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x
> > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
  2017-03-21 17:02         ` Alison Schofield
  (?)
@ 2017-03-21 17:09         ` Julia Lawall
  -1 siblings, 0 replies; 14+ messages in thread
From: Julia Lawall @ 2017-03-21 17:09 UTC (permalink / raw)
  To: Alison Schofield
  Cc: Julia Lawall, Arushi Singhal, Jonathan Cameron, Hartmut Knaack,
	outreachy-kernel, Michael Hennerich, lars, Greg KH, speakup,
	driverdevel, linux-kernel, Peter Meerwald-Stadler, linux-iio

[-- Attachment #1: Type: text/plain, Size: 4461 bytes --]



On Tue, 21 Mar 2017, Alison Schofield wrote:

> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 21 Mar 2017, Arushi Singhal wrote:
> >
> > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield <amsfield22@gmail.com>
> > > wrote:
> > >       On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> > >       > Patchseries of IIO coding tasks
> > >
> > >       This wouldn't be a patchset.  Although they touch the same
> > >       driver, the changes are unrelated.  See more below...
> > >
> > > This I have send as a Patchset because as you have mentioned below that the
> > > [PATCH 2/2] was already done before by someone but I think so it is not yet
> > > applied in the Greg's tree yet.So I have done both the changes and as they
> > > should be applied one after other so that's why I have send them as
> > > Patchset.
> >
> > For the IIO patches, it is better to work on the IIO tree, not Greg's.
> > Greg manages staging, not IIO.  The IIO patches should appear in Greg's
> > tree eventually.
> >
> > julia
>
> We didn't direct applicants to create an iio tree.  At this point,
> it seems more than is necessary.  They can follow the directions in the
> task descriptions and avoid the collisions.

I meant just pull from the IIO tree you mentioned, work on that, submit
patches, and then expect to see the patches show up there at some time in
the future.

If someone make IIO patches on Greg's tree, then they will have an out of
date view.

julia

>
> Of course, they are welcome to create a tree to iio/testing.
>
> (IMHO it's more overhead/busy work and maybe not the best use
> of time in the home stretch of the application period.)
>
> alisons
> >
> > >       >
> > >       > Arushi Singhal (2):
> > >       >   staging: ad7759: Replace mlock with driver private lock
> > >
> > >       This one is already been submitted.  If you have a v2 for it,
> > >       then v2
> > >       the original patch.
> > >
> > > Is it submitted by me only before? And this is not the v2.
> > > I have just resed it.
> > >       >   staging: iio: ade7759: Move header content to implementation
> > >       file
> > >
> > >       This patch is done and applied already.  See the Coding Task #1
> > >       notes
> > >       in the IIO Tasks page.
> > >
> > > Not at applied I think so.
> > > Thanks
> > > Arushi
> > >
> > >       alisons
> > >
> > >       >
> > >       >  drivers/staging/iio/meter/ade7759.c   | 56
> > >       +++++++++++++++++++++++++++++++++--
> > >       >  drivers/staging/iio/meter/ade7759.h   | 53
> > >       ---------------------------------
> > >       >  2 files changed, 54 insertions(+), 57 deletions(-)
> > >       >
> > >       > --
> > >       > 2.11.0
> > >       >
> > > > --
> > > > You received this message because you are subscribed to the Google
> > > Groups "outreachy-kernel" group.
> > > > To unsubscribe from this group and stop receiving emails from it,
> > > send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > > To post to this group, send email to
> > > outreachy-kernel@googlegroups.com.
> > > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar
> > > ushisinghal19971997%40gmail.com.
> > > > For more options, visit https://groups.google.com/d/optout.
> > >
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an
> > > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x
> > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
> > >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170321170221.GB2793%40d830.WORKGROUP.
> For more options, visit https://groups.google.com/d/optout.
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
  2017-03-21 17:02         ` Alison Schofield
  (?)
  (?)
@ 2017-03-21 17:22         ` Arushi Singhal
  2017-03-21 17:27           ` Julia Lawall
  2017-03-21 17:33           ` Alison Schofield
  -1 siblings, 2 replies; 14+ messages in thread
From: Arushi Singhal @ 2017-03-21 17:22 UTC (permalink / raw)
  To: Alison Schofield
  Cc: Julia Lawall, Jonathan Cameron, Hartmut Knaack, outreachy-kernel,
	Michael Hennerich, lars, Greg KH, speakup, driverdevel,
	linux-kernel, Peter Meerwald-Stadler, linux-iio

[-- Attachment #1: Type: text/plain, Size: 3974 bytes --]

On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield <amsfield22@gmail.com>
wrote:

> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 21 Mar 2017, Arushi Singhal wrote:
> >
> > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield <
> amsfield22@gmail.com>
> > > wrote:
> > >       On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> > >       > Patchseries of IIO coding tasks
> > >
> > >       This wouldn't be a patchset.  Although they touch the same
> > >       driver, the changes are unrelated.  See more below...
> > >
> > > This I have send as a Patchset because as you have mentioned below
> that the
> > > [PATCH 2/2] was already done before by someone but I think so it is
> not yet
> > > applied in the Greg's tree yet.So I have done both the changes and as
> they
> > > should be applied one after other so that's why I have send them as
> > > Patchset.
> >
> > For the IIO patches, it is better to work on the IIO tree, not Greg's.
> > Greg manages staging, not IIO.  The IIO patches should appear in Greg's
> > tree eventually.
> >
> > julia
>
> We didn't direct applicants to create an iio tree.  At this point,
> it seems more than is necessary.  They can follow the directions in the
> task descriptions and avoid the collisions.
>
> Of course, they are welcome to create a tree to iio/testing.
>
> (IMHO it's more overhead/busy work and maybe not the best use
> of time in the home stretch of the application period.)
>
> alisons
>

Hi Alison
As you have mentioned that my [PATCH 2/2] is already being done someone. So
how can I make the changes of [PATCH 1/2] on top of it as [PATCH 2/2] is
not yet applied on the staging tree.
Please suggest me.
Thanks
Arushi

> >
> > >       >
> > >       > Arushi Singhal (2):
> > >       >   staging: ad7759: Replace mlock with driver private lock
> > >
> > >       This one is already been submitted.  If you have a v2 for it,
> > >       then v2
> > >       the original patch.
> > >
> > > Is it submitted by me only before? And this is not the v2.
> > > I have just resed it.
> > >       >   staging: iio: ade7759: Move header content to implementation
> > >       file
> > >
> > >       This patch is done and applied already.  See the Coding Task #1
> > >       notes
> > >       in the IIO Tasks page.
> > >
> > > Not at applied I think so.
> > > Thanks
> > > Arushi
> > >
> > >       alisons
> > >
> > >       >
> > >       >  drivers/staging/iio/meter/ade7759.c   | 56
> > >       +++++++++++++++++++++++++++++++++--
> > >       >  drivers/staging/iio/meter/ade7759.h   | 53
> > >       ---------------------------------
> > >       >  2 files changed, 54 insertions(+), 57 deletions(-)
> > >       >
> > >       > --
> > >       > 2.11.0
> > >       >
> > > > --
> > > > You received this message because you are subscribed to the Google
> > > Groups "outreachy-kernel" group.
> > > > To unsubscribe from this group and stop receiving emails from it,
> > > send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > > To post to this group, send email to
> > > outreachy-kernel@googlegroups.com.
> > > > To view this discussion on the web visithttps://groups.google.
> com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar
> > > ushisinghal19971997%40gmail.com.
> > > > For more options, visit https://groups.google.com/d/optout.
> > >
> > >
> > > --
> > > You received this message because you are subscribed to the Google
> Groups
> > > "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send
> an
> > > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com
> .
> > > To view this discussion on the web visithttps://groups.google.
> com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x
> > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
> > >
>
>

[-- Attachment #2: Type: text/html, Size: 6386 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
  2017-03-21 17:22         ` Arushi Singhal
@ 2017-03-21 17:27           ` Julia Lawall
  2017-03-21 17:57               ` Jonathan Cameron
  2017-03-21 17:33           ` Alison Schofield
  1 sibling, 1 reply; 14+ messages in thread
From: Julia Lawall @ 2017-03-21 17:27 UTC (permalink / raw)
  To: Arushi Singhal
  Cc: Alison Schofield, Julia Lawall, Jonathan Cameron, Hartmut Knaack,
	outreachy-kernel, Michael Hennerich, lars, Greg KH, speakup,
	driverdevel, linux-kernel, Peter Meerwald-Stadler, linux-iio

[-- Attachment #1: Type: text/plain, Size: 4991 bytes --]



On Tue, 21 Mar 2017, Arushi Singhal wrote:

>
>
> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield <amsfield22@gmail.com>
> wrote:
>       On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
>       >
>       >
>       > On Tue, 21 Mar 2017, Arushi Singhal wrote:
>       >
>       > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield
>       <amsfield22@gmail.com>
>       > > wrote:
>       > >       On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi
>       Singhal wrote:
>       > >       > Patchseries of IIO coding tasks
>       > >
>       > >       This wouldn't be a patchset.  Although they touch the
>       same
>       > >       driver, the changes are unrelated.  See more below...
>       > >
>       > > This I have send as a Patchset because as you have mentioned
>       below that the
>       > > [PATCH 2/2] was already done before by someone but I think
>       so it is not yet
>       > > applied in the Greg's tree yet.So I have done both the
>       changes and as they
>       > > should be applied one after other so that's why I have send
>       them as
>       > > Patchset.
>       >
>       > For the IIO patches, it is better to work on the IIO tree, not
>       Greg's.
>       > Greg manages staging, not IIO.  The IIO patches should appear
>       in Greg's
>       > tree eventually.
>       >
>       > julia
>
>       We didn't direct applicants to create an iio tree.  At this
>       point,
>       it seems more than is necessary.  They can follow the directions
>       in the
>       task descriptions and avoid the collisions.
>
>       Of course, they are welcome to create a tree to iio/testing.
>
>       (IMHO it's more overhead/busy work and maybe not the best use
>       of time in the home stretch of the application period.)
>
>       alisons
>
>
> Hi Alison
> As you have mentioned that my [PATCH 2/2] is already being done someone. So
> how can I make the changes of [PATCH 1/2] on top of it as [PATCH 2/2] is not
> yet applied on the staging tree.

Make a patch that applies to the current state of the IIO tree.  Just
clone that one like you cloned the staging one.

julia

> Please suggest me.
> Thanks
> Arushi
>       >
>       > >       >
>       > >       > Arushi Singhal (2):
>       > >       >   staging: ad7759: Replace mlock with driver private
>       lock
>       > >
>       > >       This one is already been submitted.  If you have a v2
>       for it,
>       > >       then v2
>       > >       the original patch.
>       > >
>       > > Is it submitted by me only before? And this is not the v2.
>       > > I have just resed it.
>       > >       >   staging: iio: ade7759: Move header content to
>       implementation
>       > >       file
>       > >
>       > >       This patch is done and applied already.  See the
>       Coding Task #1
>       > >       notes
>       > >       in the IIO Tasks page.
>       > >
>       > > Not at applied I think so.
>       > > Thanks
>       > > Arushi
>       > >
>       > >       alisons
>       > >
>       > >       >
>       > >       >  drivers/staging/iio/meter/ade7759.c   | 56
>       > >       +++++++++++++++++++++++++++++++++--
>       > >       >  drivers/staging/iio/meter/ade7759.h   | 53
>       > >       ---------------------------------
>       > >       >  2 files changed, 54 insertions(+), 57 deletions(-)
>       > >       >
>       > >       > --
>       > >       > 2.11.0
>       > >       >
>       > > > --
>       > > > You received this message because you are subscribed to
>       the Google
>       > > Groups "outreachy-kernel" group.
>       > > > To unsubscribe from this group and stop receiving emails
>       from it,
>       > > send an email to
>       outreachy-kernel+unsubscribe@googlegroups.com.
>       > > > To post to this group, send email to
>       > > outreachy-kernel@googlegroups.com.
>       > > > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737
>       -1-ar
>       > > ushisinghal19971997%40gmail.com.
>       > > > For more options, visit
>       https://groups.google.com/d/optout.
>       > >
>       > >
>       > > --
>       > > You received this message because you are subscribed to the
>       Google Groups
>       > > "outreachy-kernel" group.
>       > > To unsubscribe from this group and stop receiving emails
>       from it, send an
>       > > email to outreachy-kernel+unsubscribe@googlegroups.com.
>       > > To post to this group, send email to
>       outreachy-kernel@googlegroups.com.
>       > > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0
>       H2z8x
>       > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com.
>       > > For more options, visit https://groups.google.com/d/optout.
>       > >
>       > >
>
>
>
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
  2017-03-21 17:27           ` Julia Lawall
@ 2017-03-21 17:57               ` Jonathan Cameron
  0 siblings, 0 replies; 14+ messages in thread
From: Jonathan Cameron @ 2017-03-21 17:57 UTC (permalink / raw)
  To: Julia Lawall, Arushi Singhal
  Cc: Alison Schofield, Jonathan Cameron, Hartmut Knaack,
	outreachy-kernel, Michael Hennerich, lars, Greg KH, speakup,
	driverdevel, linux-kernel, Peter Meerwald-Stadler, linux-iio



On 21 March 2017 17:27:02 GMT+00:00, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>On Tue, 21 Mar 2017, Arushi Singhal wrote:
>
>>
>>
>> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield
><amsfield22@gmail.com>
>> wrote:
>>       On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
>>       >
>>       >
>>       > On Tue, 21 Mar 2017, Arushi Singhal wrote:
>>       >
>>       > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield
>>       <amsfield22@gmail.com>
>>       > > wrote:
>>       > >       On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi
>>       Singhal wrote:
>>       > >       > Patchseries of IIO coding tasks
>>       > >
>>       > >       This wouldn't be a patchset.  Although they touch the
>>       same
>>       > >       driver, the changes are unrelated.  See more below...
>>       > >
>>       > > This I have send as a Patchset because as you have
>mentioned
>>       below that the
>>       > > [PATCH 2/2] was already done before by someone but I think
>>       so it is not yet
>>       > > applied in the Greg's tree yet.So I have done both the
>>       changes and as they
>>       > > should be applied one after other so that's why I have send
>>       them as
>>       > > Patchset.
>>       >
>>       > For the IIO patches, it is better to work on the IIO tree,
>not
>>       Greg's.
>>       > Greg manages staging, not IIO.  The IIO patches should appear
>>       in Greg's
>>       > tree eventually.
>>       >
>>       > julia
>>
>>       We didn't direct applicants to create an iio tree.  At this
>>       point,
>>       it seems more than is necessary.  They can follow the
>directions
>>       in the
>>       task descriptions and avoid the collisions.
>>
>>       Of course, they are welcome to create a tree to iio/testing.
>>
>>       (IMHO it's more overhead/busy work and maybe not the best use
>>       of time in the home stretch of the application period.)
>>
>>       alisons
>>
>>
>> Hi Alison
>> As you have mentioned that my [PATCH 2/2] is already being done
>someone. So
>> how can I make the changes of [PATCH 1/2] on top of it as [PATCH 2/2]
>is not
>> yet applied on the staging tree.
>
>Make a patch that applies to the current state of the IIO tree.  Just
>clone that one like you cloned the staging one.
>
>julia
>
Slight amendment,. Normally would be the togreg branch which doesn't rebase.

With all the current churn might be best to use the testing branch and i will fix up any issues if i
 have to rebase as result of build tests.

Will.send Greg a pull later anyway, so should be less difference after he pulls that.

J
>> Please suggest me.
>> Thanks
>> Arushi
>>       >
>>       > >       >
>>       > >       > Arushi Singhal (2):
>>       > >       >   staging: ad7759: Replace mlock with driver
>private
>>       lock
>>       > >
>>       > >       This one is already been submitted.  If you have a v2
>>       for it,
>>       > >       then v2
>>       > >       the original patch.
>>       > >
>>       > > Is it submitted by me only before? And this is not the v2.
>>       > > I have just resed it.
>>       > >       >   staging: iio: ade7759: Move header content to
>>       implementation
>>       > >       file
>>       > >
>>       > >       This patch is done and applied already.  See the
>>       Coding Task #1
>>       > >       notes
>>       > >       in the IIO Tasks page.
>>       > >
>>       > > Not at applied I think so.
>>       > > Thanks
>>       > > Arushi
>>       > >
>>       > >       alisons
>>       > >
>>       > >       >
>>       > >       >  drivers/staging/iio/meter/ade7759.c   | 56
>>       > >       +++++++++++++++++++++++++++++++++--
>>       > >       >  drivers/staging/iio/meter/ade7759.h   | 53
>>       > >       ---------------------------------
>>       > >       >  2 files changed, 54 insertions(+), 57 deletions(-)
>>       > >       >
>>       > >       > --
>>       > >       > 2.11.0
>>       > >       >
>>       > > > --
>>       > > > You received this message because you are subscribed to
>>       the Google
>>       > > Groups "outreachy-kernel" group.
>>       > > > To unsubscribe from this group and stop receiving emails
>>       from it,
>>       > > send an email to
>>       outreachy-kernel+unsubscribe@googlegroups.com.
>>       > > > To post to this group, send email to
>>       > > outreachy-kernel@googlegroups.com.
>>       > > > To view this discussion on the
>webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737
>>       -1-ar
>>       > > ushisinghal19971997%40gmail.com.
>>       > > > For more options, visit
>>       https://groups.google.com/d/optout.
>>       > >
>>       > >
>>       > > --
>>       > > You received this message because you are subscribed to the
>>       Google Groups
>>       > > "outreachy-kernel" group.
>>       > > To unsubscribe from this group and stop receiving emails
>>       from it, send an
>>       > > email to outreachy-kernel+unsubscribe@googlegroups.com.
>>       > > To post to this group, send email to
>>       outreachy-kernel@googlegroups.com.
>>       > > To view this discussion on the
>webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0
>>       H2z8x
>>       > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com.
>>       > > For more options, visit https://groups.google.com/d/optout.
>>       > >
>>       > >
>>
>>
>>
>>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
@ 2017-03-21 17:57               ` Jonathan Cameron
  0 siblings, 0 replies; 14+ messages in thread
From: Jonathan Cameron @ 2017-03-21 17:57 UTC (permalink / raw)
  To: Julia Lawall, Arushi Singhal
  Cc: Alison Schofield, Jonathan Cameron, Hartmut Knaack,
	outreachy-kernel, Michael Hennerich, lars, Greg KH, speakup,
	driverdevel, linux-kernel, Peter Meerwald-Stadler, linux-iio



On 21 March 2017 17:27:02 GMT+00:00, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>On Tue, 21 Mar 2017, Arushi Singhal wrote:
>
>>
>>
>> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield
><amsfield22@gmail.com>
>> wrote:
>>       On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
>>       >
>>       >
>>       > On Tue, 21 Mar 2017, Arushi Singhal wrote:
>>       >
>>       > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield
>>       <amsfield22@gmail.com>
>>       > > wrote:
>>       > >       On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi
>>       Singhal wrote:
>>       > >       > Patchseries of IIO coding tasks
>>       > >
>>       > >       This wouldn't be a patchset.  Although they touch the
>>       same
>>       > >       driver, the changes are unrelated.  See more below...
>>       > >
>>       > > This I have send as a Patchset because as you have
>mentioned
>>       below that the
>>       > > [PATCH 2/2] was already done before by someone but I think
>>       so it is not yet
>>       > > applied in the Greg's tree yet.So I have done both the
>>       changes and as they
>>       > > should be applied one after other so that's why I have send
>>       them as
>>       > > Patchset.
>>       >
>>       > For the IIO patches, it is better to work on the IIO tree,
>not
>>       Greg's.
>>       > Greg manages staging, not IIO.  The IIO patches should appear
>>       in Greg's
>>       > tree eventually.
>>       >
>>       > julia
>>
>>       We didn't direct applicants to create an iio tree.  At this
>>       point,
>>       it seems more than is necessary.  They can follow the
>directions
>>       in the
>>       task descriptions and avoid the collisions.
>>
>>       Of course, they are welcome to create a tree to iio/testing.
>>
>>       (IMHO it's more overhead/busy work and maybe not the best use
>>       of time in the home stretch of the application period.)
>>
>>       alisons
>>
>>
>> Hi Alison
>> As you have mentioned that my [PATCH 2/2] is already being done
>someone. So
>> how can I make the changes of [PATCH 1/2] on top of it as [PATCH 2/2]
>is not
>> yet applied on the staging tree.
>
>Make a patch that applies to the current state of the IIO tree.  Just
>clone that one like you cloned the staging one.
>
>julia
>
Slight amendment,. Normally would be the togreg branch which doesn't rebase.

With all the current churn might be best to use the testing branch and i will fix up any issues if i
 have to rebase as result of build tests.

Will.send Greg a pull later anyway, so should be less difference after he pulls that.

J
>> Please suggest me.
>> Thanks
>> Arushi
>>       >
>>       > >       >
>>       > >       > Arushi Singhal (2):
>>       > >       >   staging: ad7759: Replace mlock with driver
>private
>>       lock
>>       > >
>>       > >       This one is already been submitted.  If you have a v2
>>       for it,
>>       > >       then v2
>>       > >       the original patch.
>>       > >
>>       > > Is it submitted by me only before? And this is not the v2.
>>       > > I have just resed it.
>>       > >       >   staging: iio: ade7759: Move header content to
>>       implementation
>>       > >       file
>>       > >
>>       > >       This patch is done and applied already.  See the
>>       Coding Task #1
>>       > >       notes
>>       > >       in the IIO Tasks page.
>>       > >
>>       > > Not at applied I think so.
>>       > > Thanks
>>       > > Arushi
>>       > >
>>       > >       alisons
>>       > >
>>       > >       >
>>       > >       >  drivers/staging/iio/meter/ade7759.c   | 56
>>       > >       +++++++++++++++++++++++++++++++++--
>>       > >       >  drivers/staging/iio/meter/ade7759.h   | 53
>>       > >       ---------------------------------
>>       > >       >  2 files changed, 54 insertions(+), 57 deletions(-)
>>       > >       >
>>       > >       > --
>>       > >       > 2.11.0
>>       > >       >
>>       > > > --
>>       > > > You received this message because you are subscribed to
>>       the Google
>>       > > Groups "outreachy-kernel" group.
>>       > > > To unsubscribe from this group and stop receiving emails
>>       from it,
>>       > > send an email to
>>       outreachy-kernel+unsubscribe@googlegroups.com.
>>       > > > To post to this group, send email to
>>       > > outreachy-kernel@googlegroups.com.
>>       > > > To view this discussion on the
>webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737
>>       -1-ar
>>       > > ushisinghal19971997%40gmail.com.
>>       > > > For more options, visit
>>       https://groups.google.com/d/optout.
>>       > >
>>       > >
>>       > > --
>>       > > You received this message because you are subscribed to the
>>       Google Groups
>>       > > "outreachy-kernel" group.
>>       > > To unsubscribe from this group and stop receiving emails
>>       from it, send an
>>       > > email to outreachy-kernel+unsubscribe@googlegroups.com.
>>       > > To post to this group, send email to
>>       outreachy-kernel@googlegroups.com.
>>       > > To view this discussion on the
>webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0
>>       H2z8x
>>       > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com.
>>       > > For more options, visit https://groups.google.com/d/optout.
>>       > >
>>       > >
>>
>>
>>
>>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
  2017-03-21 17:22         ` Arushi Singhal
  2017-03-21 17:27           ` Julia Lawall
@ 2017-03-21 17:33           ` Alison Schofield
  1 sibling, 0 replies; 14+ messages in thread
From: Alison Schofield @ 2017-03-21 17:33 UTC (permalink / raw)
  To: Arushi Singhal
  Cc: Julia Lawall, Jonathan Cameron, Hartmut Knaack, outreachy-kernel,
	Michael Hennerich, lars, Greg KH, speakup, driverdevel,
	linux-kernel, Peter Meerwald-Stadler, linux-iio

On Tue, Mar 21, 2017 at 10:52:46PM +0530, Arushi Singhal wrote:
> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield <amsfield22@gmail.com>
> wrote:
> 
> > On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 21 Mar 2017, Arushi Singhal wrote:
> > >
> > > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield <
> > amsfield22@gmail.com>
> > > > wrote:
> > > >       On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> > > >       > Patchseries of IIO coding tasks
> > > >
> > > >       This wouldn't be a patchset.  Although they touch the same
> > > >       driver, the changes are unrelated.  See more below...
> > > >
> > > > This I have send as a Patchset because as you have mentioned below
> > that the
> > > > [PATCH 2/2] was already done before by someone but I think so it is
> > not yet
> > > > applied in the Greg's tree yet.So I have done both the changes and as
> > they
> > > > should be applied one after other so that's why I have send them as
> > > > Patchset.
> > >
> > > For the IIO patches, it is better to work on the IIO tree, not Greg's.
> > > Greg manages staging, not IIO.  The IIO patches should appear in Greg's
> > > tree eventually.
> > >
> > > julia
> >
> > We didn't direct applicants to create an iio tree.  At this point,
> > it seems more than is necessary.  They can follow the directions in the
> > task descriptions and avoid the collisions.
> >
> > Of course, they are welcome to create a tree to iio/testing.
> >
> > (IMHO it's more overhead/busy work and maybe not the best use
> > of time in the home stretch of the application period.)
> >
> > alisons
> >
> 
> Hi Alison
> As you have mentioned that my [PATCH 2/2] is already being done someone. So
> how can I make the changes of [PATCH 1/2] on top of it as [PATCH 2/2] is
> not yet applied on the staging tree.
> Please suggest me.
> Thanks
> Arushi

Arushi - 
I don't see anything needing to be done by you!
Your ad7759 mlock patch is awaiting review.  It's not your issue
to keep up with all changes going into the file.  When it gets applied 
will most likely merge with no merge issue at all. 
alisons
> 
> > >
> > > >       >
> > > >       > Arushi Singhal (2):
> > > >       >   staging: ad7759: Replace mlock with driver private lock
> > > >
> > > >       This one is already been submitted.  If you have a v2 for it,
> > > >       then v2
> > > >       the original patch.
> > > >
> > > > Is it submitted by me only before? And this is not the v2.
> > > > I have just resed it.
> > > >       >   staging: iio: ade7759: Move header content to implementation
> > > >       file
> > > >
> > > >       This patch is done and applied already.  See the Coding Task #1
> > > >       notes
> > > >       in the IIO Tasks page.
> > > >
> > > > Not at applied I think so.
> > > > Thanks
> > > > Arushi
> > > >
> > > >       alisons
> > > >
> > > >       >
> > > >       >  drivers/staging/iio/meter/ade7759.c   | 56
> > > >       +++++++++++++++++++++++++++++++++--
> > > >       >  drivers/staging/iio/meter/ade7759.h   | 53
> > > >       ---------------------------------
> > > >       >  2 files changed, 54 insertions(+), 57 deletions(-)
> > > >       >
> > > >       > --
> > > >       > 2.11.0
> > > >       >
> > > > > --
> > > > > You received this message because you are subscribed to the Google
> > > > Groups "outreachy-kernel" group.
> > > > > To unsubscribe from this group and stop receiving emails from it,
> > > > send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > > > To post to this group, send email to
> > > > outreachy-kernel@googlegroups.com.
> > > > > To view this discussion on the web visithttps://groups.google.
> > com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar
> > > > ushisinghal19971997%40gmail.com.
> > > > > For more options, visit https://groups.google.com/d/optout.
> > > >
> > > >
> > > > --
> > > > You received this message because you are subscribed to the Google
> > Groups
> > > > "outreachy-kernel" group.
> > > > To unsubscribe from this group and stop receiving emails from it, send
> > an
> > > > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > > To post to this group, send email to outreachy-kernel@googlegroups.com
> > .
> > > > To view this discussion on the web visithttps://groups.google.
> > com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x
> > > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com.
> > > > For more options, visit https://groups.google.com/d/optout.
> > > >
> > > >
> >
> >


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2017-03-21 18:04 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21 13:30 [PATCH 0/2] IIO coding tasks Arushi Singhal
2017-03-21 13:30 ` [PATCH 1/2] staging: ad7759: Replace mlock with driver private lock Arushi Singhal
2017-03-21 13:30 ` [PATCH 2/2] staging: iio: ade7759: Move header content to implementation file Arushi Singhal
2017-03-21 16:03 ` [Outreachy kernel] [PATCH 0/2] IIO coding tasks Alison Schofield
2017-03-21 16:36   ` Arushi Singhal
2017-03-21 16:39     ` Julia Lawall
2017-03-21 17:02       ` Alison Schofield
2017-03-21 17:02         ` Alison Schofield
2017-03-21 17:09         ` Julia Lawall
2017-03-21 17:22         ` Arushi Singhal
2017-03-21 17:27           ` Julia Lawall
2017-03-21 17:57             ` Jonathan Cameron
2017-03-21 17:57               ` Jonathan Cameron
2017-03-21 17:33           ` Alison Schofield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.