* [PATCH v3 net-next] net: stmmac: fix dma operation mode config for older versions
@ 2017-03-22 11:56 Joao Pinto
2017-03-22 12:37 ` Corentin Labbe
2017-03-22 22:35 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Joao Pinto @ 2017-03-22 11:56 UTC (permalink / raw)
To: davem
Cc: peppe.cavallaro, alexandre.torgue, clabbe.montjoie,
thierry.reding, sergei.shtylyov, f.fainelli, netdev, Joao Pinto
The dma operation mode configuration routine was wrongly moved to a
function (stmmac_mtl_configuration) that is only executed if the
core version is >= 4.00.
Fixes: 6deee2221e11 ("net: stmmac: prepare dma op mode config for multiple queues")
Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Joao Pinto <jpinto@synopsys.com>
---
changes v2->v3:
- Commit ID and title should be under a 'Fixes' tag
changes v1->v2:
- commit id did not have 12 digits
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index d3a2151..225a3a3 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1945,9 +1945,6 @@ static void stmmac_mtl_configuration(struct stmmac_priv *priv)
/* Enable MAC RX Queues */
if (rx_queues_count > 1 && priv->hw->mac->rx_queue_enable)
stmmac_mac_enable_rx_queues(priv);
-
- /* Set the HW DMA mode and the COE */
- stmmac_dma_operation_mode(priv);
}
/**
@@ -2014,6 +2011,9 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp)
else
stmmac_set_mac(priv->ioaddr, true);
+ /* Set the HW DMA mode and the COE */
+ stmmac_dma_operation_mode(priv);
+
stmmac_mmc_setup(priv);
if (init_ptp) {
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 net-next] net: stmmac: fix dma operation mode config for older versions
2017-03-22 11:56 [PATCH v3 net-next] net: stmmac: fix dma operation mode config for older versions Joao Pinto
@ 2017-03-22 12:37 ` Corentin Labbe
2017-03-22 22:35 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Corentin Labbe @ 2017-03-22 12:37 UTC (permalink / raw)
To: Joao Pinto
Cc: davem, peppe.cavallaro, alexandre.torgue, thierry.reding,
sergei.shtylyov, f.fainelli, netdev
On Wed, Mar 22, 2017 at 11:56:05AM +0000, Joao Pinto wrote:
> The dma operation mode configuration routine was wrongly moved to a
> function (stmmac_mtl_configuration) that is only executed if the
> core version is >= 4.00.
>
> Fixes: 6deee2221e11 ("net: stmmac: prepare dma op mode config for multiple queues")
> Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> ---
> changes v2->v3:
> - Commit ID and title should be under a 'Fixes' tag
> changes v1->v2:
> - commit id did not have 12 digits
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index d3a2151..225a3a3 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1945,9 +1945,6 @@ static void stmmac_mtl_configuration(struct stmmac_priv *priv)
> /* Enable MAC RX Queues */
> if (rx_queues_count > 1 && priv->hw->mac->rx_queue_enable)
> stmmac_mac_enable_rx_queues(priv);
> -
> - /* Set the HW DMA mode and the COE */
> - stmmac_dma_operation_mode(priv);
> }
>
> /**
> @@ -2014,6 +2011,9 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp)
> else
> stmmac_set_mac(priv->ioaddr, true);
>
> + /* Set the HW DMA mode and the COE */
> + stmmac_dma_operation_mode(priv);
> +
> stmmac_mmc_setup(priv);
>
> if (init_ptp) {
> --
> 2.9.3
>
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Fix one of the reported problem on dwmac-sunxi and dwmac-sun8i
Regards
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 net-next] net: stmmac: fix dma operation mode config for older versions
2017-03-22 11:56 [PATCH v3 net-next] net: stmmac: fix dma operation mode config for older versions Joao Pinto
2017-03-22 12:37 ` Corentin Labbe
@ 2017-03-22 22:35 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-03-22 22:35 UTC (permalink / raw)
To: Joao.Pinto
Cc: peppe.cavallaro, alexandre.torgue, clabbe.montjoie,
thierry.reding, sergei.shtylyov, f.fainelli, netdev
From: Joao Pinto <Joao.Pinto@synopsys.com>
Date: Wed, 22 Mar 2017 11:56:05 +0000
> The dma operation mode configuration routine was wrongly moved to a
> function (stmmac_mtl_configuration) that is only executed if the
> core version is >= 4.00.
>
> Fixes: 6deee2221e11 ("net: stmmac: prepare dma op mode config for multiple queues")
> Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> ---
> changes v2->v3:
> - Commit ID and title should be under a 'Fixes' tag
> changes v1->v2:
> - commit id did not have 12 digits
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-22 22:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-22 11:56 [PATCH v3 net-next] net: stmmac: fix dma operation mode config for older versions Joao Pinto
2017-03-22 12:37 ` Corentin Labbe
2017-03-22 22:35 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.