[PATCH 0/3] Basical Lichee Pi Zero with Dock support

[PATCH 0/3] Basical Lichee Pi Zero with Dock support

[Icenowy Zheng]

Lichee Pi Zero have an official dock, which makes use of all stamp hole pins.

Some extra functionalities are availble via the dock, e.g. an extra MMC slot
and some keys connected to LRADC.

This patchset adds the support of these two features of the dock.

Icenowy Zheng (3):
  ARM: sun8i: v3s: add LRADC device node
  ARM: dts: sun8i: add pinmux for V3s mmc1
  ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

 arch/arm/boot/dts/Makefile                         |  3 +-
 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++
 arch/arm/boot/dts/sun8i-v3s.dtsi                   | 15 ++++
 3 files changed, 115 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts

-- 
2.12.0

[PATCH 0/3] Basical Lichee Pi Zero with Dock support

[Icenowy Zheng]

Lichee Pi Zero have an official dock, which makes use of all stamp hole pins.

Some extra functionalities are availble via the dock, e.g. an extra MMC slot
and some keys connected to LRADC.

This patchset adds the support of these two features of the dock.

Icenowy Zheng (3):
  ARM: sun8i: v3s: add LRADC device node
  ARM: dts: sun8i: add pinmux for V3s mmc1
  ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

 arch/arm/boot/dts/Makefile                         |  3 +-
 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++
 arch/arm/boot/dts/sun8i-v3s.dtsi                   | 15 ++++
 3 files changed, 115 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts

-- 
2.12.0

[PATCH 1/3] ARM: sun8i: v3s: add LRADC device node

[Icenowy Zheng]

Allwinner V3s features a LRADC like the ones in older SoCs.

Add a device tree node for it.

Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
---
 arch/arm/boot/dts/sun8i-v3s.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index 71075969e5e6..77bbf5ff9548 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -238,6 +238,13 @@
 			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
+		lradc: lradc@01c22800 {
+			compatible = "allwinner,sun4i-a10-lradc-keys";
+			reg = <0x01c22800 0x400>;
+			interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		uart0: serial@01c28000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x01c28000 0x400>;
-- 
2.12.0

[PATCH 1/3] ARM: sun8i: v3s: add LRADC device node

[Icenowy Zheng]

Allwinner V3s features a LRADC like the ones in older SoCs.

Add a device tree node for it.

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
 arch/arm/boot/dts/sun8i-v3s.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index 71075969e5e6..77bbf5ff9548 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -238,6 +238,13 @@
 			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
+		lradc: lradc at 01c22800 {
+			compatible = "allwinner,sun4i-a10-lradc-keys";
+			reg = <0x01c22800 0x400>;
+			interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		uart0: serial at 01c28000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x01c28000 0x400>;
-- 
2.12.0

[PATCH 2/3] ARM: dts: sun8i: add pinmux for V3s mmc1

[Icenowy Zheng]

Allwinner V3s SoC features 3 MMC controllers, mmc0 is used as the
MicroSD slot on Lichee Pi Zero, and on Lichee Pi Zero's dock mmc1 is
also soldered as a MicroSD slot.

Add the pinmux for mmc1, thus we can enable the MicroSD slot on the
Lichee Pi Zero dock.

Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
---
 arch/arm/boot/dts/sun8i-v3s.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index 77bbf5ff9548..a74667ec1667 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -222,6 +222,14 @@
 				drive-strength = <30>;
 				bias-pull-up;
 			};
+
+			mmc1_pins: mmc1@0 {
+				pins = "PG0", "PG1", "PG2", "PG3",
+				       "PG4", "PG5";
+				function = "mmc1";
+				drive-strength = <30>;
+				bias-pull-up;
+			};
 		};
 
 		timer@01c20c00 {
-- 
2.12.0

[PATCH 2/3] ARM: dts: sun8i: add pinmux for V3s mmc1

[Icenowy Zheng]

Allwinner V3s SoC features 3 MMC controllers, mmc0 is used as the
MicroSD slot on Lichee Pi Zero, and on Lichee Pi Zero's dock mmc1 is
also soldered as a MicroSD slot.

Add the pinmux for mmc1, thus we can enable the MicroSD slot on the
Lichee Pi Zero dock.

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
 arch/arm/boot/dts/sun8i-v3s.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index 77bbf5ff9548..a74667ec1667 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -222,6 +222,14 @@
 				drive-strength = <30>;
 				bias-pull-up;
 			};
+
+			mmc1_pins: mmc1 at 0 {
+				pins = "PG0", "PG1", "PG2", "PG3",
+				       "PG4", "PG5";
+				function = "mmc1";
+				drive-strength = <30>;
+				bias-pull-up;
+			};
 		};
 
 		timer at 01c20c00 {
-- 
2.12.0

[PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

[Icenowy Zheng]

Lichee Pi Zero features a dock, which adds some functions, and should be
soldered with the core board of Lichee Pi Zero.

Add support for the dock as a new dts, as soldering is needed to make
the dock usable and there's functions enabled on the dock that is
unavailable at the 2.54mm pins of the core board.

Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
---
 arch/arm/boot/dts/Makefile                         |  3 +-
 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++
 2 files changed, 100 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 43c27b624f94..de52d403f818 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-h3-orangepi-plus.dtb \
 	sun8i-h3-orangepi-plus2e.dtb \
 	sun8i-r16-parrot.dtb \
-	sun8i-v3s-licheepi-zero.dtb
+	sun8i-v3s-licheepi-zero.dtb \
+	sun8i-v3s-licheepi-zero-dock.dtb
 dtb-$(CONFIG_MACH_SUN9I) += \
 	sun9i-a80-optimus.dtb \
 	sun9i-a80-cubieboard4.dtb
diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
new file mode 100644
index 000000000000..956fa47fde53
--- /dev/null
+++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
@@ -0,0 +1,98 @@
+/*
+ * Copyright (C) 2016 Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "sun8i-v3s-licheepi-zero.dts"
+
+#include <dt-bindings/input/input.h>
+
+/ {
+	model = "Lichee Pi Zero with Dock";
+	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
+		     "allwinner,sun8i-v3s";
+};
+
+&leds {
+	/* The LEDs conflict with MMC1 slot */
+	status = "disabled";
+};
+
+&lradc {
+	vref-supply = <&reg_vcc3v0>;
+	status = "okay";
+
+	button@200 {
+		label = "Volume Up";
+		linux,code = <KEY_VOLUMEUP>;
+		channel = <0>;
+		voltage = <200000>;
+	};
+
+	button@400 {
+		label = "Volume Down";
+		linux,code = <KEY_VOLUMEDOWN>;
+		channel = <0>;
+		voltage = <400000>;
+	};
+
+	button@600 {
+		label = "Select";
+		linux,code = <KEY_SELECT>;
+		channel = <0>;
+		voltage = <600000>;
+	};
+
+	button@800 {
+		label = "Start";
+		linux,code = <KEY_OK>;
+		channel = <0>;
+		voltage = <800000>;
+	};
+};
+
+&mmc1 {
+	pinctrl-0 = <&mmc1_pins>;
+	pinctrl-names = "default";
+	broken-cd;
+	bus-width = <4>;
+	vmmc-supply = <&reg_vcc3v3>;
+	status = "okay";
+};
-- 
2.12.0

[PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

[Icenowy Zheng]

Lichee Pi Zero features a dock, which adds some functions, and should be
soldered with the core board of Lichee Pi Zero.

Add support for the dock as a new dts, as soldering is needed to make
the dock usable and there's functions enabled on the dock that is
unavailable at the 2.54mm pins of the core board.

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
 arch/arm/boot/dts/Makefile                         |  3 +-
 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++
 2 files changed, 100 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 43c27b624f94..de52d403f818 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-h3-orangepi-plus.dtb \
 	sun8i-h3-orangepi-plus2e.dtb \
 	sun8i-r16-parrot.dtb \
-	sun8i-v3s-licheepi-zero.dtb
+	sun8i-v3s-licheepi-zero.dtb \
+	sun8i-v3s-licheepi-zero-dock.dtb
 dtb-$(CONFIG_MACH_SUN9I) += \
 	sun9i-a80-optimus.dtb \
 	sun9i-a80-cubieboard4.dtb
diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
new file mode 100644
index 000000000000..956fa47fde53
--- /dev/null
+++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
@@ -0,0 +1,98 @@
+/*
+ * Copyright (C) 2016 Icenowy Zheng <icenowy@aosc.xyz>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "sun8i-v3s-licheepi-zero.dts"
+
+#include <dt-bindings/input/input.h>
+
+/ {
+	model = "Lichee Pi Zero with Dock";
+	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
+		     "allwinner,sun8i-v3s";
+};
+
+&leds {
+	/* The LEDs conflict with MMC1 slot */
+	status = "disabled";
+};
+
+&lradc {
+	vref-supply = <&reg_vcc3v0>;
+	status = "okay";
+
+	button at 200 {
+		label = "Volume Up";
+		linux,code = <KEY_VOLUMEUP>;
+		channel = <0>;
+		voltage = <200000>;
+	};
+
+	button at 400 {
+		label = "Volume Down";
+		linux,code = <KEY_VOLUMEDOWN>;
+		channel = <0>;
+		voltage = <400000>;
+	};
+
+	button at 600 {
+		label = "Select";
+		linux,code = <KEY_SELECT>;
+		channel = <0>;
+		voltage = <600000>;
+	};
+
+	button at 800 {
+		label = "Start";
+		linux,code = <KEY_OK>;
+		channel = <0>;
+		voltage = <800000>;
+	};
+};
+
+&mmc1 {
+	pinctrl-0 = <&mmc1_pins>;
+	pinctrl-names = "default";
+	broken-cd;
+	bus-width = <4>;
+	vmmc-supply = <&reg_vcc3v3>;
+	status = "okay";
+};
-- 
2.12.0

Re: [PATCH 0/3] Basical Lichee Pi Zero with Dock support

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

Hi,

On Fri, Mar 17, 2017 at 11:43:40PM +0800, Icenowy Zheng wrote:
> Lichee Pi Zero have an official dock, which makes use of all stamp hole pins.
> 
> Some extra functionalities are availble via the dock, e.g. an extra
> MMC slot and some keys connected to LRADC.
> 
> This patchset adds the support of these two features of the dock.

I'm a bit skeptical about the whole approach to have a split DTS for
expansion boards.

This is not fundamentally different than having expansion boards, that
we already deal with with overlays. This one is just bigger.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 0/3] Basical Lichee Pi Zero with Dock support

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

Hi,

On Fri, Mar 17, 2017 at 11:43:40PM +0800, Icenowy Zheng wrote:
> Lichee Pi Zero have an official dock, which makes use of all stamp hole pins.
> 
> Some extra functionalities are availble via the dock, e.g. an extra
> MMC slot and some keys connected to LRADC.
> 
> This patchset adds the support of these two features of the dock.

I'm a bit skeptical about the whole approach to have a split DTS for
expansion boards.

This is not fundamentally different than having expansion boards, that
we already deal with with overlays. This one is just bigger.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[PATCH 0/3] Basical Lichee Pi Zero with Dock support

[Maxime Ripard]

Hi,

On Fri, Mar 17, 2017 at 11:43:40PM +0800, Icenowy Zheng wrote:
> Lichee Pi Zero have an official dock, which makes use of all stamp hole pins.
> 
> Some extra functionalities are availble via the dock, e.g. an extra
> MMC slot and some keys connected to LRADC.
> 
> This patchset adds the support of these two features of the dock.

I'm a bit skeptical about the whole approach to have a split DTS for
expansion boards.

This is not fundamentally different than having expansion boards, that
we already deal with with overlays. This one is just bigger.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170320/31466216/attachment.sig>

Re: [PATCH 1/3] ARM: sun8i: v3s: add LRADC device node

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Fri, Mar 17, 2017 at 11:43:41PM +0800, Icenowy Zheng wrote:
> Allwinner V3s features a LRADC like the ones in older SoCs.
> 
> Add a device tree node for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  arch/arm/boot/dts/sun8i-v3s.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
> index 71075969e5e6..77bbf5ff9548 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -238,6 +238,13 @@
>  			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>  		};
>  
> +		lradc: lradc@01c22800 {

The node name should reflect the class of the device, so something like adc@..

> +			compatible = "allwinner,sun4i-a10-lradc-keys";

Please put a SoC-specific compatible there.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 1/3] ARM: sun8i: v3s: add LRADC device node

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

On Fri, Mar 17, 2017 at 11:43:41PM +0800, Icenowy Zheng wrote:
> Allwinner V3s features a LRADC like the ones in older SoCs.
> 
> Add a device tree node for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun8i-v3s.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
> index 71075969e5e6..77bbf5ff9548 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -238,6 +238,13 @@
>  			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>  		};
>  
> +		lradc: lradc@01c22800 {

The node name should reflect the class of the device, so something like adc@..

> +			compatible = "allwinner,sun4i-a10-lradc-keys";

Please put a SoC-specific compatible there.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[PATCH 1/3] ARM: sun8i: v3s: add LRADC device node

[Maxime Ripard]

On Fri, Mar 17, 2017 at 11:43:41PM +0800, Icenowy Zheng wrote:
> Allwinner V3s features a LRADC like the ones in older SoCs.
> 
> Add a device tree node for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  arch/arm/boot/dts/sun8i-v3s.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
> index 71075969e5e6..77bbf5ff9548 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -238,6 +238,13 @@
>  			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>  		};
>  
> +		lradc: lradc at 01c22800 {

The node name should reflect the class of the device, so something like adc at ..

> +			compatible = "allwinner,sun4i-a10-lradc-keys";

Please put a SoC-specific compatible there.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170322/2be98fab/attachment-0001.sig>

Re: [PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 4295 bytes --]

On Fri, Mar 17, 2017 at 11:43:43PM +0800, Icenowy Zheng wrote:
> Lichee Pi Zero features a dock, which adds some functions, and should be
> soldered with the core board of Lichee Pi Zero.
> 
> Add support for the dock as a new dts, as soldering is needed to make
> the dock usable and there's functions enabled on the dock that is
> unavailable at the 2.54mm pins of the core board.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  arch/arm/boot/dts/Makefile                         |  3 +-
>  arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++
>  2 files changed, 100 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 43c27b624f94..de52d403f818 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \
>  	sun8i-h3-orangepi-plus.dtb \
>  	sun8i-h3-orangepi-plus2e.dtb \
>  	sun8i-r16-parrot.dtb \
> -	sun8i-v3s-licheepi-zero.dtb
> +	sun8i-v3s-licheepi-zero.dtb \
> +	sun8i-v3s-licheepi-zero-dock.dtb
>  dtb-$(CONFIG_MACH_SUN9I) += \
>  	sun9i-a80-optimus.dtb \
>  	sun9i-a80-cubieboard4.dtb
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> new file mode 100644
> index 000000000000..956fa47fde53
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -0,0 +1,98 @@
> +/*
> + * Copyright (C) 2016 Icenowy Zheng <icenowy@aosc.xyz>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include "sun8i-v3s-licheepi-zero.dts"
> +
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> +	model = "Lichee Pi Zero with Dock";
> +	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
> +		     "allwinner,sun8i-v3s";
> +};
> +
> +&leds {
> +	/* The LEDs conflict with MMC1 slot */

How does it conflicts?

> +&mmc1 {
> +	pinctrl-0 = <&mmc1_pins>;
> +	pinctrl-names = "default";
> +	broken-cd;

There's no card-detect on a GPIO?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 4229 bytes --]

On Fri, Mar 17, 2017 at 11:43:43PM +0800, Icenowy Zheng wrote:
> Lichee Pi Zero features a dock, which adds some functions, and should be
> soldered with the core board of Lichee Pi Zero.
> 
> Add support for the dock as a new dts, as soldering is needed to make
> the dock usable and there's functions enabled on the dock that is
> unavailable at the 2.54mm pins of the core board.
> 
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> ---
>  arch/arm/boot/dts/Makefile                         |  3 +-
>  arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++
>  2 files changed, 100 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 43c27b624f94..de52d403f818 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \
>  	sun8i-h3-orangepi-plus.dtb \
>  	sun8i-h3-orangepi-plus2e.dtb \
>  	sun8i-r16-parrot.dtb \
> -	sun8i-v3s-licheepi-zero.dtb
> +	sun8i-v3s-licheepi-zero.dtb \
> +	sun8i-v3s-licheepi-zero-dock.dtb
>  dtb-$(CONFIG_MACH_SUN9I) += \
>  	sun9i-a80-optimus.dtb \
>  	sun9i-a80-cubieboard4.dtb
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> new file mode 100644
> index 000000000000..956fa47fde53
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -0,0 +1,98 @@
> +/*
> + * Copyright (C) 2016 Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include "sun8i-v3s-licheepi-zero.dts"
> +
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> +	model = "Lichee Pi Zero with Dock";
> +	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
> +		     "allwinner,sun8i-v3s";
> +};
> +
> +&leds {
> +	/* The LEDs conflict with MMC1 slot */

How does it conflicts?

> +&mmc1 {
> +	pinctrl-0 = <&mmc1_pins>;
> +	pinctrl-names = "default";
> +	broken-cd;

There's no card-detect on a GPIO?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

[Maxime Ripard]

On Fri, Mar 17, 2017 at 11:43:43PM +0800, Icenowy Zheng wrote:
> Lichee Pi Zero features a dock, which adds some functions, and should be
> soldered with the core board of Lichee Pi Zero.
> 
> Add support for the dock as a new dts, as soldering is needed to make
> the dock usable and there's functions enabled on the dock that is
> unavailable at the 2.54mm pins of the core board.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  arch/arm/boot/dts/Makefile                         |  3 +-
>  arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++
>  2 files changed, 100 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 43c27b624f94..de52d403f818 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \
>  	sun8i-h3-orangepi-plus.dtb \
>  	sun8i-h3-orangepi-plus2e.dtb \
>  	sun8i-r16-parrot.dtb \
> -	sun8i-v3s-licheepi-zero.dtb
> +	sun8i-v3s-licheepi-zero.dtb \
> +	sun8i-v3s-licheepi-zero-dock.dtb
>  dtb-$(CONFIG_MACH_SUN9I) += \
>  	sun9i-a80-optimus.dtb \
>  	sun9i-a80-cubieboard4.dtb
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> new file mode 100644
> index 000000000000..956fa47fde53
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -0,0 +1,98 @@
> +/*
> + * Copyright (C) 2016 Icenowy Zheng <icenowy@aosc.xyz>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include "sun8i-v3s-licheepi-zero.dts"
> +
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> +	model = "Lichee Pi Zero with Dock";
> +	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
> +		     "allwinner,sun8i-v3s";
> +};
> +
> +&leds {
> +	/* The LEDs conflict with MMC1 slot */

How does it conflicts?

> +&mmc1 {
> +	pinctrl-0 = <&mmc1_pins>;
> +	pinctrl-names = "default";
> +	broken-cd;

There's no card-detect on a GPIO?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170322/6f99466b/attachment.sig>

Re: [PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 5234 bytes --]

On Thu, Mar 23, 2017 at 03:34:18AM +0800, Icenowy Zheng wrote:
> 
> 2017年3月23日 03:24于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
> >
> > On Fri, Mar 17, 2017 at 11:43:43PM +0800, Icenowy Zheng wrote: 
> > > Lichee Pi Zero features a dock, which adds some functions, and should be 
> > > soldered with the core board of Lichee Pi Zero. 
> > > 
> > > Add support for the dock as a new dts, as soldering is needed to make 
> > > the dock usable and there's functions enabled on the dock that is 
> > > unavailable at the 2.54mm pins of the core board. 
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> 
> > > --- 
> > >  arch/arm/boot/dts/Makefile                         |  3 +- 
> > >  arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++ 
> > >  2 files changed, 100 insertions(+), 1 deletion(-) 
> > >  create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > > 
> > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
> > > index 43c27b624f94..de52d403f818 100644 
> > > --- a/arch/arm/boot/dts/Makefile 
> > > +++ b/arch/arm/boot/dts/Makefile 
> > > @@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \ 
> > >  sun8i-h3-orangepi-plus.dtb \ 
> > >  sun8i-h3-orangepi-plus2e.dtb \ 
> > >  sun8i-r16-parrot.dtb \ 
> > > - sun8i-v3s-licheepi-zero.dtb 
> > > + sun8i-v3s-licheepi-zero.dtb \ 
> > > + sun8i-v3s-licheepi-zero-dock.dtb 
> > >  dtb-$(CONFIG_MACH_SUN9I) += \ 
> > >  sun9i-a80-optimus.dtb \ 
> > >  sun9i-a80-cubieboard4.dtb 
> > > diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > > new file mode 100644 
> > > index 000000000000..956fa47fde53 
> > > --- /dev/null 
> > > +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > > @@ -0,0 +1,98 @@ 
> > > +/* 
> > > + * Copyright (C) 2016 Icenowy Zheng <icenowy@aosc.xyz> 
> > > + * 
> > > + * This file is dual-licensed: you can use it either under the terms 
> > > + * of the GPL or the X11 license, at your option. Note that this dual 
> > > + * licensing only applies to this file, and not this project as a 
> > > + * whole. 
> > > + * 
> > > + *  a) This file is free software; you can redistribute it and/or 
> > > + *     modify it under the terms of the GNU General Public License as 
> > > + *     published by the Free Software Foundation; either version 2 of the 
> > > + *     License, or (at your option) any later version. 
> > > + * 
> > > + *     This file is distributed in the hope that it will be useful, 
> > > + *     but WITHOUT ANY WARRANTY; without even the implied warranty of 
> > > + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the 
> > > + *     GNU General Public License for more details. 
> > > + * 
> > > + * Or, alternatively, 
> > > + * 
> > > + *  b) Permission is hereby granted, free of charge, to any person 
> > > + *     obtaining a copy of this software and associated documentation 
> > > + *     files (the "Software"), to deal in the Software without 
> > > + *     restriction, including without limitation the rights to use, 
> > > + *     copy, modify, merge, publish, distribute, sublicense, and/or 
> > > + *     sell copies of the Software, and to permit persons to whom the 
> > > + *     Software is furnished to do so, subject to the following 
> > > + *     conditions: 
> > > + * 
> > > + *     The above copyright notice and this permission notice shall be 
> > > + *     included in all copies or substantial portions of the Software. 
> > > + * 
> > > + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, 
> > > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES 
> > > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND 
> > > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT 
> > > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, 
> > > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
> > > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR 
> > > + *     OTHER DEALINGS IN THE SOFTWARE. 
> > > + */ 
> > > + 
> > > +#include "sun8i-v3s-licheepi-zero.dts" 
> > > + 
> > > +#include <dt-bindings/input/input.h> 
> > > + 
> > > +/ { 
> > > + model = "Lichee Pi Zero with Dock"; 
> > > + compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero", 
> > > +      "allwinner,sun8i-v3s"; 
> > > +}; 
> > > + 
> > > +&leds { 
> > > + /* The LEDs conflict with MMC1 slot */ 
> >
> > How does it conflicts? 
> 
> They both use PGx.

So they use the same bank? How is that a conflict?

> > > +&mmc1 { 
> > > + pinctrl-0 = <&mmc1_pins>; 
> > > + pinctrl-names = "default"; 
> > > + broken-cd; 
> >
> > There's no card-detect on a GPIO? 
> 
> Yes.
> 
> All SD slots on Lichee Pi series have no card-detect.

Weird... Ok.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 5627 bytes --]

On Thu, Mar 23, 2017 at 03:34:18AM +0800, Icenowy Zheng wrote:
> 
> 2017年3月23日 03:24于 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>写道：
> >
> > On Fri, Mar 17, 2017 at 11:43:43PM +0800, Icenowy Zheng wrote: 
> > > Lichee Pi Zero features a dock, which adds some functions, and should be 
> > > soldered with the core board of Lichee Pi Zero. 
> > > 
> > > Add support for the dock as a new dts, as soldering is needed to make 
> > > the dock usable and there's functions enabled on the dock that is 
> > > unavailable at the 2.54mm pins of the core board. 
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> 
> > > --- 
> > >  arch/arm/boot/dts/Makefile                         |  3 +- 
> > >  arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++ 
> > >  2 files changed, 100 insertions(+), 1 deletion(-) 
> > >  create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > > 
> > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
> > > index 43c27b624f94..de52d403f818 100644 
> > > --- a/arch/arm/boot/dts/Makefile 
> > > +++ b/arch/arm/boot/dts/Makefile 
> > > @@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \ 
> > >  sun8i-h3-orangepi-plus.dtb \ 
> > >  sun8i-h3-orangepi-plus2e.dtb \ 
> > >  sun8i-r16-parrot.dtb \ 
> > > - sun8i-v3s-licheepi-zero.dtb 
> > > + sun8i-v3s-licheepi-zero.dtb \ 
> > > + sun8i-v3s-licheepi-zero-dock.dtb 
> > >  dtb-$(CONFIG_MACH_SUN9I) += \ 
> > >  sun9i-a80-optimus.dtb \ 
> > >  sun9i-a80-cubieboard4.dtb 
> > > diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > > new file mode 100644 
> > > index 000000000000..956fa47fde53 
> > > --- /dev/null 
> > > +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > > @@ -0,0 +1,98 @@ 
> > > +/* 
> > > + * Copyright (C) 2016 Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> 
> > > + * 
> > > + * This file is dual-licensed: you can use it either under the terms 
> > > + * of the GPL or the X11 license, at your option. Note that this dual 
> > > + * licensing only applies to this file, and not this project as a 
> > > + * whole. 
> > > + * 
> > > + *  a) This file is free software; you can redistribute it and/or 
> > > + *     modify it under the terms of the GNU General Public License as 
> > > + *     published by the Free Software Foundation; either version 2 of the 
> > > + *     License, or (at your option) any later version. 
> > > + * 
> > > + *     This file is distributed in the hope that it will be useful, 
> > > + *     but WITHOUT ANY WARRANTY; without even the implied warranty of 
> > > + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the 
> > > + *     GNU General Public License for more details. 
> > > + * 
> > > + * Or, alternatively, 
> > > + * 
> > > + *  b) Permission is hereby granted, free of charge, to any person 
> > > + *     obtaining a copy of this software and associated documentation 
> > > + *     files (the "Software"), to deal in the Software without 
> > > + *     restriction, including without limitation the rights to use, 
> > > + *     copy, modify, merge, publish, distribute, sublicense, and/or 
> > > + *     sell copies of the Software, and to permit persons to whom the 
> > > + *     Software is furnished to do so, subject to the following 
> > > + *     conditions: 
> > > + * 
> > > + *     The above copyright notice and this permission notice shall be 
> > > + *     included in all copies or substantial portions of the Software. 
> > > + * 
> > > + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, 
> > > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES 
> > > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND 
> > > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT 
> > > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, 
> > > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
> > > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR 
> > > + *     OTHER DEALINGS IN THE SOFTWARE. 
> > > + */ 
> > > + 
> > > +#include "sun8i-v3s-licheepi-zero.dts" 
> > > + 
> > > +#include <dt-bindings/input/input.h> 
> > > + 
> > > +/ { 
> > > + model = "Lichee Pi Zero with Dock"; 
> > > + compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero", 
> > > +      "allwinner,sun8i-v3s"; 
> > > +}; 
> > > + 
> > > +&leds { 
> > > + /* The LEDs conflict with MMC1 slot */ 
> >
> > How does it conflicts? 
> 
> They both use PGx.

So they use the same bank? How is that a conflict?

> > > +&mmc1 { 
> > > + pinctrl-0 = <&mmc1_pins>; 
> > > + pinctrl-names = "default"; 
> > > + broken-cd; 
> >
> > There's no card-detect on a GPIO? 
> 
> Yes.
> 
> All SD slots on Lichee Pi series have no card-detect.

Weird... Ok.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

[Maxime Ripard]

On Thu, Mar 23, 2017 at 03:34:18AM +0800, Icenowy Zheng wrote:
> 
> 2017?3?23? 03:24? Maxime Ripard <maxime.ripard@free-electrons.com>???
> >
> > On Fri, Mar 17, 2017 at 11:43:43PM +0800, Icenowy Zheng wrote: 
> > > Lichee Pi Zero features a dock, which adds some functions, and should be 
> > > soldered with the core board of Lichee Pi Zero. 
> > > 
> > > Add support for the dock as a new dts, as soldering is needed to make 
> > > the dock usable and there's functions enabled on the dock that is 
> > > unavailable at the 2.54mm pins of the core board. 
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> 
> > > --- 
> > >? arch/arm/boot/dts/Makefile???????????????????????? |? 3 +- 
> > >? arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++ 
> > >? 2 files changed, 100 insertions(+), 1 deletion(-) 
> > >? create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > > 
> > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
> > > index 43c27b624f94..de52d403f818 100644 
> > > --- a/arch/arm/boot/dts/Makefile 
> > > +++ b/arch/arm/boot/dts/Makefile 
> > > @@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \ 
> > >? sun8i-h3-orangepi-plus.dtb \ 
> > >? sun8i-h3-orangepi-plus2e.dtb \ 
> > >? sun8i-r16-parrot.dtb \ 
> > > - sun8i-v3s-licheepi-zero.dtb 
> > > + sun8i-v3s-licheepi-zero.dtb \ 
> > > + sun8i-v3s-licheepi-zero-dock.dtb 
> > >? dtb-$(CONFIG_MACH_SUN9I) += \ 
> > >? sun9i-a80-optimus.dtb \ 
> > >? sun9i-a80-cubieboard4.dtb 
> > > diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > > new file mode 100644 
> > > index 000000000000..956fa47fde53 
> > > --- /dev/null 
> > > +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > > @@ -0,0 +1,98 @@ 
> > > +/* 
> > > + * Copyright (C) 2016 Icenowy Zheng <icenowy@aosc.xyz> 
> > > + * 
> > > + * This file is dual-licensed: you can use it either under the terms 
> > > + * of the GPL or the X11 license, at your option. Note that this dual 
> > > + * licensing only applies to this file, and not this project as a 
> > > + * whole. 
> > > + * 
> > > + *? a) This file is free software; you can redistribute it and/or 
> > > + *???? modify it under the terms of the GNU General Public License as 
> > > + *???? published by the Free Software Foundation; either version 2 of the 
> > > + *???? License, or (at your option) any later version. 
> > > + * 
> > > + *???? This file is distributed in the hope that it will be useful, 
> > > + *???? but WITHOUT ANY WARRANTY; without even the implied warranty of 
> > > + *???? MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.? See the 
> > > + *???? GNU General Public License for more details. 
> > > + * 
> > > + * Or, alternatively, 
> > > + * 
> > > + *? b) Permission is hereby granted, free of charge, to any person 
> > > + *???? obtaining a copy of this software and associated documentation 
> > > + *???? files (the "Software"), to deal in the Software without 
> > > + *???? restriction, including without limitation the rights to use, 
> > > + *???? copy, modify, merge, publish, distribute, sublicense, and/or 
> > > + *???? sell copies of the Software, and to permit persons to whom the 
> > > + *???? Software is furnished to do so, subject to the following 
> > > + *???? conditions: 
> > > + * 
> > > + *???? The above copyright notice and this permission notice shall be 
> > > + *???? included in all copies or substantial portions of the Software. 
> > > + * 
> > > + *???? THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, 
> > > + *???? EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES 
> > > + *???? OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND 
> > > + *???? NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT 
> > > + *???? HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, 
> > > + *???? WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
> > > + *???? FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR 
> > > + *???? OTHER DEALINGS IN THE SOFTWARE. 
> > > + */ 
> > > + 
> > > +#include "sun8i-v3s-licheepi-zero.dts" 
> > > + 
> > > +#include <dt-bindings/input/input.h> 
> > > + 
> > > +/ { 
> > > + model = "Lichee Pi Zero with Dock"; 
> > > + compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero", 
> > > + ???? "allwinner,sun8i-v3s"; 
> > > +}; 
> > > + 
> > > +&leds { 
> > > + /* The LEDs conflict with MMC1 slot */ 
> >
> > How does it conflicts? 
> 
> They both use PGx.

So they use the same bank? How is that a conflict?

> > > +&mmc1 { 
> > > + pinctrl-0 = <&mmc1_pins>; 
> > > + pinctrl-names = "default"; 
> > > + broken-cd; 
> >
> > There's no card-detect on a GPIO? 
> 
> Yes.
> 
> All SD slots on Lichee Pi series have no card-detect.

Weird... Ok.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170324/50613656/attachment.sig>

Re: [PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock

[Icenowy Zheng]

2017年3月23日 03:24于 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>写道：
>
> On Fri, Mar 17, 2017 at 11:43:43PM +0800, Icenowy Zheng wrote: 
> > Lichee Pi Zero features a dock, which adds some functions, and should be 
> > soldered with the core board of Lichee Pi Zero. 
> > 
> > Add support for the dock as a new dts, as soldering is needed to make 
> > the dock usable and there's functions enabled on the dock that is 
> > unavailable at the 2.54mm pins of the core board. 
> > 
> > Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> 
> > --- 
> >  arch/arm/boot/dts/Makefile                         |  3 +- 
> >  arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 ++++++++++++++++++++++ 
> >  2 files changed, 100 insertions(+), 1 deletion(-) 
> >  create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
> > index 43c27b624f94..de52d403f818 100644 
> > --- a/arch/arm/boot/dts/Makefile 
> > +++ b/arch/arm/boot/dts/Makefile 
> > @@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \ 
> >  sun8i-h3-orangepi-plus.dtb \ 
> >  sun8i-h3-orangepi-plus2e.dtb \ 
> >  sun8i-r16-parrot.dtb \ 
> > - sun8i-v3s-licheepi-zero.dtb 
> > + sun8i-v3s-licheepi-zero.dtb \ 
> > + sun8i-v3s-licheepi-zero-dock.dtb 
> >  dtb-$(CONFIG_MACH_SUN9I) += \ 
> >  sun9i-a80-optimus.dtb \ 
> >  sun9i-a80-cubieboard4.dtb 
> > diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > new file mode 100644 
> > index 000000000000..956fa47fde53 
> > --- /dev/null 
> > +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts 
> > @@ -0,0 +1,98 @@ 
> > +/* 
> > + * Copyright (C) 2016 Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> 
> > + * 
> > + * This file is dual-licensed: you can use it either under the terms 
> > + * of the GPL or the X11 license, at your option. Note that this dual 
> > + * licensing only applies to this file, and not this project as a 
> > + * whole. 
> > + * 
> > + *  a) This file is free software; you can redistribute it and/or 
> > + *     modify it under the terms of the GNU General Public License as 
> > + *     published by the Free Software Foundation; either version 2 of the 
> > + *     License, or (at your option) any later version. 
> > + * 
> > + *     This file is distributed in the hope that it will be useful, 
> > + *     but WITHOUT ANY WARRANTY; without even the implied warranty of 
> > + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the 
> > + *     GNU General Public License for more details. 
> > + * 
> > + * Or, alternatively, 
> > + * 
> > + *  b) Permission is hereby granted, free of charge, to any person 
> > + *     obtaining a copy of this software and associated documentation 
> > + *     files (the "Software"), to deal in the Software without 
> > + *     restriction, including without limitation the rights to use, 
> > + *     copy, modify, merge, publish, distribute, sublicense, and/or 
> > + *     sell copies of the Software, and to permit persons to whom the 
> > + *     Software is furnished to do so, subject to the following 
> > + *     conditions: 
> > + * 
> > + *     The above copyright notice and this permission notice shall be 
> > + *     included in all copies or substantial portions of the Software. 
> > + * 
> > + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, 
> > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES 
> > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND 
> > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT 
> > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, 
> > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
> > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR 
> > + *     OTHER DEALINGS IN THE SOFTWARE. 
> > + */ 
> > + 
> > +#include "sun8i-v3s-licheepi-zero.dts" 
> > + 
> > +#include <dt-bindings/input/input.h> 
> > + 
> > +/ { 
> > + model = "Lichee Pi Zero with Dock"; 
> > + compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero", 
> > +      "allwinner,sun8i-v3s"; 
> > +}; 
> > + 
> > +&leds { 
> > + /* The LEDs conflict with MMC1 slot */ 
>
> How does it conflicts? 

They both use PGx.

>
> > +&mmc1 { 
> > + pinctrl-0 = <&mmc1_pins>; 
> > + pinctrl-names = "default"; 
> > + broken-cd; 
>
> There's no card-detect on a GPIO? 

Yes.

All SD slots on Lichee Pi series have no card-detect.

>
> Maxime 
>
> -- 
> Maxime Ripard, Free Electrons 
> Embedded Linux and Kernel engineering 
> http://free-electrons.com 

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.