* [PATCH] PCI: Pull struct pci_ops definition
@ 2017-03-17 14:53 Marc Gonzalez
2017-03-22 10:18 ` Marc Gonzalez
2017-03-23 13:45 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Marc Gonzalez @ 2017-03-17 14:53 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Lorenzo Pieralisi, Jayachandran C
struct pci_ecam_ops embeds a struct pci_ops. Explicitly request the
definition for struct pci_ops, otherwise gcc might complain:
include/linux/pci-ecam.h:29:19: error: field 'pci_ops' has incomplete type
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
include/linux/pci-ecam.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/pci-ecam.h b/include/linux/pci-ecam.h
index 7adad206b1f4..33c4750781a0 100644
--- a/include/linux/pci-ecam.h
+++ b/include/linux/pci-ecam.h
@@ -16,6 +16,7 @@
#ifndef DRIVERS_PCI_ECAM_H
#define DRIVERS_PCI_ECAM_H
+#include <linux/pci.h>
#include <linux/kernel.h>
#include <linux/platform_device.h>
--
2.10.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: Pull struct pci_ops definition
2017-03-17 14:53 [PATCH] PCI: Pull struct pci_ops definition Marc Gonzalez
@ 2017-03-22 10:18 ` Marc Gonzalez
2017-03-23 13:45 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Marc Gonzalez @ 2017-03-22 10:18 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Lorenzo Pieralisi, Jayachandran C, Arnd Bergmann
On 17/03/2017 15:53, Marc Gonzalez wrote:
> struct pci_ecam_ops embeds a struct pci_ops. Explicitly request the
> definition for struct pci_ops, otherwise gcc might complain:
>
> include/linux/pci-ecam.h:29:19: error: field 'pci_ops' has incomplete type
>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---
> include/linux/pci-ecam.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/pci-ecam.h b/include/linux/pci-ecam.h
> index 7adad206b1f4..33c4750781a0 100644
> --- a/include/linux/pci-ecam.h
> +++ b/include/linux/pci-ecam.h
> @@ -16,6 +16,7 @@
> #ifndef DRIVERS_PCI_ECAM_H
> #define DRIVERS_PCI_ECAM_H
>
> +#include <linux/pci.h>
> #include <linux/kernel.h>
> #include <linux/platform_device.h>
>
Hello Bjorn,
Can you take this trivial patch?
Regards.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: Pull struct pci_ops definition
2017-03-17 14:53 [PATCH] PCI: Pull struct pci_ops definition Marc Gonzalez
2017-03-22 10:18 ` Marc Gonzalez
@ 2017-03-23 13:45 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2017-03-23 13:45 UTC (permalink / raw)
To: Marc Gonzalez; +Cc: linux-pci, Lorenzo Pieralisi, Jayachandran C
On Fri, Mar 17, 2017 at 03:53:19PM +0100, Marc Gonzalez wrote:
> struct pci_ecam_ops embeds a struct pci_ops. Explicitly request the
> definition for struct pci_ops, otherwise gcc might complain:
>
> include/linux/pci-ecam.h:29:19: error: field 'pci_ops' has incomplete type
>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Applied to pci/misc for v4.12, thanks!
> ---
> include/linux/pci-ecam.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/pci-ecam.h b/include/linux/pci-ecam.h
> index 7adad206b1f4..33c4750781a0 100644
> --- a/include/linux/pci-ecam.h
> +++ b/include/linux/pci-ecam.h
> @@ -16,6 +16,7 @@
> #ifndef DRIVERS_PCI_ECAM_H
> #define DRIVERS_PCI_ECAM_H
>
> +#include <linux/pci.h>
> #include <linux/kernel.h>
> #include <linux/platform_device.h>
>
> --
> 2.10.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-23 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-17 14:53 [PATCH] PCI: Pull struct pci_ops definition Marc Gonzalez
2017-03-22 10:18 ` Marc Gonzalez
2017-03-23 13:45 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.