* [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE @ 2017-03-16 14:19 Andy Shevchenko 2017-03-23 11:21 ` Lee Jones 0 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2017-03-16 14:19 UTC (permalink / raw) To: Lee Jones, linux-kernel; +Cc: Andy Shevchenko There is a potential flaw if cell has id > 0 and is going to be registered with PLATFORM_DEVID_NONE. Ignore if PLATFORM_DEVID_NONE is supplied. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/mfd/mfd-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index c57e407020f1..c9583f895058 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -149,7 +149,7 @@ static int mfd_add_device(struct device *parent, int id, int platform_id; int r; - if (id == PLATFORM_DEVID_AUTO) + if (id < 0) platform_id = id; else platform_id = id + cell->id; -- 2.11.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE 2017-03-16 14:19 [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE Andy Shevchenko @ 2017-03-23 11:21 ` Lee Jones 2017-03-23 13:09 ` Andy Shevchenko 0 siblings, 1 reply; 6+ messages in thread From: Lee Jones @ 2017-03-23 11:21 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-kernel On Thu, 16 Mar 2017, Andy Shevchenko wrote: > There is a potential flaw if cell has id > 0 and is going to be > registered with PLATFORM_DEVID_NONE. > > Ignore if PLATFORM_DEVID_NONE is supplied. This is a substantial change to a pretty tried and tested piece of sub-system code. Can you put some more meat on the bones in the commit log, and include examples. > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/mfd/mfd-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > index c57e407020f1..c9583f895058 100644 > --- a/drivers/mfd/mfd-core.c > +++ b/drivers/mfd/mfd-core.c > @@ -149,7 +149,7 @@ static int mfd_add_device(struct device *parent, int id, > int platform_id; > int r; > > - if (id == PLATFORM_DEVID_AUTO) > + if (id < 0) > platform_id = id; > else > platform_id = id + cell->id; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE 2017-03-23 11:21 ` Lee Jones @ 2017-03-23 13:09 ` Andy Shevchenko 2017-03-24 11:35 ` Lee Jones 0 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2017-03-23 13:09 UTC (permalink / raw) To: Lee Jones; +Cc: linux-kernel On Thu, 2017-03-23 at 11:21 +0000, Lee Jones wrote: > On Thu, 16 Mar 2017, Andy Shevchenko wrote: > > > There is a potential flaw if cell has id > 0 and is going to be > > registered with PLATFORM_DEVID_NONE. > > > > Ignore if PLATFORM_DEVID_NONE is supplied. > > This is a substantial change to a pretty tried and tested piece of > sub-system code. Can you put some more meat on the bones in the > commit log, and include examples. Example in pseudo code: cells = { [0] = { .id = 0, .name = "moduleX", }, [1] = { .id = 1, .name = "moduleY", }, [2] = { .id = 2, .name = "moduleZ", }, ... }; mfd_add_devices(..., PLATFORM_DEVID_NONE, cells, ARRAY_SIZE(cells), ...); Output (names of the devices in the drivers): "moduleX" "moduleY.0" "moduleX.1" Desired output: "moduleX" "moduleY" "moduleZ" Is it by design? > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/mfd/mfd-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > > index c57e407020f1..c9583f895058 100644 > > --- a/drivers/mfd/mfd-core.c > > +++ b/drivers/mfd/mfd-core.c > > @@ -149,7 +149,7 @@ static int mfd_add_device(struct device *parent, > > int id, > > int platform_id; > > int r; > > > > - if (id == PLATFORM_DEVID_AUTO) > > + if (id < 0) > > platform_id = id; > > else > > platform_id = id + cell->id; > > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE 2017-03-23 13:09 ` Andy Shevchenko @ 2017-03-24 11:35 ` Lee Jones 2017-03-26 12:53 ` Andy Shevchenko 0 siblings, 1 reply; 6+ messages in thread From: Lee Jones @ 2017-03-24 11:35 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-kernel On Thu, 23 Mar 2017, Andy Shevchenko wrote: > On Thu, 2017-03-23 at 11:21 +0000, Lee Jones wrote: > > On Thu, 16 Mar 2017, Andy Shevchenko wrote: > > > > > There is a potential flaw if cell has id > 0 and is going to be > > > registered with PLATFORM_DEVID_NONE. > > > > > > Ignore if PLATFORM_DEVID_NONE is supplied. > > > > This is a substantial change to a pretty tried and tested piece of > > sub-system code. Can you put some more meat on the bones in the > > commit log, and include examples. > > Example in pseudo code: > > cells = { > [0] = { .id = 0, .name = "moduleX", }, > [1] = { .id = 1, .name = "moduleY", }, > [2] = { .id = 2, .name = "moduleZ", }, > ... > }; > > mfd_add_devices(..., PLATFORM_DEVID_NONE, cells, ARRAY_SIZE(cells), > ...); > > Output (names of the devices in the drivers): > "moduleX" > "moduleY.0" > "moduleX.1" > > Desired output: > "moduleX" > "moduleY" > "moduleZ" Then what would be your reason for populating the 'id' attribute? > Is it by design? > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > --- > > > drivers/mfd/mfd-core.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > > > index c57e407020f1..c9583f895058 100644 > > > --- a/drivers/mfd/mfd-core.c > > > +++ b/drivers/mfd/mfd-core.c > > > @@ -149,7 +149,7 @@ static int mfd_add_device(struct device *parent, > > > int id, > > > int platform_id; > > > int r; > > > > > > - if (id == PLATFORM_DEVID_AUTO) > > > + if (id < 0) > > > platform_id = id; > > > else > > > platform_id = id + cell->id; > > > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE 2017-03-24 11:35 ` Lee Jones @ 2017-03-26 12:53 ` Andy Shevchenko 2017-03-27 12:41 ` Lee Jones 0 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2017-03-26 12:53 UTC (permalink / raw) To: Lee Jones; +Cc: linux-kernel On Fri, 2017-03-24 at 11:35 +0000, Lee Jones wrote: > On Thu, 23 Mar 2017, Andy Shevchenko wrote: > > > On Thu, 2017-03-23 at 11:21 +0000, Lee Jones wrote: > > > On Thu, 16 Mar 2017, Andy Shevchenko wrote: > > > > > > > There is a potential flaw if cell has id > 0 and is going to be > > > > registered with PLATFORM_DEVID_NONE. > > > > > > > > Ignore if PLATFORM_DEVID_NONE is supplied. > > > > > > This is a substantial change to a pretty tried and tested piece of > > > sub-system code. Can you put some more meat on the bones in the > > > commit log, and include examples. > > > > Example in pseudo code: > > > > cells = { > > [0] = { .id = 0, .name = "moduleX", }, > > [1] = { .id = 1, .name = "moduleY", }, > > [2] = { .id = 2, .name = "moduleZ", }, > > ... > > }; > > > > mfd_add_devices(..., PLATFORM_DEVID_NONE, cells, ARRAY_SIZE(cells), > > ...); > > > > Output (names of the devices in the drivers): > > "moduleX" > > "moduleY.0" > > "moduleX.1" > > > > Desired output: > > "moduleX" > > "moduleY" > > "moduleZ" > > Then what would be your reason for populating the 'id' attribute? That's a gray area. If I remember correctly I come to above patch through looking some incremental change. I'm fine with no patch applied if this is documented somewhere, otherwise we might update documentation to cover such cases explicitly. > > > Is it by design? > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.co > > > > m> > > > > --- > > > > drivers/mfd/mfd-core.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > > > > index c57e407020f1..c9583f895058 100644 > > > > --- a/drivers/mfd/mfd-core.c > > > > +++ b/drivers/mfd/mfd-core.c > > > > @@ -149,7 +149,7 @@ static int mfd_add_device(struct device > > > > *parent, > > > > int id, > > > > int platform_id; > > > > int r; > > > > > > > > - if (id == PLATFORM_DEVID_AUTO) > > > > + if (id < 0) > > > > platform_id = id; > > > > else > > > > platform_id = id + cell->id; > > > > > > > > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE 2017-03-26 12:53 ` Andy Shevchenko @ 2017-03-27 12:41 ` Lee Jones 0 siblings, 0 replies; 6+ messages in thread From: Lee Jones @ 2017-03-27 12:41 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-kernel On Sun, 26 Mar 2017, Andy Shevchenko wrote: > On Fri, 2017-03-24 at 11:35 +0000, Lee Jones wrote: > > On Thu, 23 Mar 2017, Andy Shevchenko wrote: > > > > > On Thu, 2017-03-23 at 11:21 +0000, Lee Jones wrote: > > > > On Thu, 16 Mar 2017, Andy Shevchenko wrote: > > > > > > > > > There is a potential flaw if cell has id > 0 and is going to be > > > > > registered with PLATFORM_DEVID_NONE. > > > > > > > > > > Ignore if PLATFORM_DEVID_NONE is supplied. > > > > > > > > This is a substantial change to a pretty tried and tested piece of > > > > sub-system code. Can you put some more meat on the bones in the > > > > commit log, and include examples. > > > > > > Example in pseudo code: > > > > > > cells = { > > > [0] = { .id = 0, .name = "moduleX", }, > > > [1] = { .id = 1, .name = "moduleY", }, > > > [2] = { .id = 2, .name = "moduleZ", }, > > > ... > > > }; > > > > > > mfd_add_devices(..., PLATFORM_DEVID_NONE, cells, ARRAY_SIZE(cells), > > > ...); > > > > > > Output (names of the devices in the drivers): > > > "moduleX" > > > "moduleY.0" > > > "moduleX.1" > > > > > > Desired output: > > > "moduleX" > > > "moduleY" > > > "moduleZ" > > > > Then what would be your reason for populating the 'id' attribute? > > That's a gray area. If I remember correctly I come to above patch > through looking some incremental change. > > I'm fine with no patch applied if this is documented somewhere, > otherwise we might update documentation to cover such cases explicitly. I'd be happy to review any proposal you put forward. :) > > > Is it by design? > > > > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.co > > > > > m> > > > > > --- > > > > > drivers/mfd/mfd-core.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > > > > > index c57e407020f1..c9583f895058 100644 > > > > > --- a/drivers/mfd/mfd-core.c > > > > > +++ b/drivers/mfd/mfd-core.c > > > > > @@ -149,7 +149,7 @@ static int mfd_add_device(struct device > > > > > *parent, > > > > > int id, > > > > > int platform_id; > > > > > int r; > > > > > > > > > > - if (id == PLATFORM_DEVID_AUTO) > > > > > + if (id < 0) > > > > > platform_id = id; > > > > > else > > > > > platform_id = id + cell->id; > > > > > > > > > > > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-27 12:42 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-03-16 14:19 [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE Andy Shevchenko 2017-03-23 11:21 ` Lee Jones 2017-03-23 13:09 ` Andy Shevchenko 2017-03-24 11:35 ` Lee Jones 2017-03-26 12:53 ` Andy Shevchenko 2017-03-27 12:41 ` Lee Jones
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.