* [PATCH] staging: lustre: Remove redundant code
@ 2017-03-24 11:39 Arushi Singhal
2017-03-24 13:44 ` [lustre-devel] " Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Arushi Singhal @ 2017-03-24 11:39 UTC (permalink / raw)
To: oleg.drokin
Cc: Andreas Dilger, James Simmons, Greg Kroah-Hartman, lustre-devel,
devel, linux-kernel, outreachy-kernel
Remove the code which do not have any value.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/lustre/lnet/lnet/net_fault.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c
index 18183cbb9859..b60261db9e67 100644
--- a/drivers/staging/lustre/lnet/lnet/net_fault.c
+++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
@@ -997,11 +997,6 @@ lnet_fault_ctl(int opc, struct libcfs_ioctl_data *data)
int
lnet_fault_init(void)
{
- BUILD_BUG_ON(LNET_PUT_BIT != 1 << LNET_MSG_PUT);
- BUILD_BUG_ON(LNET_ACK_BIT != 1 << LNET_MSG_ACK);
- BUILD_BUG_ON(LNET_GET_BIT != 1 << LNET_MSG_GET);
- BUILD_BUG_ON(LNET_REPLY_BIT != 1 << LNET_MSG_REPLY);
-
mutex_init(&delay_dd.dd_mutex);
spin_lock_init(&delay_dd.dd_lock);
init_waitqueue_head(&delay_dd.dd_waitq);
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: lustre: Remove redundant code
2017-03-24 11:39 [PATCH] staging: lustre: Remove redundant code Arushi Singhal
@ 2017-03-24 13:44 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-24 13:44 UTC (permalink / raw)
To: Arushi Singhal
Cc: oleg.drokin, Andreas Dilger, James Simmons, lustre-devel, devel,
linux-kernel, outreachy-kernel
On Fri, Mar 24, 2017 at 05:09:53PM +0530, Arushi Singhal wrote:
> Remove the code which do not have any value.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/lustre/lnet/lnet/net_fault.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c
> index 18183cbb9859..b60261db9e67 100644
> --- a/drivers/staging/lustre/lnet/lnet/net_fault.c
> +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
> @@ -997,11 +997,6 @@ lnet_fault_ctl(int opc, struct libcfs_ioctl_data *data)
> int
> lnet_fault_init(void)
> {
> - BUILD_BUG_ON(LNET_PUT_BIT != 1 << LNET_MSG_PUT);
> - BUILD_BUG_ON(LNET_ACK_BIT != 1 << LNET_MSG_ACK);
> - BUILD_BUG_ON(LNET_GET_BIT != 1 << LNET_MSG_GET);
> - BUILD_BUG_ON(LNET_REPLY_BIT != 1 << LNET_MSG_REPLY);
Why does this not have any value? How are you ensuring that these
requirements are now being met?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [lustre-devel] [PATCH] staging: lustre: Remove redundant code
@ 2017-03-24 13:44 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-24 13:44 UTC (permalink / raw)
To: Arushi Singhal
Cc: oleg.drokin, Andreas Dilger, James Simmons, lustre-devel, devel,
linux-kernel, outreachy-kernel
On Fri, Mar 24, 2017 at 05:09:53PM +0530, Arushi Singhal wrote:
> Remove the code which do not have any value.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/lustre/lnet/lnet/net_fault.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c
> index 18183cbb9859..b60261db9e67 100644
> --- a/drivers/staging/lustre/lnet/lnet/net_fault.c
> +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
> @@ -997,11 +997,6 @@ lnet_fault_ctl(int opc, struct libcfs_ioctl_data *data)
> int
> lnet_fault_init(void)
> {
> - BUILD_BUG_ON(LNET_PUT_BIT != 1 << LNET_MSG_PUT);
> - BUILD_BUG_ON(LNET_ACK_BIT != 1 << LNET_MSG_ACK);
> - BUILD_BUG_ON(LNET_GET_BIT != 1 << LNET_MSG_GET);
> - BUILD_BUG_ON(LNET_REPLY_BIT != 1 << LNET_MSG_REPLY);
Why does this not have any value? How are you ensuring that these
requirements are now being met?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: lustre: Remove redundant code
2017-03-24 13:44 ` [lustre-devel] " Greg Kroah-Hartman
@ 2017-03-24 20:10 ` Dilger, Andreas
-1 siblings, 0 replies; 5+ messages in thread
From: Dilger, Andreas @ 2017-03-24 20:10 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arushi Singhal, Drokin, Oleg, James Simmons, lustre-devel, devel,
linux-kernel, outreachy-kernel
On Mar 24, 2017, at 07:44, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Mar 24, 2017 at 05:09:53PM +0530, Arushi Singhal wrote:
>> Remove the code which do not have any value.
>>
>> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
>> ---
>> drivers/staging/lustre/lnet/lnet/net_fault.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c
>> index 18183cbb9859..b60261db9e67 100644
>> --- a/drivers/staging/lustre/lnet/lnet/net_fault.c
>> +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
>> @@ -997,11 +997,6 @@ lnet_fault_ctl(int opc, struct libcfs_ioctl_data *data)
>> int
>> lnet_fault_init(void)
>> {
>> - BUILD_BUG_ON(LNET_PUT_BIT != 1 << LNET_MSG_PUT);
>> - BUILD_BUG_ON(LNET_ACK_BIT != 1 << LNET_MSG_ACK);
>> - BUILD_BUG_ON(LNET_GET_BIT != 1 << LNET_MSG_GET);
>> - BUILD_BUG_ON(LNET_REPLY_BIT != 1 << LNET_MSG_REPLY);
>
> Why does this not have any value? How are you ensuring that these
> requirements are now being met?
It was my recommendation to remove these checks, though on closer review I might have
been a bit premature. For some reason I thought the LNET_*_BIT constants were defined
in terms of LNET_MSG_*, but I see they are not.
In conjunction with this change, the definition of LNET_*_BIT should be changed to be
defined in terms of the LNET_MSG_* constants:
#define LNET_PUT_BIT BIT(LNET_MSG_PUT)
#define LNET_ACK_BIT BIT(LNET_MSG_ACK)
#define LNET_GET_BIT BIT(LNET_MSG_GET)
#define LNET_REPLY_BIT BIT(LNET_MSG_REPLY)
The alternative would be to remove the LNET_*_BIT constants and use BIT(LNET_MSG_*)
directly in the code, since that is easy enough to read compared to (1 << LNET_MSG_*)
everywhere. There don't seem to be a lot of users, so this wouldn't be a giant patch.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* [lustre-devel] [PATCH] staging: lustre: Remove redundant code
@ 2017-03-24 20:10 ` Dilger, Andreas
0 siblings, 0 replies; 5+ messages in thread
From: Dilger, Andreas @ 2017-03-24 20:10 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arushi Singhal, Drokin, Oleg, James Simmons, lustre-devel, devel,
linux-kernel, outreachy-kernel
On Mar 24, 2017, at 07:44, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Mar 24, 2017 at 05:09:53PM +0530, Arushi Singhal wrote:
>> Remove the code which do not have any value.
>>
>> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
>> ---
>> drivers/staging/lustre/lnet/lnet/net_fault.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c
>> index 18183cbb9859..b60261db9e67 100644
>> --- a/drivers/staging/lustre/lnet/lnet/net_fault.c
>> +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
>> @@ -997,11 +997,6 @@ lnet_fault_ctl(int opc, struct libcfs_ioctl_data *data)
>> int
>> lnet_fault_init(void)
>> {
>> - BUILD_BUG_ON(LNET_PUT_BIT != 1 << LNET_MSG_PUT);
>> - BUILD_BUG_ON(LNET_ACK_BIT != 1 << LNET_MSG_ACK);
>> - BUILD_BUG_ON(LNET_GET_BIT != 1 << LNET_MSG_GET);
>> - BUILD_BUG_ON(LNET_REPLY_BIT != 1 << LNET_MSG_REPLY);
>
> Why does this not have any value? How are you ensuring that these
> requirements are now being met?
It was my recommendation to remove these checks, though on closer review I might have
been a bit premature. For some reason I thought the LNET_*_BIT constants were defined
in terms of LNET_MSG_*, but I see they are not.
In conjunction with this change, the definition of LNET_*_BIT should be changed to be
defined in terms of the LNET_MSG_* constants:
#define LNET_PUT_BIT BIT(LNET_MSG_PUT)
#define LNET_ACK_BIT BIT(LNET_MSG_ACK)
#define LNET_GET_BIT BIT(LNET_MSG_GET)
#define LNET_REPLY_BIT BIT(LNET_MSG_REPLY)
The alternative would be to remove the LNET_*_BIT constants and use BIT(LNET_MSG_*)
directly in the code, since that is easy enough to read compared to (1 << LNET_MSG_*)
everywhere. There don't seem to be a lot of users, so this wouldn't be a giant patch.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-24 20:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-24 11:39 [PATCH] staging: lustre: Remove redundant code Arushi Singhal
2017-03-24 13:44 ` Greg Kroah-Hartman
2017-03-24 13:44 ` [lustre-devel] " Greg Kroah-Hartman
2017-03-24 20:10 ` Dilger, Andreas
2017-03-24 20:10 ` [lustre-devel] " Dilger, Andreas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.