From: Krzysztof Kozlowski <krzk@kernel.org> To: Kukjin Kim <kgene@kernel.org>, Javier Martinez Canillas <javier@osg.samsung.com>, Matt Mackall <mpm@selenic.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, Krzysztof Kozlowski <krzk@kernel.org> Subject: [PATCH 0/3] crypto: hw_random - Add new Exynos RNG driver Date: Fri, 24 Mar 2017 17:24:43 +0300 [thread overview] Message-ID: <20170324142446.31129-1-krzk@kernel.org> (raw) Hi, This is a follow up of my questions around exynos-rng [1]. The existing exynos-rng has many issues. The most important one is that it is a pseudo RNG device but uses hw_random interface which does not allow proper seeding. The RNG module on Exynos4 requires seeding. On newer SoCs (like Exynos5420) it can seed itself from a true RNG. Converting the existing driver to use TRNG would effectively drop support for Exynos4 and break compatibility with existing users. Instead I decided to convert it to crypto API. In the future I hope to add support for seeding from TRNG module. Tested with app [2]. Patches are independent. I will take the defconfig changes (2/3 and 3/3) through samsung-soc tree. Best regards, Krzysztof [1] https://www.spinics.net/lists/arm-kernel/msg569641.html [2] https://www.spinics.net/lists/arm-kernel/msg571184.html Krzysztof Kozlowski (3): crypto: hw_random - Add new Exynos RNG driver ARM: exynos_defconfig: Enable Exynos RNG and user-space crypto API ARM: multi_v7_defconfig: Enable Exynos RNG and user-space crypto API MAINTAINERS | 8 + arch/arm/configs/exynos_defconfig | 6 + arch/arm/configs/multi_v7_defconfig | 6 + drivers/char/hw_random/Kconfig | 14 -- drivers/char/hw_random/Makefile | 1 - drivers/char/hw_random/exynos-rng.c | 231 --------------------------- drivers/crypto/Kconfig | 15 ++ drivers/crypto/Makefile | 1 + drivers/crypto/exynos-rng.c | 306 ++++++++++++++++++++++++++++++++++++ 9 files changed, 342 insertions(+), 246 deletions(-) delete mode 100644 drivers/char/hw_random/exynos-rng.c create mode 100644 drivers/crypto/exynos-rng.c -- 2.9.3
WARNING: multiple messages have this Message-ID (diff)
From: krzk@kernel.org (Krzysztof Kozlowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/3] crypto: hw_random - Add new Exynos RNG driver Date: Fri, 24 Mar 2017 17:24:43 +0300 [thread overview] Message-ID: <20170324142446.31129-1-krzk@kernel.org> (raw) Hi, This is a follow up of my questions around exynos-rng [1]. The existing exynos-rng has many issues. The most important one is that it is a pseudo RNG device but uses hw_random interface which does not allow proper seeding. The RNG module on Exynos4 requires seeding. On newer SoCs (like Exynos5420) it can seed itself from a true RNG. Converting the existing driver to use TRNG would effectively drop support for Exynos4 and break compatibility with existing users. Instead I decided to convert it to crypto API. In the future I hope to add support for seeding from TRNG module. Tested with app [2]. Patches are independent. I will take the defconfig changes (2/3 and 3/3) through samsung-soc tree. Best regards, Krzysztof [1] https://www.spinics.net/lists/arm-kernel/msg569641.html [2] https://www.spinics.net/lists/arm-kernel/msg571184.html Krzysztof Kozlowski (3): crypto: hw_random - Add new Exynos RNG driver ARM: exynos_defconfig: Enable Exynos RNG and user-space crypto API ARM: multi_v7_defconfig: Enable Exynos RNG and user-space crypto API MAINTAINERS | 8 + arch/arm/configs/exynos_defconfig | 6 + arch/arm/configs/multi_v7_defconfig | 6 + drivers/char/hw_random/Kconfig | 14 -- drivers/char/hw_random/Makefile | 1 - drivers/char/hw_random/exynos-rng.c | 231 --------------------------- drivers/crypto/Kconfig | 15 ++ drivers/crypto/Makefile | 1 + drivers/crypto/exynos-rng.c | 306 ++++++++++++++++++++++++++++++++++++ 9 files changed, 342 insertions(+), 246 deletions(-) delete mode 100644 drivers/char/hw_random/exynos-rng.c create mode 100644 drivers/crypto/exynos-rng.c -- 2.9.3
next reply other threads:[~2017-03-24 14:25 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-24 14:24 Krzysztof Kozlowski [this message] 2017-03-24 14:24 ` [PATCH 0/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski 2017-03-24 14:24 ` [PATCH 1/3] " Krzysztof Kozlowski 2017-03-24 14:24 ` Krzysztof Kozlowski 2017-03-24 14:37 ` Stephan Müller 2017-03-24 14:37 ` Stephan Müller 2017-03-24 14:43 ` Krzysztof Kozlowski 2017-03-24 14:43 ` Krzysztof Kozlowski 2017-03-24 14:46 ` Stephan Müller 2017-03-24 14:46 ` Stephan Müller 2017-03-24 14:46 ` Stephan Müller 2017-03-24 14:51 ` Krzysztof Kozlowski 2017-03-24 14:51 ` Krzysztof Kozlowski 2017-03-24 14:55 ` Stephan Müller 2017-03-24 14:55 ` Stephan Müller 2017-03-24 14:58 ` Krzysztof Kozlowski 2017-03-24 14:58 ` Krzysztof Kozlowski [not found] ` <CGME20170324152650epcas5p1fb48677d6b5ac7210d6df438a5e70ca3@epcas5p1.samsung.com> 2017-03-24 15:26 ` Bartlomiej Zolnierkiewicz 2017-03-24 15:26 ` Bartlomiej Zolnierkiewicz 2017-03-24 15:46 ` Krzysztof Kozlowski 2017-03-24 15:46 ` Krzysztof Kozlowski [not found] ` <CGME20170324161128epcas1p4b9ef08e3d7e640957d30afa84aa66a16@epcas1p4.samsung.com> 2017-03-24 16:11 ` Bartlomiej Zolnierkiewicz 2017-03-24 16:11 ` Bartlomiej Zolnierkiewicz 2017-03-24 16:11 ` Bartlomiej Zolnierkiewicz 2017-03-24 16:19 ` Krzysztof Kozlowski 2017-03-24 16:19 ` Krzysztof Kozlowski [not found] ` <CGME20170324164544epcas1p353b2eba5ecb6d5f7a69049c5ba9d667e@epcas1p3.samsung.com> 2017-03-24 16:45 ` Bartlomiej Zolnierkiewicz 2017-03-24 16:45 ` Bartlomiej Zolnierkiewicz 2017-03-24 17:01 ` Krzysztof Kozlowski 2017-03-24 17:01 ` Krzysztof Kozlowski 2017-03-24 17:01 ` Krzysztof Kozlowski 2017-03-24 14:24 ` [PATCH 2/3] ARM: exynos_defconfig: Enable Exynos RNG and user-space crypto API Krzysztof Kozlowski 2017-03-24 14:24 ` Krzysztof Kozlowski 2017-03-24 14:24 ` [PATCH 3/3] ARM: multi_v7_defconfig: " Krzysztof Kozlowski 2017-03-24 14:24 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170324142446.31129-1-krzk@kernel.org \ --to=krzk@kernel.org \ --cc=arnd@arndb.de \ --cc=davem@davemloft.net \ --cc=herbert@gondor.apana.org.au \ --cc=javier@osg.samsung.com \ --cc=kgene@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mpm@selenic.com \ --cc=olof@lixom.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.