* [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq
@ 2017-03-27 3:34 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2017-03-27 3:34 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni
Cc: rtc-linux, linux-kernel, Sebastian Reichel
There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE
for request_threaded_irq(). Let's fix it before it gets copied elsewhere.
Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/rtc/rtc-cpcap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
--- a/drivers/rtc/rtc-cpcap.c
+++ b/drivers/rtc/rtc-cpcap.c
@@ -275,7 +275,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
rtc->alarm_irq = platform_get_irq(pdev, 0);
err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
- cpcap_rtc_alarm_irq, IRQ_NONE,
+ cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
"rtc_alarm", rtc);
if (err) {
dev_err(dev, "Could not request alarm irq: %d\n", err);
@@ -291,7 +291,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
*/
rtc->update_irq = platform_get_irq(pdev, 1);
err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
- cpcap_rtc_update_irq, IRQ_NONE,
+ cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
"rtc_1hz", rtc);
if (err) {
dev_err(dev, "Could not request update irq: %d\n", err);
--
2.12.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [rtc-linux] [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq
@ 2017-03-27 3:34 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2017-03-27 3:34 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni
Cc: rtc-linux, linux-kernel, Sebastian Reichel
There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE
for request_threaded_irq(). Let's fix it before it gets copied elsewhere.
Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/rtc/rtc-cpcap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
--- a/drivers/rtc/rtc-cpcap.c
+++ b/drivers/rtc/rtc-cpcap.c
@@ -275,7 +275,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
rtc->alarm_irq = platform_get_irq(pdev, 0);
err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
- cpcap_rtc_alarm_irq, IRQ_NONE,
+ cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
"rtc_alarm", rtc);
if (err) {
dev_err(dev, "Could not request alarm irq: %d\n", err);
@@ -291,7 +291,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
*/
rtc->update_irq = platform_get_irq(pdev, 1);
err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
- cpcap_rtc_update_irq, IRQ_NONE,
+ cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
"rtc_1hz", rtc);
if (err) {
dev_err(dev, "Could not request update irq: %d\n", err);
--
2.12.1
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq
2017-03-27 3:34 ` [rtc-linux] " Tony Lindgren
@ 2017-03-27 14:24 ` Sebastian Reichel
-1 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2017-03-27 14:24 UTC (permalink / raw)
To: Tony Lindgren
Cc: Alessandro Zummo, Alexandre Belloni, rtc-linux, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
Hi,
On Sun, Mar 26, 2017 at 08:34:23PM -0700, Tony Lindgren wrote:
> There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE
> for request_threaded_irq(). Let's fix it before it gets copied elsewhere.
>
> Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
> ---
> drivers/rtc/rtc-cpcap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
> --- a/drivers/rtc/rtc-cpcap.c
> +++ b/drivers/rtc/rtc-cpcap.c
> @@ -275,7 +275,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
>
> rtc->alarm_irq = platform_get_irq(pdev, 0);
> err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
> - cpcap_rtc_alarm_irq, IRQ_NONE,
> + cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
> "rtc_alarm", rtc);
> if (err) {
> dev_err(dev, "Could not request alarm irq: %d\n", err);
> @@ -291,7 +291,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
> */
> rtc->update_irq = platform_get_irq(pdev, 1);
> err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
> - cpcap_rtc_update_irq, IRQ_NONE,
> + cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
> "rtc_1hz", rtc);
> if (err) {
> dev_err(dev, "Could not request update irq: %d\n", err);
> --
> 2.12.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq
@ 2017-03-27 14:24 ` Sebastian Reichel
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2017-03-27 14:24 UTC (permalink / raw)
To: Tony Lindgren
Cc: Alessandro Zummo, Alexandre Belloni, rtc-linux, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1960 bytes --]
Hi,
On Sun, Mar 26, 2017 at 08:34:23PM -0700, Tony Lindgren wrote:
> There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE
> for request_threaded_irq(). Let's fix it before it gets copied elsewhere.
>
> Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
> ---
> drivers/rtc/rtc-cpcap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
> --- a/drivers/rtc/rtc-cpcap.c
> +++ b/drivers/rtc/rtc-cpcap.c
> @@ -275,7 +275,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
>
> rtc->alarm_irq = platform_get_irq(pdev, 0);
> err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
> - cpcap_rtc_alarm_irq, IRQ_NONE,
> + cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
> "rtc_alarm", rtc);
> if (err) {
> dev_err(dev, "Could not request alarm irq: %d\n", err);
> @@ -291,7 +291,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
> */
> rtc->update_irq = platform_get_irq(pdev, 1);
> err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
> - cpcap_rtc_update_irq, IRQ_NONE,
> + cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
> "rtc_1hz", rtc);
> if (err) {
> dev_err(dev, "Could not request update irq: %d\n", err);
> --
> 2.12.1
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq
2017-03-27 3:34 ` [rtc-linux] " Tony Lindgren
@ 2017-04-08 14:39 ` Alexandre Belloni
-1 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2017-04-08 14:39 UTC (permalink / raw)
To: Tony Lindgren
Cc: Alessandro Zummo, rtc-linux, linux-kernel, Sebastian Reichel
On 26/03/2017 at 20:34:23 -0700, Tony Lindgren wrote:
> There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE
> for request_threaded_irq(). Let's fix it before it gets copied elsewhere.
>
> Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/rtc/rtc-cpcap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq
@ 2017-04-08 14:39 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2017-04-08 14:39 UTC (permalink / raw)
To: Tony Lindgren
Cc: Alessandro Zummo, rtc-linux, linux-kernel, Sebastian Reichel
On 26/03/2017 at 20:34:23 -0700, Tony Lindgren wrote:
> There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE
> for request_threaded_irq(). Let's fix it before it gets copied elsewhere.
>
> Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/rtc/rtc-cpcap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-08 14:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-27 3:34 [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq Tony Lindgren
2017-03-27 3:34 ` [rtc-linux] " Tony Lindgren
2017-03-27 14:24 ` Sebastian Reichel
2017-03-27 14:24 ` [rtc-linux] " Sebastian Reichel
2017-04-08 14:39 ` Alexandre Belloni
2017-04-08 14:39 ` [rtc-linux] " Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.