From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> To: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com>, Jingoo Han <jingoohan1@gmail.com>, Joao Pinto <Joao.Pinto@synopsys.com> Subject: [PATCH v2 16/22] PCI: designware: update PCI config space remap function Date: Mon, 27 Mar 2017 10:49:44 +0100 [thread overview] Message-ID: <20170327094954.7162-17-lorenzo.pieralisi@arm.com> (raw) In-Reply-To: <20170327094954.7162-1-lorenzo.pieralisi@arm.com> PCI configuration space should be mapped with a memory region type that generates on the CPU host bus non-posted write transations. Update the driver to use the devm_ioremap_nopost* interface to make sure the correct memory mappings for PCI configuration space are used. Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Jingoo Han <jingoohan1@gmail.com> Cc: Joao Pinto <Joao.Pinto@synopsys.com> --- drivers/pci/dwc/pcie-designware-host.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c index 5ba3349..d2dd228 100644 --- a/drivers/pci/dwc/pcie-designware-host.c +++ b/drivers/pci/dwc/pcie-designware-host.c @@ -338,8 +338,8 @@ int dw_pcie_host_init(struct pcie_port *pp) } if (!pci->dbi_base) { - pci->dbi_base = devm_ioremap(dev, pp->cfg->start, - resource_size(pp->cfg)); + pci->dbi_base = devm_ioremap_nopost(dev, pp->cfg->start, + resource_size(pp->cfg)); if (!pci->dbi_base) { dev_err(dev, "error with ioremap\n"); ret = -ENOMEM; @@ -350,8 +350,8 @@ int dw_pcie_host_init(struct pcie_port *pp) pp->mem_base = pp->mem->start; if (!pp->va_cfg0_base) { - pp->va_cfg0_base = devm_ioremap(dev, pp->cfg0_base, - pp->cfg0_size); + pp->va_cfg0_base = devm_ioremap_nopost(dev, pp->cfg0_base, + pp->cfg0_size); if (!pp->va_cfg0_base) { dev_err(dev, "error with ioremap in function\n"); ret = -ENOMEM; @@ -360,8 +360,8 @@ int dw_pcie_host_init(struct pcie_port *pp) } if (!pp->va_cfg1_base) { - pp->va_cfg1_base = devm_ioremap(dev, pp->cfg1_base, - pp->cfg1_size); + pp->va_cfg1_base = devm_ioremap_nopost(dev, pp->cfg1_base, + pp->cfg1_size); if (!pp->va_cfg1_base) { dev_err(dev, "error with ioremap\n"); ret = -ENOMEM; -- 2.10.0
WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 16/22] PCI: designware: update PCI config space remap function Date: Mon, 27 Mar 2017 10:49:44 +0100 [thread overview] Message-ID: <20170327094954.7162-17-lorenzo.pieralisi@arm.com> (raw) In-Reply-To: <20170327094954.7162-1-lorenzo.pieralisi@arm.com> PCI configuration space should be mapped with a memory region type that generates on the CPU host bus non-posted write transations. Update the driver to use the devm_ioremap_nopost* interface to make sure the correct memory mappings for PCI configuration space are used. Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Jingoo Han <jingoohan1@gmail.com> Cc: Joao Pinto <Joao.Pinto@synopsys.com> --- drivers/pci/dwc/pcie-designware-host.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c index 5ba3349..d2dd228 100644 --- a/drivers/pci/dwc/pcie-designware-host.c +++ b/drivers/pci/dwc/pcie-designware-host.c @@ -338,8 +338,8 @@ int dw_pcie_host_init(struct pcie_port *pp) } if (!pci->dbi_base) { - pci->dbi_base = devm_ioremap(dev, pp->cfg->start, - resource_size(pp->cfg)); + pci->dbi_base = devm_ioremap_nopost(dev, pp->cfg->start, + resource_size(pp->cfg)); if (!pci->dbi_base) { dev_err(dev, "error with ioremap\n"); ret = -ENOMEM; @@ -350,8 +350,8 @@ int dw_pcie_host_init(struct pcie_port *pp) pp->mem_base = pp->mem->start; if (!pp->va_cfg0_base) { - pp->va_cfg0_base = devm_ioremap(dev, pp->cfg0_base, - pp->cfg0_size); + pp->va_cfg0_base = devm_ioremap_nopost(dev, pp->cfg0_base, + pp->cfg0_size); if (!pp->va_cfg0_base) { dev_err(dev, "error with ioremap in function\n"); ret = -ENOMEM; @@ -360,8 +360,8 @@ int dw_pcie_host_init(struct pcie_port *pp) } if (!pp->va_cfg1_base) { - pp->va_cfg1_base = devm_ioremap(dev, pp->cfg1_base, - pp->cfg1_size); + pp->va_cfg1_base = devm_ioremap_nopost(dev, pp->cfg1_base, + pp->cfg1_size); if (!pp->va_cfg1_base) { dev_err(dev, "error with ioremap\n"); ret = -ENOMEM; -- 2.10.0
next prev parent reply other threads:[~2017-03-27 9:52 UTC|newest] Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-27 9:49 [PATCH v2 00/22] PCI: fix config and I/O Address space memory mappings Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 01/22] PCI: remove __weak tag from pci_remap_iospace() Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap interface Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-28 1:41 ` Bjorn Helgaas 2017-03-28 1:41 ` Bjorn Helgaas 2017-03-28 1:41 ` Bjorn Helgaas 2017-03-28 14:45 ` Lorenzo Pieralisi 2017-03-28 14:45 ` Lorenzo Pieralisi 2017-03-30 16:47 ` Bjorn Helgaas 2017-03-30 16:47 ` Bjorn Helgaas 2017-03-30 16:47 ` Bjorn Helgaas 2017-04-05 10:58 ` Russell King - ARM Linux 2017-04-05 10:58 ` Russell King - ARM Linux 2017-04-05 12:38 ` Lorenzo Pieralisi 2017-04-05 12:38 ` Lorenzo Pieralisi 2017-04-06 10:26 ` Lorenzo Pieralisi 2017-04-06 10:26 ` Lorenzo Pieralisi 2017-04-06 10:47 ` Russell King - ARM Linux 2017-04-06 10:47 ` Russell King - ARM Linux 2017-04-10 14:30 ` Lorenzo Pieralisi 2017-04-10 14:30 ` Lorenzo Pieralisi 2017-04-06 10:53 ` Luis R. Rodriguez 2017-04-06 10:53 ` Luis R. Rodriguez 2017-04-06 11:38 ` Lorenzo Pieralisi 2017-04-06 11:38 ` Lorenzo Pieralisi 2017-04-06 11:59 ` Luis R. Rodriguez 2017-04-06 11:59 ` Luis R. Rodriguez 2017-04-06 13:07 ` Russell King - ARM Linux 2017-04-06 13:07 ` Russell King - ARM Linux 2017-04-06 16:21 ` Lorenzo Pieralisi 2017-04-06 16:21 ` Lorenzo Pieralisi 2017-04-06 16:40 ` Russell King - ARM Linux 2017-04-06 16:40 ` Russell King - ARM Linux 2017-04-06 17:09 ` Lorenzo Pieralisi 2017-04-06 17:09 ` Lorenzo Pieralisi 2017-04-06 17:19 ` Russell King - ARM Linux 2017-04-06 17:19 ` Russell King - ARM Linux 2017-04-06 12:11 ` Russell King - ARM Linux 2017-04-06 12:11 ` Russell King - ARM Linux 2017-04-06 12:25 ` Luis R. Rodriguez 2017-04-06 12:25 ` Luis R. Rodriguez 2017-03-27 9:49 ` [PATCH v2 03/22] asm-generic/pgtable.h: introduce pgprot_nonposted remap attribute Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 04/22] PCI: fix pci_remap_iospace() " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 05/22] ARM64: implement ioremap_nopost() interface Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-30 16:19 ` Will Deacon 2017-03-30 16:19 ` Will Deacon 2017-03-30 16:19 ` Will Deacon 2017-03-27 9:49 ` [PATCH v2 06/22] ARM: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-31 11:08 ` Lorenzo Pieralisi 2017-03-31 11:08 ` Lorenzo Pieralisi 2017-03-31 11:08 ` Lorenzo Pieralisi 2017-04-05 10:21 ` Lorenzo Pieralisi 2017-04-05 10:21 ` Lorenzo Pieralisi 2017-04-05 10:21 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 07/22] PCI: ECAM: use ioremap_nopost() to map config region Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-30 16:20 ` Will Deacon 2017-03-30 16:20 ` Will Deacon 2017-03-30 16:20 ` Will Deacon 2017-03-27 9:49 ` [PATCH v2 08/22] lib: implement Devres ioremap_nopost() interface Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-28 1:41 ` Bjorn Helgaas 2017-03-28 1:41 ` Bjorn Helgaas 2017-03-28 1:41 ` Bjorn Helgaas 2017-03-28 14:50 ` Lorenzo Pieralisi 2017-03-28 14:50 ` Lorenzo Pieralisi 2017-03-28 15:55 ` Tejun Heo 2017-03-28 15:55 ` Tejun Heo 2017-03-27 9:49 ` [PATCH v2 09/22] PCI: xilinx: update PCI config space remap function Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 10/22] PCI: xilinx-nwl: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 11/22] PCI: spear13xx: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 12/22] PCI: rockchip: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 13/22] PCI: qcom: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 14/22] PCI: iproc-platform: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 15/22] PCI: hisi: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi [this message] 2017-03-27 9:49 ` [PATCH v2 16/22] PCI: designware: " Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 17/22] PCI: armada8k: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 18/22] PCI: xgene: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 19/22] PCI: tegra: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 20/22] PCI: layerscape: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 21/22] PCI: keystone-dw: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` [PATCH v2 22/22] PCI: versatile: " Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi 2017-03-27 9:49 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170327094954.7162-17-lorenzo.pieralisi@arm.com \ --to=lorenzo.pieralisi@arm.com \ --cc=Joao.Pinto@synopsys.com \ --cc=bhelgaas@google.com \ --cc=jingoohan1@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.