From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> To: Daniel Baluta <daniel.baluta@nxp.com> Cc: <nicoleotsuka@gmail.com>, <broonie@kernel.org>, <alsa-devel@alsa-project.org>, <timur@tabi.org>, <Xiubo.Lee@gmail.com>, <linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>, <tiwai@suse.com>, <fabio.estevam@nxp.com>, <linuxppc-dev@lists.ozlabs.org> Subject: Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Date: Tue, 28 Mar 2017 10:21:03 +0100 [thread overview] Message-ID: <20170328092103.GQ6986@localhost.localdomain> (raw) In-Reply-To: <1490691532-2086-3-git-send-email-daniel.baluta@nxp.com> On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: > Resource managed devm_clk_get only works with platform's device dev. > I feel like this could use an explaination of why not using devm is the correct fix, rather than just using the platform device for the call. Its not obvious to me, that using the platform device would be an issue. Thanks, Charles > Reported-by: Nicolin Chen <nicoleotsuka@gmail.com> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> > --- > sound/soc/fsl/imx-wm8962.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c > index 3d894d9..52659fa 100644 > --- a/sound/soc/fsl/imx-wm8962.c > +++ b/sound/soc/fsl/imx-wm8962.c > @@ -231,7 +231,7 @@ static int imx_wm8962_probe(struct platform_device *pdev) > goto fail; > } > > - codec_clk = devm_clk_get(&codec_dev->dev, NULL); > + codec_clk = clk_get(&codec_dev->dev, NULL); > if (IS_ERR(codec_clk)) { > ret = PTR_ERR(codec_clk); > dev_err(&codec_dev->dev, "failed to get codec clk: %d\n", ret); > @@ -239,6 +239,7 @@ static int imx_wm8962_probe(struct platform_device *pdev) > } > > data->clk_frequency = clk_get_rate(codec_clk); > + clk_put(codec_clk); > > data->dai.name = "HiFi"; > data->dai.stream_name = "HiFi"; > -- > 2.7.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> To: Daniel Baluta <daniel.baluta@nxp.com> Cc: alsa-devel@alsa-project.org, Xiubo.Lee@gmail.com, lgirdwood@gmail.com, tiwai@suse.com, linux-kernel@vger.kernel.org, timur@tabi.org, nicoleotsuka@gmail.com, broonie@kernel.org, fabio.estevam@nxp.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Date: Tue, 28 Mar 2017 10:21:03 +0100 [thread overview] Message-ID: <20170328092103.GQ6986@localhost.localdomain> (raw) In-Reply-To: <1490691532-2086-3-git-send-email-daniel.baluta@nxp.com> On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: > Resource managed devm_clk_get only works with platform's device dev. > I feel like this could use an explaination of why not using devm is the correct fix, rather than just using the platform device for the call. Its not obvious to me, that using the platform device would be an issue. Thanks, Charles > Reported-by: Nicolin Chen <nicoleotsuka@gmail.com> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> > --- > sound/soc/fsl/imx-wm8962.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c > index 3d894d9..52659fa 100644 > --- a/sound/soc/fsl/imx-wm8962.c > +++ b/sound/soc/fsl/imx-wm8962.c > @@ -231,7 +231,7 @@ static int imx_wm8962_probe(struct platform_device *pdev) > goto fail; > } > > - codec_clk = devm_clk_get(&codec_dev->dev, NULL); > + codec_clk = clk_get(&codec_dev->dev, NULL); > if (IS_ERR(codec_clk)) { > ret = PTR_ERR(codec_clk); > dev_err(&codec_dev->dev, "failed to get codec clk: %d\n", ret); > @@ -239,6 +239,7 @@ static int imx_wm8962_probe(struct platform_device *pdev) > } > > data->clk_frequency = clk_get_rate(codec_clk); > + clk_put(codec_clk); > > data->dai.name = "HiFi"; > data->dai.stream_name = "HiFi"; > -- > 2.7.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-03-28 9:22 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-28 8:58 [PATCH v3 0/2] imx-wm8962: Let codec driver enable/disable its MCLK Daniel Baluta 2017-03-28 8:58 ` Daniel Baluta 2017-03-28 8:58 ` [PATCH v3 1/2] ASoC: " Daniel Baluta 2017-03-28 8:58 ` Daniel Baluta 2017-03-28 8:58 ` [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Daniel Baluta 2017-03-28 8:58 ` Daniel Baluta 2017-03-28 9:21 ` Charles Keepax [this message] 2017-03-28 9:21 ` Charles Keepax 2017-03-28 10:47 ` [alsa-devel] " Daniel Baluta 2017-03-28 10:47 ` Daniel Baluta 2017-03-28 11:53 ` [alsa-devel] " Charles Keepax 2017-03-28 11:53 ` Charles Keepax 2017-03-28 15:24 ` [alsa-devel] " Mark Brown 2017-03-28 15:24 ` Mark Brown 2017-03-28 15:42 ` [alsa-devel] " Charles Keepax 2017-03-28 15:42 ` Charles Keepax 2017-03-29 11:38 ` [alsa-devel] " Daniel Baluta 2017-03-29 11:38 ` Daniel Baluta 2017-03-29 11:47 ` [alsa-devel] " Mark Brown 2017-03-29 11:47 ` Mark Brown 2017-03-29 11:54 ` Applied "ASoC: imx-wm8962: Fix codec_clk cleanup" to the asoc tree Mark Brown 2017-03-29 11:54 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170328092103.GQ6986@localhost.localdomain \ --to=ckeepax@opensource.wolfsonmicro.com \ --cc=Xiubo.Lee@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=daniel.baluta@nxp.com \ --cc=fabio.estevam@nxp.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=nicoleotsuka@gmail.com \ --cc=timur@tabi.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.