From: Christoffer Dall <cdall@linaro.org> To: Marc Zyngier <marc.zyngier@arm.com> Cc: Shannon Zhao <shannon.zhao@linaro.org>, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v2 8/9] arm: KVM: Make unexpected register accesses inject an undef Date: Tue, 28 Mar 2017 14:46:09 +0200 [thread overview] Message-ID: <20170328124609.GH31156@cbox> (raw) In-Reply-To: <20170327160345.12402-9-marc.zyngier@arm.com> On Mon, Mar 27, 2017 at 05:03:44PM +0100, Marc Zyngier wrote: > Reads from write-only system registers are generally confined to > EL1 and not propagated to EL2 (that's what the architecture > mantates). In order to be sure that we have a sane behaviour > even in the unlikely event that we have a broken system, we still > handle it in KVM. Same goes for write to RO registers. > > In that case, let's inject an undef into the guest. > Reviewed-by: Christoffer Dall <cdall@linaro.org> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > --- > arch/arm/kvm/coproc.c | 18 ++++++++++++++++++ > arch/arm/kvm/coproc.h | 18 ------------------ > 2 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/kvm/coproc.c b/arch/arm/kvm/coproc.c > index 3e5e4194ef86..519aac12b365 100644 > --- a/arch/arm/kvm/coproc.c > +++ b/arch/arm/kvm/coproc.c > @@ -40,6 +40,24 @@ > * Co-processor emulation > *****************************************************************************/ > > +static bool write_to_read_only(struct kvm_vcpu *vcpu, > + const struct coproc_params *params) > +{ > + WARN_ONCE(1, "CP15 write to read-only register\n"); > + print_cp_instr(params); > + kvm_inject_undefined(vcpu); > + return false; > +} > + > +static bool read_from_write_only(struct kvm_vcpu *vcpu, > + const struct coproc_params *params) > +{ > + WARN_ONCE(1, "CP15 read to write-only register\n"); > + print_cp_instr(params); > + kvm_inject_undefined(vcpu); > + return false; > +} > + > /* 3 bits per cache level, as per CLIDR, but non-existent caches always 0 */ > static u32 cache_levels; > > diff --git a/arch/arm/kvm/coproc.h b/arch/arm/kvm/coproc.h > index eef1759c2b65..3a41b7d1eb86 100644 > --- a/arch/arm/kvm/coproc.h > +++ b/arch/arm/kvm/coproc.h > @@ -81,24 +81,6 @@ static inline bool read_zero(struct kvm_vcpu *vcpu, > return true; > } > > -static inline bool write_to_read_only(struct kvm_vcpu *vcpu, > - const struct coproc_params *params) > -{ > - kvm_debug("CP15 write to read-only register at: %08lx\n", > - *vcpu_pc(vcpu)); > - print_cp_instr(params); > - return false; > -} > - > -static inline bool read_from_write_only(struct kvm_vcpu *vcpu, > - const struct coproc_params *params) > -{ > - kvm_debug("CP15 read to write-only register at: %08lx\n", > - *vcpu_pc(vcpu)); > - print_cp_instr(params); > - return false; > -} > - > /* Reset functions */ > static inline void reset_unknown(struct kvm_vcpu *vcpu, > const struct coproc_reg *r) > -- > 2.11.0 >
WARNING: multiple messages have this Message-ID (diff)
From: cdall@linaro.org (Christoffer Dall) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 8/9] arm: KVM: Make unexpected register accesses inject an undef Date: Tue, 28 Mar 2017 14:46:09 +0200 [thread overview] Message-ID: <20170328124609.GH31156@cbox> (raw) In-Reply-To: <20170327160345.12402-9-marc.zyngier@arm.com> On Mon, Mar 27, 2017 at 05:03:44PM +0100, Marc Zyngier wrote: > Reads from write-only system registers are generally confined to > EL1 and not propagated to EL2 (that's what the architecture > mantates). In order to be sure that we have a sane behaviour > even in the unlikely event that we have a broken system, we still > handle it in KVM. Same goes for write to RO registers. > > In that case, let's inject an undef into the guest. > Reviewed-by: Christoffer Dall <cdall@linaro.org> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > --- > arch/arm/kvm/coproc.c | 18 ++++++++++++++++++ > arch/arm/kvm/coproc.h | 18 ------------------ > 2 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/kvm/coproc.c b/arch/arm/kvm/coproc.c > index 3e5e4194ef86..519aac12b365 100644 > --- a/arch/arm/kvm/coproc.c > +++ b/arch/arm/kvm/coproc.c > @@ -40,6 +40,24 @@ > * Co-processor emulation > *****************************************************************************/ > > +static bool write_to_read_only(struct kvm_vcpu *vcpu, > + const struct coproc_params *params) > +{ > + WARN_ONCE(1, "CP15 write to read-only register\n"); > + print_cp_instr(params); > + kvm_inject_undefined(vcpu); > + return false; > +} > + > +static bool read_from_write_only(struct kvm_vcpu *vcpu, > + const struct coproc_params *params) > +{ > + WARN_ONCE(1, "CP15 read to write-only register\n"); > + print_cp_instr(params); > + kvm_inject_undefined(vcpu); > + return false; > +} > + > /* 3 bits per cache level, as per CLIDR, but non-existent caches always 0 */ > static u32 cache_levels; > > diff --git a/arch/arm/kvm/coproc.h b/arch/arm/kvm/coproc.h > index eef1759c2b65..3a41b7d1eb86 100644 > --- a/arch/arm/kvm/coproc.h > +++ b/arch/arm/kvm/coproc.h > @@ -81,24 +81,6 @@ static inline bool read_zero(struct kvm_vcpu *vcpu, > return true; > } > > -static inline bool write_to_read_only(struct kvm_vcpu *vcpu, > - const struct coproc_params *params) > -{ > - kvm_debug("CP15 write to read-only register at: %08lx\n", > - *vcpu_pc(vcpu)); > - print_cp_instr(params); > - return false; > -} > - > -static inline bool read_from_write_only(struct kvm_vcpu *vcpu, > - const struct coproc_params *params) > -{ > - kvm_debug("CP15 read to write-only register at: %08lx\n", > - *vcpu_pc(vcpu)); > - print_cp_instr(params); > - return false; > -} > - > /* Reset functions */ > static inline void reset_unknown(struct kvm_vcpu *vcpu, > const struct coproc_reg *r) > -- > 2.11.0 >
next prev parent reply other threads:[~2017-03-28 12:46 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-27 16:03 [PATCH v2 0/9] arm64: KVM: Fix PMU exception generation Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-27 16:03 ` [PATCH v2 1/9] arm64: KVM: PMU: Refactor pmu_*_el0_disabled Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-27 17:03 ` Suzuki K Poulose 2017-03-27 17:03 ` Suzuki K Poulose 2017-03-27 17:11 ` Marc Zyngier 2017-03-27 17:11 ` Marc Zyngier 2017-03-28 12:46 ` Christoffer Dall 2017-03-28 12:46 ` Christoffer Dall 2017-03-28 13:21 ` Marc Zyngier 2017-03-28 13:21 ` Marc Zyngier 2017-03-27 16:03 ` [PATCH v2 2/9] arm64: KVM: PMU: Inject UNDEF exception on illegal register access Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-28 12:44 ` Christoffer Dall 2017-03-28 12:44 ` Christoffer Dall 2017-03-27 16:03 ` [PATCH v2 3/9] arm64: KVM: PMU: Inject UNDEF on non-privileged accesses Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-28 12:45 ` Christoffer Dall 2017-03-28 12:45 ` Christoffer Dall 2017-03-27 16:03 ` [PATCH v2 4/9] arm64: KVM: Make unexpected reads from WO registers inject an undef Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-28 12:45 ` Christoffer Dall 2017-03-28 12:45 ` Christoffer Dall 2017-03-27 16:03 ` [PATCH v2 5/9] arm64: KVM: PMU: Inject UNDEF on read access to PMSWINC_EL0 Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-28 12:45 ` Christoffer Dall 2017-03-28 12:45 ` Christoffer Dall 2017-03-27 16:03 ` [PATCH v2 6/9] arm64: KVM: Treat sysreg accessors returning false as successful Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-28 12:45 ` Christoffer Dall 2017-03-28 12:45 ` Christoffer Dall 2017-03-27 16:03 ` [PATCH v2 7/9] arm64: KVM: Do not corrupt registers on failed 64bit CP read Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-28 12:46 ` Christoffer Dall 2017-03-28 12:46 ` Christoffer Dall 2017-03-28 13:24 ` Marc Zyngier 2017-03-28 13:24 ` Marc Zyngier 2017-03-27 16:03 ` [PATCH v2 8/9] arm: KVM: Make unexpected register accesses inject an undef Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-28 12:46 ` Christoffer Dall [this message] 2017-03-28 12:46 ` Christoffer Dall 2017-03-27 16:03 ` [PATCH v2 9/9] arm: KVM: Treat CP15 accessors returning false as successful Marc Zyngier 2017-03-27 16:03 ` Marc Zyngier 2017-03-28 12:46 ` Christoffer Dall 2017-03-28 12:46 ` Christoffer Dall 2017-03-28 13:37 ` [PATCH v2 0/9] arm64: KVM: Fix PMU exception generation Christoffer Dall 2017-03-28 13:37 ` Christoffer Dall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170328124609.GH31156@cbox \ --to=cdall@linaro.org \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=shannon.zhao@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.