* [rtc-linux] [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ
@ 2017-03-28 17:22 David Lowe
2017-04-22 15:54 ` [rtc-linux] " Alexandre Belloni
0 siblings, 1 reply; 3+ messages in thread
From: David Lowe @ 2017-03-28 17:22 UTC (permalink / raw)
To: rtc-linux; +Cc: Alexandre Belloni
This patch extends the fixes for ds1337, ds1339, ds3231 in 8bc2a40730ec
to mcp794xx devices, so that those parts can similarly be used as a wakeup
source without an IRQ to the processor.
Tested on Raspberry Pi ZeroW with MCP79400.
Signed-off-by: David Lowe <dave-lowe@ntlworld.com>
---
--- a/drivers/rtc/rtc-ds1307.c 2017-03-28 16:16:38.158076224 +0100
+++ b/drivers/rtc/rtc-ds1307.c 2017-03-28 16:16:52.248431799 +0100
@@ -1487,7 +1487,8 @@ static int ds1307_probe(struct i2c_clien
break;
case mcp794xx:
rtc_ops = &mcp794xx_rtc_ops;
- if (ds1307->client->irq > 0 && chip->alarm) {
+ if (chip->alarm && (ds1307->client->irq > 0 ||
+
ds1307_can_wakeup_device)) { irq_handler = mcp794xx_irq;
want_irq = true;
}
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 3+ messages in thread* [rtc-linux] Re: [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ
2017-03-28 17:22 [rtc-linux] [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ David Lowe
@ 2017-04-22 15:54 ` Alexandre Belloni
0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2017-04-22 15:54 UTC (permalink / raw)
To: David Lowe; +Cc: rtc-linux
Hi,
On 28/03/2017 at 18:22:04 +0100, David Lowe wrote:
> This patch extends the fixes for ds1337, ds1339, ds3231 in 8bc2a40730ec
> to mcp794xx devices, so that those parts can similarly be used as a wakeup
> source without an IRQ to the processor.
>
> Tested on Raspberry Pi ZeroW with MCP79400.
>
> Signed-off-by: David Lowe <dave-lowe@ntlworld.com>
> ---
> --- a/drivers/rtc/rtc-ds1307.c 2017-03-28 16:16:38.158076224 +0100
> +++ b/drivers/rtc/rtc-ds1307.c 2017-03-28 16:16:52.248431799 +0100
> @@ -1487,7 +1487,8 @@ static int ds1307_probe(struct i2c_clien
> break;
> case mcp794xx:
> rtc_ops = &mcp794xx_rtc_ops;
> - if (ds1307->client->irq > 0 && chip->alarm) {
> + if (chip->alarm && (ds1307->client->irq > 0 ||
> +
> ds1307_can_wakeup_device)) { irq_handler = mcp794xx_irq;
This seems right but your mailer as mangled the patch. Can you resend?
> want_irq = true;
> }
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [rtc-linux] [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ
@ 2017-04-22 17:28 David Lowe
0 siblings, 0 replies; 3+ messages in thread
From: David Lowe @ 2017-04-22 17:28 UTC (permalink / raw)
To: rtc-linux, Alexandre Belloni
This patch extends the fixes for ds1337, ds1339, ds3231 in 8bc2a40730ec
to mcp794xx devices, so that those parts can similarly be used as a wakeup
source without an IRQ to the processor.
Tested on Raspberry Pi ZeroW with MCP79400.
Signed-off-by: David Lowe <dave-lowe@ntlworld.com>
---
--- a/drivers/rtc/rtc-ds1307.c 2017-03-28 16:16:38.158076224 +0100
+++ b/drivers/rtc/rtc-ds1307.c 2017-03-28 16:16:52.248431799 +0100
@@ -1487,7 +1487,8 @@ static int ds1307_probe(struct i2c_clien
break;
case mcp794xx:
rtc_ops = &mcp794xx_rtc_ops;
- if (ds1307->client->irq > 0 && chip->alarm) {
+ if (chip->alarm && (ds1307->client->irq > 0 ||
+ ds1307_can_wakeup_device)) {
irq_handler = mcp794xx_irq;
want_irq = true;
}
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-22 17:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 17:22 [rtc-linux] [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ David Lowe
2017-04-22 15:54 ` [rtc-linux] " Alexandre Belloni
2017-04-22 17:28 [rtc-linux] " David Lowe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.