* [PATCH] Remove atomisp/i2c style errors.
@ 2017-03-29 3:31 Daniel Cashman
2017-03-29 7:08 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Cashman @ 2017-03-29 3:31 UTC (permalink / raw)
To: mchehab, gregkh, alan
Cc: rvarsha016, linux-media, devel, linux-kernel, Dan Cashman
From: Dan Cashman <dan.a.cashman@gmail.com>
Remove two ' , ' issues and change spaces to tabs found by poking around in
drivers/staging/. Warnings left untouched.
Test: Run checkpatch script in drivers/staging/media/atomisp/i2c before and
after change. Errors go from 3 to 0.
Signed-off-by: Dan Cashman <dan.a.cashman@gmail.com>
---
drivers/staging/media/atomisp/i2c/ap1302.c | 4 ++--
drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c
index bacffbe..8432ee9 100644
--- a/drivers/staging/media/atomisp/i2c/ap1302.c
+++ b/drivers/staging/media/atomisp/i2c/ap1302.c
@@ -606,8 +606,8 @@ static s32 ap1302_try_mbus_fmt_locked(struct v4l2_subdev *sd,
static int ap1302_get_fmt(struct v4l2_subdev *sd,
- struct v4l2_subdev_pad_config *cfg,
- struct v4l2_subdev_format *format)
+ struct v4l2_subdev_pad_config *cfg,
+ struct v4l2_subdev_format *format)
{
struct v4l2_mbus_framefmt *fmt = &format->format;
diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c
index add8b90..1ec616a 100644
--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -54,7 +54,7 @@ static int gc0310_read_reg(struct i2c_client *client,
return -EINVAL;
}
- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));
msg[0].addr = client->addr;
msg[0].flags = 0;
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index 9b41023..50f4317 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -55,7 +55,7 @@ static int gc2235_read_reg(struct i2c_client *client,
return -EINVAL;
}
- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));
msg[0].addr = client->addr;
msg[0].flags = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Remove atomisp/i2c style errors.
2017-03-29 3:31 [PATCH] Remove atomisp/i2c style errors Daniel Cashman
@ 2017-03-29 7:08 ` Greg KH
2017-03-29 16:57 ` [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs Daniel Cashman
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2017-03-29 7:08 UTC (permalink / raw)
To: Daniel Cashman
Cc: mchehab, alan, devel, rvarsha016, linux-kernel, linux-media
On Tue, Mar 28, 2017 at 08:31:37PM -0700, Daniel Cashman wrote:
> From: Dan Cashman <dan.a.cashman@gmail.com>
Please list what the issue you fixed in the subject line.
Also change the subject to match others for this driver, a 'git log'
will show you what to do there.
>
> Remove two ' , ' issues and change spaces to tabs found by poking around in
> drivers/staging/. Warnings left untouched.
>
> Test: Run checkpatch script in drivers/staging/media/atomisp/i2c before and
> after change. Errors go from 3 to 0.
This isn't needed, and really, you didn't test the code, only a random
perl script :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs.
2017-03-29 7:08 ` Greg KH
@ 2017-03-29 16:57 ` Daniel Cashman
2017-03-29 17:30 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Cashman @ 2017-03-29 16:57 UTC (permalink / raw)
To: mchehab, gregkh, alan
Cc: rvarsha016, linux-media, devel, linux-kernel, dan.a.cashman
From: Dan Cashman <dan.a.cashman@gmail.com>
Signed-off-by: Dan Cashman <dan.a.cashman@gmail.com>
---
drivers/staging/media/atomisp/i2c/ap1302.c | 4 ++--
drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c
index bacffbe..8432ee9 100644
--- a/drivers/staging/media/atomisp/i2c/ap1302.c
+++ b/drivers/staging/media/atomisp/i2c/ap1302.c
@@ -606,8 +606,8 @@ static s32 ap1302_try_mbus_fmt_locked(struct v4l2_subdev *sd,
static int ap1302_get_fmt(struct v4l2_subdev *sd,
- struct v4l2_subdev_pad_config *cfg,
- struct v4l2_subdev_format *format)
+ struct v4l2_subdev_pad_config *cfg,
+ struct v4l2_subdev_format *format)
{
struct v4l2_mbus_framefmt *fmt = &format->format;
diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c
index add8b90..1ec616a 100644
--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -54,7 +54,7 @@ static int gc0310_read_reg(struct i2c_client *client,
return -EINVAL;
}
- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));
msg[0].addr = client->addr;
msg[0].flags = 0;
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index 9b41023..50f4317 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -55,7 +55,7 @@ static int gc2235_read_reg(struct i2c_client *client,
return -EINVAL;
}
- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));
msg[0].addr = client->addr;
msg[0].flags = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs.
2017-03-29 16:57 ` [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs Daniel Cashman
@ 2017-03-29 17:30 ` Alan Cox
2017-04-02 2:50 ` Daniel Cashman
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2017-03-29 17:30 UTC (permalink / raw)
To: Daniel Cashman, mchehab, gregkh
Cc: rvarsha016, linux-media, devel, linux-kernel
On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote:
> From: Dan Cashman <dan.a.cashman@gmail.com>
>
> Signed-off-by: Dan Cashman <dan.a.cashman@gmail.com>
As the TODO asks - please no whitespace cleanups yet. They make it
harder to keep other cleanups that fix (or mostly remove) code
applying.
Nothing wrong with the patch otherwise - but it should also have
something in the commit message.
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs.
2017-03-29 17:30 ` Alan Cox
@ 2017-04-02 2:50 ` Daniel Cashman
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Cashman @ 2017-04-02 2:50 UTC (permalink / raw)
To: Alan Cox, mchehab, gregkh; +Cc: rvarsha016, linux-media, devel, linux-kernel
My apologies; I did not review the TODO. Consider this withdrawn.
Dan
On 03/29/2017 10:30 AM, Alan Cox wrote:
> On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote:
>> From: Dan Cashman <dan.a.cashman@gmail.com>
>>
>> Signed-off-by: Dan Cashman <dan.a.cashman@gmail.com>
>
>
> As the TODO asks - please no whitespace cleanups yet. They make it
> harder to keep other cleanups that fix (or mostly remove) code
> applying.
>
> Nothing wrong with the patch otherwise - but it should also have
> something in the commit message.
>
> Alan
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-02 2:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-29 3:31 [PATCH] Remove atomisp/i2c style errors Daniel Cashman
2017-03-29 7:08 ` Greg KH
2017-03-29 16:57 ` [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs Daniel Cashman
2017-03-29 17:30 ` Alan Cox
2017-04-02 2:50 ` Daniel Cashman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.