* [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
@ 2017-03-29 9:27 Tobias Regnery
2017-03-30 6:49 ` Jani Nikula
2017-03-30 9:43 ` ✗ Fi.CI.BAT: warning for " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Tobias Regnery @ 2017-03-29 9:27 UTC (permalink / raw)
To: daniel.vetter, intel-gfx, dri-devel, linux-kernel; +Cc: Tobias Regnery
With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following
link error in the i915 driver:
drivers/built-in.o: In function 'intel_backlight_device_register':
(.text+0x2a921d): undefined reference to 'backlight_device_register'
Fix this by removing the condition on ACPI from the appropriate select
statement.
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
drivers/gpu/drm/i915/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index a5cd5dacf055..532df4bb9283 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -15,7 +15,7 @@ config DRM_I915
# i915 depends on ACPI_VIDEO when ACPI is enabled
# but for select to work, need to select ACPI_VIDEO's dependencies, ick
select BACKLIGHT_LCD_SUPPORT if ACPI
- select BACKLIGHT_CLASS_DEVICE if ACPI
+ select BACKLIGHT_CLASS_DEVICE
select INPUT if ACPI
select ACPI_VIDEO if ACPI
select ACPI_BUTTON if ACPI
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
2017-03-29 9:27 [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE Tobias Regnery
@ 2017-03-30 6:49 ` Jani Nikula
2017-03-30 9:43 ` ✗ Fi.CI.BAT: warning for " Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-03-30 6:49 UTC (permalink / raw)
To: Tobias Regnery, daniel.vetter, intel-gfx, dri-devel, linux-kernel
Cc: Tobias Regnery
On Wed, 29 Mar 2017, Tobias Regnery <tobias.regnery@gmail.com> wrote:
> With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following
> link error in the i915 driver:
>
> drivers/built-in.o: In function 'intel_backlight_device_register':
> (.text+0x2a921d): undefined reference to 'backlight_device_register'
>
> Fix this by removing the condition on ACPI from the appropriate select
> statement.
The right fix for the build problem is to add empty stub functions for
BACKLIGHT_CLASS_DEVICE=n in include/linux/backlight.h. I'm frankly
surprised nobody's done that yet.
It's another question whether we should support and select backlight for
ACPI=n, and yet another question whether we should support ACPI=n.
Also, selecting BACKLIGHT_CLASS_DEVICE is fundamentally broken, but
people aren't interested [1].
BR,
Jani.
[1] http://mid.mail-archive.com/1413580403-16225-1-git-send-email-jani.nikula@intel.com
>
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
> ---
> drivers/gpu/drm/i915/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index a5cd5dacf055..532df4bb9283 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -15,7 +15,7 @@ config DRM_I915
> # i915 depends on ACPI_VIDEO when ACPI is enabled
> # but for select to work, need to select ACPI_VIDEO's dependencies, ick
> select BACKLIGHT_LCD_SUPPORT if ACPI
> - select BACKLIGHT_CLASS_DEVICE if ACPI
> + select BACKLIGHT_CLASS_DEVICE
> select INPUT if ACPI
> select ACPI_VIDEO if ACPI
> select ACPI_BUTTON if ACPI
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
@ 2017-03-30 6:49 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-03-30 6:49 UTC (permalink / raw)
To: daniel.vetter, intel-gfx, dri-devel, linux-kernel; +Cc: Tobias Regnery
On Wed, 29 Mar 2017, Tobias Regnery <tobias.regnery@gmail.com> wrote:
> With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following
> link error in the i915 driver:
>
> drivers/built-in.o: In function 'intel_backlight_device_register':
> (.text+0x2a921d): undefined reference to 'backlight_device_register'
>
> Fix this by removing the condition on ACPI from the appropriate select
> statement.
The right fix for the build problem is to add empty stub functions for
BACKLIGHT_CLASS_DEVICE=n in include/linux/backlight.h. I'm frankly
surprised nobody's done that yet.
It's another question whether we should support and select backlight for
ACPI=n, and yet another question whether we should support ACPI=n.
Also, selecting BACKLIGHT_CLASS_DEVICE is fundamentally broken, but
people aren't interested [1].
BR,
Jani.
[1] http://mid.mail-archive.com/1413580403-16225-1-git-send-email-jani.nikula@intel.com
>
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
> ---
> drivers/gpu/drm/i915/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index a5cd5dacf055..532df4bb9283 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -15,7 +15,7 @@ config DRM_I915
> # i915 depends on ACPI_VIDEO when ACPI is enabled
> # but for select to work, need to select ACPI_VIDEO's dependencies, ick
> select BACKLIGHT_LCD_SUPPORT if ACPI
> - select BACKLIGHT_CLASS_DEVICE if ACPI
> + select BACKLIGHT_CLASS_DEVICE
> select INPUT if ACPI
> select ACPI_VIDEO if ACPI
> select ACPI_BUTTON if ACPI
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
2017-03-29 9:27 [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE Tobias Regnery
2017-03-30 6:49 ` Jani Nikula
@ 2017-03-30 9:43 ` Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-03-30 9:43 UTC (permalink / raw)
To: Tobias Regnery; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
URL : https://patchwork.freedesktop.org/series/22174/
State : warning
== Summary ==
Series 22174v1 drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
https://patchwork.freedesktop.org/api/1.0/series/22174/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-snb-2520m)
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 430s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time: 431s
fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 572s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 515s
fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time: 567s
fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 483s
fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 483s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 408s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 410s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 421s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 493s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 485s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 453s
fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 570s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 452s
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 573s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 460s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 492s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time: 432s
fi-snb-2520m total:278 pass:249 dwarn:1 dfail:0 fail:0 skip:28 time: 531s
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time: 408s
096f7a6356b9fb071e5bee15652ef842519d77f4 drm-tip: 2017y-03m-30d-08h-56m-23s UTC integration manifest
16ee08f drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4352/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
2017-03-30 6:49 ` Jani Nikula
@ 2017-03-31 6:35 ` Tobias Regnery
-1 siblings, 0 replies; 6+ messages in thread
From: Tobias Regnery @ 2017-03-31 6:35 UTC (permalink / raw)
To: Jani Nikula; +Cc: daniel.vetter, intel-gfx, dri-devel, linux-kernel
On 30.03.17, Jani Nikula wrote:
> On Wed, 29 Mar 2017, Tobias Regnery <tobias.regnery@gmail.com> wrote:
> > With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following
> > link error in the i915 driver:
> >
> > drivers/built-in.o: In function 'intel_backlight_device_register':
> > (.text+0x2a921d): undefined reference to 'backlight_device_register'
> >
> > Fix this by removing the condition on ACPI from the appropriate select
> > statement.
>
> The right fix for the build problem is to add empty stub functions for
> BACKLIGHT_CLASS_DEVICE=n in include/linux/backlight.h. I'm frankly
> surprised nobody's done that yet.
Thanks for the advice, I will try to come up with a patch.
--
Tobias
>
> It's another question whether we should support and select backlight for
> ACPI=n, and yet another question whether we should support ACPI=n.
>
> Also, selecting BACKLIGHT_CLASS_DEVICE is fundamentally broken, but
> people aren't interested [1].
>
>
> BR,
> Jani.
>
> [1] http://mid.mail-archive.com/1413580403-16225-1-git-send-email-jani.nikula@intel.com
>
> >
> > Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
> > ---
> > drivers/gpu/drm/i915/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> > index a5cd5dacf055..532df4bb9283 100644
> > --- a/drivers/gpu/drm/i915/Kconfig
> > +++ b/drivers/gpu/drm/i915/Kconfig
> > @@ -15,7 +15,7 @@ config DRM_I915
> > # i915 depends on ACPI_VIDEO when ACPI is enabled
> > # but for select to work, need to select ACPI_VIDEO's dependencies, ick
> > select BACKLIGHT_LCD_SUPPORT if ACPI
> > - select BACKLIGHT_CLASS_DEVICE if ACPI
> > + select BACKLIGHT_CLASS_DEVICE
> > select INPUT if ACPI
> > select ACPI_VIDEO if ACPI
> > select ACPI_BUTTON if ACPI
>
> --
> Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
@ 2017-03-31 6:35 ` Tobias Regnery
0 siblings, 0 replies; 6+ messages in thread
From: Tobias Regnery @ 2017-03-31 6:35 UTC (permalink / raw)
To: Jani Nikula; +Cc: daniel.vetter, intel-gfx, linux-kernel, dri-devel
On 30.03.17, Jani Nikula wrote:
> On Wed, 29 Mar 2017, Tobias Regnery <tobias.regnery@gmail.com> wrote:
> > With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following
> > link error in the i915 driver:
> >
> > drivers/built-in.o: In function 'intel_backlight_device_register':
> > (.text+0x2a921d): undefined reference to 'backlight_device_register'
> >
> > Fix this by removing the condition on ACPI from the appropriate select
> > statement.
>
> The right fix for the build problem is to add empty stub functions for
> BACKLIGHT_CLASS_DEVICE=n in include/linux/backlight.h. I'm frankly
> surprised nobody's done that yet.
Thanks for the advice, I will try to come up with a patch.
--
Tobias
>
> It's another question whether we should support and select backlight for
> ACPI=n, and yet another question whether we should support ACPI=n.
>
> Also, selecting BACKLIGHT_CLASS_DEVICE is fundamentally broken, but
> people aren't interested [1].
>
>
> BR,
> Jani.
>
> [1] http://mid.mail-archive.com/1413580403-16225-1-git-send-email-jani.nikula@intel.com
>
> >
> > Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
> > ---
> > drivers/gpu/drm/i915/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> > index a5cd5dacf055..532df4bb9283 100644
> > --- a/drivers/gpu/drm/i915/Kconfig
> > +++ b/drivers/gpu/drm/i915/Kconfig
> > @@ -15,7 +15,7 @@ config DRM_I915
> > # i915 depends on ACPI_VIDEO when ACPI is enabled
> > # but for select to work, need to select ACPI_VIDEO's dependencies, ick
> > select BACKLIGHT_LCD_SUPPORT if ACPI
> > - select BACKLIGHT_CLASS_DEVICE if ACPI
> > + select BACKLIGHT_CLASS_DEVICE
> > select INPUT if ACPI
> > select ACPI_VIDEO if ACPI
> > select ACPI_BUTTON if ACPI
>
> --
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-31 6:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-29 9:27 [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE Tobias Regnery
2017-03-30 6:49 ` Jani Nikula
2017-03-30 6:49 ` Jani Nikula
2017-03-31 6:35 ` Tobias Regnery
2017-03-31 6:35 ` Tobias Regnery
2017-03-30 9:43 ` ✗ Fi.CI.BAT: warning for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.