[PATCH v2] net: netfilter: remove unused variable

[PATCH v2] net: netfilter: remove unused variable

[Arushi Singhal]

This patch uses the following coccinelle script to remove
a variable that was simply used to store the return
value of a function call before returning it:

@@
identifier len,f;
@@

-int len;
 ... when != len
     when strict
-len =
+return
        f(...);
-return len;

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
   - remove extra blank line.

 net/netfilter/ipvs/ip_vs_ftp.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
index d30c327bb578..c93c93762354 100644
--- a/net/netfilter/ipvs/ip_vs_ftp.c
+++ b/net/netfilter/ipvs/ip_vs_ftp.c
@@ -482,11 +482,8 @@ static struct pernet_operations ip_vs_ftp_ops = {
 
 static int __init ip_vs_ftp_init(void)
 {
-	int rv;
-
-	rv = register_pernet_subsys(&ip_vs_ftp_ops);
 	/* rcu_barrier() is called by netns on error */
-	return rv;
+	return register_pernet_subsys(&ip_vs_ftp_ops);
 }
 
 /*
-- 
2.11.0

Re: [PATCH v2] net: netfilter: remove unused variable

[Simon Horman]

On Wed, Mar 29, 2017 at 08:27:52PM +0530, Arushi Singhal wrote:
> This patch uses the following coccinelle script to remove
> a variable that was simply used to store the return
> value of a function call before returning it:
> 
> @@
> identifier len,f;
> @@
> 
> -int len;
>  ... when != len
>      when strict
> -len =
> +return
>         f(...);
> -return len;
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>

Applied with patch prefix updated to "ipvs:".

Re: [PATCH v2] net: netfilter: remove unused variable

[Arushi Singhal]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

On Thu, Mar 30, 2017 at 6:25 PM, Simon Horman <horms@verge.net.au> wrote:

> On Wed, Mar 29, 2017 at 08:27:52PM +0530, Arushi Singhal wrote:
> > This patch uses the following coccinelle script to remove
> > a variable that was simply used to store the return
> > value of a function call before returning it:
> >
> > @@
> > identifier len,f;
> > @@
> >
> > -int len;
> >  ... when != len
> >      when strict
> > -len =
> > +return
> >         f(...);
> > -return len;
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
>
> Applied with patch prefix updated to "ipvs:".
>
Hi
Thanks
How can I see my accepted patches of netfilter.
Thanks
Arushi

[-- Attachment #2: Type: text/html, Size: 1314 bytes --]

Re: [PATCH v2] net: netfilter: remove unused variable

[Pablo Neira Ayuso]

On Thu, Mar 30, 2017 at 07:38:08PM +0530, Arushi Singhal wrote:
> On Thu, Mar 30, 2017 at 6:25 PM, Simon Horman <horms@verge.net.au> wrote:
> 
> > On Wed, Mar 29, 2017 at 08:27:52PM +0530, Arushi Singhal wrote:
> > > This patch uses the following coccinelle script to remove
> > > a variable that was simply used to store the return
> > > value of a function call before returning it:
> > >
> > > @@
> > > identifier len,f;
> > > @@
> > >
> > > -int len;
> > >  ... when != len
> > >      when strict
> > > -len =
> > > +return
> > >         f(...);
> > > -return len;
> > >
> > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> >
> > Applied with patch prefix updated to "ipvs:".
> >
> Hi
> Thanks
> How can I see my accepted patches of netfilter.

You can use links from patchwork:

http://patchwork.ozlabs.org/project/netfilter-devel/